Re: [codec] submitting a StringEncoder

2011-06-24 Thread Matthew Pocock
Hi, I've submitted an issue: https://issues.apache.org/jira/browse/CODEC-125 I have BMPM implemented now, with good (but not complete) test coverage. It's certainly ready for someone else to try to break it for me. So, 1. The original authors are very keen to see this integrated with

Re: [codec] submitting a StringEncoder

2011-05-17 Thread Gary Gregory
Also, you should probably create one ticket for each encoder, one of BM, one for DM. Thank you, Gary On Mon, May 16, 2011 at 11:49 AM, Gary Gregory garydgreg...@gmail.comwrote: Hi Matthiew, If I've not already mentioned this, make sure you get good coverage for the code to be included. You

Re: [codec] submitting a StringEncoder

2011-05-16 Thread Matthew Pocock
Hi, Sorry to be slow getting back to you. Thanks for all the helpful feedback. The codec implements Beider-Morse Phonetic Matching which is optimised for sounds-like in family names, particularly Central/Eastern European and Jewish names. I'm in the process of contacting all the relevant people

Re: [codec] submitting a StringEncoder

2011-05-16 Thread Gary Gregory
Hi Mathew, Will you also provide a Daitch–Mokotoff Soundex for comparison? Gary On May 16, 2011, at 7:17, Matthew Pocock turingatemyhams...@gmail.com wrote: Beider-Morse

Re: [codec] submitting a StringEncoder

2011-05-16 Thread Matthew Pocock
Hi Gary, I will see how much extra work is involved in also implementing D-M. I'm only contracted to port B-M, but if it's not oodles of extra work I'll do D-M also. Matthew On 16 May 2011 12:50, Gary Gregory garydgreg...@gmail.com wrote: Hi Mathew, Will you also provide a Daitch–Mokotoff

Re: [codec] submitting a StringEncoder

2011-05-16 Thread Gary Gregory
Hi Matthiew, If I've not already mentioned this, make sure you get good coverage for the code to be included. You can see the code coverage report in the generated site, for example http://commons.apache.org/codec/cobertura/index.html Gary On Mon, May 16, 2011 at 8:00 AM, Matthew Pocock

[codec] submitting a StringEncoder

2011-05-12 Thread Matthew Pocock
Hi, How would I go about submitting a new StringEncoder to the language package of codec? I have been contracted to port an existing sounds-like coding from PHP to Java and ideally to contribute the result to the codec project. To the best of my knowledge, there are no IP issues as the original

Re: [codec] submitting a StringEncoder

2011-05-12 Thread Gary Gregory
Hello Matthew, What standard does this new encoder implement? The best way to submit any code is as a patch including unit tests attached to a new JIRA issue: https://issues.apache.org/jira/secure/Dashboard.jspa and http://commons.apache.org/patches.html You'll have to create yourself a

Re: [codec] submitting a StringEncoder

2011-05-12 Thread Henri Yandell
Original code under GPL is an IP issue. Namely that your Java code must also be under GPL. That subsequently can't be included in the Apache project, unless you can get the original PHP author to change the license to something listed here: http://www.apache.org/legal/resolved.html#category-a

Re: [codec] submitting a StringEncoder

2011-05-12 Thread Matt Benson
On Thu, May 12, 2011 at 10:08 AM, Henri Yandell flame...@gmail.com wrote: Original code under GPL is an IP issue. Namely that your Java code must also be under GPL. That subsequently can't be included in the Apache project, unless you can get the original PHP author to change the license to

Re: [codec] submitting a StringEncoder

2011-05-12 Thread Henri Yandell
On Thu, May 12, 2011 at 8:31 AM, Matt Benson gudnabr...@gmail.com wrote: On Thu, May 12, 2011 at 10:08 AM, Henri Yandell flame...@gmail.com wrote: Original code under GPL is an IP issue. Namely that your Java code must also be under GPL. That subsequently can't be included in the Apache