RE: [crypto] Instructions MUST mention running the tests

2016-06-06 Thread Sun, Dapeng
ubject: Re: [crypto] Instructions MUST mention running the tests Hello, I also make a habit out of using "mvn verify" instead of "mvn package" (for the same reason, do never document circumventing potential tests). Gruss Bernd -- http://bernd.eckenfels.net -Original M

RE: [crypto] Instructions MUST mention running the tests

2016-06-06 Thread Sun, Dapeng
o: Commons Developers List Subject: [crypto] Instructions MUST mention running the tests Hi All: When I see instructions in BUILDING.txt like: Create binary distribution: $ mvn package -DskipTests I am worried! Why would you NOT want to run unit tests? Skipping tests from Maven is a hack when you

Re: [crypto] Instructions MUST mention running the tests

2016-06-06 Thread ecki
o: Commons Developers List <dev@commons.apache.org> Sent: Di., 07 Juni 2016 4:37 Subject: [crypto] Instructions MUST mention running the tests Hi All: When I see instructions in BUILDING.txt like: Create binary distribution: $ mvn package -DskipTests I am worried! Why would you NOT

[crypto] Instructions MUST mention running the tests

2016-06-06 Thread Gary Gregory
Hi All: When I see instructions in BUILDING.txt like: Create binary distribution: $ mvn package -DskipTests I am worried! Why would you NOT want to run unit tests? Skipping tests from Maven is a hack when you know what you are doing. Like when I just ran the tests, all passed, and I changed