Re: [geometry] Rename Transform to AffineTransform

2020-01-21 Thread Gilles Sadowski
Hello. 2020-01-20 20:39 UTC+01:00, Matt Juntunen : > Gilles, > >> I was not indicating that the name "EuclideanTransform" would be >> better than "AffineTransform", I was wondering about whether the >> class itself is redundant. > > Oh, I misunderstood. The "EuclideanTransform" interface is

Re: [geometry] Rename Transform to AffineTransform

2020-01-20 Thread Matt Juntunen
d as: > ---CUT--- > In Euclidean space, this must be an affine transform. > ---CUT--- That's part of what the documentation now says. -Matt From: Gilles Sadowski Sent: Monday, January 20, 2020 2:28 PM To: Commons Developers List Subject: Re: [geometry] Rename T

Re: [geometry] Rename Transform to AffineTransform

2020-01-20 Thread Gilles Sadowski
Hello. Le lun. 20 janv. 2020 à 16:57, Matt Juntunen a écrit : > > Gilles, > > > From a design POV, I still think that "AffineTransform" is redundant: > > The "AffineTransform" name change has been reverted. It is now the original > "EuclideanTransform". I was not indicating that the name

Re: [geometry] Rename Transform to AffineTransform

2020-01-20 Thread Matt Juntunen
e most complete and mathematically accurate. -Matt From: Gilles Sadowski Sent: Monday, January 20, 2020 8:52 AM To: Commons Developers List Subject: Re: [geometry] Rename Transform to AffineTransform Hello. 2020-01-20 14:28 UTC+01:00, Matt Juntunen : > Gilles, > >> I

Re: [geometry] Rename Transform to AffineTransform

2020-01-20 Thread Gilles Sadowski
ood point on the protected > methods, though. I've moved them into the internal "Matrices" utility > class. Thanks. Gilles > > -Matt > > From: Gilles Sadowski > Sent: Sunday, January 19, 2020 9:06 AM > To: Commons Developers Lis

Re: [geometry] Rename Transform to AffineTransform

2020-01-20 Thread Matt Juntunen
;preservesOrientation". Good point on the protected methods, though. I've moved them into the internal "Matrices" utility class. -Matt ________ From: Gilles Sadowski Sent: Sunday, January 19, 2020 9:06 AM To: Commons Developers List Subject: Re: [geometry] Rename Transform to AffineT

Re: [geometry] Rename Transform to AffineTransform

2020-01-19 Thread Gilles Sadowski
he public API). Regards, Gilles > > -Matt > ________ > From: Gilles Sadowski > Sent: Saturday, January 18, 2020 1:40 PM > To: Commons Developers List > Subject: Re: [geometry] Rename Transform to AffineTransform > > Hello. > > 2020-01

Re: [geometry] Rename Transform to AffineTransform

2020-01-18 Thread Matt Juntunen
changed. -Matt From: Gilles Sadowski Sent: Saturday, January 18, 2020 1:40 PM To: Commons Developers List Subject: Re: [geometry] Rename Transform to AffineTransform Hello. 2020-01-18 15:40 UTC+01:00, Matt Juntunen : > Gilles, > >> If the "Transform&quo

Re: [geometry] Rename Transform to AffineTransform

2020-01-18 Thread Gilles Sadowski
1S implements Transform > Transform2S implements Transform > > WDYT? +1 Best, Gilles > > -Matt > > > > From: Gilles Sadowski > Sent: Monday, January 13, 2020 8:03 PM > To: Commons Developers List > Subject: Re: [geometry] R

Re: [geometry] Rename Transform to AffineTransform

2020-01-18 Thread Matt Juntunen
__ From: Gilles Sadowski Sent: Monday, January 13, 2020 8:03 PM To: Commons Developers List Subject: Re: [geometry] Rename Transform to AffineTransform Hi. Le lun. 13 janv. 2020 à 04:39, Matt Juntunen a écrit : > > Gilles, > > > How about keeping "Transform" for

Re: [geometry] Rename Transform to AffineTransform

2020-01-13 Thread Gilles Sadowski
e "Transform" is intimately related to the "core" and there is a single set of properties that make it "affine" (and work correctly), I'd tend to keep the name "Transform". [As long as unit tests ensure that concrete implementations possess the expected propertie

Re: [geometry] Rename Transform to AffineTransform

2020-01-12 Thread Matt Juntunen
ce should be able to check whether it can use it for the intended purpose. I wonder why the documented requirement that an "inverse transform must exist" does not translate into a method ---CUT--- Transform getInverse(); ---CUT--- Regards, Gilles > -Matt > _

Re: [geometry] Rename Transform to AffineTransform

2020-01-08 Thread Gilles Sadowski
nsform must exist" does not translate into a method ---CUT--- Transform getInverse(); ---CUT--- Regards, Gilles > -Matt > ________ > From: Gilles Sadowski > Sent: Tuesday, January 7, 2020 6:41 PM > To: Commons Developers List > Subject: Re:

Re: [geometry] Rename Transform to AffineTransform

2020-01-07 Thread Matt Juntunen
be restricted to affine transform? Regards, Gilles [1] https://en.wikipedia.org/wiki/Affine_transformation > -Matt > ____ > From: Gilles Sadowski > Sent: Tuesday, January 7, 2020 10:29 AM > To: Commons Developers List > Subject: Re: [geometry] Re

Re: [geometry] Rename Transform to AffineTransform

2020-01-07 Thread Gilles Sadowski
ttps://en.wikipedia.org/wiki/Affine_transformation > -Matt > ________ > From: Gilles Sadowski > Sent: Tuesday, January 7, 2020 10:29 AM > To: Commons Developers List > Subject: Re: [geometry] Rename Transform to AffineTransform > > Hello. > > Le m

Re: [geometry] Rename Transform to AffineTransform

2020-01-07 Thread Matt Juntunen
h"? Indirectly. SphericalPolygonsSet extended AbstractRegion, which included an applyTransform(Transform) method. -Matt From: Gilles Sadowski Sent: Tuesday, January 7, 2020 10:29 AM To: Commons Developers List Subject: Re: [geometry] Rename Transform to Af

Re: [geometry] Rename Transform to AffineTransform

2020-01-07 Thread Gilles Sadowski
Hello. Le mar. 7 janv. 2020 à 16:00, Matt Juntunen a écrit : > > Hi all, > > The documentation for the o.a.c.geometry.core.Transform interface (which > comes from the original commons-math version) states that implementations > must be affine. Therefore, I think we should rename this interface

[geometry] Rename Transform to AffineTransform

2020-01-07 Thread Matt Juntunen
Hi all, The documentation for the o.a.c.geometry.core.Transform interface (which comes from the original commons-math version) states that implementations must be affine. Therefore, I think we should rename this interface to AffineTransform to avoid confusion with other types of transforms,