[jcs] logging

2014-06-01 Thread Romain Manni-Bucau
Hi I have two main point to discuss regarding the logging: 1) LogHelper stuffI committed. Idea was to cache isDebugEnabled to get a if (boolean) complexity and not go through the logging framework which can imply several layers (filter, appender, handler, logger...) for nothing and slow down cachi

Re: [jcs] logging

2014-06-01 Thread sebb
On 1 June 2014 20:26, Romain Manni-Bucau wrote: > Hi > > I have two main point to discuss regarding the logging: > 1) LogHelper stuffI committed. Idea was to cache isDebugEnabled to get a if > (boolean) complexity and not go through the logging framework which can > imply several layers (filter, a

RE: [jcs] logging

2014-06-01 Thread Gary Gregory
There is also log4j 2. Gary Original message From: Romain Manni-Bucau Date:06/01/2014 15:26 (GMT-05:00) To: Commons Developers List Subject: [jcs] logging Hi I have two main point to discuss regarding the logging: 1) LogHelper stuffI committed. Idea was to cache

RE: [jcs] logging

2014-06-01 Thread Romain Manni-Bucau
would be JUL (where loghelper is needed) or another dependency... Le 2 juin 2014 00:01, "Gary Gregory" a écrit : > There is also log4j 2. > > Gary > > Original message From: Romain Manni-Bucau > Date:06/01/2014 15:26 (GMT-05:00) > To: Commons D

Re: [jcs] logging

2014-06-01 Thread Jörg Schaible
Romain Manni-Bucau wrote: > Hi > > I have two main point to discuss regarding the logging: > 1) LogHelper stuffI committed. Idea was to cache isDebugEnabled to get a > if (boolean) complexity and not go through the logging framework which can > imply several layers (filter, appender, handler, log

Re: [jcs] logging

2014-06-01 Thread Romain Manni-Bucau
Well because [logging] was longly broken in a not flat classloading environment (didnt check last release but almost all logging facade got this issue at a point) and because almost nothing in TomEE stacks uses it, it is not as integrated as log4j, slf4j or JUL (which is the default). Main issue I

Re: [jcs] logging

2014-06-01 Thread Gary Gregory
Gregory" a écrit : > > > There is also log4j 2. > > > > Gary > > > > Original message From: Romain > Manni-Bucau > > Date:06/01/2014 15:26 (GMT-05:00) > > To: Commons Developers List > > Subject: [jcs] logging >

Re: [jcs] logging

2014-06-02 Thread Romain Manni-Bucau
h would be a regression IMHO + either would be JUL (where > > loghelper is needed) or another dependency... > > Le 2 juin 2014 00:01, "Gary Gregory" a écrit : > > > > > There is also log4j 2. > > > > > > Gary > > > > > > Origina

Re: [jcs] logging

2014-06-02 Thread Gary Gregory
h would be a regression IMHO + either would be JUL (where > > loghelper is needed) or another dependency... > > Le 2 juin 2014 00:01, "Gary Gregory" a écrit : > > > > > There is also log4j 2. > > > > > > Gary > > > > > >

Re: [jcs] logging

2014-06-02 Thread Romain Manni-Bucau
e a log4j 2 Jira for this? There might be one > already though. I have seen discussions about this area on the log4j dev ML. > > Gary > > Original message From: Romain Manni-Bucau > Date:06/02/2014 08:31 (GMT-05:00) > To: Commons Developers List >

Re: [jcs] logging

2014-06-02 Thread Phil Steitz
On 6/1/14, 12:26 PM, Romain Manni-Bucau wrote: > Hi > > I have two main point to discuss regarding the logging: > 1) LogHelper stuffI committed. Idea was to cache isDebugEnabled to get a if > (boolean) complexity and not go through the logging framework which can > imply several layers (filter, app

Re: [jcs] logging

2014-06-02 Thread Romain Manni-Bucau
actually these logs are really debug log not intended to be activated in prod excepted if there is a big issue (@thomas: if you can confirm it would be great). Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github:

Re: [jcs] logging

2014-06-02 Thread Thomas Vandahl
On 02.06.14 17:02, Romain Manni-Bucau wrote: > actually these logs are really debug log not intended to be activated in > prod excepted if there is a big issue (@thomas: if you can confirm it would > be great). Yes, logging is for debugging purposes mostly. But if you remove them: how would you do

Re: [jcs] logging

2014-06-02 Thread Thomas Vandahl
On 01.06.14 21:26, Romain Manni-Bucau wrote: > Hi > > I have two main point to discuss regarding the logging: > 1) LogHelper stuffI committed. Idea was to cache isDebugEnabled to get a if > (boolean) complexity and not go through the logging framework which can > imply several layers (filter, appe

Re: [jcs] logging

2014-06-02 Thread Romain Manni-Bucau
@Thomas: never said [logging] is bad and JUL is better. Sorry if I was not clear. All logging facades don't handle very well EE case for several good or bad reasons. [logging] is as good as slf4j for it (even better out of the box IIRC). JUL is far to be perfect but is in the JVM (so no dependency)

Re: [jcs] logging

2014-06-03 Thread Benedikt Ritter
Send from my mobile device > Am 02.06.2014 um 21:51 schrieb Romain Manni-Bucau : > > @Thomas: never said [logging] is bad and JUL is better. Sorry if I was not > clear. All logging facades don't handle very well EE case for several good > or bad reasons. [logging] is as good as slf4j for it (ev