Re: [rng] Update ProviderBuilder factory methods

2019-06-05 Thread Alex Herbert
> On 5 Jun 2019, at 22:51, Gilles Sadowski wrote: > > Hi. > > Le lun. 3 juin 2019 à 16:49, Alex Herbert > a écrit : >> >> Can I get a review of a PR that changes the ProviderBuilder [1]? >> >> The aim is to move the creation of the seed and the RNG into the

Re: [rng] Update ProviderBuilder factory methods

2019-06-05 Thread Gilles Sadowski
Hi. Le lun. 3 juin 2019 à 16:49, Alex Herbert a écrit : > > Can I get a review of a PR that changes the ProviderBuilder [1]? > > The aim is to move the creation of the seed and the RNG into the > RandomSourceInternal. > > This allows for customisation of the seed creation on a per-RNG basis. >

[rng] Update ProviderBuilder factory methods

2019-06-03 Thread Alex Herbert
Can I get a review of a PR that changes the ProviderBuilder [1]? The aim is to move the creation of the seed and the RNG into the RandomSourceInternal. This allows for customisation of the seed creation on a per-RNG basis. The reason is that some new generators in the library for v1.3