Re: [text] license header

2017-09-22 Thread Amey Jadiye
Ah, my bad actually after your commit for TEXT-102 Travis was failed [1]. so seems we are good here. [1] https://travis-ci.org/apache/commons-text/builds/278697845 Regards, Amey On Fri, Sep 22, 2017 at 11:41 PM, Amey Jadiye wrote: > Its already there [1] and fails if something is not correct i

Re: [text] license header

2017-09-22 Thread Amey Jadiye
Its already there [1] and fails if something is not correct in *main* but I guess it doesn't check anything for test resources and test java files. thats why build was passing till date. [1]. https://github.com/apache/commons-text/blob/master/pom.xml Regards, Amey On Fri, Sep 22, 2017 at 10:58

Re: [text] license header

2017-09-22 Thread Gary Gregory
Hm, I guess we could add 'apache-rat:check' and 'clirr:check' to the Travis and Jenkins builds. Gary On Fri, Sep 22, 2017 at 11:26 AM, Gary Gregory wrote: > Good catch and thank you. > > I wish we could set up Maven to run the RAT check and fail a local build > if a header is missing. > > Gary

Re: [text] license header

2017-09-22 Thread Gary Gregory
Good catch and thank you. I wish we could set up Maven to run the RAT check and fail a local build if a header is missing. Gary On Fri, Sep 22, 2017 at 11:24 AM, wrote: > Repository: commons-text > Updated Branches: > refs/heads/master 3292f74df -> 8cdbbd34b > > > license header > > > Proje