Re: GitHub Pull Requests (and Confluence)

2019-03-26 Thread Benedikt Ritter
Hello Jochen, Am Mo., 25. März 2019 um 16:32 Uhr schrieb Jochen Wiedmann < jochen.wiedm...@gmail.com>: > Hi, > > just FIY: Today I tried to accept a pull request from Github, > following the procedure, as outlined on > > >

Confluence space (was: GitHub Pull Requests (and Confluence))

2019-03-25 Thread sebb
On Mon, 25 Mar 2019 at 15:32, Jochen Wiedmann wrote: > > Which reminds me: Do we have a Confluence space? If not: Would anyone > mind, if I asked for one on Jira? Remember that Moin Moin is being withdrawn. There is quite a large Commons Wiki on it; maybe that should be migrated rather than

GitHub Pull Requests (and Confluence)

2019-03-25 Thread Jochen Wiedmann
Hi, just FIY: Today I tried to accept a pull request from Github, following the procedure, as outlined on https://cwiki.apache.org/confluence/display/ROLLER/How+to+accept+a+GitHub+Pull+Request (Of course, the Git URL has to be adjusted to your subproject, in my case

Re: GitHub Pull Requests

2018-10-15 Thread Sudeendra Nadager
Dear Zack, I gave a shot at it. I have some comments and see if they make sense. Regards, Sudeendra Nadager On 13/10/18, 01:33, "Pascal Schumacher" wrote: Hi Zack, there is no hard and fast rule when pull request get reviewed and/or commented on. It happens

Re: GitHub Pull Requests

2018-10-12 Thread Pascal Schumacher
Hi Zack, there is no hard and fast rule when pull request get reviewed and/or commented on. It happens whenever a committer feels motivated to do so (we are all volunteers). I understand that waiting a long time for pull request reviews is demotivating. Sorry, Pascal Am 11.10.2018 um

GitHub Pull Requests

2018-10-11 Thread zmacomber
Hello, I have submitted a Pull Request at https://github.com/apache/commons-lang/pull/358. 10 days ago, "coveralls" commented on the request and all checks passed. Otherwise, I have heard nothing regarding the request. When do requests get reviewed and/or commented on? Thanks, Zack

Re: commons-vfs: github pull requests

2016-03-22 Thread Bernd Eckenfels
Am Tue, 22 Mar 2016 16:33:12 + schrieb "Epstein, Ezra" : > Is commons-vfs being maintained? And is GitHub the up-to-date code > repo? Yes, github is a mirror of the apache git repo and the apache git repo mirrors the SVN based master. They should be in sync. The

commons-vfs: github pull requests

2016-03-22 Thread Epstein, Ezra
Is commons-vfs being maintained? And is GitHub the up-to-date code repo? I notice a number of open pull requests, one from yours truly. https://github.com/apache/commons-vfs/pulls Just checking in to see if something more is needed for contributing to this project.

Re: [math] github pull requests

2015-08-25 Thread Stefan Bodewig
On 2015-08-25, Luc Maisonobe wrote: Le 25/08/2015 16:14, Stefan Bodewig a écrit : On 2015-08-25, Luc Maisonobe wrote: As the github pull request are not forwarded here, You know that you can enable automatic notifications? I don't recall the details - probably something involving a ticket

Re: [math] github pull requests

2015-08-25 Thread Otmar Ertl
On Tue, Aug 25, 2015 at 4:11 PM, Gilles gil...@harfang.homelinux.org wrote: Hello. On Tue, 25 Aug 2015 15:29:37 +0200, Luc Maisonobe wrote: Hi all, As the github pull request are not forwarded here, there are two new requests since yesterday:

Re: [math] github pull requests

2015-08-25 Thread Gilles
Hello. On Tue, 25 Aug 2015 15:29:37 +0200, Luc Maisonobe wrote: Hi all, As the github pull request are not forwarded here, there are two new requests since yesterday: https://github.com/apache/commons-math/pull/11 I don't understand that one.

Re: [math] github pull requests

2015-08-25 Thread Luc Maisonobe
Le 25/08/2015 16:14, Stefan Bodewig a écrit : On 2015-08-25, Luc Maisonobe wrote: As the github pull request are not forwarded here, You know that you can enable automatic notifications? I don't recall the details - probably something involving a ticket for INFRA - but we do see PR

Re: [math] github pull requests

2015-08-25 Thread Stefan Bodewig
On 2015-08-25, Luc Maisonobe wrote: As the github pull request are not forwarded here, You know that you can enable automatic notifications? I don't recall the details - probably something involving a ticket for INFRA - but we do see PR notifications in Ant for example. Stefan

[math] github pull requests

2015-08-25 Thread Luc Maisonobe
Hi all, As the github pull request are not forwarded here, there are two new requests since yesterday: https://github.com/apache/commons-math/pull/11 https://github.com/apache/commons-math/pull/12 What do you think about them? Luc

Re: [ALL] Ask for CLA before merging pending GitHub pull requests

2015-03-21 Thread Stian Soiland-Reyes
. If signing CLA's is a requirement for GitHub pull requests, maybe we could ping @infra and check with them if we could use clabot [2] for that? No need. Just review the pull request and - if it is acceptable - merge it. Mark

Re: [ALL] Ask for CLA before merging pending GitHub pull requests

2015-03-19 Thread Bruno P. Kinoshita
Hi Mark, Thanks a lot for clarifying! :) All the best,Bruno From: Mark Thomas ma...@apache.org To: Commons Developers List dev@commons.apache.org Sent: Thursday, March 19, 2015 5:39 PM Subject: Re: [ALL] Ask for CLA before merging pending GitHub pull requests On 19/03/2015 17:32

[ALL] Ask for CLA before merging pending GitHub pull requests

2015-03-19 Thread Bruno P. Kinoshita
via JIRA it displays an option to donate the code submitted via patch to ASF. If signing CLA's is a requirement for GitHub pull requests, maybe we could ping @infra and check with them if we could use clabot [2] for that? Thanks!Bruno [1] https://people.apache.org/committer-index.html

Re: [ALL] How to handle GitHub pull requests

2014-10-18 Thread Benedikt Ritter
Good Point. Would be nice if the jira issues could be generated automatically... is anybody aware of such a service? Send from my mobile device Am 17.10.2014 um 21:43 schrieb sebb seb...@gmail.com: A related issue: when filing a JIRA from the pull request, please include more than just the

[ALL] How to handle GitHub pull requests

2014-10-17 Thread Duncan Jones
Hi everyone, Some of our contributors like to use GitHub pull requests (PRs) as a means of providing patches. Until now, I've tended to access the .patch version of these pull requests and apply them in SVN. Is there a preferred approach to take here? I have a GitHub account, so presumably I

Re: [ALL] How to handle GitHub pull requests

2014-10-17 Thread Emmanuel Bourg
Le 17/10/2014 09:44, Duncan Jones a écrit : Is there a preferred approach to take here? I have a GitHub account, so presumably I could be given rights to the repositories I commit to (lang) and this would allow me to merge PRs directly into trunk. Would such changes be reflected in our SVN

Re: [ALL] How to handle GitHub pull requests

2014-10-17 Thread Duncan Jones
On 17 October 2014 09:07, Emmanuel Bourg ebo...@apache.org wrote: Le 17/10/2014 09:44, Duncan Jones a écrit : Is there a preferred approach to take here? I have a GitHub account, so presumably I could be given rights to the repositories I commit to (lang) and this would allow me to merge PRs

Re: [ALL] How to handle GitHub pull requests

2014-10-17 Thread Emmanuel Bourg
Le 17/10/2014 10:16, Duncan Jones a écrit : Do you happen to know if GitHub will react to commit messages from SVN in order to close PRs, such as described in [1]? Yes it does. Emmanuel Bourg - To unsubscribe, e-mail:

Applying GitHub pull requests

2013-11-11 Thread Henri Yandell
Apologies if this is obvious to all, but I figured I'd share as it took a moment to look it up and get the right answer out of the noise on StackOverflow :) A simple way to apply a GitHub pull request, say: https://github.com/apache/commons-lang/pull/11/ Download (wget etc)

Re: Applying GitHub pull requests

2013-11-11 Thread Gary Gregory
On Tue, Nov 12, 2013 at 12:43 AM, Henri Yandell flame...@gmail.com wrote: Apologies if this is obvious to all, but I figured I'd share as it took a moment to look it up and get the right answer out of the noise on StackOverflow :) A simple way to apply a GitHub pull request, say: