I've raised some pull requests to add the Takari maven wrapper.
The Takari maven wrapper is EOL and will be replaced with the Maven
Wrapper when Maven v3.7.0 is released.
I've added the Takari version as maven v3.7.0 is not yet out. I've
been using the Takari maven wrapper for about 4 years now a
-1 from me, use a set up action instead, for example:
https://github.com/marketplace?type=actions&query=maven
In particular:
https://github.com/marketplace/actions/setup-maven
As recommended here:
https://github.com/actions/setup-java/issues/40#issuecomment-675817329
Gary
On Sat, Aug 15, 2020
On Wed, Aug 19, 2020 at 7:49 AM Gary Gregory wrote:
> -1 from me, use a set up action instead, for example:
>
> https://github.com/marketplace?type=actions&query=maven
>
> In particular:
>
> https://github.com/marketplace/actions/setup-maven
>
> As recommended here:
> https://github.com/actions/s
Le mer. 19 août 2020 à 14:33, Gary Gregory a
écrit :
> On Wed, Aug 19, 2020 at 7:49 AM Gary Gregory
> wrote:
>
> > -1 from me, use a set up action instead, for example:
> >
> > https://github.com/marketplace?type=actions&query=maven
> >
> > In particular:
> >
> > https://github.com/marketplace/a
All the suggestions I'm seeing appear to be hard code solutions to
specific implementations, require defining things in multiple places,
or needing developers to select the correct version.
https://github.com/marketplace/actions/setup-maven won't work on my laptop
https://github.com/marketplace/ac
I’m still a +1 for mvnw….do we have a consensus here?
-Rob
> On Aug 19, 2020, at 4:27 PM, John Patrick wrote:
>
> All the suggestions I'm seeing appear to be hard code solutions to
> specific implementations, require defining things in multiple places,
> or needing developers to select the corr
me +0 for mvnw.
I don't hate it and it is well implemented.
But I have no idea whether we need it.
Rob Tompkins 于2020年8月20日周四 上午4:36写道：
> I’m still a +1 for mvnw….do we have a consensus here?
>
> -Rob
>
> > On Aug 19, 2020, at 4:27 PM, John Patrick
> wrote:
> >
> > All the suggestions I'm seein
The consensus is do nothing IMO.
What I really dislike is that if I have 20 components that over time end up
containing 20 different versions of these Cmd/Sh/JavaSource/PropertiesFiles
that point to 20 different versions of Maven, and I build everything, I'll
end up with 20 different versions of M
Le mer. 19 août 2020 à 22:49, Gary Gregory a écrit :
>
> The consensus is do nothing IMO.
"Those who do the work" etc. (see below).
>
> What I really dislike is that if I have 20 components that over time end up
> containing 20 different versions of these Cmd/Sh/JavaSource/PropertiesFiles
> that
I've now closed all PR's, and deleted the source branches.
Giles I've pushed the changes back into my commons-lang fork, so this
would recreate that branch
https://github.com/nhojpatrick/apache_commons-lang/pull/new/takari.maven-wrapper.
The PR if raised again, would include changes needed for gi
Hello John.
Le mer. 19 août 2020 à 23:38, John Patrick a écrit :
>
> I've now closed all PR's, and deleted the source branches.
>
> Giles I've pushed the changes back into my commons-lang fork, so this
> would recreate that branch
> https://github.com/nhojpatrick/apache_commons-lang/pull/new/taka
Hello all,
I first want to thank John for bringing these points to light as I think we can
have quite a healthy discussion about the CI/CD philosophy employed by the
project (Apache Commons) generally. Furthermore, I hope to set precedent with
intent and direction with the following comments. N
I'll note that at least from a Jenkins point of view (probably similar
with GitHub Actions), it's easier to set up your CI config to use the
Maven wrapper script instead of configuring a Maven tool (Jenkins) or
using a specific Docker image or similar extra config. We've had a
wrapper script in Log
Hello.
Le sam. 15 août 2020 à 19:22, Rob Tompkins a écrit :
>
> Hello all,
>
> I first want to thank John for bringing these points to light as I think we
> can have quite a healthy discussion about the CI/CD philosophy employed by
> the project (Apache Commons) generally. Furthermore, I hope t
Hi All,
I would really prefer we do not do this.
Note that there is no blocking issue to fix here. When you build in a CI,
you know what OS you get and Maven is pre-configured, no mystery.
My view here is that it would be the CI's job to toggle the Maven version
just like a CI does for Java, the
I personally only use mvnw as a tool to force maven versions, or on
situations where we must use some machines without maven installed.
It is quite like gradlew in usage, but notice that maven have far less
major versions and far better backward compatibility than gradle, so in
most repos we do not
16 matches
Mail list logo
