Re: PR Merge process lang vs text ?

As far as I know the commit is only displayed as merged on git hub if it was not altered in any way. Forhttps://github.com/apache/commons-lang/pull/274 I appended "( closes

Re: PR Merge process lang vs text ?

well It's still confusing... Example. https://github.com/apache/commons-lang/pull/270 Here in #270 asfgit merged the PR While https://github.com/apache/commons-lang/pull/274 Here in #274 asfgit closed PR. Regards, Amey On Sat, Jul 15, 2017, 2:07 AM Gary Gregory

Re: PR Merge process lang vs text ?

If a Git commit comment says "Closes #" like "Closes #29", PR #29 will be closed. I forget to do that sometimes. Gary On Fri, Jul 14, 2017 at 1:29 PM, Amey Jadiye wrote: > I wonder is there different process for accepting PR in text and lang ? > > Whenever I open PR

PR Merge process lang vs text ?

I wonder is there different process for accepting PR in text and lang ? Whenever I open PR for text ,after acceptance it says "asfgit merged branch" and it automatically shows pr status as #merged on github while for lang after merging my code PR stays open and I have to manually close it?