On Tue, Jul 28, 2009 at 4:59 AM, Gary
Gregory wrote:
>
> Maybe we can start by marking the Ant build files as deprecated.
>
> It seems to work fine right now.
>
IMO its more a documentation thing -- marking as deprecated perhaps,
and stressing that the releases are built with m2. We don't
necess
> -Original Message-
> From: news [mailto:n...@ger.gmane.org] On Behalf Of Jörg Schaible
> Sent: Tuesday, July 28, 2009 1:54 AM
> To: dev@commons.apache.org
> Subject: RE: [VOTE] Release Codec 1.4 based on RC2
>
> Gary Gregory wrote at Dienstag, 28. Juli 2009 10:39:
Hi Mat,
Mat Booth wrote at Dienstag, 28. Juli 2009 10:37:
> Heh, turns out my request to make the ant build better will probably
> get it abolished, though I don't blame you for wanting to maintain
> only one buildsystem. I thought ant and maven would both be first
> class citizens around here bu
Gary Gregory wrote at Dienstag, 28. Juli 2009 10:39:
>> -Original Message-
>> From: Emmanuel Bourg [mailto:ebo...@apache.org]
>> Sent: Tuesday, July 28, 2009 1:29 AM
>> To: Commons Developers List
>> Subject: Re: [VOTE] Release Codec 1.4 based on RC
> -Original Message-
> From: Emmanuel Bourg [mailto:ebo...@apache.org]
> Sent: Tuesday, July 28, 2009 1:29 AM
> To: Commons Developers List
> Subject: Re: [VOTE] Release Codec 1.4 based on RC2
>
> Jörg Schaible a écrit :
>
> > Maybe we should start asking t
On Tue, Jul 28, 2009 at 9:04 AM, Jörg Schaible wrote:
> sebb wrote at Dienstag, 28. Juli 2009 09:40:
>
>> On 28/07/2009, Jörg Schaible wrote:
>>> sebb wrote at Montag, 27. Juli 2009 23:14:
>>>
>>>
>>> > On 27/07/2009, Niall Pemberton wrote:
>>>
>>>
>>> [sinp]
>>>
>>>
>>> >> I dont know the plug
think I am done with fiddling with 1.4-dev for now.
Gary
> -Original Message-
> From: Gary Gregory
> Sent: Saturday, July 25, 2009 8:50 AM
> To: 'Commons Developers List'
> Subject: RE: [VOTE] Release Codec 1.4 based on RC2
>
> I have increased the code cove
Jörg Schaible a écrit :
Maybe we should start asking the other way round: Why do *we* want to
maintain an additional Ant build file? We build our artifacts with Maven,
vote on them and distribute exactly those in the end. I'd never expect to
get the exactly same jar using a different build syste
sebb wrote at Dienstag, 28. Juli 2009 09:40:
> On 28/07/2009, Jörg Schaible wrote:
>> sebb wrote at Montag, 27. Juli 2009 23:14:
>>
>>
>> > On 27/07/2009, Niall Pemberton wrote:
>>
>>
>> [sinp]
>>
>>
>> >> I dont know the plugin, but looking at the code it looks like it
>> >> generates the j
On 28/07/2009, Gary Gregory wrote:
> > -Original Message-
> > From: Niall Pemberton [mailto:niall.pember...@gmail.com]
>
> > Sent: Monday, July 27, 2009 2:01 PM
> > To: Commons Developers List
> > Subject: Re: [VOTE] Release Codec 1.4 based on RC2
>
On 28/07/2009, Jörg Schaible wrote:
> sebb wrote at Montag, 27. Juli 2009 23:14:
>
>
> > On 27/07/2009, Niall Pemberton wrote:
>
>
> [sinp]
>
>
> >> I dont know the plugin, but looking at the code it looks like it
> >> generates the jar and extracts the manifest:
> >>
> >>
>
> http://svn.
On 28/07/2009, Gary Gregory wrote:
> > -Original Message-
> > From: news [mailto:n...@ger.gmane.org] On Behalf Of Jörg Schaible
> > Sent: Monday, July 27, 2009 10:50 PM
> > To: dev@commons.apache.org
> > Subject: Re: [VOTE] Release Codec 1.4 based o
> -Original Message-
> From: news [mailto:n...@ger.gmane.org] On Behalf Of Jörg Schaible
> Sent: Monday, July 27, 2009 10:50 PM
> To: dev@commons.apache.org
> Subject: Re: [VOTE] Release Codec 1.4 based on RC2
>
> sebb wrote at Montag, 27. Juli 2009 23:14:
>
sebb wrote at Montag, 27. Juli 2009 23:14:
> On 27/07/2009, Niall Pemberton wrote:
[sinp]
>> I dont know the plugin, but looking at the code it looks like it
>> generates the jar and extracts the manifest:
>>
>>
http://svn.apache.org/repos/asf/felix/releases/maven-bundle-plugin-2.0.0/src/main
> -Original Message-
> From: Niall Pemberton [mailto:niall.pember...@gmail.com]
> Sent: Monday, July 27, 2009 2:01 PM
> To: Commons Developers List
> Subject: Re: [VOTE] Release Codec 1.4 based on RC2
>
> On Mon, Jul 27, 2009 at 9:45 PM, sebb wrote:
> > On
On 27/07/2009, Niall Pemberton wrote:
> On Mon, Jul 27, 2009 at 9:45 PM, sebb wrote:
> > On 27/07/2009, Niall Pemberton wrote:
> >> On Mon, Jul 27, 2009 at 1:42 PM, sebb wrote:
> >> > On 27/07/2009, Mat Booth wrote:
> >> >> On 27/07/2009, sebb wrote:
> >> >> > I had a quick look at this
On Mon, Jul 27, 2009 at 9:45 PM, sebb wrote:
> On 27/07/2009, Niall Pemberton wrote:
>> On Mon, Jul 27, 2009 at 1:42 PM, sebb wrote:
>> > On 27/07/2009, Mat Booth wrote:
>> >> On 27/07/2009, sebb wrote:
>> >> > I had a quick look at this. It would be trivial to copy the OSGI
>> >> > headers
On Mon, Jul 27, 2009 at 9:45 PM, sebb wrote:
> On 27/07/2009, Niall Pemberton wrote:
>> On Mon, Jul 27, 2009 at 1:42 PM, sebb wrote:
>> > On 27/07/2009, Mat Booth wrote:
>> >> On 27/07/2009, sebb wrote:
>> >> > I had a quick look at this. It would be trivial to copy the OSGI
>> >> > headers
On 27/07/2009, Niall Pemberton wrote:
> On Mon, Jul 27, 2009 at 1:42 PM, sebb wrote:
> > On 27/07/2009, Mat Booth wrote:
> >> On 27/07/2009, sebb wrote:
> >> > I had a quick look at this. It would be trivial to copy the OSGI
> >> > headers as generated by the Maven build, but autogenerating
On Mon, Jul 27, 2009 at 1:42 PM, sebb wrote:
> On 27/07/2009, Mat Booth wrote:
>> On 27/07/2009, sebb wrote:
>> > I had a quick look at this. It would be trivial to copy the OSGI
>> > headers as generated by the Maven build, but autogenerating the
>> > headers (so they would still be OK if the
On Mon, Jul 27, 2009 at 3:05 PM, Mat Booth wrote:
> On 27/07/2009, sebb wrote:
>> On 27/07/2009, Mat Booth wrote:
>> > On 27/07/2009, sebb wrote:
>> > > I had a quick look at this. It would be trivial to copy the OSGI
>> > > headers as generated by the Maven build, but autogenerating the
>> > >
On Sun, Jul 26, 2009 at 11:47 PM, Mat Booth wrote:
>> -Original Message-
>> From: Niall Pemberton [mailto:niall.pember...@gmail.com]
>> Sent: Sunday, July 26, 2009 11:11 AM
>> To: Commons Developers List
>> Subject: Re: [VOTE] Release Codec 1.4 based on RC2
&
On 27/07/2009, sebb wrote:
> On 27/07/2009, Mat Booth wrote:
> > On 27/07/2009, sebb wrote:
> > > I had a quick look at this. It would be trivial to copy the OSGI
> > > headers as generated by the Maven build, but autogenerating the
> > > headers (so they would still be OK if the source changed
On 27/07/2009, Mat Booth wrote:
> On 27/07/2009, sebb wrote:
> > I had a quick look at this. It would be trivial to copy the OSGI
> > headers as generated by the Maven build, but autogenerating the
> > headers (so they would still be OK if the source changed) looks
> > somewhat harder.
> >
>
On Sun, Jul 26, 2009 at 11:47 PM, Mat Booth wrote:
>> -Original Message-
>> From: Niall Pemberton [mailto:niall.pember...@gmail.com]
>> Sent: Sunday, July 26, 2009 11:11 AM
>> To: Commons Developers List
>> Subject: Re: [VOTE] Release Codec 1.4 based on RC2
&
On 27/07/2009, sebb wrote:
> I had a quick look at this. It would be trivial to copy the OSGI
> headers as generated by the Maven build, but autogenerating the
> headers (so they would still be OK if the source changed) looks
> somewhat harder.
>
> For one thing, the "bnd" jar tool seems to need Ja
On 26/07/2009, Mat Booth wrote:
> > -Original Message-
> > From: Niall Pemberton [mailto:niall.pember...@gmail.com]
> > Sent: Sunday, July 26, 2009 11:11 AM
> > To: Commons Developers List
> > Subject: Re: [VOTE] Release Codec 1.4 based on RC2
> >
> -Original Message-
> From: Niall Pemberton [mailto:niall.pember...@gmail.com]
> Sent: Sunday, July 26, 2009 11:11 AM
> To: Commons Developers List
> Subject: Re: [VOTE] Release Codec 1.4 based on RC2
>
> On Sun, Jul 26, 2009 at 5:05 PM, Mat Booth wrote:
> >
>
> -Original Message-
> From: Niall Pemberton [mailto:niall.pember...@gmail.com]
> Sent: Sunday, July 26, 2009 11:11 AM
> To: Commons Developers List
> Subject: Re: [VOTE] Release Codec 1.4 based on RC2
>
> On Sun, Jul 26, 2009 at 5:05 PM, Mat Booth wrote:
>
On Sun, Jul 26, 2009 at 5:05 PM, Mat Booth wrote:
>> -Original Message-
>> From: Julius Davies [mailto:juliusdav...@gmail.com]
>> Sent: Friday, July 24, 2009 1:47 PM
>> To: Commons Developers List
>> Subject: Re: [VOTE] Release Codec 1.4 based on RC2
>>
> -Original Message-
> From: Julius Davies [mailto:juliusdav...@gmail.com]
> Sent: Friday, July 24, 2009 1:47 PM
> To: Commons Developers List
> Subject: Re: [VOTE] Release Codec 1.4 based on RC2
>
> Probably the Maven2 generated Jar is okay in this department?
>
Commons Developers List
>> Subject: Re: [VOTE] Release Codec 1.4 based on RC2
>>
>> Gary Gregory a écrit :
>>
>> > Actually, RequiredCharsetNames is like [lang]'s CharEncoding [1]
>> (http://commons.apache.org/lang/api/org/apache/commons/lang/CharEncoding.h
>
> -Original Message-
> From: Emmanuel Bourg [mailto:ebo...@apache.org]
> Sent: Saturday, July 25, 2009 12:29 PM
> To: Commons Developers List
> Subject: Re: [VOTE] Release Codec 1.4 based on RC2
>
> Gary Gregory a écrit :
>
> > Actually, RequiredCharsetNames
Niall Pemberton wrote:
> I have prepared a second release candidate for Codec 1.4 following the
> feedback (thanks!) from the first.
Although it seems we're heading to RC3, I simply wanna report that the
version builds from the source tarball fine with my compiler zoo.
- Jörg
Gary Gregory a écrit :
Actually, RequiredCharsetNames is like [lang]'s CharEncoding [1]
(http://commons.apache.org/lang/api/org/apache/commons/lang/CharEncoding.htm). But
we've never wanted this kind of dependency from codec->lang.
In work code, we have used [lang]'s CharEncoding and our own
> -Original Message-
> From: Emmanuel Bourg [mailto:ebo...@apache.org]
> Sent: Saturday, July 25, 2009 11:13 AM
> To: Commons Developers List
> Subject: Re: [VOTE] Release Codec 1.4 based on RC2
>
> I looked quickly at the new classes, I'm not convinc
I looked quickly at the new classes, I'm not convinced by the benefit of
the RequiredCharsetNames class in the codec API. I understand it's
useful internally to factorize some string constants in the classes, but
as a user I don't think I would ever use it myself.
Regarding the StringBytesUtil
?) talking about improving code coverage for the
language package. It would be nice to fit that in
Gary
> -Original Message-
> From: Oliver Heger [mailto:oliver.he...@oliver-heger.de]
> Sent: Saturday, July 25, 2009 7:04 AM
> To: Commons Developers List
> Subject: Re: [VOTE
Found no other points than the ones already mentioned in this vote thread.
So +1
Oliver
Niall Pemberton schrieb:
I have prepared a second release candidate for Codec 1.4 following the
feedback (thanks!) from the first.
[ ] +1 Yes go ahead an release based on RC2
[ ] -1 No, because...
The tag
t 1:50 PM, Gary
Gregory wrote:
> Note that for the release, the version should be "1.4", not "1.4-dev" or
> "1.4.0.SNAPSHOT"
>
> Gary
>
>> -Original Message-
>> From: Julius Davies [mailto:juliusdav...@gmail.com]
>> Sent: Friday, July
Codec
> Implementation-Version: 1.4-dev
> Implementation-Vendor: The Apache Software Foundation
> Implementation-Vendor-Id: org.apache
>
>
>
> I don't think missing OSGI headers in the Ant generated jar is a big deal.
>
>
Gregory wrote:
>> -Original Message-----
>> From: sebb [mailto:seb...@gmail.com]
>> Sent: Friday, July 24, 2009 7:35 AM
>> To: Commons Developers List
>> Subject: Re: [VOTE] Release Codec 1.4 based on RC2
>>
>> DoubleMetaphone is not thread-safe - maxCode
> -Original Message-
> From: Luc Maisonobe [mailto:luc.maison...@free.fr]
> Sent: Friday, July 24, 2009 8:17 AM
> To: Commons Developers List
> Subject: Re: [VOTE] Release Codec 1.4 based on RC2
>
> Gary Gregory a écrit :
> >> -Original Message
Gary Gregory a écrit :
>> -Original Message-
>> From: Luc Maisonobe [mailto:luc.maison...@free.fr]
>> Sent: Friday, July 24, 2009 5:40 AM
>> To: Commons Developers List
>> Subject: Re: [VOTE] Release Codec 1.4 based on RC2
>>
>> Niall Pember
> -Original Message-
> From: sebb [mailto:seb...@gmail.com]
> Sent: Friday, July 24, 2009 7:35 AM
> To: Commons Developers List
> Subject: Re: [VOTE] Release Codec 1.4 based on RC2
>
> DoubleMetaphone is not thread-safe - maxCodeLen field - but that could
> be add
> -Original Message-
> From: Luc Maisonobe [mailto:luc.maison...@free.fr]
> Sent: Friday, July 24, 2009 5:40 AM
> To: Commons Developers List
> Subject: Re: [VOTE] Release Codec 1.4 based on RC2
>
> Niall Pemberton a écrit :
> > I have prepared a second rele
> -Original Message-
> From: Luc Maisonobe [mailto:luc.maison...@free.fr]
> Sent: Friday, July 24, 2009 5:40 AM
> To: Commons Developers List
> Subject: Re: [VOTE] Release Codec 1.4 based on RC2
>
> Niall Pemberton a écrit :
> > I have prepared a second rele
DoubleMetaphone is not thread-safe - maxCodeLen field - but that could
be addressed later by adding a new ctor to set the field and make it
final.
The Manifest created by the Ant build file does not include the
compiler settings or OSGI headers.
default.properties uses junit 3.8.1 rather than 3.8
Niall Pemberton a écrit :
> I have prepared a second release candidate for Codec 1.4 following the
> feedback (thanks!) from the first.
>
> [ ] +1 Yes go ahead an release based on RC2
+1
A few findbugs and checkstyle warnings, but really minor ones. Seems to
have very complete testing, congratul
49 matches
Mail list logo
