Re: [jcs] logging

2014-06-03 Thread Benedikt Ritter
Send from my mobile device Am 02.06.2014 um 21:51 schrieb Romain Manni-Bucau rmannibu...@gmail.com: @Thomas: never said [logging] is bad and JUL is better. Sorry if I was not clear. All logging facades don't handle very well EE case for several good or bad reasons. [logging] is as good as

Re: [jcs] logging

2014-06-02 Thread Jörg Schaible
Romain Manni-Bucau wrote: Hi I have two main point to discuss regarding the logging: 1) LogHelper stuffI committed. Idea was to cache isDebugEnabled to get a if (boolean) complexity and not go through the logging framework which can imply several layers (filter, appender, handler,

Re: [jcs] logging

2014-06-02 Thread Romain Manni-Bucau
Well because [logging] was longly broken in a not flat classloading environment (didnt check last release but almost all logging facade got this issue at a point) and because almost nothing in TomEE stacks uses it, it is not as integrated as log4j, slf4j or JUL (which is the default). Main issue I

Re: [jcs] logging

2014-06-02 Thread Gary Gregory
On Mon, Jun 2, 2014 at 1:20 AM, Romain Manni-Bucau rmannibu...@gmail.com wrote: Well ATM log4j2 doesnt work well, didnt get time to dig into it but tested last week for another topic and lost all my shutdown messages (guess cleanup is called too early). Please to check out trunk and give us

Re: [jcs] logging

2014-06-02 Thread Romain Manni-Bucau
@Gary: same with trunk. Here what I do (we can move it to another thread since that's 100% log4j2 related): unzip apache-tomee-1.7.0-SNAPSHOT-webprofile.zip cd apache-tomee-webprofile-1.7.0-SNAPSHOT/ rm conf/logging.properties echo 'openejb.log.factory=log4j'conf/system.properties cp

Re: [jcs] logging

2014-06-02 Thread Gary Gregory
: Commons Developers List dev@commons.apache.org /divdivSubject: Re: [jcs] logging /divdiv /div@Gary: same with trunk. Here what I do (we can move it to another thread since that's 100% log4j2 related): unzip apache-tomee-1.7.0-SNAPSHOT-webprofile.zip cd apache-tomee-webprofile-1.7.0-SNAPSHOT/ rm

Re: [jcs] logging

2014-06-02 Thread Romain Manni-Bucau
: Commons Developers List dev@commons.apache.org /divdivSubject: Re: [jcs] logging /divdiv /div@Gary: same with trunk. Here what I do (we can move it to another thread since that's 100% log4j2 related): unzip apache-tomee-1.7.0-SNAPSHOT-webprofile.zip cd apache-tomee-webprofile-1.7.0-SNAPSHOT

Re: [jcs] logging

2014-06-02 Thread Phil Steitz
On 6/1/14, 12:26 PM, Romain Manni-Bucau wrote: Hi I have two main point to discuss regarding the logging: 1) LogHelper stuffI committed. Idea was to cache isDebugEnabled to get a if (boolean) complexity and not go through the logging framework which can imply several layers (filter,

Re: [jcs] logging

2014-06-02 Thread Romain Manni-Bucau
actually these logs are really debug log not intended to be activated in prod excepted if there is a big issue (@thomas: if you can confirm it would be great). Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau

Re: [jcs] logging

2014-06-02 Thread Thomas Vandahl
On 02.06.14 17:02, Romain Manni-Bucau wrote: actually these logs are really debug log not intended to be activated in prod excepted if there is a big issue (@thomas: if you can confirm it would be great). Yes, logging is for debugging purposes mostly. But if you remove them: how would you do

Re: [jcs] logging

2014-06-02 Thread Thomas Vandahl
On 01.06.14 21:26, Romain Manni-Bucau wrote: Hi I have two main point to discuss regarding the logging: 1) LogHelper stuffI committed. Idea was to cache isDebugEnabled to get a if (boolean) complexity and not go through the logging framework which can imply several layers (filter, appender,

Re: [jcs] logging

2014-06-02 Thread Romain Manni-Bucau
@Thomas: never said [logging] is bad and JUL is better. Sorry if I was not clear. All logging facades don't handle very well EE case for several good or bad reasons. [logging] is as good as slf4j for it (even better out of the box IIRC). JUL is far to be perfect but is in the JVM (so no

Re: [jcs] logging

2014-06-01 Thread sebb
On 1 June 2014 20:26, Romain Manni-Bucau rmannibu...@gmail.com wrote: Hi I have two main point to discuss regarding the logging: 1) LogHelper stuffI committed. Idea was to cache isDebugEnabled to get a if (boolean) complexity and not go through the logging framework which can imply several

RE: [jcs] logging

2014-06-01 Thread Gary Gregory
There is also log4j 2. Gary div Original message /divdivFrom: Romain Manni-Bucau rmannibu...@gmail.com /divdivDate:06/01/2014 15:26 (GMT-05:00) /divdivTo: Commons Developers List dev@commons.apache.org /divdivSubject: [jcs] logging /divdiv /divHi I have two main point to

RE: [jcs] logging

2014-06-01 Thread Romain Manni-Bucau
Well ATM log4j2 doesnt work well, didnt get time to dig into it but tested last week for another topic and lost all my shutdown messages (guess cleanup is called too early). 3 would be an option if we dont rely on [logging] anymore but the impl directly which would be a regression IMHO + either