Re: svn commit: r1457788 - in /commons/proper/fileupload/trunk/src/test/java/org/apache/commons/fileupload/utils: ./ mime/ mime/MimeUtilityTestCase.java

2013-03-19 Thread Simone Tripodi
Best not to enable Date or HeadURL; they are both dependent on the user's settings (Locale and http/https) Not sure there is a use-case for Author either. For a short way to identify a file version, use $Revision$; for the longer version use $Id$ I don't think there's any need for anything

Re: svn commit: r1457788 - in /commons/proper/fileupload/trunk/src/test/java/org/apache/commons/fileupload/utils: ./ mime/ mime/MimeUtilityTestCase.java

2013-03-19 Thread Simone Tripodi
Hi Bene, which is the side effect of having them enabled and not used? we are no longer using Revision and Date for the known reason, so even if they are enabled... what's the downside? I'm playing the devil's advocate here: aren't you the guy you tries to avoid unnecessary code/config as

Re: svn commit: r1457788 - in /commons/proper/fileupload/trunk/src/test/java/org/apache/commons/fileupload/utils: ./ mime/ mime/MimeUtilityTestCase.java

2013-03-19 Thread sebb
It's all getting a bit unnecessary here. My comment was about a new file; I did not see the point of including properties that are not going to be used. I did not veto the commit; it was just an observation. Having said that, if the properties are set it might suggest that they can be used. But

Re: svn commit: r1457788 - in /commons/proper/fileupload/trunk/src/test/java/org/apache/commons/fileupload/utils: ./ mime/ mime/MimeUtilityTestCase.java

2013-03-18 Thread sebb
On 18 March 2013 14:56, simonetrip...@apache.org wrote: Author: simonetripodi Date: Mon Mar 18 14:56:34 2013 New Revision: 1457788 URL: http://svn.apache.org/r1457788 Log: [FILEUPLOAD-232] started importing MimeUtility test case from