Re: svn commit: r1594073 - in /commons/proper/jcs/trunk/commons-jcs-core/src/main/java/org/apache/commons/jcs: auxiliary/remote/server/ engine/memory/ engine/memory/util/

2014-05-13 Thread Phil Steitz
On 5/12/14, 12:46 PM, rmannibu...@apache.org wrote: > Author: rmannibucau > Date: Mon May 12 19:46:08 2014 > New Revision: 1594073 > > URL: http://svn.apache.org/r1594073 > Log: > removing a bunch of synchronized thanks to ConcurrentHashMap - still > removeAll to review since it can be not that go

Re: svn commit: r1594073 - in /commons/proper/jcs/trunk/commons-jcs-core/src/main/java/org/apache/commons/jcs: auxiliary/remote/server/ engine/memory/ engine/memory/util/

2014-05-27 Thread Benedikt Ritter
Send from my mobile device > Am 13.05.2014 um 20:53 schrieb Phil Steitz : > >> On 5/12/14, 12:46 PM, rmannibu...@apache.org wrote: >> Author: rmannibucau >> Date: Mon May 12 19:46:08 2014 >> New Revision: 1594073 >> >> URL: http://svn.apache.org/r1594073 >> Log: >> removing a bunch of synchron

Re: svn commit: r1594073 - in /commons/proper/jcs/trunk/commons-jcs-core/src/main/java/org/apache/commons/jcs: auxiliary/remote/server/ engine/memory/ engine/memory/util/

2014-05-27 Thread Phil Steitz
On 5/27/14, 11:17 AM, Benedikt Ritter wrote: > > Send from my mobile device > >> Am 13.05.2014 um 20:53 schrieb Phil Steitz : >> >>> On 5/12/14, 12:46 PM, rmannibu...@apache.org wrote: >>> Author: rmannibucau >>> Date: Mon May 12 19:46:08 2014 >>> New Revision: 1594073 >>> >>> URL: http://svn.apach

Re: svn commit: r1594073 - in /commons/proper/jcs/trunk/commons-jcs-core/src/main/java/org/apache/commons/jcs: auxiliary/remote/server/ engine/memory/ engine/memory/util/

2014-05-28 Thread Romain Manni-Bucau
I'm convinced of it (why the comment was this way). I'll try to rework it this week based on the LockFactory we spoke about in another thread. Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.c

Re: svn commit: r1594073 - in /commons/proper/jcs/trunk/commons-jcs-core/src/main/java/org/apache/commons/jcs: auxiliary/remote/server/ engine/memory/ engine/memory/util/

2014-05-28 Thread Phil Steitz
On 5/28/14, 4:47 AM, Romain Manni-Bucau wrote: > I'm convinced of it (why the comment was this way). I'll try to rework it > this week based on the LockFactory we spoke about in another thread. Great. Would would be good to explain when implementing these changes is: 0) what sequences of operati

Re: svn commit: r1594073 - in /commons/proper/jcs/trunk/commons-jcs-core/src/main/java/org/apache/commons/jcs: auxiliary/remote/server/ engine/memory/ engine/memory/util/

2014-05-29 Thread Thomas Vandahl
On 28.05.14 13:47, Romain Manni-Bucau wrote: > I'm convinced of it (why the comment was this way). I'll try to rework it > this week based on the LockFactory we spoke about in another thread. Please try to make sure that your conviction is proven by some unit test. Bye, Thomas. ---

Re: svn commit: r1594073 - in /commons/proper/jcs/trunk/commons-jcs-core/src/main/java/org/apache/commons/jcs: auxiliary/remote/server/ engine/memory/ engine/memory/util/

2014-05-29 Thread Romain Manni-Bucau
Hi we should be as before now excepted we use ReentrantLock instead of synchronized and method using a single structure (actually the map in practice) which relies on ConcurrentHashMap thread safety. Build passes locally (not sure why continuum is not happy but it was the case before). BTW I hav