Re: [Codec] Codec 1.4 RC1 available for review
Hi, Niall, That's a nice Gaelic name you have there (my dad's name is Hywel Rhys). Thanks so much for RM'ing codec-1.4. Here's some feedback for you! Codec-1.4 will need the patches from CODEC-80 applied, since they fix an annoying bug. I would also like to get a patch in for CODEC-59 (Add methods to Base64 which work with String instead of byte[]), but I want to upload a new patch. Please ignore the one I uploaded on July 17th. I'll have my * real * patch for CODEC-59 uploaded around this time in 24 hours (11:00PM PDT). But it's not that important. This whole CODEC-59 business can be postponed for a 1.5 release, if ever. yours, Julius On Wed, Jul 22, 2009 at 8:10 PM, sebbseb...@gmail.com wrote: On 23/07/2009, Niall Pemberton niall.pember...@gmail.com wrote: I have prepared a release candidate for Codec 1.4 available here: http://people.apache.org/~niallp/codec-1.4-rc1/ Sigs, hashes OK. NL files look OK It's a bit confusing to have Ant, M1 and M2 build files present - are they all up to date? Builds and tests OK using M2 on Java 1.4. Did not try Ant or M1 builds. Site is available here: http://people.apache.org/~niallp/codec-1.4-rc1/site/ (note: some links are relative and will be broken until deployed to proper codec home) I cannot find any reference to the minimum Java version required. JUnit could be updated to 3.8.2 (assuming Java 1.4+) RAT Report: http://people.apache.org/~niallp/codec-1.4-rc1/site/rat-report.html CLIRR Report: http://people.apache.org/~niallp/codec-1.4-rc1/site/clirr-report.html Release Notes: http://people.apache.org/~niallp/codec-1.4-rc1/site/clirr-report.html http://people.apache.org/~niallp/codec-1.4-rc1/RELEASE-NOTES.txt Feedback welcome. Niall -- yours, Julius Davies 250-592-2284 (Home) 250-893-4579 (Mobile) http://juliusdavies.ca/logging.html - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [Codec] Codec 1.4 RC1 available for review
ps. Regarding CODEC-80, the javadoc and inline comment for testChunkedEncodeMultipleOf76() is wrong. Sorry, I'm tired. On Wed, Jul 22, 2009 at 11:18 PM, Julius Daviesjuliusdav...@gmail.com wrote: Hi, Niall, That's a nice Gaelic name you have there (my dad's name is Hywel Rhys). Thanks so much for RM'ing codec-1.4. Here's some feedback for you! Codec-1.4 will need the patches from CODEC-80 applied, since they fix an annoying bug. I would also like to get a patch in for CODEC-59 (Add methods to Base64 which work with String instead of byte[]), but I want to upload a new patch. Please ignore the one I uploaded on July 17th. I'll have my * real * patch for CODEC-59 uploaded around this time in 24 hours (11:00PM PDT). But it's not that important. This whole CODEC-59 business can be postponed for a 1.5 release, if ever. yours, Julius On Wed, Jul 22, 2009 at 8:10 PM, sebbseb...@gmail.com wrote: On 23/07/2009, Niall Pemberton niall.pember...@gmail.com wrote: I have prepared a release candidate for Codec 1.4 available here: http://people.apache.org/~niallp/codec-1.4-rc1/ Sigs, hashes OK. NL files look OK It's a bit confusing to have Ant, M1 and M2 build files present - are they all up to date? Builds and tests OK using M2 on Java 1.4. Did not try Ant or M1 builds. Site is available here: http://people.apache.org/~niallp/codec-1.4-rc1/site/ (note: some links are relative and will be broken until deployed to proper codec home) I cannot find any reference to the minimum Java version required. JUnit could be updated to 3.8.2 (assuming Java 1.4+) RAT Report: http://people.apache.org/~niallp/codec-1.4-rc1/site/rat-report.html CLIRR Report: http://people.apache.org/~niallp/codec-1.4-rc1/site/clirr-report.html Release Notes: http://people.apache.org/~niallp/codec-1.4-rc1/site/clirr-report.html http://people.apache.org/~niallp/codec-1.4-rc1/RELEASE-NOTES.txt Feedback welcome. Niall -- yours, Julius Davies 250-592-2284 (Home) 250-893-4579 (Mobile) http://juliusdavies.ca/logging.html -- yours, Julius Davies 250-592-2284 (Home) 250-893-4579 (Mobile) http://juliusdavies.ca/logging.html - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [Codec] Codec 1.4 RC1 available for review
On Thu, Jul 23, 2009 at 4:10 AM, sebbseb...@gmail.com wrote: On 23/07/2009, Niall Pemberton niall.pember...@gmail.com wrote: I have prepared a release candidate for Codec 1.4 available here: http://people.apache.org/~niallp/codec-1.4-rc1/ Sigs, hashes OK. NL files look OK It's a bit confusing to have Ant, M1 and M2 build files present - are they all up to date? I have just made some improvements to the ant build. I think we should get rid of the m1 build. Builds and tests OK using M2 on Java 1.4. Did not try Ant or M1 builds. Site is available here: http://people.apache.org/~niallp/codec-1.4-rc1/site/ (note: some links are relative and will be broken until deployed to proper codec home) I cannot find any reference to the minimum Java version required. OK I'll add it to the index page later. thanks for the feedback. Niall JUnit could be updated to 3.8.2 (assuming Java 1.4+) RAT Report: http://people.apache.org/~niallp/codec-1.4-rc1/site/rat-report.html CLIRR Report: http://people.apache.org/~niallp/codec-1.4-rc1/site/clirr-report.html Release Notes: http://people.apache.org/~niallp/codec-1.4-rc1/site/clirr-report.html http://people.apache.org/~niallp/codec-1.4-rc1/RELEASE-NOTES.txt Feedback welcome. Niall - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [Codec] Codec 1.4 RC1 available for review
On Thu, Jul 23, 2009 at 7:18 AM, Julius Daviesjuliusdav...@gmail.com wrote: Hi, Niall, That's a nice Gaelic name you have there (my dad's name is Hywel Rhys). Thanks so much for RM'ing codec-1.4. Here's some feedback for you! Codec-1.4 will need the patches from CODEC-80 applied, since they fix an annoying bug. I would also like to get a patch in for CODEC-59 (Add methods to Base64 which work with String instead of byte[]), but I want to upload a new patch. Please ignore the one I uploaded on July 17th. I'll have my * real * patch for CODEC-59 uploaded around this time in 24 hours (11:00PM PDT). But it's not that important. This whole CODEC-59 business can be postponed for a 1.5 release, if ever. I'm not a Codec developer, so I'm hoping one of them (Gary, Henri?) will review these and apply the patches as they see fit. Thanks for the feedback Niall yours, Julius On Wed, Jul 22, 2009 at 8:10 PM, sebbseb...@gmail.com wrote: On 23/07/2009, Niall Pemberton niall.pember...@gmail.com wrote: I have prepared a release candidate for Codec 1.4 available here: http://people.apache.org/~niallp/codec-1.4-rc1/ Sigs, hashes OK. NL files look OK It's a bit confusing to have Ant, M1 and M2 build files present - are they all up to date? Builds and tests OK using M2 on Java 1.4. Did not try Ant or M1 builds. Site is available here: http://people.apache.org/~niallp/codec-1.4-rc1/site/ (note: some links are relative and will be broken until deployed to proper codec home) I cannot find any reference to the minimum Java version required. JUnit could be updated to 3.8.2 (assuming Java 1.4+) RAT Report: http://people.apache.org/~niallp/codec-1.4-rc1/site/rat-report.html CLIRR Report: http://people.apache.org/~niallp/codec-1.4-rc1/site/clirr-report.html Release Notes: http://people.apache.org/~niallp/codec-1.4-rc1/site/clirr-report.html http://people.apache.org/~niallp/codec-1.4-rc1/RELEASE-NOTES.txt Feedback welcome. Niall -- yours, Julius Davies 250-592-2284 (Home) 250-893-4579 (Mobile) http://juliusdavies.ca/logging.html - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: DBCP deadlock. Is this bug DBCP-270?
Ying Chyn Ng wrote: Hi Mark, Attached is the full thread dump of the DBCP deadlock issue I encountered. Is the information sufficient? Please let me know what other info is required and how to collect it. snip/ Yes, that was sufficient. Actually it was more than sufficient. All that was required was the complete stack traces from the deadlock section. Answers to your original questions below. - Original Message - From: Mark Thomas ma...@apache.org To: Commons Developers List dev@commons.apache.org Sent: Wednesday, July 22, 2009 11:09 PM Subject: Re: DBCP deadlock. Is this bug DBCP-270? Ying Chyn Ng wrote: Hello. I encountered an issue that looks similar to Bug DBCP-270. I wish to know: 1) Is it the same bug or a new one? Don't know. Without the full stack traces for the locked threads it is impossible to tell. Yes, that is DBCP-270 2) Which patch can I apply and how to apply it? That depends on what problem you are seeing. You'd need to apply the patch for DBCP-270 to a local copy of DBCP and then build Tomcat with your modified DBCP sources. 3) Will setting testWhileIdle=false avoid the problem? No. You'd need to completely disable the evictor thread. Note that there are other potential deadlocks not related to the evictor that you may still hit. If you have any more questions, please use either the Commons or Tomcat users list as appropriate. Mark - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[g...@vmgump]: Project commons-configuration-test (in module apache-commons) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-configuration-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 22 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-configuration-test : Apache Commons Full details are available at: http://vmgump.apache.org/gump/public/apache-commons/commons-configuration-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -WARNING- Overriding Maven2 settings: [/srv/gump/public/workspace/apache-commons/configuration/gump_mvn_settings.xml] -DEBUG- (Gump generated) Maven2 Settings in: /srv/gump/public/workspace/apache-commons/configuration/gump_mvn_settings.xml -INFO- Failed with reason build failed -DEBUG- Maven POM in: /srv/gump/public/workspace/apache-commons/configuration/pom.xml -INFO- Project Reports in: /srv/gump/public/workspace/apache-commons/configuration/target/surefire-reports The following work was performed: http://vmgump.apache.org/gump/public/apache-commons/commons-configuration-test/gump_work/build_apache-commons_commons-configuration-test.html Work Name: build_apache-commons_commons-configuration-test (Type: Build) Work ended in a state of : Failed Elapsed: 1 min 51 secs Command Line: mvn --batch-mode --settings /srv/gump/public/workspace/apache-commons/configuration/gump_mvn_settings.xml test [Working Directory: /srv/gump/public/workspace/apache-commons/configuration] CLASSPATH: /usr/lib/jvm/java-6-sun/lib/tools.jar:/srv/gump/public/workspace/apache-commons/configuration/target/commons-configuration-1.7-SNAPSHOT.jar - testInitCopy(org.apache.commons.configuration.TestXMLConfiguration) testSaveWithDelimiterParsingDisabled(org.apache.commons.configuration.TestXMLConfiguration) testSetRootAttribute(org.apache.commons.configuration.TestXMLConfiguration) testLoadAndSaveFromFile(org.apache.commons.configuration.TestXMLConfiguration) testSaveToURL(org.apache.commons.configuration.TestXMLConfiguration) testSaveToStream(org.apache.commons.configuration.TestXMLConfiguration) testAutoSave(org.apache.commons.configuration.TestXMLConfiguration) testSaveAttributes(org.apache.commons.configuration.TestXMLConfiguration) testCloneWithSave(org.apache.commons.configuration.TestXMLConfiguration) testEmptyElements(org.apache.commons.configuration.TestXMLConfiguration) testSaveWithEncoding(org.apache.commons.configuration.TestXMLConfiguration) testSaveWithNullEncoding(org.apache.commons.configuration.TestXMLConfiguration) testSaveWithDoctype(org.apache.commons.configuration.TestXMLConfiguration) testSaveWithDoctypeIDs(org.apache.commons.configuration.TestXMLConfiguration) testSubsetWithReload(org.apache.commons.configuration.TestXMLConfiguration) testConfigurationAtWithReload(org.apache.commons.configuration.TestXMLConfiguration) testConfigurationsAtWithReload(org.apache.commons.configuration.TestXMLConfiguration) testGetKeysWithReload(org.apache.commons.configuration.TestXMLConfiguration) testSetTextRootElement(org.apache.commons.configuration.TestXMLConfiguration) testClearTextRootElement(org.apache.commons.configuration.TestXMLConfiguration) testAutoSaveWithSubnodeConfig(org.apache.commons.configuration.TestXMLConfiguration) testAutoSaveWithSubSubnodeConfig(org.apache.commons.configuration.TestXMLConfiguration) testSaveDelimiterParsingDisabled(org.apache.commons.configuration.TestXMLConfiguration) testSaveDelimiterParsingDisabledAttrs(org.apache.commons.configuration.TestXMLConfiguration) testMultipleAttrValuesEscaped(org.apache.commons.configuration.TestXMLConfiguration) testAutoSaveWithReloadingStrategy(org.apache.commons.configuration.TestXMLConfiguration) testAutoSaveAddNodes(org.apache.commons.configuration.TestXMLConfiguration) testAddNodesAndSave(org.apache.commons.configuration.TestXMLConfiguration) testRegisterEntityId(org.apache.commons.configuration.TestXMLConfiguration) testSaveAfterCreateWithCopyConstructor(org.apache.commons.configuration.TestXMLConfiguration) testCopyRootName(org.apache.commons.configuration.TestXMLConfiguration) testCopyRootNameNoDocument(org.apache.commons.configuration.TestXMLConfiguration) testSaveWithValidation(org.apache.commons.configuration.TestXMLConfiguration) testSaveWithValidationFailure(org.apache.commons.configuration.TestXMLConfiguration) Tests run: 1432, Failures: 0, Errors: 54, Skipped: 0 [INFO] [ERROR] BUILD FAILURE [INFO]
[g...@vmgump]: Project commons-jelly-tags-fmt-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-jelly-tags-fmt-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 3 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-fmt-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-fmt-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -WARNING- Overriding Maven properties: [/srv/gump/public/workspace/commons-jelly/jelly-tags/fmt/build.properties] -DEBUG- (Gump generated) Maven Properties in: /srv/gump/public/workspace/commons-jelly/jelly-tags/fmt/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /srv/gump/public/workspace/commons-jelly/jelly-tags/fmt/project.xml -DEBUG- Maven project properties in: /srv/gump/public/workspace/commons-jelly/jelly-tags/fmt/project.properties -INFO- Project Reports in: /srv/gump/public/workspace/commons-jelly/jelly-tags/fmt/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-fmt-test/gump_work/build_commons-jelly_commons-jelly-tags-fmt-test.html Work Name: build_commons-jelly_commons-jelly-tags-fmt-test (Type: Build) Work ended in a state of : Failed Elapsed: 6 secs Command Line: maven --offline jar [Working Directory: /srv/gump/public/workspace/commons-jelly/jelly-tags/fmt] CLASSPATH: /usr/lib/jvm/java-6-sun/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/ant/dist/lib/ant-trax.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/packages/bsh-2.0b4/bsh-commands-2.0b4.jar:/srv/gump/packages/bsh-2.0b4/bsh-classpath-2.0b4.jar:/srv/gump/packages/bsh-2.0b4/bsh-core-2.0b4.jar:/srv/gump/packages/bsh-2.0b4/bsh-bsf-2.0b4.jar:/srv/gump/packages/bsh-2.0b4/bsh-2.0b4.jar:/srv/gump/packages/bsh-2.0b4/bsh-reflect-2.0b4.jar:/srv/gump/packages/bsh-2.0b4/bsh-util-2.0b4.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-23072009.jar:/srv/gump/pu blic/workspace/apache-commons/collections/build/commons-collections-23072009.jar:/srv/gump/public/workspace/commons-jelly/target/commons-jelly-23072009.jar:/srv/gump/public/workspace/commons-jelly/jelly-tags/ant/target/commons-jelly-tags-ant-23072009.jar:/srv/gump/public/workspace/commons-jelly/jelly-tags/beanshell/target/commons-jelly-tags-beanshell-23072009.jar:/srv/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-23072009.jar:/srv/gump/public/workspace/apache-commons/jexl/dist/commons-jexl-23072009.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-23072009.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-23072009.jar:/srv/gump/public/workspace/dom4j/build/dom4j.jar:/srv/gump/public/workspace/jaxen/target/jaxen-23072009.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar:/srv/gump/public/workspace/commons-jelly/jelly-tags/fmt/target/commons-jelly-tags- fmt-23072009.jar - [junit] at org.apache.commons.jelly.tags.ant.AntTag.doTag(AntTag.java:111) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:267) [junit] ... 11 more [junit] Root cause [junit] java.lang.NoClassDefFoundError: org/apache/tools/ant/Main [junit] at org.apache.commons.jelly.tags.ant.AntTagLibrary.createProject(AntTagLibrary.java:128) [junit] at org.apache.commons.jelly.tags.ant.AntTagLibrary.getProject(AntTagLibrary.java:96) [junit] at org.apache.commons.jelly.tags.ant.AntTag.getAntProject(AntTag.java:310) [junit] at org.apache.commons.jelly.tags.ant.AntTag.doTag(AntTag.java:111) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:267) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:96) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:60) [junit] [junit] [junit] Testcase:
[g...@vmgump]: Project commons-jelly-tags-jaxme (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-jelly-tags-jaxme has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 3 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-jaxme : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jaxme/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-jelly-tags-jaxme-23072009.jar] identifier set to project name -DEBUG- Dependency on packaged-jaxme exists, no need to add for property maven.jar.jaxme. -DEBUG- Dependency on packaged-jaxme exists, no need to add for property maven.jar.jaxme-js. -DEBUG- Dependency on packaged-jaxme exists, no need to add for property maven.jar.jaxme-xs. -DEBUG- Dependency on packaged-jaxme exists, no need to add for property maven.jar.jaxme-api. -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -DEBUG- Dependency on xmlunit exists, no need to add for property maven.jar.xmlunit. -DEBUG- (Gump generated) Maven Properties in: /srv/gump/public/workspace/commons-jelly/jelly-tags/jaxme/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /srv/gump/public/workspace/commons-jelly/jelly-tags/jaxme/project.xml -DEBUG- Maven project properties in: /srv/gump/public/workspace/commons-jelly/jelly-tags/jaxme/project.properties -INFO- Project Reports in: /srv/gump/public/workspace/commons-jelly/jelly-tags/jaxme/target/test-reports -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jaxme/gump_work/build_commons-jelly_commons-jelly-tags-jaxme.html Work Name: build_commons-jelly_commons-jelly-tags-jaxme (Type: Build) Work ended in a state of : Failed Elapsed: 15 secs Command Line: maven --offline jar [Working Directory: /srv/gump/public/workspace/commons-jelly/jelly-tags/jaxme] CLASSPATH: /usr/lib/jvm/java-6-sun/lib/tools.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-23072009.jar:/srv/gump/public/workspace/apache-commons/collections/build/commons-collections-23072009.jar:/srv/gump/public/workspace/commons-jelly/target/commons-jelly-23072009.jar:/srv/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-23072009.jar:/srv/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-23072009.jar:/srv/gump/public/workspace/commons-jelly/jelly-tags/xmlunit/target/commons-jelly-tags-xmlunit-23072009.jar:/srv/gump/public/workspace/apache-commons/jexl/dist/commons-jexl-23072009.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-23072009.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-23072009.jar:/srv/gump/public/workspace/dom4j/build/dom4j.jar:/srv/gump/public/workspace/jaxen/target/jaxen-23072009.jar:/srv/gump/pack ages/ws-jaxme-0.5/lib/jaxme2-0.5.jar:/srv/gump/packages/ws-jaxme-0.5/lib/jaxmeapi-0.5.jar:/srv/gump/packages/ws-jaxme-0.5/lib/jaxmejs-0.5.jar:/srv/gump/packages/ws-jaxme-0.5/lib/jaxmexs-0.5.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar:/srv/gump/public/workspace/xmlunit/build/java/lib/xmlunit-sumo-23072009.jar:/srv/gump/public/workspace/xmlunit/build/java/lib/xmlunit-legacy-23072009.jar:/srv/gump/public/workspace/xmlunit/build/java/lib/xmlunit-core-23072009.jar - [javac] symbol : variable super [javac] location: class org.apache.ws.jaxme.examples.misc.address.impl.AddressTypeHandler [javac] super.characters(pChars, pOffset, pLen); [javac] ^ [javac] /srv/gump/public/workspace/commons-jelly/jelly-tags/jaxme/src/test/org/apache/ws/jaxme/examples/misc/address/impl/AddressTypeHandler.java:305: cannot find symbol [javac] symbol : variable super [javac] location: class org.apache.ws.jaxme.examples.misc.address.impl.AddressTypeHandler [javac] super.init(pData); [javac] ^ [javac] /srv/gump/public/workspace/commons-jelly/jelly-tags/jaxme/src/test/org/apache/ws/jaxme/examples/misc/address/impl/AddressTypeHandler.java:315: cannot find symbol [javac] symbol : method getData() [javac] location: class org.apache.ws.jaxme.examples.misc.address.impl.AddressTypeHandler [javac] __handler_Name.init(getData()); [javac] ^ [javac]
Re: [Codec] Codec 1.4 RC1 available for review
On 23/07/2009, Niall Pemberton niall.pember...@gmail.com wrote: On Thu, Jul 23, 2009 at 4:10 AM, sebbseb...@gmail.com wrote: On 23/07/2009, Niall Pemberton niall.pember...@gmail.com wrote: I have prepared a release candidate for Codec 1.4 available here: http://people.apache.org/~niallp/codec-1.4-rc1/ Sigs, hashes OK. NL files look OK It's a bit confusing to have Ant, M1 and M2 build files present - are they all up to date? I have just made some improvements to the ant build. I think we should get rid of the m1 build. +1 Builds and tests OK using M2 on Java 1.4. Did not try Ant or M1 builds. Site is available here: http://people.apache.org/~niallp/codec-1.4-rc1/site/ (note: some links are relative and will be broken until deployed to proper codec home) I cannot find any reference to the minimum Java version required. OK I'll add it to the index page later. thanks for the feedback. Niall JUnit could be updated to 3.8.2 (assuming Java 1.4+) RAT Report: http://people.apache.org/~niallp/codec-1.4-rc1/site/rat-report.html CLIRR Report: http://people.apache.org/~niallp/codec-1.4-rc1/site/clirr-report.html Release Notes: http://people.apache.org/~niallp/codec-1.4-rc1/site/clirr-report.html http://people.apache.org/~niallp/codec-1.4-rc1/RELEASE-NOTES.txt Feedback welcome. Niall - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
RE: [Codec] Codec 1.4 RC1 available for review
-Original Message- From: sebb [mailto:seb...@gmail.com] Sent: Wednesday, July 22, 2009 8:10 PM To: Commons Developers List Subject: Re: [Codec] Codec 1.4 RC1 available for review On 23/07/2009, Niall Pemberton niall.pember...@gmail.com wrote: I have prepared a release candidate for Codec 1.4 available here: http://people.apache.org/~niallp/codec-1.4-rc1/ Sigs, hashes OK. NL files look OK It's a bit confusing to have Ant, M1 and M2 build files present - are they all up to date? Builds and tests OK using M2 on Java 1.4. Did not try Ant or M1 builds. Site is available here: http://people.apache.org/~niallp/codec-1.4-rc1/site/ (note: some links are relative and will be broken until deployed to proper codec home) I cannot find any reference to the minimum Java version required. The minimum Java requirement is 1.4.2 as of codec 1.4. JUnit could be updated to 3.8.2 (assuming Java 1.4+) Sure, please migrate up. Gary - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [Codec] Codec 1.4 RC1 available for review
On Thu, Jul 23, 2009 at 4:31 PM, Gary Gregoryggreg...@seagullsoftware.com wrote: -Original Message- From: sebb [mailto:seb...@gmail.com] Sent: Thursday, July 23, 2009 8:22 AM To: Commons Developers List Subject: Re: [Codec] Codec 1.4 RC1 available for review On 23/07/2009, Niall Pemberton niall.pember...@gmail.com wrote: On Thu, Jul 23, 2009 at 4:10 AM, sebbseb...@gmail.com wrote: On 23/07/2009, Niall Pemberton niall.pember...@gmail.com wrote: I have prepared a release candidate for Codec 1.4 available here: http://people.apache.org/~niallp/codec-1.4-rc1/ Sigs, hashes OK. NL files look OK It's a bit confusing to have Ant, M1 and M2 build files present - are they all up to date? I have just made some improvements to the ant build. I think we should get rid of the m1 build. +1 Yes, I have used m2, which works; I do not see the point of keeping m1 around. OK m1 build has been removed so we need someone to look at the issues Julius raised before cutting another RC. Niall Gary - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
RE: Commons Dbutils: Request feedback for possible patch; handling nested beans.
I disagree. I see it as an enhancement. This limitation of dbutils is not
mentioned in the docs and the user stumbles upon it as a bug when he finds the
member is unfilled.
However this fix to BeanProcessor only covers bean(s) containing singly nested
beans. IMHO It would be good if we can figure out how to do bean(s) containing
singly nested or a list of nested beans; one-many.
thanks,
Anil Philip
-Original Message-
From: Dan Fabulich [mailto:d...@fabulich.com]
Sent: Wednesday, July 22, 2009 7:03 PM
To: Commons Developers List
Subject: RE: Commons Dbutils: Request feedback for possible patch; handling
nested beans.
I share Liam's intuition that I don't think we need this.
Now that you've written this processor for yourself, you can use it; it's
easy to pass your own BeanProcessor to BasicRowProcessor, and you can
always hand that BRP to any of our existing ResultSetHandlers.
Trying to provide perfectly general bean-mapping functionality may be
over-engineering the problem. The fact that you were able to pull this
together in just a few lines of code is evidence that it may not be
necessary to provide it in DBUtils.
-Dan
Philip, Anil - Kansas City, MO wrote:
My fix was to create a NestedBeanProcessor that inherited from BeanProcessor
and accepts a mapping in the constructor.
However, **in a patch, it would be better to simply modify the toBean() in
BeanProcessor and add a constructor that accepts a Hashtable**.
Current fix:
1) For each nested bean, users will provide a mapping of property to nested
object reference so that the property can be found. In the above example,
that would be: bar--- ['activity', Bar.class]
2) A new class, NestedBeanProcessor inherits from the BeanProcessor class in
Dbutils. It overrides the toBean() method.(Note: for a patch, We would add a
constructor that accepts a hashtable, and also modify toBean()) When this
method is called to populate a bean from a result set, it asks the superclass
to fill in the data. Then it examines each mapping. Using Java Reflection, it
retrieves the nested reference. If this is null, it creates the nested bean.
Next, it retrieves the value of the field in the result set and calls the
setter method on the bean.
3) In the case where Foo contained a list of nested beans:
for example
ArrayListBar bar;
There is no way to specify this one-many relationship in Dbutils for
automatic filling of bar.activity from the top-level query. We would in this
case, fill in the fields of Foo and then use this instance to run a second
query, using the BeanListHandler to fill in the bar list and any nested
fields of Bar.
HashtablePropertyDescriptor, String ht = new HashtablePropertyDescriptor,
String();
PropertyDescriptor prop = new PropertyDescriptor(activity, Bar.class);
ht.put(prop, bar);
NestedBeanProcessor nbp = new NestedBeanProcessor(ht);
QueryRunner runner = new QueryRunner();
BasicRowProcessor burp = new BasicRowProcessor(nbp);
BeanHandler bh = new BeanHandler(Foo.class, burp);
Foo foo = (Foo) runner.query(connection, select face, activity from
Mood, bh);
System.out.println(foo.getFace() + during this activity: +
foo.getBar().getActivity());
Result:
huffing during this activity: jog
public class NestedBeanProcessor extends BeanProcessor {
...relevant methods shown...
HashtablePropertyDescriptor, String propertyForBeanMember;
public NestedBeanProcessor(
HashtablePropertyDescriptor, String propertyForBeanMember) {
super();
this.propertyForBeanMember = propertyForBeanMember;
}
@Override
public Object toBean(ResultSet rs, Class type) throws SQLException {
Object bean = super.toBean(rs, type);
EnumerationPropertyDescriptor keys = propertyForBeanMember.keys();
while (keys.hasMoreElements()) {
PropertyDescriptor property = keys.nextElement();
Class? beanClass = bean.getClass();
try {
String fieldName = propertyForBeanMember.get(property);
String fieldNameCapitalized = fieldName.substring(0, 1)
.toUpperCase()
+ fieldName.substring(1);
String fieldGetterName = get + fieldNameCapitalized;
String fieldSetterName = set + fieldNameCapitalized;
Method fieldGetterMethod = beanClass
.getDeclaredMethod(fieldGetterName);
Method fieldSetterMethod = null;
// we have to go thru all the methods because
// PropertyDescriptor doesn't seem to provide a way to retrieve
// the fieldClass
// i.e. we would have liked to simply do
// fieldSetterMethod = beanClass.getDeclaredMethod(fieldSetterName,
Bar.class);
Method[] allMethods = beanClass.getDeclaredMethods();
for (Method m : allMethods) {
Re: Commons Dbutils: Request feedback for possible patch; handling nested beans.
It's not a bug though.
No where in the documentation for your push mower does it say it won't split
logs.
dbutils is not a complete DAO solution, or an ORM tool, it's a framework on
top of which to build custom DAO and ORM solutions.
handling relationships is far and beyond scope.
On Thu, Jul 23, 2009 at 1:06 PM, Philip, Anil - Kansas City, MO
anil.phi...@kcc.usda.gov wrote:
I disagree. I see it as an enhancement. This limitation of dbutils is not
mentioned in the docs and the user stumbles upon it as a bug when he finds
the member is unfilled.
However this fix to BeanProcessor only covers bean(s) containing singly
nested beans. IMHO It would be good if we can figure out how to do bean(s)
containing singly nested or a list of nested beans; one-many.
thanks,
Anil Philip
-Original Message-
From: Dan Fabulich [mailto:d...@fabulich.com]
Sent: Wednesday, July 22, 2009 7:03 PM
To: Commons Developers List
Subject: RE: Commons Dbutils: Request feedback for possible patch; handling
nested beans.
I share Liam's intuition that I don't think we need this.
Now that you've written this processor for yourself, you can use it; it's
easy to pass your own BeanProcessor to BasicRowProcessor, and you can
always hand that BRP to any of our existing ResultSetHandlers.
Trying to provide perfectly general bean-mapping functionality may be
over-engineering the problem. The fact that you were able to pull this
together in just a few lines of code is evidence that it may not be
necessary to provide it in DBUtils.
-Dan
Philip, Anil - Kansas City, MO wrote:
My fix was to create a NestedBeanProcessor that inherited from
BeanProcessor and accepts a mapping in the constructor.
However, **in a patch, it would be better to simply modify the toBean()
in BeanProcessor and add a constructor that accepts a Hashtable**.
Current fix:
1) For each nested bean, users will provide a mapping of property to
nested object reference so that the property can be found. In the above
example, that would be: bar--- ['activity', Bar.class]
2) A new class, NestedBeanProcessor inherits from the BeanProcessor class
in Dbutils. It overrides the toBean() method.(Note: for a patch, We would
add a constructor that accepts a hashtable, and also modify toBean()) When
this method is called to populate a bean from a result set, it asks the
superclass to fill in the data. Then it examines each mapping. Using Java
Reflection, it retrieves the nested reference. If this is null, it creates
the nested bean. Next, it retrieves the value of the field in the result set
and calls the setter method on the bean.
3) In the case where Foo contained a list of nested beans:
for example
ArrayListBar bar;
There is no way to specify this one-many relationship in Dbutils for
automatic filling of bar.activity from the top-level query. We would in this
case, fill in the fields of Foo and then use this instance to run a second
query, using the BeanListHandler to fill in the bar list and any nested
fields of Bar.
HashtablePropertyDescriptor, String ht = new
HashtablePropertyDescriptor, String();
PropertyDescriptor prop = new PropertyDescriptor(activity, Bar.class);
ht.put(prop, bar);
NestedBeanProcessor nbp = new NestedBeanProcessor(ht);
QueryRunner runner = new QueryRunner();
BasicRowProcessor burp = new BasicRowProcessor(nbp);
BeanHandler bh = new BeanHandler(Foo.class, burp);
Foo foo = (Foo) runner.query(connection, select face, activity from
Mood, bh);
System.out.println(foo.getFace() + during this activity: +
foo.getBar().getActivity());
Result:
huffing during this activity: jog
public class NestedBeanProcessor extends BeanProcessor {
...relevant methods shown...
HashtablePropertyDescriptor, String propertyForBeanMember;
public NestedBeanProcessor(
HashtablePropertyDescriptor, String propertyForBeanMember) {
super();
this.propertyForBeanMember = propertyForBeanMember;
}
@Override
public Object toBean(ResultSet rs, Class type) throws SQLException {
Object bean = super.toBean(rs, type);
EnumerationPropertyDescriptor keys =
propertyForBeanMember.keys();
while (keys.hasMoreElements()) {
PropertyDescriptor property = keys.nextElement();
Class? beanClass = bean.getClass();
try {
String fieldName =
propertyForBeanMember.get(property);
String fieldNameCapitalized =
fieldName.substring(0, 1)
.toUpperCase()
+ fieldName.substring(1);
String fieldGetterName = get +
fieldNameCapitalized;
String fieldSetterName = set +
fieldNameCapitalized;
Method fieldGetterMethod = beanClass
.getDeclaredMethod(fieldGetterName);
Method fieldSetterMethod = null;
RE: [Codec] Codec 1.4 RC1 available for review
I have taken care of [CODEC-80]. Gary -Original Message- From: Niall Pemberton [mailto:niall.pember...@gmail.com] Sent: Wednesday, July 22, 2009 11:37 PM To: Commons Developers List Subject: Re: [Codec] Codec 1.4 RC1 available for review On Thu, Jul 23, 2009 at 7:18 AM, Julius Daviesjuliusdav...@gmail.com wrote: Hi, Niall, That's a nice Gaelic name you have there (my dad's name is Hywel Rhys). Thanks so much for RM'ing codec-1.4. Here's some feedback for you! Codec-1.4 will need the patches from CODEC-80 applied, since they fix an annoying bug. I would also like to get a patch in for CODEC-59 (Add methods to Base64 which work with String instead of byte[]), but I want to upload a new patch. Please ignore the one I uploaded on July 17th. I'll have my * real * patch for CODEC-59 uploaded around this time in 24 hours (11:00PM PDT). But it's not that important. This whole CODEC-59 business can be postponed for a 1.5 release, if ever. I'm not a Codec developer, so I'm hoping one of them (Gary, Henri?) will review these and apply the patches as they see fit. Thanks for the feedback Niall yours, Julius On Wed, Jul 22, 2009 at 8:10 PM, sebbseb...@gmail.com wrote: On 23/07/2009, Niall Pemberton niall.pember...@gmail.com wrote: I have prepared a release candidate for Codec 1.4 available here: http://people.apache.org/~niallp/codec-1.4-rc1/ Sigs, hashes OK. NL files look OK It's a bit confusing to have Ant, M1 and M2 build files present - are they all up to date? Builds and tests OK using M2 on Java 1.4. Did not try Ant or M1 builds. Site is available here: http://people.apache.org/~niallp/codec-1.4-rc1/site/ (note: some links are relative and will be broken until deployed to proper codec home) I cannot find any reference to the minimum Java version required. JUnit could be updated to 3.8.2 (assuming Java 1.4+) RAT Report: http://people.apache.org/~niallp/codec-1.4-rc1/site/rat-report.html CLIRR Report: http://people.apache.org/~niallp/codec-1.4-rc1/site/clirr-report.html Release Notes: http://people.apache.org/~niallp/codec-1.4-rc1/site/clirr-report.html http://people.apache.org/~niallp/codec-1.4-rc1/RELEASE-NOTES.txt Feedback welcome. Niall -- yours, Julius Davies 250-592-2284 (Home) 250-893-4579 (Mobile) http://juliusdavies.ca/logging.html - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
RE: [Codec] Codec 1.4 RC1 available for review
Julius: Do you mean it should be: // ... convert to \r\n instead of // ... convert to \n ? Gary -Original Message- From: Julius Davies [mailto:juliusdav...@gmail.com] Sent: Wednesday, July 22, 2009 11:31 PM To: Commons Developers List Subject: Re: [Codec] Codec 1.4 RC1 available for review ps. Regarding CODEC-80, the javadoc and inline comment for testChunkedEncodeMultipleOf76() is wrong. Sorry, I'm tired. On Wed, Jul 22, 2009 at 11:18 PM, Julius Daviesjuliusdav...@gmail.com wrote: Hi, Niall, That's a nice Gaelic name you have there (my dad's name is Hywel Rhys). Thanks so much for RM'ing codec-1.4. Here's some feedback for you! Codec-1.4 will need the patches from CODEC-80 applied, since they fix an annoying bug. I would also like to get a patch in for CODEC-59 (Add methods to Base64 which work with String instead of byte[]), but I want to upload a new patch. Please ignore the one I uploaded on July 17th. I'll have my * real * patch for CODEC-59 uploaded around this time in 24 hours (11:00PM PDT). But it's not that important. This whole CODEC-59 business can be postponed for a 1.5 release, if ever. yours, Julius On Wed, Jul 22, 2009 at 8:10 PM, sebbseb...@gmail.com wrote: On 23/07/2009, Niall Pemberton niall.pember...@gmail.com wrote: I have prepared a release candidate for Codec 1.4 available here: http://people.apache.org/~niallp/codec-1.4-rc1/ Sigs, hashes OK. NL files look OK It's a bit confusing to have Ant, M1 and M2 build files present - are they all up to date? Builds and tests OK using M2 on Java 1.4. Did not try Ant or M1 builds. Site is available here: http://people.apache.org/~niallp/codec-1.4-rc1/site/ (note: some links are relative and will be broken until deployed to proper codec home) I cannot find any reference to the minimum Java version required. JUnit could be updated to 3.8.2 (assuming Java 1.4+) RAT Report: http://people.apache.org/~niallp/codec-1.4-rc1/site/rat-report.html CLIRR Report: http://people.apache.org/~niallp/codec-1.4-rc1/site/clirr-report.html Release Notes: http://people.apache.org/~niallp/codec-1.4-rc1/site/clirr-report.html http://people.apache.org/~niallp/codec-1.4-rc1/RELEASE-NOTES.txt Feedback welcome. Niall -- yours, Julius Davies 250-592-2284 (Home) 250-893-4579 (Mobile) http://juliusdavies.ca/logging.html -- yours, Julius Davies 250-592-2284 (Home) 250-893-4579 (Mobile) http://juliusdavies.ca/logging.html - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: svn commit: r797120 - in /commons/proper/codec/trunk: build.xml maven.xml project.properties project.xml src/assembly/src.xml src/conf/
Hi, Niall,
This removal breaks the ant build:
commons/proper/codec/trunk/src/conf/
But it's easy to fix. Just remove these 3 lines from build.xml:
53 copy todir=${build.home}/conf filtering=on
54 fileset dir=${conf.home} includes=*.MF/
55 /copy
yours,
Julius
On Thu, Jul 23, 2009 at 8:56 AM, nia...@apache.org wrote:
Author: niallp
Date: Thu Jul 23 15:56:03 2009
New Revision: 797120
URL: http://svn.apache.org/viewvc?rev=797120view=rev
Log:
Remove Maven 1 build
Removed:
commons/proper/codec/trunk/maven.xml
commons/proper/codec/trunk/project.properties
commons/proper/codec/trunk/project.xml
commons/proper/codec/trunk/src/conf/
Modified:
commons/proper/codec/trunk/build.xml
commons/proper/codec/trunk/src/assembly/src.xml
Modified: commons/proper/codec/trunk/build.xml
URL:
http://svn.apache.org/viewvc/commons/proper/codec/trunk/build.xml?rev=797120r1=797119r2=797120view=diff
==
--- commons/proper/codec/trunk/build.xml (original)
+++ commons/proper/codec/trunk/build.xml Thu Jul 23 15:56:03 2009
@@ -164,11 +164,8 @@
zipfileset dir=. includes=checkstyle.xml
prefix=${final.name}//
zipfileset dir=. includes=default.properties
prefix=${final.name}//
zipfileset dir=. includes=LICENSE*.txt
prefix=${final.name}//
- zipfileset dir=. includes=maven.xml prefix=${final.name}//
zipfileset dir=. includes=NOTICE.txt prefix=${final.name}//
zipfileset dir=. includes=pom.xml prefix=${final.name}//
- zipfileset dir=. includes=project.properties
prefix=${final.name}//
- zipfileset dir=. includes=project.xml
prefix=${final.name}//
zipfileset dir=. includes=RELEASE-NOTES*.txt
prefix=${final.name}//
/zip
checksum algorithm=md5 file=${zip-src.path} fileext=.md5/
Modified: commons/proper/codec/trunk/src/assembly/src.xml
URL:
http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/assembly/src.xml?rev=797120r1=797119r2=797120view=diff
==
--- commons/proper/codec/trunk/src/assembly/src.xml (original)
+++ commons/proper/codec/trunk/src/assembly/src.xml Thu Jul 23 15:56:03 2009
@@ -30,11 +30,8 @@
includedefault.properties/include
includeLICENSE.txt/include
includeLICENSE-header.txt/include
- includemaven.xml/include
includeNOTICE.txt/include
includepom.xml/include
- includeproject.properties/include
- includeproject.xml/include
includeRELEASE-NOTES*.txt/include
includeRELEASE-PLAN/include
includeTODO/include
--
yours,
Julius Davies
250-592-2284 (Home)
250-893-4579 (Mobile)
http://juliusdavies.ca/logging.html
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
RE: svn commit: r797267 - in /commons/proper/configuration/trunk/src/java/org/apache/commons/configuration: FileSystem.java VFSFileSystem.java
Hi!
Modified:
commons/proper/configuration/trunk/src/java/org/apache/commons/configur
ation/VFSFileSystem.java
-private FileSystemOptions setHttpOptions(FileSystemOptions opts,
Map map)
+private void setProperty(FileSystemConfigBuilder builder,
FileSystemOptions options,
+ String key, Object value)
{
-setDefaultOptions(opts, map);
+String methodName = set + key.substring(0,1).toUpperCase() +
key.substring(1);
+Class[] paramTypes = new Class[2];
+paramTypes[0] = FileSystemOptions.class;
+paramTypes[1] = value.getClass();
Hmmm ... I am not quite sure of the rest of the code, but did you see the
DelegatingFileSystemOptionsBuilder [1]?
It also sets the configuration using reflection based on just strings.
Ciao,
Mario
[1]
http://commons.apache.org/vfs/apidocs/org/apache/commons/vfs/util/DelegatingFileSystemOptionsBuilder.html
