Re: [compress] potential bzip2 improvement

2009-03-27 Thread Stefan Bodewig
On 2009-03-26, Torsten Curdt tcu...@apache.org wrote: If the code has been tested by the folks at hadoop I trust it very much. (They do extensive testing!) and would be all for replacing the current code base. I just did it 8-) svn revision 759143 Stefan

Re: [compress] potential bzip2 improvement

2009-03-26 Thread Jochen Wiedmann
On Thu, Mar 26, 2009 at 12:36 PM, sebb seb...@gmail.com wrote: Would it be a silly idea to include both variants? I'd clearly tend to avoid that. It would likely cause confusion. On a related matter: Stefan, wouldn't it be possible for the others to start using compress? Jochen -- I have

Re: [compress] potential bzip2 improvement

2009-03-26 Thread sebb
On 26/03/2009, Stefan Bodewig bode...@apache.org wrote: Hi folks, first of all I don't know enough about the bzip2 format to undestand the existing code, nor the one I'll be pointing at further down. The current code in compress is the one of Ant 1.7.1 and versions prior to 1.7.0. In

Re: [compress] potential bzip2 improvement

2009-03-26 Thread sebb
On 26/03/2009, Jochen Wiedmann jochen.wiedm...@gmail.com wrote: On Thu, Mar 26, 2009 at 12:36 PM, sebb seb...@gmail.com wrote: Would it be a silly idea to include both variants? I'd clearly tend to avoid that. It would likely cause confusion. Surely that depends on how well it is

Re: [compress] potential bzip2 improvement

2009-03-26 Thread Torsten Curdt
If the code has been tested by the folks at hadoop I trust it very much. (They do extensive testing!) and would be all for replacing the current code base. But IMO that's no blocker. In the end the algorithm should be a black box for everyone using compress. So changing this in a later release

Re: [compress] potential bzip2 improvement

2009-03-26 Thread Torsten Curdt
On a related matter: Stefan, wouldn't it be possible for the others to start using compress? Not sure who the others may be. As for Ant, I don't expect it to move away from its own classes. Creating jars is a core requirement for a build tool for Java and the Ant community probably won't