Re: [dbutils] bugfixing/java5 branches ready for merge

2009-02-25 Thread Henri Yandell
On Tue, Feb 24, 2009 at 9:55 AM, Dan Fabulich d...@fabulich.com wrote: Henri Yandell wrote: 742870 - ?? - Lacking Unit Tests, not liking the catch Exception. RuntimeException throwing needs String arg. Generally not trusting the Java API here to work beautifully and wanting to have covered a

Re: [dbutils] bugfixing/java5 branches ready for merge

2009-02-25 Thread Liam Coughlin
DBUTILS-49QueryRunner - fillStatement method does not work for PostgreSQL database drivershttps://issues.apache.org/jira/browse/DBUTILS-49 I'm pretty sure this is addressed with the fill change to use the parametermetadata. DBUTILS-48 Maintaining a parallel Java 1.5 version of

Re: [dbutils] bugfixing/java5 branches ready for merge

2009-02-24 Thread Dan Fabulich
Henri Yandell wrote: 742870 - ?? - Lacking Unit Tests, not liking the catch Exception. RuntimeException throwing needs String arg. Generally not trusting the Java API here to work beautifully and wanting to have covered a bunch of use cases. Thanks for reviewing! I tweaked exception handling

Re: [dbutils] bugfixing/java5 branches ready for merge

2009-02-24 Thread Liam Coughlin
I vote for karma. On Tue, Feb 24, 2009 at 12:55 PM, Dan Fabulich d...@fabulich.com wrote: Henri Yandell wrote: 742870 - ?? - Lacking Unit Tests, not liking the catch Exception. RuntimeException throwing needs String arg. Generally not trusting the Java API here to work beautifully and

Re: [dbutils] bugfixing/java5 branches ready for merge

2009-02-22 Thread Henri Yandell
Looking at the revisions on the bugfixes branch: 742870 - ?? - Lacking Unit Tests, not liking the catch Exception. RuntimeException throwing needs String arg. Generally not trusting the Java API here to work beautifully and wanting to have covered a bunch of use cases. 743293 - +1 - rename