Re: [Codec] Codec 1.4 RC1 available for review

2009-07-23 Thread Julius Davies
Hi, Niall, That's a nice Gaelic name you have there (my dad's name is Hywel Rhys). Thanks so much for RM'ing codec-1.4. Here's some feedback for you! Codec-1.4 will need the patches from CODEC-80 applied, since they fix an annoying bug. I would also like to get a patch in for CODEC-59 (Add

Re: [Codec] Codec 1.4 RC1 available for review

2009-07-23 Thread Julius Davies
ps. Regarding CODEC-80, the javadoc and inline comment for testChunkedEncodeMultipleOf76() is wrong. Sorry, I'm tired. On Wed, Jul 22, 2009 at 11:18 PM, Julius Daviesjuliusdav...@gmail.com wrote: Hi, Niall, That's a nice Gaelic name you have there (my dad's name is Hywel Rhys). Thanks so

Re: [Codec] Codec 1.4 RC1 available for review

2009-07-23 Thread Niall Pemberton
On Thu, Jul 23, 2009 at 4:10 AM, sebbseb...@gmail.com wrote: On 23/07/2009, Niall Pemberton niall.pember...@gmail.com wrote: I have prepared a release candidate for Codec 1.4 available here:  http://people.apache.org/~niallp/codec-1.4-rc1/ Sigs, hashes OK. NL files look OK It's a bit

Re: [Codec] Codec 1.4 RC1 available for review

2009-07-23 Thread Niall Pemberton
On Thu, Jul 23, 2009 at 7:18 AM, Julius Daviesjuliusdav...@gmail.com wrote: Hi, Niall, That's a nice Gaelic name you have there (my dad's name is Hywel Rhys). Thanks so much for RM'ing codec-1.4.  Here's some feedback for you! Codec-1.4 will need the patches from CODEC-80 applied, since

Re: [Codec] Codec 1.4 RC1 available for review

2009-07-23 Thread sebb
On 23/07/2009, Niall Pemberton niall.pember...@gmail.com wrote: On Thu, Jul 23, 2009 at 4:10 AM, sebbseb...@gmail.com wrote: On 23/07/2009, Niall Pemberton niall.pember...@gmail.com wrote: I have prepared a release candidate for Codec 1.4 available here:

RE: [Codec] Codec 1.4 RC1 available for review

2009-07-23 Thread Gary Gregory
-Original Message- From: sebb [mailto:seb...@gmail.com] Sent: Wednesday, July 22, 2009 8:10 PM To: Commons Developers List Subject: Re: [Codec] Codec 1.4 RC1 available for review On 23/07/2009, Niall Pemberton niall.pember...@gmail.com wrote: I have prepared a release candidate

Re: [Codec] Codec 1.4 RC1 available for review

2009-07-23 Thread Niall Pemberton
On Thu, Jul 23, 2009 at 4:31 PM, Gary Gregoryggreg...@seagullsoftware.com wrote: -Original Message- From: sebb [mailto:seb...@gmail.com] Sent: Thursday, July 23, 2009 8:22 AM To: Commons Developers List Subject: Re: [Codec] Codec 1.4 RC1 available for review On 23/07/2009, Niall

RE: [Codec] Codec 1.4 RC1 available for review

2009-07-23 Thread Gary Gregory
I have taken care of [CODEC-80]. Gary -Original Message- From: Niall Pemberton [mailto:niall.pember...@gmail.com] Sent: Wednesday, July 22, 2009 11:37 PM To: Commons Developers List Subject: Re: [Codec] Codec 1.4 RC1 available for review On Thu, Jul 23, 2009 at 7:18 AM, Julius

RE: [Codec] Codec 1.4 RC1 available for review

2009-07-23 Thread Gary Gregory
Julius: Do you mean it should be: // ... convert to \r\n instead of // ... convert to \n ? Gary -Original Message- From: Julius Davies [mailto:juliusdav...@gmail.com] Sent: Wednesday, July 22, 2009 11:31 PM To: Commons Developers List Subject: Re: [Codec] Codec 1.4 RC1

Re: [Codec] Codec 1.4 RC1 available for review

2009-07-22 Thread sebb
On 23/07/2009, Niall Pemberton niall.pember...@gmail.com wrote: I have prepared a release candidate for Codec 1.4 available here: http://people.apache.org/~niallp/codec-1.4-rc1/ Sigs, hashes OK. NL files look OK It's a bit confusing to have Ant, M1 and M2 build files present - are they all