Intro + First contribution

2013-01-21 Thread Yaniv De Ridder
Hi, I would like to contribute to Cordova, more precisely to the iOS side of it but first of all let me present myself. I'm a computer scientist at Adobe in the Experience Design team mainly working on seed-products and researches. For more information you can look at my linkedIn profile:

[jira] [Commented] (CB-975) camera.getPicture crashes app on iPad3 when capturing multiple images

2013-01-21 Thread Lucas Heezen (JIRA)
[ https://issues.apache.org/jira/browse/CB-975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13558693#comment-13558693 ] Lucas Heezen commented on CB-975: - The error still exists on an iPad 3 with phonegap 2.2.0.

[jira] [Comment Edited] (CB-975) camera.getPicture crashes app on iPad3 when capturing multiple images

2013-01-21 Thread Lucas Heezen (JIRA)
[ https://issues.apache.org/jira/browse/CB-975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13558693#comment-13558693 ] Lucas Heezen edited comment on CB-975 at 1/21/13 11:13 AM: --- The

Re: Media APIs - some research and discussion

2013-01-21 Thread Brian LeRoux
I think that spec is defunct and the functionality was removed from Chrome recently. =.( On Sun, Jan 20, 2013 at 10:29 PM, Simon MacDonald simon.macdon...@gmail.com wrote: Just reading everything over and looking at the way things are going it seems like we should get the Web Intents API

[jira] [Created] (CB-2274) Cordova don't trigger hidekeyboard or showkeyboard with adjustPan in the Android Manifest

2013-01-21 Thread Unai Sarasola (JIRA)
Unai Sarasola created CB-2274: - Summary: Cordova don't trigger hidekeyboard or showkeyboard with adjustPan in the Android Manifest Key: CB-2274 URL: https://issues.apache.org/jira/browse/CB-2274 Project:

[jira] [Resolved] (CB-2274) Cordova don't trigger hidekeyboard or showkeyboard with adjustPan in the Android Manifest

2013-01-21 Thread Simon MacDonald (JIRA)
[ https://issues.apache.org/jira/browse/CB-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon MacDonald resolved CB-2274. - Resolution: Won't Fix Assignee: Simon MacDonald (was: Joe Bowser) Sorry but this is a

[jira] [Commented] (CB-2274) Cordova don't trigger hidekeyboard or showkeyboard with adjustPan in the Android Manifest

2013-01-21 Thread Unai Sarasola (JIRA)
[ https://issues.apache.org/jira/browse/CB-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13558805#comment-13558805 ] Unai Sarasola commented on CB-2274: --- Ok thank you. I 'll try to make a workaround to manage

[jira] [Commented] (CB-975) camera.getPicture crashes app on iPad3 when capturing multiple images

2013-01-21 Thread Andrew Grieve (JIRA)
[ https://issues.apache.org/jira/browse/CB-975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13558814#comment-13558814 ] Andrew Grieve commented on CB-975: -- Hey Lucas, just to confirm: Have you confirmed that you

[jira] [Commented] (CB-2165) The saveToPhotoAlbum option for Camera.getPicture does not work with Cordova 2.2/Android

2013-01-21 Thread Andrew Grieve (JIRA)
[ https://issues.apache.org/jira/browse/CB-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13558815#comment-13558815 ] Andrew Grieve commented on CB-2165: --- I don't think we should support this since it's not

[jira] [Commented] (CB-975) camera.getPicture crashes app on iPad3 when capturing multiple images

2013-01-21 Thread Lucas Heezen (JIRA)
[ https://issues.apache.org/jira/browse/CB-975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13558818#comment-13558818 ] Lucas Heezen commented on CB-975: - No we havent test it only with camera. I have a crash log.

[jira] [Commented] (CB-622) FileTransfer interface should provide progress monitoring

2013-01-21 Thread Andrew Grieve (JIRA)
[ https://issues.apache.org/jira/browse/CB-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13558824#comment-13558824 ] Andrew Grieve commented on CB-622: -- gzip encoding is almost certainly the problem. There's

Re: Cygwin for Windows

2013-01-21 Thread Andrew Grieve
Yep, I was mostly thinking about Android with this question. There's really two aspects that it would simplify: 1. Our documentation would not have to worry about windows vs. unix 2. Our scripts (and upgrade scripts) won't have to be written twice. Although maybe if we are making node a

[jira] [Commented] (CB-2165) The saveToPhotoAlbum option for Camera.getPicture does not work with Cordova 2.2/Android

2013-01-21 Thread Simon MacDonald (JIRA)
[ https://issues.apache.org/jira/browse/CB-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13558830#comment-13558830 ] Simon MacDonald commented on CB-2165: - [~agrieve] If we can throw an exception when we

Re: Cygwin for Windows

2013-01-21 Thread Simon MacDonald
I think we have someone internally here who will look at making the create script more descriptive when errors occur. One thing Don Coleman mentioned a while back and I haven't yet responded (sorry Don) is to have a script that checks the dependencies and downloads/installs everything you need to

Re: Intro + First contribution

2013-01-21 Thread Andrew Grieve
Hi Yaniv! Very excited to see new contributors! I think what you propose sounds great. If you haven't seen it yet, be sure to give this wiki page a read through: http://wiki.apache.org/cordova/ContributorWorkflow You'll need to sign an ICLA before committing any code. Had a look at your

Re: Media APIs - some research and discussion

2013-01-21 Thread Andrew Grieve
Yeah, I believe that's the case as well. I'm not sure what the replacement is though :( On Mon, Jan 21, 2013 at 9:01 AM, Brian LeRoux b...@brian.io wrote: I think that spec is defunct and the functionality was removed from Chrome recently. =.( On Sun, Jan 20, 2013 at 10:29 PM, Simon

[jira] [Commented] (CB-2207) Xcode sometimes does not pick up changes to www/

2013-01-21 Thread Andrew Grieve (JIRA)
[ https://issues.apache.org/jira/browse/CB-2207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13558865#comment-13558865 ] Andrew Grieve commented on CB-2207: --- I've found rsync to be slow when used local-local, and

Re: Issues with Mobile-spec on iOS

2013-01-21 Thread Andrew Grieve
Just to close the loop on this. I believe this to be fixed with (CB-2094). Please report if it's still happening. On Thu, Jan 3, 2013 at 7:12 PM, Shazron shaz...@gmail.com wrote: Amended: If you have a multi-page app, and you use InAppBrowser, and you use iOS 6, you must use iframe bridge

[jira] [Commented] (CB-2180) Convert iOS project template to use ARC

2013-01-21 Thread Andrew Grieve (JIRA)
[ https://issues.apache.org/jira/browse/CB-2180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13558873#comment-13558873 ] Andrew Grieve commented on CB-2180: --- ML thread:

Re: Should Automatic Reference Counting be on?

2013-01-21 Thread Andrew Grieve
Not sure how to move forward with this. I don't think that asking plugin devs to use macros to make their code work in both environments is reasonable. We don't do that in any of our core plugins. I don't think plugin devs will be motivated to update their plugins to use ARC until we change the

[jira] [Created] (CB-2275) Explicitly initialize NSURLCache in the project template

2013-01-21 Thread Andrew Grieve (JIRA)
Andrew Grieve created CB-2275: - Summary: Explicitly initialize NSURLCache in the project template Key: CB-2275 URL: https://issues.apache.org/jira/browse/CB-2275 Project: Apache Cordova Issue

[jira] [Created] (CB-2276) Refactor to eliminate casts of viewControlled - CDVViewController

2013-01-21 Thread Andrew Grieve (JIRA)
Andrew Grieve created CB-2276: - Summary: Refactor to eliminate casts of viewControlled - CDVViewController Key: CB-2276 URL: https://issues.apache.org/jira/browse/CB-2276 Project: Apache Cordova

Re: Media APIs - some research and discussion

2013-01-21 Thread Becky Gibson
Interesting. The latest Editor's draft of the Web Intents spec ( https://dvcs.w3.org/hg/web-intents/raw-file/tip/spec/Overview-respec.html) is dated today. However, looking at the page source that could be an auto-generated date?? The Pick Content Intent editor's draft has a date of Jan. 18,

Re: Cygwin for Windows

2013-01-21 Thread Filip Maj
Yes, node is already a dependency for the CLI, so why not roll with that for cross-platform goodness. On 1/21/13 7:24 AM, Andrew Grieve agri...@chromium.org wrote: Yep, I was mostly thinking about Android with this question. There's really two aspects that it would simplify: 1. Our

[jira] [Commented] (CB-1518) FileTransfer.download progress events has this.lengthComputable = false when response is gzipped on iOS

2013-01-21 Thread Samik R (JIRA)
[ https://issues.apache.org/jira/browse/CB-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13558908#comment-13558908 ] Samik R commented on CB-1518: - Faced this problem today. Hopefully some fix can emerge.

Re: Should Automatic Reference Counting be on?

2013-01-21 Thread Brian LeRoux
I say we roll w/ the assumption of #3 (but share your pragmatism that #2 will likely result). On Mon, Jan 21, 2013 at 10:27 AM, Andrew Grieve agri...@chromium.org wrote: Not sure how to move forward with this. I don't think that asking plugin devs to use macros to make their code work in both

Re: navigator.onLine

2013-01-21 Thread Filip Maj
Sorry for the late reply. On some platforms navigator.onLine doesn't update. I believe older Androids had this issue. Our API is event-based which is a bit more elegant than polling a dangling property off navigator. Not sure what the latest redux for the appropriate W3C spec is. On 1/18/13

Re: navigator.onLine

2013-01-21 Thread Andrew Grieve
Most mobile browsers now do support online/offline events + navigator.onLine out-of-the box. The thing Cordova adds ontop of this is the navigator.connection.type API. We override onLine by default to ensure that it stays in sync with what connection.type reports. It's up to each platform to

[jira] [Commented] (CB-2227) Move mapping of module-symbol into individual plugins

2013-01-21 Thread Andrew Grieve (JIRA)
[ https://issues.apache.org/jira/browse/CB-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13558940#comment-13558940 ] Andrew Grieve commented on CB-2227: --- Initial work is now done merged:

mobile spec pass rate sizable drop on android

2013-01-21 Thread Filip Maj
Hey everyone, Working over the weekend on the ci dashboard I noticed that the pass rate on android for mobile-spec dropped from ~95% to ~85%. It looks like the majority of failures are due to new tests for the File slice stuff that was added recently, perhaps also related to the Blob stuff. If

[jira] [Resolved] (CB-2269) Whitelisting is broken on Android following creation of Config class

2013-01-21 Thread Joe Bowser (JIRA)
[ https://issues.apache.org/jira/browse/CB-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser resolved CB-2269. Resolution: Fixed Assignee: Joe Bowser (was: Braden Shepherdson) We still need to create a doc task

[jira] [Commented] (CB-2269) Whitelisting is broken on Android following creation of Config class

2013-01-21 Thread Joe Bowser (JIRA)
[ https://issues.apache.org/jira/browse/CB-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13558959#comment-13558959 ] Joe Bowser commented on CB-2269: It appears that redirects work if you include all the

Re: mobile spec pass rate sizable drop on android

2013-01-21 Thread Andrew Grieve
Fil, is there any way on ci.cordova.io to see which tests are failing and on which devices? AFAIK, the slice() tests that braden added *should* be passing on both iOS Android. If they are not, we should fix them. I added one test that checks that native Blob objects still work with FileReader.

[jira] [Created] (CB-2277) New Config API needs to be documented for CordovaWebView case

2013-01-21 Thread Joe Bowser (JIRA)
Joe Bowser created CB-2277: -- Summary: New Config API needs to be documented for CordovaWebView case Key: CB-2277 URL: https://issues.apache.org/jira/browse/CB-2277 Project: Apache Cordova Issue

[jira] [Resolved] (CB-2277) New Config API needs to be documented for CordovaWebView case

2013-01-21 Thread Joe Bowser (JIRA)
[ https://issues.apache.org/jira/browse/CB-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser resolved CB-2277. Resolution: Fixed This has already been done. New Config API needs to be documented for

Can we talk about large features before they arrive in master?

2013-01-21 Thread Joe Bowser
Recently we've been noticing that there's been a lot of new features going into Cordova this release, especially in Android. Now, I know that I've been guilty of this in the past, which is partly why I'm saying this now. I think that we need to talk about features and make sure they work before

Re: Can we talk about large features before they arrive in master?

2013-01-21 Thread Brian LeRoux
Agree, but this should be just the regular flow rather than a formal check in. Anything big should be in a branch and ideally ppl should socialize branches on the list before the merge. On Mon, Jan 21, 2013 at 12:41 PM, Joe Bowser bows...@gmail.com wrote: Recently we've been noticing that

[jira] [Created] (CB-2278) Docs reference old incubator links

2013-01-21 Thread mike billau (JIRA)
mike billau created CB-2278: --- Summary: Docs reference old incubator links Key: CB-2278 URL: https://issues.apache.org/jira/browse/CB-2278 Project: Apache Cordova Issue Type: Bug

Re: mobile spec pass rate sizable drop on android

2013-01-21 Thread Filip Maj
On 1/21/13 10:27 AM, Andrew Grieve agri...@chromium.org wrote: Fil, is there any way on ci.cordova.io to see which tests are failing and on which devices? Yep, click the outer slice on the pie chart - this should popup the failed assertions for a particular device. AFAIK, the slice() tests

Re: Can we talk about large features before they arrive in master?

2013-01-21 Thread Jesse MacFadyen
Agree with both of you. Also of note is the ripple effect of adding a feature to one platform, see the slice() discussion for an example. Any new feature should be explored and discussed further than just ios/android. Cheers, Jesse Sent from my iPhone5 On 2013-01-21, at 10:50 AM, Brian

Re: Should Automatic Reference Counting be on?

2013-01-21 Thread Shazron
+1 to what Brian said On Mon, Jan 21, 2013 at 9:03 AM, Brian LeRoux b...@brian.io wrote: I say we roll w/ the assumption of #3 (but share your pragmatism that #2 will likely result). On Mon, Jan 21, 2013 at 10:27 AM, Andrew Grieve agri...@chromium.org wrote: Not sure how to move forward

Re: Cygwin for Windows

2013-01-21 Thread Shazron
I would vote for standardizing on node for all our scripts On Mon, Jan 21, 2013 at 8:54 AM, Filip Maj f...@adobe.com wrote: Yes, node is already a dependency for the CLI, so why not roll with that for cross-platform goodness. On 1/21/13 7:24 AM, Andrew Grieve agri...@chromium.org wrote:

Re: Cygwin for Windows

2013-01-21 Thread Filip Maj
+1 On 1/21/13 11:16 AM, Shazron shaz...@gmail.com wrote: I would vote for standardizing on node for all our scripts On Mon, Jan 21, 2013 at 8:54 AM, Filip Maj f...@adobe.com wrote: Yes, node is already a dependency for the CLI, so why not roll with that for cross-platform goodness. On

Re: mobile spec pass rate sizable drop on android

2013-01-21 Thread Filip Maj
As well, the latest mobile-spec is not running at all on Android 2.x devices. This definitely needs to be fixed. On 1/21/13 10:27 AM, Andrew Grieve agri...@chromium.org wrote: Fil, is there any way on ci.cordova.io to see which tests are failing and on which devices? AFAIK, the slice() tests

[jira] [Created] (CB-2279) Mobile-Spec does not run on Android 2.x

2013-01-21 Thread Joe Bowser (JIRA)
Joe Bowser created CB-2279: -- Summary: Mobile-Spec does not run on Android 2.x Key: CB-2279 URL: https://issues.apache.org/jira/browse/CB-2279 Project: Apache Cordova Issue Type: Bug Affects

[jira] [Commented] (CB-1957) InAppBrowser - video/audio does not stop playing when browser is closed

2013-01-21 Thread Chris Weinert (JIRA)
[ https://issues.apache.org/jira/browse/CB-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13559019#comment-13559019 ] Chris Weinert commented on CB-1957: --- Worked perfect. Thanks! InAppBrowser

Re: Cygwin for Windows

2013-01-21 Thread Brian LeRoux
++ On Mon, Jan 21, 2013 at 1:26 PM, Filip Maj f...@adobe.com wrote: +1 On 1/21/13 11:16 AM, Shazron shaz...@gmail.com wrote: I would vote for standardizing on node for all our scripts On Mon, Jan 21, 2013 at 8:54 AM, Filip Maj f...@adobe.com wrote: Yes, node is already a dependency for

Re: mobile spec pass rate sizable drop on android

2013-01-21 Thread Tim Kim
The relevant bug for it is here: https://issues.apache.org/jira/browse/CB-2167 There are sub-bugs for BB and WP. Not sure if anyone has the intention of addressing this for this release? I've been busy working on some plugman stuff so I won't be able to get to the BB one for this release.

[jira] [Updated] (CB-2279) Mobile-Spec does not run on Android 2.x

2013-01-21 Thread Joe Bowser (JIRA)
[ https://issues.apache.org/jira/browse/CB-2279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser updated CB-2279: --- Component/s: Android Mobile-Spec does not run on Android 2.x ---

[jira] [Updated] (CB-2279) Mobile-Spec does not run on Android 2.x

2013-01-21 Thread Joe Bowser (JIRA)
[ https://issues.apache.org/jira/browse/CB-2279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser updated CB-2279: --- Component/s: CordovaJS Mobile-Spec does not run on Android 2.x ---

[jira] [Commented] (CB-2279) Mobile-Spec does not run on Android 2.x

2013-01-21 Thread Joe Bowser (JIRA)
[ https://issues.apache.org/jira/browse/CB-2279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13559030#comment-13559030 ] Joe Bowser commented on CB-2279: This appears to be a JS error with the most recent

[jira] [Commented] (CB-2279) Mobile-Spec does not run on Android 2.x

2013-01-21 Thread Joe Bowser (JIRA)
[ https://issues.apache.org/jira/browse/CB-2279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13559031#comment-13559031 ] Joe Bowser commented on CB-2279: 01-21 19:35:21.588: E/Web Console(3505): Uncaught

CordovaJS is broken on Android 2.x, rollback and re-tag?

2013-01-21 Thread Joe Bowser
Hey We're going through the motions for release, and it seems that the we may have to roll back the recent changes to the JS so that we can tag for a release. It seems that there were issues with the ArrayBuffer changes on Android (and likely others) and the most recent work is displaying alert

Re: CordovaJS is broken on Android 2.x, rollback and re-tag?

2013-01-21 Thread Filip Maj
Have we identified exactly which commit(s) in JS messed stuff up? We have a few options. 1. roll back to the last working commit. This may or may not affect two branches that were recently merged into js: array buffers + symbol mapping. 2. go with it and get an rc2 out asap. However, this means

[jira] [Updated] (CB-2278) Docs reference old incubator links

2013-01-21 Thread mike billau (JIRA)
[ https://issues.apache.org/jira/browse/CB-2278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mike billau updated CB-2278: Assignee: mike billau Docs reference old incubator links --

Re: CordovaJS is broken on Android 2.x, rollback and re-tag?

2013-01-21 Thread Filip Maj
According to the CI this isn't working properly on Android 4.x either. I think part of this is the array check in the android exec: https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=blob;f=fram ework/assets/js/cordova.android.js;h=8d8b80889c140210012ac57a3fbc8c632e151d

[jira] [Resolved] (CB-1957) InAppBrowser - video/audio does not stop playing when browser is closed

2013-01-21 Thread Andrew Grieve (JIRA)
[ https://issues.apache.org/jira/browse/CB-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grieve resolved CB-1957. --- Resolution: Fixed Glad to hear it! Marking as closed again then. InAppBrowser -

Re: mobile spec pass rate sizable drop on android

2013-01-21 Thread Shazron
I updated the cordova-js on iOS with cordova-js commit 1aa3643deaa9f14970806277d5f651f3cd78caa9 (the latest as of this email) and I got all the automatic tests to pass. I'll be doing more tests before I would consider a tag, probably later today. On Mon, Jan 21, 2013 at 10:07 AM, Filip Maj

Re: Can we talk about large features before they arrive in master?

2013-01-21 Thread Andrew Grieve
One tough thing about this is knowing when you have agreement or not. E.g. for adding File.slice(), Braden sent out an email on the 7th saying that he'd like to add it for iOS Android. Simon gave it a +1, and no one else responded. He then implemented the feature in a feature branch and then

[jira] [Commented] (CB-2279) Mobile-Spec does not run on Android 2.x

2013-01-21 Thread Andrew Grieve (JIRA)
[ https://issues.apache.org/jira/browse/CB-2279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13559102#comment-13559102 ] Andrew Grieve commented on CB-2279: --- This is from Braden's ArrayBuffer work, but he's out

Re: Can we talk about large features before they arrive in master?

2013-01-21 Thread Shazron
I always thought silence is assent, especially if the ML was given enough notice. Per the Apache Voting Process: http://www.apache.org/foundation/voting.html (Consensus Gauging through Silence -- since we don't have a review then commit policy like WebKit) On Mon, Jan 21, 2013 at 1:06 PM,

[jira] [Updated] (CB-2235) FileTransfer spec test failing on iOS5

2013-01-21 Thread Max Woghiren (JIRA)
[ https://issues.apache.org/jira/browse/CB-2235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Max Woghiren updated CB-2235: - Assignee: Max Woghiren (was: Andrew Grieve) FileTransfer spec test failing on iOS5

Re: CordovaJS is broken on Android 2.x, rollback and re-tag?

2013-01-21 Thread Andrew Grieve
Yikes, I somehow missed that we're trying to do a 2.4 release. I see now that there were bugs created for it, but was there any kind of hey, let's do a release-type email? I thought we'd at least figure out this master vs dev/Next/Stable branch thing before we cut a 2.4. I think the JS fix should

[jira] [Assigned] (CB-2279) Mobile-Spec does not run on Android 2.x

2013-01-21 Thread Joe Bowser (JIRA)
[ https://issues.apache.org/jira/browse/CB-2279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser reassigned CB-2279: -- Assignee: Andrew Grieve I thought it would be a one-liner. Mobile-Spec does not run on

[jira] [Comment Edited] (CB-2235) FileTransfer spec test failing on iOS5

2013-01-21 Thread Max Woghiren (JIRA)
[ https://issues.apache.org/jira/browse/CB-2235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13559131#comment-13559131 ] Max Woghiren edited comment on CB-2235 at 1/21/13 9:47 PM: --- I only

Re: Can we talk about large features before they arrive in master?

2013-01-21 Thread Andrew Grieve
On Mon, Jan 21, 2013 at 4:24 PM, Joe Bowser bows...@gmail.com wrote: On Mon, Jan 21, 2013 at 1:06 PM, Andrew Grieve agri...@chromium.org wrote: One tough thing about this is knowing when you have agreement or not. E.g. for adding File.slice(), Braden sent out an email on the 7th saying

[jira] [Comment Edited] (CB-2235) FileTransfer spec test failing on iOS5

2013-01-21 Thread Max Woghiren (JIRA)
[ https://issues.apache.org/jira/browse/CB-2235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13559131#comment-13559131 ] Max Woghiren edited comment on CB-2235 at 1/21/13 10:01 PM: I

RE: Cygwin for Windows

2013-01-21 Thread Josh Soref
Fwiw, Mozilla doesn't require Cygwin. And I'm quite glad not to be forced to use it If you're going to require something, just use Node.js (or whatever JS thing wins). -Original Message- From: Andrew Grieve [mailto:agri...@google.com] Sent: Sunday, January 20, 2013 9:15 AM To:

[jira] [Commented] (CB-2235) FileTransfer spec test failing on iOS5

2013-01-21 Thread Andrew Grieve (JIRA)
[ https://issues.apache.org/jira/browse/CB-2235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13559152#comment-13559152 ] Andrew Grieve commented on CB-2235: --- Committed your one fix:

Re: Can we talk about large features before they arrive in master?

2013-01-21 Thread Filip Maj
In my opinion the last few omfg shit's broken emails comes mainly from lack of testing. If a committer puts something into master, they need to do due diligence for it, and that boils down to one question: do tests pass on devices+platforms affected by the commit? iOS this is easier (per se) than

Re: Can we talk about large features before they arrive in master?

2013-01-21 Thread Filip Maj
Braden just used a private branch and didn't ask for review. Maybe the take-away from this is that we it would be good to have the chance for a review for anything that was big enough to warrant a branch? I'll add this to the committer's wiki page. Yeah let's summarize our discussion points /

Re: CordovaJS is broken on Android 2.x, rollback and re-tag?

2013-01-21 Thread Filip Maj
BTW: the last commit on Android bumped the latest results on the ci dashboard from ~84% to 97%. Thank you everyone for resolving this promptly! On 1/21/13 1:48 PM, Joe Bowser bows...@gmail.com wrote: Cool. I re-tagged the JS and Android to include the fix for Android 2.3.0, since it's early

[jira] [Commented] (CB-2213) Add support for native URIs

2013-01-21 Thread Max Woghiren (JIRA)
[ https://issues.apache.org/jira/browse/CB-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13559161#comment-13559161 ] Max Woghiren commented on CB-2213: -- The above two pull requests are about ready to go.

[jira] [Resolved] (CB-2251) Update JavaScript for webOS

2013-01-21 Thread Herm Wong (JIRA)
[ https://issues.apache.org/jira/browse/CB-2251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herm Wong resolved CB-2251. --- Resolution: Fixed Update JavaScript for webOS --- Key: CB-2251

[jira] [Resolved] (CB-2262) Tag webOS

2013-01-21 Thread Herm Wong (JIRA)
[ https://issues.apache.org/jira/browse/CB-2262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herm Wong resolved CB-2262. --- Resolution: Fixed Tag webOS - Key: CB-2262 URL:

[jira] [Resolved] (CB-2242) Update JavaScript for Bada

2013-01-21 Thread Anis Kadri (JIRA)
[ https://issues.apache.org/jira/browse/CB-2242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anis Kadri resolved CB-2242. Resolution: Fixed Update JavaScript for Bada -- Key: CB-2242

[jira] [Resolved] (CB-2261) Tag Tizen

2013-01-21 Thread Anis Kadri (JIRA)
[ https://issues.apache.org/jira/browse/CB-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anis Kadri resolved CB-2261. Resolution: Fixed Tag Tizen - Key: CB-2261 URL:

[jira] [Resolved] (CB-2249) Update JavaScript for Qt

2013-01-21 Thread Anis Kadri (JIRA)
[ https://issues.apache.org/jira/browse/CB-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anis Kadri resolved CB-2249. Resolution: Fixed Update JavaScript for Qt Key: CB-2249

[jira] [Resolved] (CB-2250) Update JavaScript for Tizen

2013-01-21 Thread Anis Kadri (JIRA)
[ https://issues.apache.org/jira/browse/CB-2250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anis Kadri resolved CB-2250. Resolution: Fixed Update JavaScript for Tizen --- Key:

[jira] [Resolved] (CB-2256) Tag Bada

2013-01-21 Thread Anis Kadri (JIRA)
[ https://issues.apache.org/jira/browse/CB-2256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anis Kadri resolved CB-2256. Resolution: Fixed Tag Bada Key: CB-2256 URL:

[jira] [Commented] (CB-1593) WP7 : Media callback called multiple times

2013-01-21 Thread Benn Mapes (JIRA)
[ https://issues.apache.org/jira/browse/CB-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13559177#comment-13559177 ] Benn Mapes commented on CB-1593: Update: We have two bugs going on here, the first is that

Re: Cygwin for Windows

2013-01-21 Thread Benn Mapes
+1 Node On Mon, Jan 21, 2013 at 2:02 PM, Josh Soref jso...@rim.com wrote: Fwiw, Mozilla doesn't require Cygwin. And I'm quite glad not to be forced to use it If you're going to require something, just use Node.js (or whatever JS thing wins). -Original Message- From:

Re: mobile spec pass rate sizable drop on android

2013-01-21 Thread Shazron
I tested with the cordova-js 2.4.0rc1, and all tests pass. There is one intermittent failure though, relating to Media.position, which doesn't seem a blocker to me (see attached screenshot). Might be related to: https://issues.apache.org/jira/browse/CB-1452 [image: Inline image 1] On Mon, Jan

[jira] [Resolved] (CB-2248) Update JavaScript for iOS

2013-01-21 Thread Shazron Abdullah (JIRA)
[ https://issues.apache.org/jira/browse/CB-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah resolved CB-2248. -- Resolution: Fixed Fix commit - http://git-wip-us.apache.org/repos/asf/cordova-ios/commit/725419c1

[jira] [Resolved] (CB-2259) Tag Mac

2013-01-21 Thread Shazron Abdullah (JIRA)
[ https://issues.apache.org/jira/browse/CB-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah resolved CB-2259. -- Resolution: Fixed Tag Mac --- Key: CB-2259 URL:

[jira] [Resolved] (CB-2267) Tag Mobile Spec

2013-01-21 Thread Filip Maj (JIRA)
[ https://issues.apache.org/jira/browse/CB-2267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Filip Maj resolved CB-2267. --- Resolution: Fixed Resolved here:

[jira] [Resolved] (CB-573) Automate Backbutton jQM tab test

2013-01-21 Thread Joe Bowser (JIRA)
[ https://issues.apache.org/jira/browse/CB-573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser resolved CB-573. --- Resolution: Won't Fix This is tied too tightly to jQuery Mobile. jQuery Mobile should be testing their tab bar,

[jira] [Comment Edited] (CB-573) Automate Backbutton jQM tab test

2013-01-21 Thread Joe Bowser (JIRA)
[ https://issues.apache.org/jira/browse/CB-573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13559214#comment-13559214 ] Joe Bowser edited comment on CB-573 at 1/21/13 11:45 PM: - This is tied

[jira] [Commented] (CB-2272) can't add android to project

2013-01-21 Thread Filip Maj (JIRA)
[ https://issues.apache.org/jira/browse/CB-2272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13559216#comment-13559216 ] Filip Maj commented on CB-2272: --- [~brianleroux] yes, I think so. I will try it out. Another fun

[jira] [Resolved] (CB-2258) Tag iOS

2013-01-21 Thread Shazron Abdullah (JIRA)
[ https://issues.apache.org/jira/browse/CB-2258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah resolved CB-2258. -- Resolution: Fixed Tag iOS --- Key: CB-2258 URL:

Re: mobile spec pass rate sizable drop on android

2013-01-21 Thread Becky Gibson
I can reliably reproduce that issue but only in the manual tests. I do have a local branch to fix it - the fix is pretty straightforward. I didn't do it when I filed the issue because we keep talking abt over hauling media. -becky Sent from my iPad On Jan 21, 2013, at 5:58 PM, Shazron

Re: Cygwin for Windows

2013-01-21 Thread Simon MacDonald
+1 to node On Jan 21, 2013 5:56 PM, Benn Mapes benn.ma...@gmail.com wrote: +1 Node On Mon, Jan 21, 2013 at 2:02 PM, Josh Soref jso...@rim.com wrote: Fwiw, Mozilla doesn't require Cygwin. And I'm quite glad not to be forced to use it If you're going to require something, just

[jira] [Resolved] (CB-2247) Update JavaScript for BlackBerry

2013-01-21 Thread Tim Kim (JIRA)
[ https://issues.apache.org/jira/browse/CB-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Kim resolved CB-2247. - Resolution: Fixed Update JavaScript for BlackBerry Key:

[jira] [Commented] (CB-2247) Update JavaScript for BlackBerry

2013-01-21 Thread Tim Kim (JIRA)
[ https://issues.apache.org/jira/browse/CB-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13559264#comment-13559264 ] Tim Kim commented on CB-2247: - Fixed here:

[jira] [Commented] (CB-2257) Tag BlackBerry

2013-01-21 Thread Tim Kim (JIRA)
[ https://issues.apache.org/jira/browse/CB-2257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13559267#comment-13559267 ] Tim Kim commented on CB-2257: - Fixed here:

[jira] [Resolved] (CB-2257) Tag BlackBerry

2013-01-21 Thread Tim Kim (JIRA)
[ https://issues.apache.org/jira/browse/CB-2257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Kim resolved CB-2257. - Resolution: Fixed Tag BlackBerry -- Key: CB-2257 URL:

Re: Can we talk about large features before they arrive in master?

2013-01-21 Thread Brian M Dube
On 01/21/2013 01:24 PM, Joe Bowser wrote: On Mon, Jan 21, 2013 at 1:06 PM, Andrew Grieve agri...@chromium.org wrote: As for code reviews: I'd certainly be interested in more code-reviews. I think it's really useful to get feedback on changes. The only time when it becomes a burden is when

Re: CordovaJS is broken on Android 2.x, rollback and re-tag?

2013-01-21 Thread Brian LeRoux
man, sure is nice having continuous integration. which is to say: thank you fil On Mon, Jan 21, 2013 at 4:14 PM, Filip Maj f...@adobe.com wrote: BTW: the last commit on Android bumped the latest results on the ci dashboard from ~84% to 97%. Thank you everyone for resolving this promptly! On

[jira] [Resolved] (CB-2272) can't add android to project

2013-01-21 Thread Filip Maj (JIRA)
[ https://issues.apache.org/jira/browse/CB-2272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Filip Maj resolved CB-2272. --- Resolution: Unresolved Still won't work. When you install a node module globally it goes into /usr/local where

[jira] [Commented] (CB-2272) can't add android to project

2013-01-21 Thread Brian LeRoux (JIRA)
[ https://issues.apache.org/jira/browse/CB-2272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13559287#comment-13559287 ] Brian LeRoux commented on CB-2272: -- so hold on, I expect to sudo when I install w/ the -g

  1   2   >