Re: Retag JS

2013-02-27 Thread Andrew Grieve
On Wed, Feb 27, 2013 at 12:53 AM, Anis KADRI anis.ka...@gmail.com wrote: I'd like to add bada specific code as well. No impact on any other platforms. On Tuesday, February 26, 2013, Shazron wrote: Seems fine to me since it's all BB stuff On Tue, Feb 26, 2013 at 8:37 PM, Gord Tanner

Re: Supporting multiple plugin return values

2013-02-27 Thread Michal Mocny
All this work has landed and I've just updated the documentation. Since there was no documentation at all for plugin return values, I added a whole section about it. If anyone wants to proof read, Commit: http://git-wip-us.apache.org/repos/asf/cordova-docs/commit/9927fcdf Also, I've replaced

Re: Retag JS

2013-02-27 Thread Gord Tanner
The second change is a very localized bugfix: https://issues.apache.org/jira/browse/CB-2158 All this does is make a broken API work and doesn't leach out into any other areas of BlackBerry. I have tested these changes and the worst case is that we end up with an API broken in another way ;)

Re: Supporting multiple plugin return values

2013-02-27 Thread Filip Maj
Thanks Michal! On 2/27/13 6:59 AM, Michal Mocny mmo...@chromium.org wrote: All this work has landed and I've just updated the documentation. Since there was no documentation at all for plugin return values, I added a whole section about it. If anyone wants to proof read, Commit:

Re: cordova-cli plugin add/remove/prepare proposal

2013-02-27 Thread Filip Maj
Couple notes before I add some comments: - in general plugin add and rm is COMPLETELY delegated to the plugman tool. See [1]. Most of the code linked is error checking, otherwise it shells out to plugman.. With one exception.. - what happens in [2]. Which is the point Braden brought up about

Re: cordova-cli plugin add/remove/prepare proposal

2013-02-27 Thread Braden Shepherdson
I'm on the fence about native plugin code. I think iOS has some complications there. Over the course of my work on the installation prototype, I've actually moved to copying plugin www files on every prepare, that works great. For native code, I wonder if that's best done on add/remove. I was

Re: cordova-cli plugin add/remove/prepare proposal

2013-02-27 Thread Filip Maj
I think this is a good conversation to have. Note that, if we do split up how plugins are treated and when we copy files around (I.e. Move the www assets on every prepare, but the native files only on platform/plugin adds), then the plugman tool will either need finer-grained support for these

Re: cordova-cli plugin add/remove/prepare proposal

2013-02-27 Thread Michal Mocny
I think we have a hangout scheduled for that conversation (among others) right? Its good that Braden is setting up topics of conversation :) -Michal On Wed, Feb 27, 2013 at 4:37 PM, Filip Maj f...@adobe.com wrote: I think this is a good conversation to have. Note that, if we do split up

Re: cordova-cli plugin add/remove/prepare proposal

2013-02-27 Thread Filip Maj
Yep! There's an online code review planned for March 22nd for both the cli tools as well as the plugman tool. Also: next week most Adobe cordova folk will be in SF, and so will you Googlers ya? We can talk specifics and hash out our ideas better then and bring it back to the list. On 2/27/13

Re: cordova-cli plugin add/remove/prepare proposal

2013-02-27 Thread Michal Mocny
Oh sweet, we were just saying how we still haven't met most of you. Sadly, Braden is not coming on this trip, but Andrew, Max and I will be there (and working from Adobe Friday) we will have time to chat. Can bring Braden in via Hangout. -Michal On Wed, Feb 27, 2013 at 5:40 PM, Filip Maj

Re: cordova-cli plugin add/remove/prepare proposal

2013-02-27 Thread Al Harding
Awesome! We've got a room booked at Adobe SF with projector, camera, beer, so we can loop anyone in who is remote. Look forward to meeting the Google guys! -Al On Wed, Feb 27, 2013 at 2:44 PM, Michal Mocny mmo...@chromium.org wrote: Oh sweet, we were just saying how we still haven't met

Re: cordova-cli plugin add/remove/prepare proposal

2013-02-27 Thread Tommy-Carlos Williams
Poking my nose in… Aside from 100% agreeing that the user's www should no be polluted, I would also like to flag that perhaps being able to re-add a plugin to a platform would be useful. If you are not pushing your platforms dirs to your repo, for instance… you will need some way to get your

Re: cordova-cli plugin add/remove/prepare proposal

2013-02-27 Thread Jeffrey Heifetz
Actually I'm lucky enough to be heading down to join in on the fun, looking forward to meeting all of you. On 2013-02-27, at 6:26 PM, Al Harding wrote: Awesome! We've got a room booked at Adobe SF with projector, camera, beer, so we can loop anyone in who is remote. Look forward to meeting

Re: cordova-cli plugin add/remove/prepare proposal

2013-02-27 Thread Al Harding
...and the BlackBerry guys! :) On Wed, Feb 27, 2013 at 4:37 PM, Jeffrey Heifetz jheif...@rim.com wrote: Actually I'm lucky enough to be heading down to join in on the fun, looking forward to meeting all of you. On 2013-02-27, at 6:26 PM, Al Harding wrote: Awesome! We've got a room

Re: Supporting multiple plugin return values

2013-02-27 Thread Brian LeRoux
ya that looks great thanks mang On Wed, Feb 27, 2013 at 1:12 PM, Filip Maj f...@adobe.com wrote: Thanks Michal! On 2/27/13 6:59 AM, Michal Mocny mmo...@chromium.org wrote: All this work has landed and I've just updated the documentation. Since there was no documentation at all for plugin