Fix the DroidGap activity Lifecycle broken issue onDestroy.

2013-04-02 Thread HUANG Menghuai
This request is trying to fix the issue that a DroidGap derived Activity is restarted by the system in an incorrect order due to the finish() invocation onDestroy() upon say, device Config Changes*. Upon device Config Changes, onDestroy is followed by a onCreate as promised in: -

Re: App-Harness Description

2013-04-02 Thread Filip Maj
Fineee. +1 harness. I'll save WebKeg for another day! On 4/1/13 4:40 PM, Lorin Beer lorin.beer@gmail.com wrote: while some truly excellent names have been suggested, I'll +1 harness. Fil will just have to wait for a project named WebKeg. On Mon, Apr 1, 2013 at 9:05 AM, Michael Brooks

Re: Is cordova.utils.vformat a documented API?

2013-04-02 Thread Shazron
It's not documented AFAIK. Did a grep in cordova-docs, no mention of it in any version On Tue, Apr 2, 2013 at 8:08 AM, Ian Clelland iclell...@chromium.org wrote: Working on CB-2825, I've come to the conclusion that cordova.utils.vformat should be working more like the string formatting in

Re: Platform-level command line scripts ;)

2013-04-02 Thread Filip Maj
TL;DR I agree with all your points Mike. I'll update the doc shortly with your suggestions. Assuming there are no other qualms, I'll slate this stuff for 2.7? Specific comments in-line below. `build` ... What happens when a user specifies both --debug and --release? I'm happy as long as

Re: Is cordova.utils.vformat a documented API?

2013-04-02 Thread Ian Clelland
Cool, thanks -- pull request sent then :) If this becomes an issue--if there are third party developers relying on the old behaviour of vformat--then we should point them at cordova.utils.format, which does swallow any extra params, but has a slightly different function signature. It's behaviour

Re: File version numbers in release branches

2013-04-02 Thread Andrew Grieve
running this version. However, if they're running files checked out of the master branch on github, then we need to know more specifically what commit they're using. It would be far more useful for them to be able to say It's version master-20130402, or to include the commit hash, as master-5a6b48a

Re: File version numbers in release branches

2013-04-02 Thread Shazron
what commit they're using. It would be far more useful for them to be able to say It's version master-20130402, or to include the commit hash, as master-5a6b48a, than a general 2.7.0-pre.) Ian

Delete cordova.utils.vformat

2013-04-02 Thread Andrew Grieve
Ian suggested patching this function to be used by the Logger plugin, but also pointed out that it's undocumented and not currently used. I think it would be better to move this function into the Logger plugin and rip it out of cordova.util to cut down on bloat. Worth an extra check to see if

[1 of 15] commits

2013-04-02 Thread Andrew Grieve
There's quite a bit of email spam from both of you and I wasn't sure what caused it? Do you know? rebasing? merging? branching? Hard to figure out what actually has changed when these happen, so I'd like to figure out what causes them. I did one recently where I rebased a remote feature branch.

Re: [1 of 15] commits

2013-04-02 Thread Jesse
merging most likely, set up a filter. I commit to master, checkout 2.6.x, pull master, push 2.6.x because I want all the work I am doing in 2.6.0 https://github.com/purplecabbage/cordova-wp8/network Looks good to me ... @purplecabbage risingj.com On Tue, Apr 2, 2013 at 12:52 PM, Andrew Grieve

Re: File version numbers in release branches

2013-04-02 Thread Ian Clelland
be far more useful for them to be able to say It's version master-20130402, or to include the commit hash, as master-5a6b48a, than a general 2.7.0-pre.) Ian

Re: [1 of 15] commits

2013-04-02 Thread Lorin Beer
hmm, likely a merge. A local commit before pulling in upstream changes, then doing a merge seems to be the cause. On Tue, Apr 2, 2013 at 1:07 PM, Jesse purplecabb...@gmail.com wrote: merging most likely, set up a filter. I commit to master, checkout 2.6.x, pull master, push 2.6.x because I

Plugman Future Qs

2013-04-02 Thread Tim Kim
Hey Braden, I'm working on getting the plugman future branch tests running and I noticed a couple of things: 1) Removal of moving the assets to the www/: https://git-wip-us.apache.org/repos/asf?p=cordova-plugman.git;a=commit;h=eeb5f0104f449ae5cac6045786874559fe1edf50 Are we not doing this

Re: File version numbers in release branches

2013-04-02 Thread Andrew Grieve
-20130402, or to include the commit hash, as master-5a6b48a, than a general 2.7.0-pre.) Ian

Re: [1 of 15] commits

2013-04-02 Thread Andrew Grieve
Sounds good. Cool graph Jesse! On Tue, Apr 2, 2013 at 4:49 PM, Lorin Beer lorin.beer@gmail.com wrote: hmm, likely a merge. A local commit before pulling in upstream changes, then doing a merge seems to be the cause. On Tue, Apr 2, 2013 at 1:07 PM, Jesse purplecabb...@gmail.com wrote:

Re: App-Harness Description

2013-04-02 Thread Andrew Grieve
INFRA ticket filed! https://issues.apache.org/jira/browse/INFRA-6103 On Tue, Apr 2, 2013 at 1:30 PM, Filip Maj f...@adobe.com wrote: Fineee. +1 harness. I'll save WebKeg for another day! On 4/1/13 4:40 PM, Lorin Beer lorin.beer@gmail.com wrote: while some truly excellent names

Re: App-Harness Description

2013-04-02 Thread Andrew Grieve
Fastest Yet! Repo is created: https://git-wip-us.apache.org/repos/asf/cordova-app-harness.git On Tue, Apr 2, 2013 at 8:39 PM, Andrew Grieve agri...@chromium.org wrote: INFRA ticket filed! https://issues.apache.org/jira/browse/INFRA-6103 On Tue, Apr 2, 2013 at 1:30 PM, Filip Maj

Speaking Opportunity

2013-04-02 Thread Filip Maj
Hello fellow committers, I've been in contact with someone who is running http://www.mobilewebdevconference.com and they are looking for speakers. It's just before PhoneGap Day so most likely no one from Adobe will be able to attend. If you've got nothing planned for July 16-18, are active on