1. The assets are moved on --prepare now, based on the asset tags. The old
behavior copied on install and expected the plugin to have a www directory.
2. That plugin fetching change looks fine at a glance. I've only been
testing the local case, I don't actually know the state of the download
Hey Gorkem,
Thanks for this and putting the effort into kick starting this. Sorry
about the late reply.
I like the changes (made a minor comment re: widget element id in the
github pull request). Correctly adopting the spec should help. Leveraging
several param elements inside a feature element,
Merges are dangerous in that sense. Rebase when you can!
On 4/3/13 11:59 AM, Max Woghiren m...@google.com wrote:
Just wanted to quickly chime in here‹Lorin, your sizeable merge reverted
one of my bug fixes (CB-2732). Not a huge deal, and a re-fix is on the
way, but try to be extra careful when
hmm, I was under the impression that rebasing was more dangerous, I'll
reassess my workflow.
Sorry for the trouble Max!
On Wed, Apr 3, 2013 at 9:03 AM, Filip Maj f...@adobe.com wrote:
Merges are dangerous in that sense. Rebase when you can!
On 4/3/13 11:59 AM, Max Woghiren m...@google.com
In terms of the git notification emails, merge or rebase, doesn't matter.
Each commit that is being merged in in the case of a merge, or reapplied
in the case of a rebase, will be sent as a notification. So we lose either
way. Woot.
In the case of rebase vs merge in terms of workflow, merge drops
Thanks Andrew!
On Tue, Apr 2, 2013 at 5:57 PM, Andrew Grieve agri...@chromium.org wrote:
Fastest Yet! Repo is created:
https://git-wip-us.apache.org/repos/asf/cordova-app-harness.git
On Tue, Apr 2, 2013 at 8:39 PM, Andrew Grieve agri...@chromium.org
wrote:
INFRA ticket filed!
Hey
I've started moving the various Android plugins into their
corresponding repositories, and it seems that these were made up, and
that they don't really correspond to what exists in the code today. I
don't think that it's realistic for us to get this done for 2.7
because there are certain
Things start to suck if everyone does it differently (some do merges, some
do rebases). I like rebase better because it provides a clear/n history. I
usually do merges because I know that most people do that as well. I would
like to do rebase instead but everyone else has to do that to avoid
We can file infra requests to modify names / add more repos for plugins as
needed, so that shouldn't be an issue. Some plugins may not be completely
cross-platform (debug console, for example, will likely only have iOS
native code).
As for landing it all in 2.7: also not a big deal. We can try to
I think a good first pass is to plugin-ize what is plugin-izable and leave
everything else (platform specific code) as part of the 'core'
implementation. Things will never exactly be exactly the same across
platforms in my opinion.
On Wed, Apr 3, 2013 at 11:17 AM, Joe Bowser bows...@gmail.com
I'm leaning towards rebasing. I felt that rebasing was the more dangerous
option, due to the potential/power of changing history that is already
upstream, but I find the merge commits annoying as well. It sounds like
whenever this happens, our list is going to get spammed regardless.
On Wed, Apr
Awesome! I also dropped comments and questions into the google doc
yesterday.
On Wed, Apr 3, 2013 at 10:56 AM, Michael Brooks mich...@michaelbrooks.cawrote:
Thanks Andrew!
On Tue, Apr 2, 2013 at 5:57 PM, Andrew Grieve agri...@chromium.org
wrote:
Fastest Yet! Repo is created:
Agree w/ Anis. Just move what can be moved and file up tickets for
that which cannot be done in the immediate term / that is in the
'official' list of plugins.
On Wed, Apr 3, 2013 at 11:27 AM, Anis KADRI anis.ka...@gmail.com wrote:
I think a good first pass is to plugin-ize what is plugin-izable
I generally prefer rebasing so that I can see / choose the individual commits.
-James Jong
On Apr 3, 2013, at 2:34 PM, Lorin Beer lorin.beer@gmail.com wrote:
I'm leaning towards rebasing. I felt that rebasing was the more dangerous
option, due to the potential/power of changing history
Forgive me if this was already discussed, for the plugins:
1. cordova-plugin-device
2. cordova-plugin-network-information
deviceready event being dispatched will not be dependent on these two
anymore right? At least on iOS it is currently.
On Wed, Apr 3, 2013 at 11:17 AM, Joe Bowser
Note that we mandate pull requests to be rebased on our wiki:
http://wiki.apache.org/cordova/ContributorWorkflow
And we tell committers to rebase as well here:
http://wiki.apache.org/cordova/CommitterWorkflow
Rebasing is safe in that if you've done it wrong, you'll get an error when
you try to
Hmm, another question - Max / Lorin, have you checked if any other commits
were reverted? (is there a way to check?)
On Wed, Apr 3, 2013 at 11:08 PM, Andrew Grieve agri...@chromium.org wrote:
Note that we mandate pull requests to be rebased on our wiki:
That crossed my mind, but I didn't know of a way offhand to determine if
anything else was reverted. My commit's reversion was hidden away in an
unrelated commit that was merged.
On Wed, Apr 3, 2013 at 11:17 PM, Andrew Grieve agri...@chromium.org wrote:
Hmm, another question - Max / Lorin,
Works for me?
On 4/3/13 11:35 PM, Andrew Grieve agri...@chromium.org wrote:
for netinfo, I think it's fine to not delay deviceready since we can just
set it to unknown at the start.
For device though, if we're not going to delay deviceready, then we should
remove the device symbol being exposed so that the only way to get to the
properties is through the async API. For
hrm, yeah, working for me now too. Must have been transient.
On Wed, Apr 3, 2013 at 11:37 PM, Filip Maj f...@adobe.com wrote:
Works for me?
On 4/3/13 11:35 PM, Andrew Grieve agri...@chromium.org wrote:
Same here. Maybe it's type coercion
Sent from my BlackBerry 10 smartphone.
From: Filip Maj
Sent: Wednesday, April 3, 2013 11:38 PM
To: dev@cordova.apache.org
Reply To: dev@cordova.apache.org
Subject: Re: docs.cordova.io == 404
Works for me?
On 4/3/13 11:35 PM, Andrew Grieve
Hi, i'll try be positive...
So 129 issues, 17 lonely PRs
https://github.com/phonegap/phonegap-facebook-plugin/contributors
^
Maybe 3 active commiters (last 3 months) to a project with 339 forks and
781 stars
Need help? ;)
We are your community, you are our overlords, command us.
Its all about making the best of a bad situation with FB... I heard they
have 1 billion users..
On Thu, Apr 4, 2013 at 12:43 PM, Filip Maj f...@adobe.com wrote:
Yeah, where the hell is Facebook on this?!
;)
On 4/3/13 11:41 PM, Ally Ogilvie aogil...@wizcorp.jp wrote:
Hi, i'll try be
25 matches
Mail list logo
