update script

2013-05-23 Thread David Kemp
Hi all, I am running some tests and find that the script cordova-android/bin/update (and probably cordova-android/bin/update.js) refer to cordova-android/framework/assets/www/cordova-dev.js which does not exist. Is this script still used? Is it expected to work? Note that the companion script

Re: New directory structure in cordova-cli's future branch

2013-05-23 Thread Michal Mocny
Clarification of typing mistake, below.. Also, curious why this breaks things in the first place? I thought this is the first time we are releasing these tools? The current create script workflow is totally different, and I know there is a npm package for cordova cli already, but that was never

Re: New directory structure in cordova-cli's future branch

2013-05-23 Thread Filip Maj
https://npmjs.org/package/cordova While CLI is not a documented flow, it is deployed and has 1000 downloads per month. That's my only concern: not fucking those people over. I'm in favor of that structure I just don't want it to change without warning in this next release. Ideally set up

Re: 2.8.0rc1

2013-05-23 Thread Steven Gill
Sweet. I will have to take a look at these new changes to coho later today. On Wed, May 22, 2013 at 9:40 PM, Andrew Grieve agri...@chromium.org wrote: Okay, had to fix some things in the coho script (which I will push tomorrow). Parent bug is here:

Re: 2.8.0rc1

2013-05-23 Thread Jesse
So are we going with the tagged version? Should I push off the plugin-loader changes until 2.9.0? @purplecabbage risingj.com On Thu, May 23, 2013 at 10:11 AM, Steven Gill stevengil...@gmail.comwrote: Sweet. I will have to take a look at these new changes to coho later today. On Wed, May

Re: 2.8.0rc1

2013-05-23 Thread Filip Maj
FYI if this doesn't get in for 2.8 then we'll have to revert some stuff in plugman that couples with this functionality in JS. Not a big deal On 5/23/13 10:28 AM, Jesse purplecabb...@gmail.com wrote: So are we going with the tagged version? Should I push off the plugin-loader changes until

Re: 2.8.0rc1

2013-05-23 Thread Filip Maj
SORRY false alarm: not true. Not merged into plugman yet. On a branch. On 5/23/13 10:28 AM, Jesse purplecabb...@gmail.com wrote: So are we going with the tagged version? Should I push off the plugin-loader changes until 2.9.0? @purplecabbage risingj.com On Thu, May 23, 2013 at 10:11 AM,

request: authority to own items in JIRA

2013-05-23 Thread Lisa Seacat DeLuca
Can someone grant me the authority to own items in JIRA? My id is: ldeluca. Thanks, Lisa

Re: 2.8.0rc1

2013-05-23 Thread Braden Shepherdson
I just merged the git_refs changes. They shouldn't affect anything else. On Thu, May 23, 2013 at 1:35 PM, Filip Maj f...@adobe.com wrote: SORRY false alarm: not true. Not merged into plugman yet. On a branch. On 5/23/13 10:28 AM, Jesse purplecabb...@gmail.com wrote: So are we going with

Re: New directory structure in cordova-cli's future branch

2013-05-23 Thread Michal Mocny
Fil, that sounds extremely sensible. On Thu, May 23, 2013 at 12:32 PM, Filip Maj f...@adobe.com wrote: https://npmjs.org/package/cordova While CLI is not a documented flow, it is deployed and has 1000 downloads per month. That's my only concern: not fucking those people over. I'm in

Re: New directory structure in cordova-cli's future branch

2013-05-23 Thread Filip Maj
So for the sake of moving the RC release along, Michal/Braden/Andrew are you guys cool if we: A) revert to www/ as root folder B) proceed with 2.8.0rc1 tagging C) continue with this discussion to try to get to a resolution. Worst-case we call a vote next week? On 5/23/13 10:56 AM, Michal Mocny

Re: 2.8.0rc1

2013-05-23 Thread Andrew Grieve
Given that our goal was to cut Tuesday, I think we should just stick with the current code for now. I don't think there's any real reason to change this code at the last second. On Thu, May 23, 2013 at 1:40 PM, Braden Shepherdson bra...@chromium.orgwrote: I just merged the git_refs changes.

Re: 2.8.0rc1

2013-05-23 Thread Jesse
I agree. @purplecabbage risingj.com On Thu, May 23, 2013 at 11:10 AM, Andrew Grieve agri...@chromium.orgwrote: Given that our goal was to cut Tuesday, I think we should just stick with the current code for now. I don't think there's any real reason to change this code at the last second.

Re: update script

2013-05-23 Thread Andrew Grieve
This probably broke with the recent change to drop the VERSION from the cordova.js file name. I see you've filed a bug for it already, so that's great! On Thu, May 23, 2013 at 9:36 AM, David Kemp drk...@chromium.org wrote: Hi all, I am running some tests and find that the script

Re: update script

2013-05-23 Thread Ian Clelland
And I've merged the change into 2.8.x; it looks good. On Thu, May 23, 2013 at 2:23 PM, Andrew Grieve agri...@chromium.org wrote: This probably broke with the recent change to drop the VERSION from the cordova.js file name. I see you've filed a bug for it already, so that's great! On Thu,

Re: request: authority to own items in JIRA

2013-05-23 Thread Joe Bowser
Hey Thanks for adding yourself to the JIRA. I think we can probably set you up to have some tickets, but there's some housekeeping that we're going to have to do as well. 1. Have you signed the ICLA? This isn't required, but is probably a good idea if you're going to become a contributor.

Re: New directory structure in cordova-cli's future branch

2013-05-23 Thread Brian LeRoux
+1 Lets start a fresh thread that describes the problem discreetly and work out a solution together. I suspect we'll arrive at a different solution than moving folders around. On Thu, May 23, 2013 at 11:04 AM, Filip Maj f...@adobe.com wrote: So for the sake of moving the RC release along,

Re: 2.8.0rc1

2013-05-23 Thread Filip Maj
Hey everyone, Can folk hold off on committing to cordova-cli until Braden sorts out the branch merging? IM LOOKING AT YOU, BENN! ;) On 5/23/13 11:15 AM, Jesse purplecabb...@gmail.com wrote: I agree. @purplecabbage risingj.com On Thu, May 23, 2013 at 11:10 AM, Andrew Grieve

Re: 2.8.0rc1

2013-05-23 Thread Steven Gill
Damn Botson fans On Thu, May 23, 2013 at 11:34 AM, Filip Maj f...@adobe.com wrote: Hey everyone, Can folk hold off on committing to cordova-cli until Braden sorts out the branch merging? IM LOOKING AT YOU, BENN! ;) On 5/23/13 11:15 AM, Jesse purplecabb...@gmail.com wrote: I agree.

Re: request: authority to own items in JIRA

2013-05-23 Thread Lisa Seacat DeLuca
Thanks Joe, to answer your questions: 1. yes, I signed the ICLA and it was filed in the Apache Software Foundation records. 2. Okay, I understand. I have been submitting pull requests against my fork and branching open issues. I just wanted to assign some of the issues to myself so they

Re: New directory structure in cordova-cli's future branch

2013-05-23 Thread Michal Mocny
Sure, move the RC along so we can discuss calmly. -Michal On Thu, May 23, 2013 at 2:31 PM, Brian LeRoux b...@brian.io wrote: +1 Lets start a fresh thread that describes the problem discreetly and work out a solution together. I suspect we'll arrive at a different solution than moving

Re: 2.8.0rc1

2013-05-23 Thread Benn Mapes
*guilty face* On Thu, May 23, 2013 at 11:36 AM, Steven Gill stevengil...@gmail.comwrote: Damn Botson fans On Thu, May 23, 2013 at 11:34 AM, Filip Maj f...@adobe.com wrote: Hey everyone, Can folk hold off on committing to cordova-cli until Braden sorts out the branch merging? IM

2.8.0rc1 iOS testing

2013-05-23 Thread Ian Clelland
I've been running through cordova-mobile-spec 2.8.0rc1 on my ipad, and things are looking good! I had to update a couple of tests, but it's all green right now. Ian

Cordova CLI merge, new branch, INFRA ticket

2013-05-23 Thread Braden Shepherdson
tl;dr version: cordova-cli now has a master2 branch that should be treated as master going forward. DO NOT use master or future anymore. Short version: - I tried to merge future and master. - I couldn't because the history is a train wreck. The morbidly curious should see [2]. - Ian and I dug

Why does deviceready take a second to load on Android?

2013-05-23 Thread Joe Bowser
Hey I just tested Cordova with the latest JS on Android and I'm noticing a pretty solid lag in how long it takes for things like the platform name, version and UUID appear. Was there a recent change to deviceReady that causes it to be noticeably slower than it used to be? I'd figure that asking

Re: 2.8.0rc1

2013-05-23 Thread Filip Maj
So I did some tweaks after Braden's gnarly cordova-cli merge to get the tests up to par, remove some of them for cases that are no longer applicable (I.e. New plugman integration), and updated the android, bb, and iOS libraries. Android and iOS build fine. The new blackberry repo, though, has an

CORDOVA_JS_BUILD_LABEL

2013-05-23 Thread Jesse
Given a CORDOVA_JS_BUILD_LABEL of 2.8.0rc1-0-g22bc4d8 How can I find that commit, so I can be sure I am building the js for windows from the same commit? TIA @purplecabbage risingj.com

Re: CORDOVA_JS_BUILD_LABEL

2013-05-23 Thread Jesse
I got there ... thanks! @purplecabbage risingj.com On Thu, May 23, 2013 at 5:09 PM, Jesse purplecabb...@gmail.com wrote: Given a CORDOVA_JS_BUILD_LABEL of 2.8.0rc1-0-g22bc4d8 How can I find that commit, so I can be sure I am building the js for windows from the same commit? TIA

Re: CORDOVA_JS_BUILD_LABEL

2013-05-23 Thread Ian Clelland
On Thu, May 23, 2013 at 5:09 PM, Jesse purplecabb...@gmail.com wrote: Given a CORDOVA_JS_BUILD_LABEL of 2.8.0rc1-0-g22bc4d8 How can I find that commit, so I can be sure I am building the js for windows from the same commit? In case anyone else has the same question, now or in the future