1st pull request

2013-07-05 Thread Loic Pfister
Hello Dev, As I want to start to contriubte to apache cordova, I did the most easiest ticket I found (remove to line of code) and did a pull request. I hope I did the workflow in a correct way Here is the pull request: https://github.com/apache/cordova-ios/pull/66 And here is the jira issue s

Re: Whitelist: *.doman vs subdomain attribute

2013-07-05 Thread Andrew Grieve
Love that idea Andrew, but not sure it's doable on iOS. There's no native callback that would tell us the type of request. We could try and pipe through the request URLs to JS, but since our network interception happens on a non-UI thread, that would require proxying all requests, which is tough to

Re: Android Froyo (2.2 - 2.2.3) Deprecation in Cordova v2.9 or v3.0?

2013-07-05 Thread Brian LeRoux
That said, its important to note that the code and therefore tags lives so you can still target those devices w/ older releases of Cordova for as long as you need to. On Fri, Jul 5, 2013 at 1:12 PM, Joe Bowser wrote: > Turns out that removing this didn't break anything on Froyo, so we did it > ea

Re: cordova-cli CORDOVA_HOME env variable

2013-07-05 Thread Don Coleman
CORDOVA_HOME is the project directory? To me a name like CORDOVA_HOME infers the Corodva install directory (see JAVA_HOME, ANT_HOME, ANDROID_SDK_HOME.) CORDOVA_PROJECT_HOME is clunkier but may be more accurate. On Fri, Jul 5, 2013 at 1:28 PM, Michal Mocny wrote: > I think the use case is val

Re: Android Froyo (2.2 - 2.2.3) Deprecation in Cordova v2.9 or v3.0?

2013-07-05 Thread Joe Bowser
Turns out that removing this didn't break anything on Froyo, so we did it early. We really wanted to remove support because we are running out of test devices and can't guarantee it'll still work. Basically any old version that has less than 5% of devices on Google Play will end up getting deprec

Re: Whitelist: *.doman vs subdomain attribute

2013-07-05 Thread Andrew Lunny
We ran into a lot of issues with this at PhoneGap Build, when I was there. It's very difficult to anticipate all of the use cases that app developers will have (what kind of resources should be allowed from which domains, where links should open, if links should be followed, etc etc). One lower-le

Re: Whitelist: *.doman vs subdomain attribute

2013-07-05 Thread Brian LeRoux
TBH I'm still unsure of the entire whitelist thing. It feels like we've spent a great deal of time on a feature that is essentially just a talking point for security checklists. Our community is otherwise uninterested if not outright frustrated by it! I know the whitelist is pretty tied up to our

Re: Whitelist: *.doman vs subdomain attribute

2013-07-05 Thread Ian Clelland
That spec does have offer couple of advantages over the widget spec: - pathnames / filenames - * for scheme There doesn't appear to be anything that the widget spec allows that can't be represented with wildcards. You're right that we don't *need* to support any particular standard. What we do

Re: Whitelist: *.doman vs subdomain attribute

2013-07-05 Thread Andrew Grieve
As another point of reference, here's the white-listing scheme that Chrome extensions use: http://developer.chrome.com/extensions/match_patterns.html It uses * for wildcards, but adds some restrictions as to where the * may appear and what schemes are valid. It's not a goal for Cordova to be run

Re: Uninstallation of dependency-only plugins

2013-07-05 Thread Ian Clelland
Oh, don't be sad, Brian ;) That's why I only pushed to my fork; looking for constructive review. And now I know where the cli and plugman tests are, and they shall be made better before anything is pushed to a real repo. On Fri, Jul 5, 2013 at 2:23 PM, Brian LeRoux wrote: > =( > > Should go

Re: Whitelist: *.doman vs subdomain attribute

2013-07-05 Thread Andrew Grieve
We've had several requests for finer-grain whitelist. The main ask is a way to allow images. I think a simple step towards this would be to allow the whitelist to specify patterns that match against the full URL, and not just the domain. e.g. On Fri, Jul 5, 2013 at 2:05 PM, Ian Clelland wr

Re: Uninstallation of dependency-only plugins

2013-07-05 Thread Brian LeRoux
=( Should go without saying but lets not commit stuff without first ensuring the tests pass, eh. On Fri, Jul 5, 2013 at 10:05 AM, Filip Maj wrote: > Added comments to the issue thread. The tests no longer pass + we'll need > new tests to cover your changes. > > On 7/4/13 8:21 PM, "Ian Clelland"

Whitelist: *.doman vs subdomain attribute

2013-07-05 Thread Ian Clelland
There seem to be two competing methods for whitelisting domains with subdomains, and support for each varies by platform. - is supported on ios - is supported on android as of CB-3854 - is backwards-compatible with previous versions of cordova - is supported by cordova-cli - is

Re: cordova-cli CORDOVA_HOME env variable

2013-07-05 Thread Michal Mocny
I think the use case is valid. Patch seems simple enough. -Michal On Fri, Jul 5, 2013 at 1:25 PM, Filip Maj wrote: > Someone sent a pull request: > > https://github.com/apache/cordova-cli/pull/16 > > > Thoughts? > >

cordova-cli CORDOVA_HOME env variable

2013-07-05 Thread Filip Maj
Someone sent a pull request: https://github.com/apache/cordova-cli/pull/16 Thoughts?

Re: iOS: shouldRotateToOrientation javascript handler

2013-07-05 Thread Shazron
CDVInAppBrowser kinda does this already (hook into orientation changes) https://github.com/apache/cordova-ios/blob/2.9.0/CordovaLib/Classes/CDVInAppBrowser.m#L730-L756 https://github.com/apache/cordova-ios/blob/2.9.0/CordovaLib/Classes/CDVInAppBrowser.m#L99-L101 https://github.com/apache/cordova-io

Re: Uninstallation of dependency-only plugins

2013-07-05 Thread Filip Maj
Added comments to the issue thread. The tests no longer pass + we'll need new tests to cover your changes. On 7/4/13 8:21 PM, "Ian Clelland" wrote: >Thanks, Fil, > >Created CB-4077 to track this. I'll start working on separating those >functions. > >Ian > >On Thu, Jul 4, 2013 at 7:08 PM, Filip M

Re: iOS: shouldRotateToOrientation javascript handler

2013-07-05 Thread Shazron
+1. We planned to make this cross-platform sometime ago, but nothing came of it (see comments): https://issues.apache.org/jira/browse/CB-751 On Fri, Jul 5, 2013 at 9:58 AM, Michal Mocny wrote: > Yes, the use cases are real, but I thought it was odd that we only have it > for iOS. Also odd tha

Re: [Cordova] Cache encryption

2013-07-05 Thread Shazron
We had one: https://issues.apache.org/jira/browse/CB-50 For iOS, I believe the only thing we can control is the usage of this in the File API plugin, and perhaps the other plugins that write to file such as Camera and Capture. The rest are opaque to us. On Fri, Jul 5, 2013 at 9:55 AM, Loic Pfist

Re: iOS: shouldRotateToOrientation javascript handler

2013-07-05 Thread Michal Mocny
Yes, the use cases are real, but I thought it was odd that we only have it for iOS. Also odd that there is overhead for every rotation for every app, regardless of using this feature. We could perhaps add a config.xml flag to disable it by default, but its probably best to just replace it altoget

Re: restructuring guide content in doc

2013-07-05 Thread Shazron
The "versioning"/folder structure is still in place I reckon? Here was my idea: http://markmail.org/message/iebcuv2ztuna73az Whole thread regarding this problem: http://markmail.org/thread/6b5oylvfe6y3r64x On Fri, Jul 5, 2013 at 9:35 AM, Michael Sierra wrote: > This is a heads-up for some fai

Re: [Cordova] Cache encryption

2013-07-05 Thread Loic Pfister
Hello, I was wondering the same thing so I had a look at the cordova code for android & ios. For Android: Nothing is done, which means it will be only encrypted if the user decide to encrypt the full phone using android os encryption mechanism. For iOS: Same here nothing is done, The only diff

Re: iOS: shouldRotateToOrientation javascript handler

2013-07-05 Thread Shazron
If we have a suitable replacement to point users to - I'm all for it. The use case for this is if a user has an app that is portrait only, but needs to display something (video?) in landscape thus "overriding" the app default.s On Fri, Jul 5, 2013 at 9:11 AM, Michal Mocny wrote: > Yeah, sorry,

restructuring guide content in doc

2013-07-05 Thread Michael Sierra
This is a heads-up for some fairly extensive changes to the organization of the cordova-docs guide content. You may have noticed a bunch of new doc-related JIRAs. Of these, #3827 revises the content structure. It adds Overview & CLI sections, which are currently in place. To avoid confusion, I've

Re: ArrayBuffer support for Cordova OS X ?

2013-07-05 Thread Tyler Wilson
Okay, I just added an issue in the JIRA system - CB-4085. Let me know if I missed anything. Thank you, Tyler On Jul 5, 2013, at 11:49 AM, Tyler Wilson wrote: > Yes, I thought it would have handled it too, since I had seen that exec code > in the cordova.js file. But it appears the OS X versi

Re: [Cordova] Cache encryption

2013-07-05 Thread Filip Maj
My understanding is that Android cache and local storage are both encrypted by the OS as well, but I will defer to Joe's input on that / providing links to documentation that it is so. Joe should be back in action next week. On 7/5/13 12:34 AM, "Shazron" wrote: >On iOS, we rely on OS encryption,

Re: CLI's master2

2013-07-05 Thread Filip Maj
Thanks Andrew! Ian, will do. On 7/5/13 8:14 AM, "Ian Clelland" wrote: >Doh. I *just* submitted a pull req against master2. > >Fil -- let me know if you have any problems with it, and I'll resubmit as >necessary. > > >On Fri, Jul 5, 2013 at 8:50 AM, Andrew Grieve >wrote: > >> Okay, I made maste

Re: iOS: shouldRotateToOrientation javascript handler

2013-07-05 Thread Michal Mocny
Yeah, sorry, I meant the JS method: window.shouldRotateToOrientation is undocumented and not supported on other platforms. On Fri, Jul 5, 2013 at 11:47 AM, Andrew Grieve wrote: > I think he means it's undocumented within Cordova's docs. > > > On Fri, Jul 5, 2013 at 11:20 AM, Ian Clelland > wro

Re: Success with Cordova CLI and custom plugin

2013-07-05 Thread Tyler Wilson
Not even a poor man would accept Windows shortcuts for symlinks. It is a whole different file that just contains a reference back to the original. The closest thing on Windows are junction points, which only work for directories, which doesn't help me/us. Again, for me links are useful since I

Re: ArrayBuffer support for Cordova OS X ?

2013-07-05 Thread Tyler Wilson
Yes, I thought it would have handled it too, since I had seen that exec code in the cordova.js file. But it appears the OS X version uses a different method to get the JS objects into the native side. Odd, since I would expect that code to be identical in both iOS and OS X. I will see if I can

Re: iOS: shouldRotateToOrientation javascript handler

2013-07-05 Thread Andrew Grieve
I think he means it's undocumented within Cordova's docs. On Fri, Jul 5, 2013 at 11:20 AM, Ian Clelland wrote: > I'm not sure what you mean by "Undocumented" in this case -- it's not a > private API that would get you booted from the App Store; it's a documented > method on UIView, although it'

Re: cordova cli and OS X platform

2013-07-05 Thread Tyler Wilson
Shazron, Thank you for the response. I took a quick look at it, and as you say it appears much of the code can be gotten from the iOS platform code. It is not a high priority for me at the moment until the OS X version of Cordova supports ArrayBuffers as parameters, which is required for all my

Re: iOS: shouldRotateToOrientation javascript handler

2013-07-05 Thread Ian Clelland
I'm not sure what you mean by "Undocumented" in this case -- it's not a private API that would get you booted from the App Store; it's a documented method on UIView, although it's been deprecated recently.[1] Agreed that supporting the screen-orientation spec is probably the way to go in the futur

Re: CLI's master2

2013-07-05 Thread Ian Clelland
Doh. I *just* submitted a pull req against master2. Fil -- let me know if you have any problems with it, and I'll resubmit as necessary. On Fri, Jul 5, 2013 at 8:50 AM, Andrew Grieve wrote: > Okay, I made master look like master2, but the commit log is essentially > lost. Have not removed mast

iOS: shouldRotateToOrientation javascript handler

2013-07-05 Thread Michal Mocny
iOS seems to have an undocumented "feature" to call into javascript before every device orientation change (pasted below for your viewing pleasure). I can't find any such similar functionality on other platforms, should it be removed? Likely we will want to write a screen orientation ( http://www

Re: CLI's master2

2013-07-05 Thread Andrew Grieve
Okay, I made master look like master2, but the commit log is essentially lost. Have not removed master2. git rm -r . git checkout --theirs master2 -- . git commit -a Maybe lets now go back to committing to master, and keep master2 around for history's sake? On Thu, Jul

Re: [Cordova] Cache encryption

2013-07-05 Thread Shazron
On iOS, we rely on OS encryption, we do nothing to encrypt explicitly. See: https://github.com/phonegap/phonegap/wiki/Platform-Security (doc may not be up to date, and should be moved to the Apache wiki) On Thu, Jul 4, 2013 at 11:24 PM, Nguyen Van Duy1 wrote: > Hello, > > Thanks for the great p

[Cordova] Cache encryption

2013-07-05 Thread Nguyen Van Duy1
Hello, Thanks for the great project Cordova! I have a very quick newbie question: Does Cordova encrypt the cache data? If encrypting data is a fundamental requirement before saving them to disk, do you have any suggestion how to make it work in Cordova? Thanks a lot. Regards - Duy.

Android Froyo (2.2 - 2.2.3) Deprecation in Cordova v2.9 or v3.0?

2013-07-05 Thread Fowler, Angela
Hi devs, We are looking at moving from Cordova v2.7.0 to v2.9.x and have some concerns about which Android platforms are still supported. Froyo accounts for 3% of users on the Google Play Store. According to the deprecation policy, Froyo should still be in until v3.0 http://wiki.apache.org/