Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/42#discussion_r12221118
--- Diff: src/ios/CDVFile.m ---
@@ -313,11 +313,9 @@ - (void)pluginInitialize
--- End diff --
Since you are doing the copy route
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/42#discussion_r12221112
--- Diff: plugin.xml ---
@@ -212,6 +212,27 @@
xmlns:android="http://schemas.android.com/apk/res/android";
+
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-plugman/pull/76
Fix plugin check error, when plugin dependency with specific version is
given.
Fix for this issue: https://issues.apache.org/jira/browse/CB-6615
You can merge this pull request int
I'll take care of it. https://issues.apache.org/jira/browse/CB-6616
On May 1, 2014, at 4:52 PM, Martin Gonzalez Glez
wrote:
> Createmobilespec.js can support it, Add an option to createmobilespec.js,
> in order to accept the argument and use plugman install, instead of cordova
> plugin add.
> I
I've gotten a lot of good feedback. My plan is to review, update, etc, and see
if it feels like a good 1.0 release for Monday at which point yall can take it
over.
From: kerrisho...@gmail.com on behalf of Kerri Shotts
Sent: Friday, May 02, 2014 12:05 A
Only if you run the command.
On Thu, May 1, 2014 at 1:26 PM, Joe Bowser wrote:
> Doesn't coho audit every time we cut a release?
>
> On Thu, May 1, 2014 at 10:17 AM, Andrew Grieve
> wrote:
> > Drafted this up here:
> >
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
Since you talked about plugin so do you plan to introduce/merge xwalk
extension mechanism to Cordova plugin mechanism?
Thanks,
Leo
On Wed, Apr 30, 2014 at 12:23 PM, Joe Bowser wrote:
> Hey
>
> So, once again, we're dealing with some major API changes once we
> introduce pluggable webview. The
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugman/pull/76#issuecomment-42056008
Would be great if there was a test for this in:
https://github.com/apache/cordova-plugman/blob/master/spec/fetch.spec.js
---
If your project is set up for it,
GitHub user Zaspire opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/25
ubuntu: use application directory for images
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Zaspire/cordova-plugin-camera master
GitHub user Zaspire opened a pull request:
https://github.com/apache/cordova-ubuntu/pull/6
3.5
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Zaspire/cordova-ubuntu master
Alternatively you can review and apply these changes as
GitHub user Zaspire opened a pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/12
ubuntu: don't destroy callback after use
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Zaspire/cordova-plugin-device-moti
GitHub user Zaspire opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/43
ubuntu: Change FS URL scheme to 'cdvfile'
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Zaspire/cordova-plugin-file master
Altern
GitHub user Zaspire opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/29
ubuntu: support 'cdvfile' URI
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Zaspire/cordova-plugin-file-transfer master
Github user pororious commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/43#issuecomment-42056757
NAVER - http://www.naver.com/
hyunsu1...@naver.com ëê» ë³´ë´ì ë©ì¼ <[cordova-plugin-fil
Hi All,
Cordova-lib is here. And since there is no way to do it gradually without
eternally chasing changes between repos, I'm landing it on master in a big
heavy chunk (as well as on branch named cordova-lib).
Cordova lib is here: https://git-wip-us.apache.org/repos/asf/cordova-lib.git
when clo
Instructions for checking history in cordova-lib:
git log will show no history from before this commit for files that
moved. To see full history use either
git log --follow
or
git log cli_pre_lib
git log plugman_pre_lib
'cli_pre_lib' and 'plugman_pre_lib' are tags for the last commit in
cordo
Hey Maxim,
I'm assuming you want me to pull those in :P
On Fri, May 2, 2014 at 10:35 AM, Maxim Ermilov (JIRA) wrote:
>
> [
> https://issues.apache.org/jira/browse/CB-6594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13987982#comment-13987982]
>
> Ma
Thanks Mark, I'll take a look now.
One quick note: at the hangout we raised the option of placing everything
in cordova-lib.git repo inside a top-level node_modules dir. There was
some debate if that was a good idea, bad idea, or just a joke.. Right now,
we think it may help with dev workflow, b
Oh no you don't. This is YOUR baby to maintain. =)
On Fri, May 2, 2014 at 6:59 AM, Ray Camden wrote:
> I've gotten a lot of good feedback. My plan is to review, update, etc, and
> see if it feels like a good 1.0 release for Monday at which point yall can
> take it over.
>
>
On Fri, May 2, 2014 at 2:43 PM, Mark Koudritsky wrote:
> Instructions for checking history in cordova-lib:
>
> git log will show no history from before this commit for files that
> moved. To see full history use either
> git log --follow
> or
> git log cli_pre_lib
> git log plugman_pre_lib
>
Thanks Mark for sending this out. I just noticed these changes as I need
to fix something in amazon_fireos_parser.js. :)
Question: re: code that does require('cordova/something') will break.
Platform scripts use 'cordova/something' and I guess we will have to take
care of those. Is this change goi
Added JIRA component: CordovaLib
On Fri, May 2, 2014 at 3:12 PM, Naik, Archana wrote:
> Thanks Mark for sending this out. I just noticed these changes as I need
> to fix something in amazon_fireos_parser.js. :)
>
> Question: re: code that does require('cordova/something') will break.
> Platform
On Fri, May 2, 2014 at 3:12 PM, Naik, Archana wrote:
> Thanks Mark for sending this out. I just noticed these changes as I need
> to fix something in amazon_fireos_parser.js. :)
>
> Question: re: code that does require('cordova/something') will break.
> Platform scripts use 'cordova/something' an
Cool. I just checked amazon-fireos and looks like there are no scripts
referring to cordova/something. So all is well. :)
Thanks
Archana
On 5/2/14 12:33 PM, "Mark Koudritsky" wrote:
>On Fri, May 2, 2014 at 3:12 PM, Naik, Archana wrote:
>
>> Thanks Mark for sending this out. I just noticed thes
Added cordova-lib to coho repo list --- but I haven't figured out which
lists it needs to go in yet, so that will need to be updated for releases
etc.
Mark, I noticed that cordova-lib is in CLI package.json deps, but not for
plugman. I imagine thats an oversight?
Also, if you npm install before
GitHub user rodms10 opened a pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/17
CB-5416 - Adding support for auto-managing permissions
With [CB-5416](https://github.com/apache/cordova-cli/pull/168) merged into
cordova-cli, we can have plugins automatically se
On Fri, May 2, 2014 at 3:52 PM, Michal Mocny wrote:
> Added cordova-lib to coho repo list --- but I haven't figured out which
> lists it needs to go in yet, so that will need to be updated for releases
> etc.
>
> Mark, I noticed that cordova-lib is in CLI package.json deps, but not for
> plugman.
1. node_modules is a bad idea and yep it was a joke
2. are we looking to break out into something wherein the cordova-lib is a
dumb directory w/ modules inside it still? (unclear in current structure)
On Fri, May 2, 2014 at 12:13 PM, Michal Mocny wrote:
> On Fri, May 2, 2014 at 2:43 PM, Mark Ko
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/9#issuecomment-42079997
This can be closed, merged already: see
44005034004559bb798f402b4ef177f5f70167d8
---
If your project is set up for it, you can reply to this e
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/6#issuecomment-42080099
Fixed in commit 44005034004559bb798f402b4ef177f5f70167d8
---
If your project is set up for it, you can reply to this email and have your
reply
We will see how it goes, but I think cordova-lib should be a real module,
rather than just a prefix. Even if eventually it will be a thin layer that
just proxies to all other submodules. Anyway, right it would be very
difficult to split it into several cordova-lib-something modules without
cordova-
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/13#issuecomment-42082556
@Inwinder Can you file a new issue?
https://issues.apache.org/jira/browse/CB
I'll work on it. what this needs is a possible re-factor so it is un
Releasing options for 3.5.0.
Option 1: Release like we always have.
* One zip containing zips of the platforms, js, docs, cli
Option 2: Break up platforms/tools/plugins
This is the option we are going towards with independent releases.
* Platforms go in the platforms directory
* Tools in the tool
What does cordova lib do? Grab bag of properties like this?
module.exports = {
}
On Fri, May 2, 2014 at 2:44 PM, Mark Koudritsky wrote:
> We will see how it goes, but I think cordova-lib should be a real module,
> rather than just a prefix. Even if eventually it will be a thin layer that
> ju
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/42#issuecomment-42088711
Filed issue: https://issues.apache.org/jira/browse/CB-6624
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-vibration/pull/11#issuecomment-42088838
iCLA received.
Filed: https://issues.apache.org/jira/browse/CB-6625
---
If your project is set up for it, you can reply to this email and have
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugins/pull/10
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-contacts/pull/28
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/20
Updated the cadence release process doc
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-4
Alternatively y
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-coho/pull/20
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/40#issuecomment-42089981
From my code review comments (3 of them) in this PR, my recommendation is
this pull request is unnecessary and is therefore rejected. Please close this
pull r
Github user pororious commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/40#issuecomment-42089984
NAVER - http://www.naver.com/
hyunsu1...@naver.com ëê» ë³´ë´ì ë©ì¼ ì´ ë¤ìê³¼ ê°ì
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/4#issuecomment-42090058
Filed: https://issues.apache.org/jira/browse/CB-6626
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-42090217
Filed https://issues.apache.org/jira/browse/CB-6627
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-42091340
How are you testing this? My device is non-responsive when I integrated
your code and do:
```
navigator.camera.getPicture(onSuccess, onFail, { quali
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-42091677
After debugging, there are two spots that are not handled:
1.
https://github.com/shazron/cordova-plugin-camera/blob/e9c48138c1e3afdb7a18811042507026e3f5
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-42091967
Found the culprit:
https://github.com/shazron/cordova-plugin-camera/blob/e9c48138c1e3afdb7a18811042507026e3f5880b/src/ios/CDVCamera.m#L312
If e
Sorry I'm late to the party, being trapped on a work conference all week.
- Ray, thanks for starting this I'm interested on helping also, I know is
difficult on not being opinionated when giving advice base on our own
experiences, and that sometimes folks looking for solutions to problems
there is
I can help with testing Firefox OS. I assume I can't do much on the firefox os
subtask[1] as a non-committer.
There are a couple of pull requests for Firefox OS that I'd love to see in the
release ([2] & [3]). PR [4] would be amazing too, but might need some rework.
I'm waiting on cordova-lib t
Mike,
spajs.io didn't get the track we wanted, so we ended putting the content
here:
*"Best practices for mobile app development"*
https://www.ibm.com/developerworks/mobile/worklight/best-practices.html
We created this because we often got questioned "What are the best
practices when doing hybri
Andrew,
Should we add a link to this document from the other
*-release-process.md[1], maybe near the section "Start VOTE Thread"?
[1]:
https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md#start-vote-thread
https://github.com/apache/cordova-coho/blob/master/docs/caden
Hi Freak
Are you referring about having a link on the website
http://cordova.apache.org ?
There is a link at the top "Plugins" it will take you to the plugins
registry http://plugins.cordova.io
On Thu, May 1, 2014 at 10:37 AM, Freak Show wrote:
>
> On May 1, 2014, at 10:21 AM, Andrew Grieve
haha "is so 2007" love it
On Thu, May 1, 2014 at 7:58 AM, Joe Bowser wrote:
> How? With something like this?
>
> "Even their dev process is slow. With Famo.us, we make you sign an NDA so
> that you can't complain about how we change our API."
>
> In all seriousness, we're cool with anyone writi
Sorry for being late to the party.
When I was a consumer of Phonegap back in the days, my most precious doc
was the upgrade guides [1]. We didn't have the bandwidth or test process to
update our app with every release of phonegap. But when it was time to
upgrade (i.e. 1.4 to 1.9) The upgrade guide
54 matches
Mail list logo