[GitHub] cordova-plugin-splashscreen pull request: Fix ios launchimage

2014-05-02 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/13#issuecomment-41994042 https://github.com/apache/cordova-plugin-splashscreen/commit/e3e39967660c5715da2838f434bba288776ae358#commitcomment-6168568 --- If your project is

[GitHub] cordova-osx pull request: enhancements to the cordova-osx

2014-05-02 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-osx/pull/9#issuecomment-41994793 I believe you said you are re-submitting? If so, please close this PR --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-osx pull request: CB-6567 Adding the OSX platform also cop...

2014-05-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-osx/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-osx pull request: isArray and isDictionary checks in the C...

2014-05-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-osx/pull/1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-plugin-file pull request: updated support for the OS X pla...

2014-05-02 Thread shazron
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/42#discussion_r12221118 --- Diff: src/ios/CDVFile.m --- @@ -313,11 +313,9 @@ - (void)pluginInitialize --- End diff -- Since you are doing the copy

[GitHub] cordova-plugin-file pull request: updated support for the OS X pla...

2014-05-02 Thread shazron
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/42#discussion_r12221112 --- Diff: plugin.xml --- @@ -212,6 +212,27 @@ xmlns:android=http://schemas.android.com/apk/res/android; framework

[GitHub] cordova-plugman pull request: Fix plugin check error, when plugin ...

2014-05-02 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugman/pull/76 Fix plugin check error, when plugin dependency with specific version is given. Fix for this issue: https://issues.apache.org/jira/browse/CB-6615 You can merge this pull request

Re: createmobilespecandroid-usingplugman.sh

2014-05-02 Thread Marcel Kinard
I'll take care of it. https://issues.apache.org/jira/browse/CB-6616 On May 1, 2014, at 4:52 PM, Martin Gonzalez Glez martin.c.glez.g...@gmail.com wrote: Createmobilespec.js can support it, Add an option to createmobilespec.js, in order to accept the argument and use plugman install, instead

RE: First stab at Next Steps article

2014-05-02 Thread Ray Camden
I've gotten a lot of good feedback. My plan is to review, update, etc, and see if it feels like a good 1.0 release for Monday at which point yall can take it over. From: kerrisho...@gmail.com kerrisho...@gmail.com on behalf of Kerri Shotts

Re: What should it mean to +1 a release

2014-05-02 Thread Andrew Grieve
Only if you run the command. On Thu, May 1, 2014 at 1:26 PM, Joe Bowser bows...@gmail.com wrote: Doesn't coho audit every time we cut a release? On Thu, May 1, 2014 at 10:17 AM, Andrew Grieve agri...@chromium.org wrote: Drafted this up here:

Re: [Android] Not so fast....API changes in Cordova-Android for Pluggable WebView

2014-05-02 Thread Leo Yang
Since you talked about plugin so do you plan to introduce/merge xwalk extension mechanism to Cordova plugin mechanism? Thanks, Leo On Wed, Apr 30, 2014 at 12:23 PM, Joe Bowser bows...@gmail.com wrote: Hey So, once again, we're dealing with some major API changes once we introduce pluggable

[GitHub] cordova-plugman pull request: Fix plugin check error, when plugin ...

2014-05-02 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugman/pull/76#issuecomment-42056008 Would be great if there was a test for this in: https://github.com/apache/cordova-plugman/blob/master/spec/fetch.spec.js --- If your project is set up for

[GitHub] cordova-plugin-camera pull request: ubuntu: use application direct...

2014-05-02 Thread Zaspire
GitHub user Zaspire opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/25 ubuntu: use application directory for images You can merge this pull request into a Git repository by running: $ git pull https://github.com/Zaspire/cordova-plugin-camera master

[GitHub] cordova-ubuntu pull request: 3.5

2014-05-02 Thread Zaspire
GitHub user Zaspire opened a pull request: https://github.com/apache/cordova-ubuntu/pull/6 3.5 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Zaspire/cordova-ubuntu master Alternatively you can review and apply these changes

[GitHub] cordova-plugin-device-motion pull request: ubuntu: don't destroy c...

2014-05-02 Thread Zaspire
GitHub user Zaspire opened a pull request: https://github.com/apache/cordova-plugin-device-motion/pull/12 ubuntu: don't destroy callback after use You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-file pull request: ubuntu: Change FS URL scheme to ...

2014-05-02 Thread Zaspire
GitHub user Zaspire opened a pull request: https://github.com/apache/cordova-plugin-file/pull/43 ubuntu: Change FS URL scheme to 'cdvfile' You can merge this pull request into a Git repository by running: $ git pull https://github.com/Zaspire/cordova-plugin-file master

[GitHub] cordova-plugin-file pull request: ubuntu: Change FS URL scheme to ...

2014-05-02 Thread pororious
Github user pororious commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/43#issuecomment-42056757 NAVER - http://www.naver.com/ hyunsu1...@naver.com 님께 보내신 메일

Re: cordova-lib split out

2014-05-02 Thread Mark Koudritsky
Instructions for checking history in cordova-lib: git log file will show no history from before this commit for files that moved. To see full history use either git log --follow file or git log cli_pre_lib old file name git log plugman_pre_lib old file name 'cli_pre_lib' and 'plugman_pre_lib'

Re: [jira] [Commented] (CB-6594) [Release + 3.5.0] Branch Test Tag RC1 for Ubuntu

2014-05-02 Thread Steven Gill
Hey Maxim, I'm assuming you want me to pull those in :P On Fri, May 2, 2014 at 10:35 AM, Maxim Ermilov (JIRA) j...@apache.orgwrote: [

Re: cordova-lib split out

2014-05-02 Thread Michal Mocny
Thanks Mark, I'll take a look now. One quick note: at the hangout we raised the option of placing everything in cordova-lib.git repo inside a top-level node_modules dir. There was some debate if that was a good idea, bad idea, or just a joke.. Right now, we think it may help with dev workflow,

Re: First stab at Next Steps article

2014-05-02 Thread Brian LeRoux
Oh no you don't. This is YOUR baby to maintain. =) On Fri, May 2, 2014 at 6:59 AM, Ray Camden rayca...@adobe.com wrote: I've gotten a lot of good feedback. My plan is to review, update, etc, and see if it feels like a good 1.0 release for Monday at which point yall can take it over.

Re: cordova-lib split out

2014-05-02 Thread Michal Mocny
On Fri, May 2, 2014 at 2:43 PM, Mark Koudritsky kam...@google.com wrote: Instructions for checking history in cordova-lib: git log file will show no history from before this commit for files that moved. To see full history use either git log --follow file or git log cli_pre_lib old file

Re: cordova-lib split out

2014-05-02 Thread Naik, Archana
Thanks Mark for sending this out. I just noticed these changes as I need to fix something in amazon_fireos_parser.js. :) Question: re: code that does require('cordova/something') will break. Platform scripts use 'cordova/something' and I guess we will have to take care of those. Is this change

Re: cordova-lib split out

2014-05-02 Thread Mark Koudritsky
On Fri, May 2, 2014 at 3:12 PM, Naik, Archana na...@lab126.com wrote: Thanks Mark for sending this out. I just noticed these changes as I need to fix something in amazon_fireos_parser.js. :) Question: re: code that does require('cordova/something') will break. Platform scripts use

Re: cordova-lib split out

2014-05-02 Thread Naik, Archana
Cool. I just checked amazon-fireos and looks like there are no scripts referring to cordova/something. So all is well. :) Thanks Archana On 5/2/14 12:33 PM, Mark Koudritsky kam...@google.com wrote: On Fri, May 2, 2014 at 3:12 PM, Naik, Archana na...@lab126.com wrote: Thanks Mark for sending

Re: cordova-lib split out

2014-05-02 Thread Michal Mocny
Added cordova-lib to coho repo list --- but I haven't figured out which lists it needs to go in yet, so that will need to be updated for releases etc. Mark, I noticed that cordova-lib is in CLI package.json deps, but not for plugman. I imagine thats an oversight? Also, if you npm install before

[GitHub] cordova-plugin-geolocation pull request: CB-5416 - Adding support ...

2014-05-02 Thread rodms10
GitHub user rodms10 opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/17 CB-5416 - Adding support for auto-managing permissions With [CB-5416](https://github.com/apache/cordova-cli/pull/168) merged into cordova-cli, we can have plugins automatically

Re: cordova-lib split out

2014-05-02 Thread Mark Koudritsky
On Fri, May 2, 2014 at 3:52 PM, Michal Mocny mmo...@chromium.org wrote: Added cordova-lib to coho repo list --- but I haven't figured out which lists it needs to go in yet, so that will need to be updated for releases etc. Mark, I noticed that cordova-lib is in CLI package.json deps, but not

Re: cordova-lib split out

2014-05-02 Thread Brian LeRoux
1. node_modules is a bad idea and yep it was a joke 2. are we looking to break out into something wherein the cordova-lib is a dumb directory w/ modules inside it still? (unclear in current structure) On Fri, May 2, 2014 at 12:13 PM, Michal Mocny mmo...@chromium.org wrote: On Fri, May 2, 2014

[GitHub] cordova-plugin-network-information pull request: CB-3207 Newer imp...

2014-05-02 Thread rodms10
Github user rodms10 commented on the pull request: https://github.com/apache/cordova-plugin-network-information/pull/9#issuecomment-42079997 This can be closed, merged already: see 44005034004559bb798f402b4ef177f5f70167d8 --- If your project is set up for it, you can reply to this

[GitHub] cordova-plugin-network-information pull request: Fixed syntax erro...

2014-05-02 Thread rodms10
Github user rodms10 commented on the pull request: https://github.com/apache/cordova-plugin-network-information/pull/6#issuecomment-42080099 Fixed in commit 44005034004559bb798f402b4ef177f5f70167d8 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-splashscreen pull request: Fix ios launchimage

2014-05-02 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/13#issuecomment-42082556 @Inwinder Can you file a new issue? https://issues.apache.org/jira/browse/CB I'll work on it. what this needs is a possible re-factor so it is

Re: [DISCUSS] Release 3.5.0

2014-05-02 Thread Steven Gill
Releasing options for 3.5.0. Option 1: Release like we always have. * One zip containing zips of the platforms, js, docs, cli Option 2: Break up platforms/tools/plugins This is the option we are going towards with independent releases. * Platforms go in the platforms directory * Tools in the

Re: cordova-lib split out

2014-05-02 Thread Brian LeRoux
What does cordova lib do? Grab bag of properties like this? module.exports = { } On Fri, May 2, 2014 at 2:44 PM, Mark Koudritsky kam...@google.com wrote: We will see how it goes, but I think cordova-lib should be a real module, rather than just a prefix. Even if eventually it will be a thin

[GitHub] cordova-plugin-inappbrowser pull request: Only Navigate *after* th...

2014-05-02 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/42#issuecomment-42088711 Filed issue: https://issues.apache.org/jira/browse/CB-6624 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-vibration pull request: Implemented vibrateWithPatt...

2014-05-02 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-vibration/pull/11#issuecomment-42088838 iCLA received. Filed: https://issues.apache.org/jira/browse/CB-6625 --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-plugins pull request: Update README.md

2014-05-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugins/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-contacts pull request: Add error codes to index.md

2014-05-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-coho pull request: Updated the cadence release process doc

2014-05-02 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-coho/pull/20 Updated the cadence release process doc You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-coho patch-4 Alternatively

[GitHub] cordova-coho pull request: Updated the cadence release process doc

2014-05-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/20 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-file pull request: Update plugin.xml

2014-05-02 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/40#issuecomment-42089981 From my code review comments (3 of them) in this PR, my recommendation is this pull request is unnecessary and is therefore rejected. Please close this pull

[GitHub] cordova-plugin-file pull request: Update plugin.xml

2014-05-02 Thread pororious
Github user pororious commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/40#issuecomment-42089984 NAVER - http://www.naver.com/ hyunsu1...@naver.com 님께 보내신 메일 Re:

[GitHub] cordova-plugin-statusbar pull request: Added javascript event on s...

2014-05-02 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/4#issuecomment-42090058 Filed: https://issues.apache.org/jira/browse/CB-6626 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-camera pull request: Make dest NATIVE_URI compatibl...

2014-05-02 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-42090217 Filed https://issues.apache.org/jira/browse/CB-6627 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-camera pull request: Make dest NATIVE_URI compatibl...

2014-05-02 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-42091340 How are you testing this? My device is non-responsive when I integrated your code and do: ``` navigator.camera.getPicture(onSuccess, onFail, {

[GitHub] cordova-plugin-camera pull request: Make dest NATIVE_URI compatibl...

2014-05-02 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-42091677 After debugging, there are two spots that are not handled: 1.

[GitHub] cordova-plugin-camera pull request: Make dest NATIVE_URI compatibl...

2014-05-02 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-42091967 Found the culprit: https://github.com/shazron/cordova-plugin-camera/blob/e9c48138c1e3afdb7a18811042507026e3f5880b/src/ios/CDVCamera.m#L312 If

Re: First stab at Next Steps article

2014-05-02 Thread Carlos Santana
Sorry I'm late to the party, being trapped on a work conference all week. - Ray, thanks for starting this I'm interested on helping also, I know is difficult on not being opinionated when giving advice base on our own experiences, and that sometimes folks looking for solutions to problems there

Re: First stab at Next Steps article

2014-05-02 Thread Carlos Santana
Mike, spajs.io didn't get the track we wanted, so we ended putting the content here: *Best practices for mobile app development* https://www.ibm.com/developerworks/mobile/worklight/best-practices.html We created this because we often got questioned What are the best practices when doing hybrid

Re: What should it mean to +1 a release

2014-05-02 Thread Carlos Santana
Andrew, Should we add a link to this document from the other *-release-process.md[1], maybe near the section Start VOTE Thread? [1]: https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md#start-vote-thread

Re: Docs for plugins

2014-05-02 Thread Carlos Santana
Hi Freak Are you referring about having a link on the website http://cordova.apache.org ? There is a link at the top Plugins it will take you to the plugins registry http://plugins.cordova.io On Thu, May 1, 2014 at 10:37 AM, Freak Show freaksho...@me.com wrote: On May 1, 2014, at 10:21 AM,

Re: Success with Crosswalk Engine (and webview plugins for 3.5.0)

2014-05-02 Thread Carlos Santana
haha is so 2007 love it On Thu, May 1, 2014 at 7:58 AM, Joe Bowser bows...@gmail.com wrote: How? With something like this? Even their dev process is slow. With Famo.us, we make you sign an NDA so that you can't complain about how we change our API. In all seriousness, we're cool with

Re: Some pain points from our users :'(

2014-05-02 Thread Carlos Santana
Sorry for being late to the party. When I was a consumer of Phonegap back in the days, my most precious doc was the upgrade guides [1]. We didn't have the bandwidth or test process to update our app with every release of phonegap. But when it was time to upgrade (i.e. 1.4 to 1.9) The upgrade