[GitHub] cordova-firefoxos pull request: add icon for firefoxos

Github user marti1125 commented on the pull request: https://github.com/apache/cordova-firefoxos/pull/12#issuecomment-45401978 @rodms10 update new-icon branch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cordova-plugin-device pull request: Use Windows system calls to ge...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/14#issuecomment-45399940 Hard to see, but the text icla is actually a link. To here: http://www.apache.org/licenses/#clas And a link to the PDF http://www.apache.

[GitHub] cordova-plugin-device pull request: Use Windows system calls to ge...

Github user EionRobb commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/14#issuecomment-45399103 No I haven't. I've had other submitted code accepted though if that helps ;-) Do you have a link to the agreement to sign? I couldn't find one

[GitHub] cordova-plugin-device pull request: Use Windows system calls to ge...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/14#issuecomment-45397561 Eion, Thanks for your contribution. Have you signed the ICLA? http://cordova.apache.org/#contribute Cheers, Jesse --- If your

[GitHub] cordova-coho pull request: Added info on how to format commit

GitHub user stevengill opened a pull request: https://github.com/apache/cordova-coho/pull/29 Added info on how to format commit You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-coho patch-12 Alternatively you c

[GitHub] cordova-coho pull request: Update plugins-release-process.md

Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-coho pull request: Added info on how to format commit

Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Plugins Release Blog Post Review!

Please review the blog post at https://github.com/cordova/apache-blog-posts/blob/master/2014-06-05-plugins-release.md. Send a pull request for changes. Or ask and I shall give you access to the repo. Once again, I would love some input on the notable changes section. Mainly, what else should I m

[GitHub] cordova-plugin-contacts pull request: Fix reference to contacts in...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/20#issuecomment-45393281 Thanks, this was fixed here: https://github.com/apache/cordova-plugin-contacts/commit/a97110465f11c9c4feb041bde8ac9aa9b954ea19 Please c

[GitHub] cordova-firefoxos pull request: add icon for firefoxos

Github user rodms10 commented on the pull request: https://github.com/apache/cordova-firefoxos/pull/12#issuecomment-45392401 Can you pull from master and rebase your branch? I still don't see the changes from the [clean up PR](https://github.com/apache/cordova-firefoxos/pull/11) in yo

[GitHub] cordova-firefoxos pull request: add icon for firefoxos

Github user marti1125 commented on the pull request: https://github.com/apache/cordova-firefoxos/pull/12#issuecomment-45389256 @rodms10 could you check? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-device-motion pull request: CB-6888 Polish translat...

Github user rodms10 commented on the pull request: https://github.com/apache/cordova-plugin-device-motion/pull/13#issuecomment-45388123 I think you must go through crowdin for translation, [see the wiki](http://wiki.apache.org/cordova/CordovaTranslations). @ldeluca can probably confi

[GitHub] cordova-windows pull request: CB 6728 Support chip architecture as...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/33 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [VOTE] Plugins Release

Marcel: Yes. Andrew: I see it https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git On Fri, Jun 6, 2014 at 9:02 AM, Andrew Grieve wrote: > I don't see the tag for inappbrowser. Forgot to push it? > > > On Fri, Jun 6, 2014 at 10:46 AM, Marcel Kinard wrote: > > > Steve, to c

[GitHub] cordova-wp8 pull request: CB-6728 Support chip architecture as an ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-wp8/pull/39 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Problem adding camera plugin

Rebuilding a new project solved the issue, but it's really annoying when this happens. Anyone know what causes issues like this? Sometimes I need to re-install plugins because I get errors that the plugin doesn't exist in Xcode. I'd love to better understand the problem. Thanks, Marc On Fri, Jun

Problem adding camera plugin

Hey guys, Ran into this issue today, and can't find it documented anywhere. I'm running 3.4.1-0.1.1-dev, not sure if that's the issue. I removed the camera plugin, (which used to work), and after re-adding it, I get the following error when trying to do cordova build: Undefined symbols for archi

Re: publish coho to npm

On Fri, Jun 6, 2014 at 3:47 PM, Ian Clelland wrote: > On Friday, June 6, 2014, Andrew Grieve wrote: > > > There's definitely some upside, but some downsides as well: > > - would add some overhead for us to have to remember to version & publish > > it after every change > > > Sure, but that's lik

Re: Plugman support for Android libraries

Just tested this out today! Everything worked great except it tried to find my custom library within the project dir instead of within the plugin. Fixed it with: http://git-wip-us.apache.org/repos/asf/cordova-lib/commit/04588a42 But wanted to check that you think this is correct. On Thu, May 15

Re: Cordova strategy for Hosted Apps

Hi Jeff, 1. Currently (out of the box) you can load the start page from the network or the device file system. However, you need to be aware of both CORS issues as well as App store policies which may make this approach un-submittable [1] . You can achieve this either by setting the in your conf

Cordova strategy for Hosted Apps

I have a tool that allows developers to take their web apps and build them into hosted store apps on Windows 8.1 and Windows Phone (8 and 8.1) called the Web App Template. Some of the developers who are using the tool would like to see it go cross platform to Android

Re: publish coho to npm

On Friday, June 6, 2014, Andrew Grieve wrote: > There's definitely some upside, but some downsides as well: > - would add some overhead for us to have to remember to version & publish > it after every change Sure, but that's like any tool. Or we could just periodically bundle all of the changes

Re: wip on cordova-lib? pls let us know

Anis: sounds good. Thats was the original intent, and cordova-lib repo was the first step. Also agree that once we have a package that really is well decoupled from the rest, we can consider moving to independent repos, especially if it has some utility on its own. (The CordovaError point was ju

Re: wip on cordova-lib? pls let us know

Here's a wip for the breakout of the config parser module https://github.com/lorinbeer/cordova-lib/tree/configparser_module still need to tidy up the referencing but feedback welcome On Fri, Jun 6, 2014 at 11:03 AM, Anis KADRI wrote: > The goal is to have independent modules that can be consume

[GitHub] cordova-plugin-file pull request: fix for CB-6872

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/50 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] cordova-firefoxos pull request: add icon for firefoxos

Github user rodms10 commented on the pull request: https://github.com/apache/cordova-firefoxos/pull/12#issuecomment-45371763 Thanks for working on this! Can you address the review comments? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-firefoxos pull request: add icon for firefoxos

Github user rodms10 commented on a diff in the pull request: https://github.com/apache/cordova-firefoxos/pull/12#discussion_r13504812 --- Diff: bin/lib/create.js --- @@ -67,7 +67,7 @@ exports.createProject = function(project_path,package_name,project_name){ shjs.cp( path.j

[GitHub] cordova-firefoxos pull request: add icon for firefoxos

Github user rodms10 commented on a diff in the pull request: https://github.com/apache/cordova-firefoxos/pull/12#discussion_r13504727 --- Diff: .gitignore --- @@ -1 +1,2 @@ .DS_Store +node_modules/ --- End diff -- Please remove this line. I can't find the discu

Re: android commit: Remove Ant custom build directories

Done (on a 4.0.x docs branch) On Fri, Jun 6, 2014 at 11:33 AM, Ian Clelland wrote: > Thanks, Marcel. I'll take care of that one too > > > On Friday, June 6, 2014, Marcel Kinard wrote: > >> Ian, there is also this doc that may need to be mostly reverted: >> >> >> https://github.com/apache/cordo

Re: Ant/Crosswalk woes

If I may have a word on this: I fought for quite a few weeks before I could get my project to a working state for both CLI and my IDE (Intellij IDEA). Considering what my final solution was and development workflow has been since then, I could say that for me the CLI working is much more important

Re: wip on cordova-lib? pls let us know

The goal is to have independent modules that can be consumed. Andrew, your second example reflects what we want to achieve. Obviously, there will be more than CordovaError. Brian and I think that we can keep the current cordova-lib repository and create folders for each module (each with its own d

Re: wip on cordova-lib? pls let us know

Michal Mocny wrote: >Additionally, I think it will only be a problem when each of the modules >call into one another. I.e. when cordova-cli calls into cordova-plugman >and that throws a CordovaError which is caught by cordova-cli and then >compared with instanceof to its own version.. Its not a p

Re: wip on cordova-lib? pls let us know

Additionally, I think it will only be a problem when each of the modules call into one another. I.e. when cordova-cli calls into cordova-plugman and that throws a CordovaError which is caught by cordova-cli and then compared with instanceof to its own version.. Its not a problem in isolation. Th

[GitHub] cordova-firefoxos pull request: Cleanup templates www folder

Github user asfgit closed the pull request at: https://github.com/apache/cordova-firefoxos/pull/11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

Re: publish coho to npm

oh weird, I use it globally as convenience for cloning and looking at PRs / never tried using as 'top level' …it does work for that use case currently without any env variables or passing anything. just works from cwd. (and you could make that assumption generally imo) On Fri, Jun 6, 2014 at 10:1

Parent for browserify?

Was asked in https://issues.apache.org/jira/browse/CB-5671 Couldn't find one after a quick search though.

Re: [Android] 4.0.x plugin fixes

This is the code that I'd be using to get, for instance, the File plugin from the FileTransfer plugin: Class webViewClass = webView.getClass(); PluginManager pm; try { Method gpm = webViewClass.getMethod("getPluginManager"); pm = (PluginManager) gpm.invoke(webView);

Re: publish coho to npm

There's definitely some upside, but some downsides as well: - would add some overhead for us to have to remember to version & publish it after every change - you then need to npm update coho separately from updating all your other repos (via coho repo-update) - coho currently puts all repos as sibl

Re: wip on cordova-lib? pls let us know

On Fri, Jun 6, 2014 at 12:37 PM, Brian LeRoux wrote: > Ya I spoke to Issac a bit about this last week and he wasn't being entirely > facetious. One path that apparently works well is to treat root > `./node_modules` as something npm manages and then nested node_modules for > userspace stuff. > >

publish coho to npm

I don't see why not. Its pretty damn good now and would only help onboard more contributors.

Re: [Android] 4.0.x plugin fixes

Yes, 3.5 is out. http://cordova.apache.org/announcements/2014/05/23/cordova-350.html On Jun 6, 2014, at 12:40 PM, Joe Bowser wrote: > Can't we ease in the methods and deprecate in 3.6??? > > BTW: Is 3.5 out yet? I voted on the thread for the Android platform.

Re: [Android] 4.0.x plugin fixes

Can't we ease in the methods and deprecate in 3.6??? BTW: Is 3.5 out yet? I voted on the thread for the Android platform. On Fri, Jun 6, 2014 at 9:09 AM, Andrew Grieve wrote: > I like the reflection idea since that will let us avoid branching & make > the plugins work with both 3.x and 4.x. Othe

Re: wip on cordova-lib? pls let us know

Ya I spoke to Issac a bit about this last week and he wasn't being entirely facetious. One path that apparently works well is to treat root `./node_modules` as something npm manages and then nested node_modules for userspace stuff. eg. `./src/node_modules` and then `var foo = require('src/foo')`

doubt regarding adding new platforms

We are through with steps from 1-4 mentioned here : http://wiki.apache.org/cordova/AddingNewPlatforms and our almost done with integration with cordova-js : https://github.com/apache/cordova-js#adding-a-new-platform Just need to run the mobile spec test : https://github.com/apache/cordova-mobile-

Coho updates

Spent some time on it yesterday & today. Highlights: - Much faster start-up on node 0.10 (made some requires lazy) - Much faster repo-clone and repo-update commands (made network work concurrent) - Clearer output for repo-status command (prints nothing for no changes, prints unpushed changes & unco

Re: wip on cordova-lib? pls let us know

Exciting! I tried the "check in node_modules" approach in cordova-app-harness and it works really well there: https://github.com/apache/cordova-app-harness/tree/master/harness-push It's a simpler case since there's a strict parent/child relationship. The main unknown for me is how to make CordovaE

Re: [Android] 4.0.x plugin fixes

I like the reflection idea since that will let us avoid branching & make the plugins work with both 3.x and 4.x. Others will hit the same problem, but likely others will want a way to target both versions as the solution. On Fri, Jun 6, 2014 at 10:51 AM, Ian Clelland wrote: > This has been bugg

Re: [VOTE] Plugins Release

I don't see the tag for inappbrowser. Forgot to push it? On Fri, Jun 6, 2014 at 10:46 AM, Marcel Kinard wrote: > Steve, to clarify, a single vote is for all the plugins listed below, > correct? > > On Jun 5, 2014, at 5:44 PM, Steven Gill wrote: > > > Please review and vote on the release of th

Re: wip on cordova-lib? pls let us know

Brian: sounds good. Looking forward to see where we get. -Michal On Fri, Jun 6, 2014 at 11:36 AM, Brian LeRoux wrote: > @Michal: we're going to start extracting things to their own modules. (As > discussed.) We're going to start small and simple: CordovaError, > SuperSpawn, etc. But before we

Re: wip on cordova-lib? pls let us know

@axe: ok. keep an eye on the PR's getting merged and make sure you guys are rebasing and we should be ok On Thu, Jun 5, 2014 at 11:52 PM, Parashuram Narasimhan (MS OPEN TECH) < panar...@microsoft.com> wrote: > We are prototyping the Windows Universal apps on this repo. > > -Original Message-

Re: wip on cordova-lib? pls let us know

@Michal: we're going to start extracting things to their own modules. (As discussed.) We're going to start small and simple: CordovaError, SuperSpawn, etc. But before we do that we'll try to merge up as many PRs as possible. Ideally there are none when we get rolling. (Next week.) Many repos (or j

Re: android commit: Remove Ant custom build directories

Thanks, Marcel. I'll take care of that one too On Friday, June 6, 2014, Marcel Kinard wrote: > Ian, there is also this doc that may need to be mostly reverted: > > > https://github.com/apache/cordova-docs/commit/d520506be5068ae290a4209401305815548487f3 > > Begin forwarded message: > > > From: i.

Fwd: android commit: Remove Ant custom build directories

Ian, there is also this doc that may need to be mostly reverted: https://github.com/apache/cordova-docs/commit/d520506be5068ae290a4209401305815548487f3 Begin forwarded message: > From: i...@apache.org > Subject: android commit: Remove Ant custom build directories > Date: June 6, 2014 at 10:45:44

Re: Ant/Crosswalk woes

Perhaps this is an oversimplification, but if the choice is between simple/clean/slow versus complex/fragile/fast, I’d prefer the former.

Re: [Android] 4.0.x plugin fixes

This has been bugging me for a bit now. We definitely need a branch for development on the plugins. (FTR, there's a pluggable_webview branch on file, file-transfer and media-capture already, with this particular fix. We can rename that) We're going to have trouble releasing these plugins when we r

Re: [VOTE] Plugins Release

Steve, to clarify, a single vote is for all the plugins listed below, correct? On Jun 5, 2014, at 5:44 PM, Steven Gill wrote: > Please review and vote on the release of this plugins release. > > Release issue: https://issues.apache.org/jira/browse/CB-6877 > > The plugins have been published to

[GitHub] cordova-lib pull request: Refer properties-parser package from NPM

Github user mbektchiev commented on the pull request: https://github.com/apache/cordova-lib/pull/24#issuecomment-45342579 :) Thank you, Mark. Then maybe the build script should be made to completely remove **node_modules** before running `npm install`. This should detect errors wi

[GitHub] cordova-lib pull request: Refer properties-parser package from NPM

Github user kamrik commented on the pull request: https://github.com/apache/cordova-lib/pull/24#issuecomment-45342017 Thanks. Merged that pull request. Just re-running the tests didn't catch it, even our BuildBot didn't catch it. I guess this is because npm install didn't over

[GitHub] cordova-lib pull request: Fix android unit tests to no...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/25 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [Android] 4.0.x plugin fixes

That is my first thought as well. Perhaps name the plugin branch something like “android-4.0”? On Jun 5, 2014, at 5:38 PM, Steven Gill wrote: > 4.0 branch for the plugins? > > > On Thu, Jun 5, 2014 at 2:33 PM, Joe Bowser wrote: > >> Hey >> >> So, since we're wanting to introduce new APIs,

[GitHub] cordova-windows pull request: CB 6728 Support chip architecture as...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-windows/pull/33 CB 6728 Support chip architecture as an option when building Windows projects Adds support for target architectures to build command Implementation for [CB-6728](https://issues.

[GitHub] cordova-wp8 pull request: CB-6728 Support chip architecture as an ...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-wp8/pull/39 CB-6728 Support chip architecture as an option when building Windows Phone projects Adds support for target architectures to build command You can merge this pull request into a Git re

[GitHub] cordova-plugin-device-motion pull request: CB-4967 [FFOS docs] sup...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-motion/pull/8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-device-motion pull request: CB-6888 Polish translat...

GitHub user zalun opened a pull request: https://github.com/apache/cordova-plugin-device-motion/pull/13 CB-6888 Polish translation fixed * and _ fixed automatic translation issues You can merge this pull request into a Git repository by running: $ git pull https://github.co

[GitHub] cordova-firefoxos pull request: Cleanup templates www folder

Github user zalun commented on the pull request: https://github.com/apache/cordova-firefoxos/pull/11#issuecomment-45317175 Wow, that's interesting! r+ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] cordova-cli pull request: CB-2606 add icon support

Github user rohitagg28 commented on the pull request: https://github.com/apache/cordova-cli/pull/126#issuecomment-45308768 Thanks. The problem get solved by using the updated version. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu