Re: Monthly Cordova hangouts

2014-07-18 Thread Jesse
+1 @purplecabbage risingj.com On Thu, Jul 17, 2014 at 10:56 PM, tommy-carlos williams to...@devgeeks.org wrote: +1 On 18 July 2014 at 14:00:59, Marcel Kinard (cmarc...@gmail.com) wrote: So is the consensus 1pm PDT / 4pm EDT on Friday July 25? On Jul 16, 2014, at 6:04 PM, Tommy Williams

Re: Change background color of Android Cordova app

2014-07-18 Thread Jan Velecký
It's so simple reproduce this even without opacity. Simply make new Android Cordova project. Add this to css to make clear that css doesn't play any role here: * {     background-color: black !important } Then infest body with HTML code from http://html-ipsum.com/ and ideally form code.

Re: Monthly Cordova hangouts

2014-07-18 Thread Mike Billau
If there are people on the view-only link that have stuff to say, there is always IRC that I think a bunch of us monitor during the hangouts. On Fri, Jul 18, 2014 at 1:59 AM, Jesse purplecabb...@gmail.com wrote: +1 @purplecabbage risingj.com On Thu, Jul 17, 2014 at 10:56 PM, tommy-carlos

Re: Monthly Cordova hangouts

2014-07-18 Thread Ian Clelland
Yes, and I think that's what Michal wanted to set up the Hangouts QA feature for, as well -- not for an actual QA session, but to allow everyone to participate, even if they can't stream their video. On Fri, Jul 18, 2014 at 8:58 AM, Mike Billau mike.bil...@gmail.com wrote: If there are people

Re: Change background color of Android Cordova app

2014-07-18 Thread Joe Bowser
So, where's your repro steps? Also, where's the basic info, like which device you used to reproduce it. Which version of Android? https://issues.apache.org/jira/browse/CB-7159 Also, if this is really just a few hundreds of a millisecond, and this is only on your device, which we don't have, this

Re: Monthly Cordova hangouts

2014-07-18 Thread Joe Bowser
What's the purpose of the hangout? If it's to allow our users to ask questions, etc, that's fine. If it's to actually discuss planning decisions to be made on the list, that's fine as well. However, I don't think we have time to do both, and I can see us dropping QA really quickly. On Fri,

Re: Change background color of Android Cordova app

2014-07-18 Thread Joe Bowser
BTW: I don't know exactly which device you have, since all I really have is a photo of it. I don't have any modern Android phones with keyboards, nor am I even aware of a modern Android phone with a keyboard other than the Desire Z and some weird Samsung Galaxy model on T-Mobile. These usually

[GitHub] cordova-blackberry pull request: Fixed issue: --buildId will disna...

2014-07-18 Thread jkeshavarzi
Github user jkeshavarzi commented on a diff in the pull request: https://github.com/apache/cordova-blackberry/pull/169#discussion_r15113856 --- Diff: bin/templates/project/cordova/lib/build.js --- @@ -108,8 +110,15 @@ try { bbwpArgv.push(-d);

[GitHub] cordova-blackberry pull request: Fixed issue: --buildId will disna...

2014-07-18 Thread jkeshavarzi
Github user jkeshavarzi commented on a diff in the pull request: https://github.com/apache/cordova-blackberry/pull/169#discussion_r15113926 --- Diff: bin/templates/project/cordova/lib/build.js --- @@ -81,10 +74,16 @@ try { keystorepass =

[GitHub] cordova-blackberry pull request: Fixed issue: --buildId will disna...

2014-07-18 Thread jkeshavarzi
Github user jkeshavarzi commented on a diff in the pull request: https://github.com/apache/cordova-blackberry/pull/169#discussion_r15114139 --- Diff: bin/templates/project/cordova/lib/build.js --- @@ -81,10 +74,16 @@ try { keystorepass =

[GitHub] cordova-ios pull request: Fix __PROECT_NAME__ replacing code

2014-07-18 Thread lapo-luchini
GitHub user lapo-luchini opened a pull request: https://github.com/apache/cordova-ios/pull/100 Fix __PROECT_NAME__ replacing code `` is a special character for `sed` and this fixes the problem of having `__PROJECT_NAME__` in the final output when the project name contains an

[GitHub] cordova-blackberry pull request: Fixed issue: --buildId will disna...

2014-07-18 Thread jkeshavarzi
Github user jkeshavarzi commented on a diff in the pull request: https://github.com/apache/cordova-blackberry/pull/169#discussion_r15114357 --- Diff: bin/templates/project/cordova/lib/cmdline.js --- @@ -20,7 +20,7 @@ var command = require(commander), command

[GitHub] cordova-blackberry pull request: Fixed issue: --buildId will disna...

2014-07-18 Thread jkeshavarzi
Github user jkeshavarzi commented on a diff in the pull request: https://github.com/apache/cordova-blackberry/pull/169#discussion_r15114473 --- Diff: bin/templates/project/cordova/lib/cmdline.js --- @@ -30,7 +30,8 @@ command .option('-p, --params params JSON file',

Re: Monthly Cordova hangouts

2014-07-18 Thread Marcel Kinard
OK, I’ve updated the wiki. Everyone add this to your calendar, and take a look at the agenda. I assume that just before the meeting, links will be posted for the read/write stream (10 slots) and the read-only stream (unlimited slots). On Jul 18, 2014, at 1:56 AM, tommy-carlos williams

[GitHub] cordova-blackberry pull request: Fixed issue: --buildId will disna...

2014-07-18 Thread jkeshavarzi
Github user jkeshavarzi commented on a diff in the pull request: https://github.com/apache/cordova-blackberry/pull/169#discussion_r15114609 --- Diff: bin/templates/project/cordova/lib/localize.js --- @@ -29,10 +29,10 @@ var Localize = require(localize), en: Build

[GitHub] cordova-blackberry pull request: Fixed issue: --buildId will disna...

2014-07-18 Thread jkeshavarzi
Github user jkeshavarzi commented on a diff in the pull request: https://github.com/apache/cordova-blackberry/pull/169#discussion_r15115130 --- Diff: bin/templates/project/cordova/lib/session.js --- @@ -58,6 +58,7 @@ module.exports = { signerParams =

[GitHub] cordova-wp8 pull request: Attempted to cleanup readme for a noob

2014-07-18 Thread chaffeqa
Github user chaffeqa commented on the pull request: https://github.com/apache/cordova-wp8/pull/13#issuecomment-49440313 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-plugin-file-transfer pull request: CB-6961 port file-trans...

2014-07-18 Thread stacic
GitHub user stacic opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/35 CB-6961 port file-transfer tests to framework Automated and manual tests ported You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-network-information pull request: [CB-7166] Fix nav...

2014-07-18 Thread BBosman
GitHub user BBosman opened a pull request: https://github.com/apache/cordova-plugin-network-information/pull/13 [CB-7166] Fix naviagtor typo There is a typo in one of the comments. naviagtor should be navigator. You can merge this pull request into a Git repository by running:

Re: Monthly Cordova hangouts

2014-07-18 Thread Michal Mocny
Joe, QA was just an experiment. I'm doubtful we'll get activity on it, but if it becomes a distraction we will drop it. The purpose of the meeting is for commiters to get face time and to make progress on work which usually happens on these lists -- not to answer cordova user questions. -Michal

Re: [Discuss] The Future of Ripple as a Top Level ASF Project

2014-07-18 Thread Gorkem Ercan
Did this discussion concluded? What was the conclusion? I would like to see Ripple to have a healthy future and if having it as a sub-project on Cordova ensures it, I would like to help with that. I think we can have one or two people from Red Hat assisting on the maintenance of Ripple. This

Re: Change background color of Android Cordova app

2014-07-18 Thread Jan Velecký
Okay, okay, I just have done more testing. It occurs on Xperia X10 mini pro running Android 2.3 and Xperia mini pro running 4.0 (both better devices than Samsung and HTC you mentioned). But it don't relate with fact, that these are qwerty devices – I tested it alson on emulators and 4.0

Re: Change background color of Android Cordova app

2014-07-18 Thread Joe Bowser
So, you only tested on Sony devices. That's a way smaller percentage than even ICS. Last time I checked, it was around 1%. You should test on more than one manufacturer's device. While you may not like Samsung, the fact is that they are ridiculously common devices and should be tested before

Re: Change background color of Android Cordova app

2014-07-18 Thread Jan Velecký
From when is Android emulator Sony device?!? You downplay every bug, you are interested in... - So, you only tested on Sony devices. That's a way smaller percentage than even ICS. Last time I checked, it was around 1%. You should test on

[GitHub] cordova-plugin-file pull request: [BlackBerry10] Add file system p...

2014-07-18 Thread bryanhiggins
GitHub user bryanhiggins opened a pull request: https://github.com/apache/cordova-plugin-file/pull/63 [BlackBerry10] Add file system paths fix tests cc @jengee @jsoref 1f21e3b3 should be tested on Android 2.3 before merging You can merge this pull request into a Git

Re: Change background color of Android Cordova app

2014-07-18 Thread Joe Bowser
What makes you think I'm interested in this bug? On Fri, Jul 18, 2014 at 9:52 AM, Jan Velecký vve...@seznam.cz wrote: From when is Android emulator Sony device?!? You downplay every bug, you are interested in... - So, you only tested on

Quick File plugin test on Android 2.3 needed

2014-07-18 Thread Bryan Higgins
It would be great if someone with a Gingerbread device could run the cdvtests for my pull request. [1] On BB10 Blobs are BlobConstructor objects. With the previous check, the test failed as unsupported even though it does pass when allowed to run [2] I'd feel better knowing this still works

Re: Change background color of Android Cordova app

2014-07-18 Thread Jan Velecký
Your effort to make Android Cordova looks without bug... Cannon reproduce, not a problem, won't fix... - What makes you think I'm interested in this bug? On Fri, Jul 18, 2014 at 9:52 AM, Jan Velecký vve...@seznam.cz wrote: From when is Android

Re: Change background color of Android Cordova app

2014-07-18 Thread Joe Bowser
You're more than welcome to submit a patch, since you clearly know what the problem is. On Fri, Jul 18, 2014 at 10:30 AM, Jan Velecký vve...@seznam.cz wrote: Your effort to make Android Cordova looks without bug... Cannon reproduce, not a problem, won't fix...

[GitHub] cordova-plugin-network-information pull request: CB-6964 port netw...

2014-07-18 Thread stacic
GitHub user stacic opened a pull request: https://github.com/apache/cordova-plugin-network-information/pull/14 CB-6964 port network-information tests to plugin-test-framework You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-dialogs pull request: CB-6965 ported notification t...

2014-07-18 Thread stacic
GitHub user stacic opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/23 CB-6965 ported notification tests to plugin-test-framework You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-geolocation pull request: CB-7146 ported geolocatio...

2014-07-18 Thread stacic
GitHub user stacic opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/19 CB-7146 ported geolocation tests to plugin-test-framework Added manual tests and removed js-module from plugin.xml. Can someone please merge this into cdvtest and then merge

Re: Add build status to github

2014-07-18 Thread Mark Koudritsky
The test failure on Travis is in plugman/install spec. It seems to only happen with a fresh checkout, once you run the test second time, it works ok. I was bitten by this before. Maybe something with bad management of temp dirs. I'll investigate. For now just removing that spec file fixes the

Re: Add build status to github

2014-07-18 Thread Jesse
awesome! Has anyone created an INFRA ticket for adding the github service hooks? @purplecabbage risingj.com On Fri, Jul 18, 2014 at 11:36 AM, Mark Koudritsky kam...@google.com wrote: The test failure on Travis is in plugman/install spec. It seems to only happen with a fresh checkout, once

[GitHub] cordova-plugin-contacts pull request: CB-7148 Ported contacts test...

2014-07-18 Thread stacic
GitHub user stacic opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/33 CB-7148 Ported contacts tests to plugin-test-framework Removed js-module from plugin.xml and added manual tests. Can someone please merge this into cdvtest and then merge cdvtest

Re: Add build status to github

2014-07-18 Thread Mark Koudritsky
I didn't. I guess we also need to provide the INFRA people with some short instructions on how to enable this on the AppVeyor site. On Fri, Jul 18, 2014 at 2:48 PM, Jesse purplecabb...@gmail.com wrote: awesome! Has anyone created an INFRA ticket for adding the github service hooks?

[GitHub] cordova-plugin-network-information pull request: CB-6964. Port net...

2014-07-18 Thread javierbb31
Github user javierbb31 closed the pull request at: https://github.com/apache/cordova-plugin-network-information/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-plugin-media-capture pull request: CB-6959 ported capture ...

2014-07-18 Thread stacic
GitHub user stacic opened a pull request: https://github.com/apache/cordova-plugin-media-capture/pull/22 CB-6959 ported capture tests to plugin-test-framework You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-blackberry pull request: Fixed issue: --buildId will disna...

2014-07-18 Thread dylin
Github user dylin commented on a diff in the pull request: https://github.com/apache/cordova-blackberry/pull/169#discussion_r15130287 --- Diff: bin/templates/project/cordova/lib/build.js --- @@ -81,10 +74,16 @@ try { keystorepass =

[GitHub] cordova-blackberry pull request: Fixed issue: --buildId will disna...

2014-07-18 Thread dylin
Github user dylin commented on a diff in the pull request: https://github.com/apache/cordova-blackberry/pull/169#discussion_r15130863 --- Diff: bin/templates/project/cordova/lib/build.js --- @@ -81,10 +74,16 @@ try { keystorepass =

Re: Proposal: hooks support for plugins

2014-07-18 Thread Andrew Grieve
Finally got to having a look. Lots of neat stuff in there! Some specific feedback: - Not a fan of script, hook might be better - context.commonModules is a great idea, but I don't think exposing requireCordovaModule or elementtree is a good idea. - E.g. what if we want to drop our dependency on

[GitHub] cordova-lib pull request: CB-7132: fix regression regarding defaul...

2014-07-18 Thread VVelda
Github user VVelda commented on the pull request: https://github.com/apache/cordova-lib/pull/58#issuecomment-49475950 Now it works good with icons. But I have one question, you plain that your changes removes splashcreen from project, if in config.xml is blank splash / tag, don't

Re: Proposal: hooks support for plugins

2014-07-18 Thread Michal Mocny
What about prompting during plugin install instead of prepare? This plugin has hooks, would you like continue? Y/N I'm concerned about being prompted on each prepare, especially in the face of --watch type scripts. I'm also not sure that plugin authors should worry about supporting the no use

[GitHub] cordova-blackberry pull request: Fixed issue: --buildId will disna...

2014-07-18 Thread jkeshavarzi
Github user jkeshavarzi commented on a diff in the pull request: https://github.com/apache/cordova-blackberry/pull/169#discussion_r15132995 --- Diff: bin/templates/project/cordova/lib/build.js --- @@ -81,9 +81,13 @@ try { keystorepass =

[GitHub] cordova-blackberry pull request: Fixed issue: --buildId will disna...

2014-07-18 Thread jkeshavarzi
Github user jkeshavarzi commented on a diff in the pull request: https://github.com/apache/cordova-blackberry/pull/169#discussion_r15133006 --- Diff: bin/templates/project/cordova/lib/build.js --- @@ -97,6 +101,9 @@ try { } else {

Re: Proposal: hooks support for plugins

2014-07-18 Thread Jesse
Prompting would make it nearly impossible for third party tools to use, there is no one to accept. PGBuild will allow scripts, but they will only be for pre-verified plugins, just like they deal with compiling arbitrary native code ... the script-exec is NOT a new backdoor in this case, just

Re: [GitHub] cordova-lib pull request: CB-7132: fix regression regarding defaul...

2014-07-18 Thread Axel Nennker
What do you mean with blank splash? Splash without src? If yes then I consider this illegal anyway. I tested these cases on Android: - no splash in config.xml - one default splash. No density. - all densities that exist in project. - one density (xhdpi) All worked. Axel PS: I am traveling and

[GitHub] cordova-plugin-media pull request: CB-6963 Port Media manual aut...

2014-07-18 Thread martincgg
GitHub user martincgg opened a pull request: https://github.com/apache/cordova-plugin-media/pull/21 CB-6963 Port Media manual automated tests for plugin-test-framework Ported 17 Media automated manual tests from mobilespec. This commit adds the work done by javierbb31

Re: Proposal: hooks support for plugins

2014-07-18 Thread Shazron
Echoing what Jesse said - having a prompt will defeat tools, especially since early on we kinda had consensus not to add in a security layer. The middle way is to add a CLI option to auto-accept all prompts with Y, kinda like a lot of command line tools. I think there is this pattern in Windows

[GitHub] cordova-lib pull request: Breaking src into submodules

2014-07-18 Thread surajpindoria
GitHub user surajpindoria opened a pull request: https://github.com/apache/cordova-lib/pull/62 Breaking src into submodules Split up src/cordova and src/plugman into submodules based on functionality You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-ios pull request: Fix __PROJECT_NAME__ replacing code

2014-07-18 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/100#issuecomment-49486359 Created [CB-7169](https://issues.apache.org/jira/browse/CB-7169) --- If your project is set up for it, you can reply to this email and have your reply appear on

Re: Cordova-lib Submodules

2014-07-18 Thread Suraj Pindoria
And I just got reminded that I haven't introduced myself before on this mailing list.  I'm Suraj and am working for the PhoneGap/Cordova team at Adobe for the summer.  Also, here is a link to the pull request. https://github.com/apache/cordova-lib/pull/62 Suraj. On Friday, July 18, 2014

[GitHub] cordova-lib pull request: Breaking src into submodules

2014-07-18 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/62#issuecomment-49488330 Thanks Suraj! I am a little worried about the impact on several outstanding pull-requests. This is a pretty big change, and will definitely cause merge