[GitHub] cordova-plugin-contacts pull request: Removed [optional] tag from ...

2014-08-01 Thread SebastianMH
GitHub user SebastianMH opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/37 Removed [optional] tag from contactFindOptions. Fixes #CB-7247 https://issues.apache.org/jira/browse/CB-7247 The parameter contactFindOptions of navigator.contacts.find is

[GitHub] cordova-wp8 pull request: CB-6728 Support chip architecture as an ...

2014-08-01 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-wp8/pull/39#issuecomment-50854468 Hi @purplecabbage . I can't repro your issue with cordova-wp8 checked to this commit and latest cordova-cli/lib. Anyway, i've tried to change app version in

[GitHub] cordova-plugin-vibration pull request: CB-6966 Ported Vibration au...

2014-08-01 Thread martincgg
GitHub user martincgg opened a pull request: https://github.com/apache/cordova-plugin-vibration/pull/19 CB-6966 Ported Vibration automated manual tests Ported tests from Mobilespec. Jasmine version: ported from v1.3 to v2.0 You can merge this pull request into a Git repository

[GitHub] cordova-plugin-battery-status pull request: CB-6957 Style improvem...

2014-08-01 Thread martincgg
GitHub user martincgg opened a pull request: https://github.com/apache/cordova-plugin-battery-status/pull/15 CB-6957 Style improvements on Manual tests Usage of info, which is wired a css class, aimed to only show results. Reorganization of titles and tables. Just

[GitHub] cordova-mobile-spec pull request: CB-6963 Removed old media tests

2014-08-01 Thread martincgg
GitHub user martincgg opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/85 CB-6963 Removed old media tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/martincgg/cordova-mobile-spec CB-6963

[GitHub] cordova-plugin-media pull request: CB-6963 Port Media manual aut...

2014-08-01 Thread martincgg
Github user martincgg commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/21#issuecomment-50857321 Removed old media tests: https://github.com/apache/cordova-mobile-spec/pull/85 --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-mobile-spec pull request: CB-7094 Removed old file tests

2014-08-01 Thread martincgg
GitHub user martincgg opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/86 CB-7094 Removed old file tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/martincgg/cordova-mobile-spec CB-7094

[GitHub] cordova-plugin-file pull request: CB-7094 Ported File manual tests

2014-08-01 Thread martincgg
Github user martincgg commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/62#issuecomment-50857437 Removed old file tests https://github.com/apache/cordova-mobile-spec/pull/86 --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-mobile-spec pull request: CB-6957 Removed old battery-stat...

2014-08-01 Thread martincgg
GitHub user martincgg opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/87 CB-6957 Removed old battery-status tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/martincgg/cordova-mobile-spec CB-6957

[GitHub] cordova-plugin-battery-status pull request: CB-6957 Style improvem...

2014-08-01 Thread martincgg
Github user martincgg commented on the pull request: https://github.com/apache/cordova-plugin-battery-status/pull/15#issuecomment-50857488 Removed old battery-status tests https://github.com/apache/cordova-mobile-spec/pull/87 --- If your project is set up for it, you can reply

[GitHub] cordova-plugin-vibration pull request: CB-6966 Ported Vibration au...

2014-08-01 Thread martincgg
Github user martincgg commented on the pull request: https://github.com/apache/cordova-plugin-vibration/pull/19#issuecomment-50857537 https://github.com/apache/cordova-mobile-spec/pull/88 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-mobile-spec pull request: CB-6966 Removed old vibration te...

2014-08-01 Thread martincgg
GitHub user martincgg opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/88 CB-6966 Removed old vibration tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/martincgg/cordova-mobile-spec CB-6966

Re: plugin-test-framework PRs

2014-08-01 Thread Martin Gonzalez
Hey Michal, I've followed up your instructions to easily integrate the test along with plugin-test-framework, as you can see I have spammed a little bit the dev list with PRs, anyway here's the list of PRs, that includes File, Media, Battery-Status and Vibration:

[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...

2014-08-01 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-lib/pull/55#issuecomment-50883550 Addressed @kamrik code review notes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: [DISCUSS] Plugins Release

2014-08-01 Thread Bryan Higgins
Thanks Steve. I've done this, but RAT doesn't recognize zlib/libpng even though it has been approved by Apache legal. http://www.apache.org/legal/resolved.html On Thu, Jul 31, 2014 at 7:18 PM, Steven Gill stevengil...@gmail.com wrote: So Globalization has issues with missing headers and

[GitHub] cordova-plugin-contacts pull request: Removed [optional] tag from ...

2014-08-01 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/37#issuecomment-50886099 Hey Sebastian, I think missing contactFindOptions means return all contacts and is correctly handled on some platforms. Is there specific platform which

Re: Cordova Hangout August 19

2014-08-01 Thread Marcel Kinard
Added to wiki, with a placeholder agenda. Set your calendars, and we'll see you then. http://wiki.apache.org/cordova/Google%20Hangout%20Discussion%20Notes On Jul 28, 2014, at 7:26 PM, tommy-carlos williams to...@devgeeks.org wrote: On Mon, Jul 28, 2014 at 12:37 PM, Marcel Kinard

PTO notices for August

2014-08-01 Thread Joe Bowser
Hey I'll be on PTO starting on Monday, August 4, 2014. I'll be back on August 12, 2014. I'm also going to be out of the office from Aug 20nd to Sept 3 as well. I'll probably have internet, but I probably won't be able to respond with anything more meaningful than +1, -1 and DON'T DO THAT at

Re: plugin-test-framework PRs

2014-08-01 Thread Staci Cooper
I've noticed some problems I'd like to bring up. 1) https://github.com/apache/cordova-mobile-spec/blob/master/www/index.html#L44 This line breaks on windows phone when the query property is used. 2) My pull requests include the manual tests for contacts, device-motion, and geolocation on top of

Re: remotely loaded pages

2014-08-01 Thread Victor Sosa
Hello Marcel. Interesting scenario here. I'm not an expert on this topic, but loading remote web artifacts that have native access looks very insecure to me. Whether it is possible? Yeah, maybe... But is it advisable and, more important, recommended by the Cordova experts community? I'd like to

Re: plugin-test-framework PRs

2014-08-01 Thread Michal Mocny
On Fri, Aug 1, 2014 at 1:19 PM, Staci Cooper staci@gmail.com wrote: I've noticed some problems I'd like to bring up. 1) https://github.com/apache/cordova-mobile-spec/blob/master/www/index.html#L44 This line breaks on windows phone when the query property is used. 1. was a recent

Re: remotely loaded pages

2014-08-01 Thread Shazron
I agree that it is not recommended, but it's possible. I delved into this question here: https://github.com/shazron/phonegap-questions/issues/37 The PhoneGap Developer App is an example of how this is working at http://app.phonegap.com but they do some proxying to get around the CORS limitations

[GitHub] cordova-firefoxos pull request: Discover b2g ports

2014-08-01 Thread nicola
GitHub user nicola opened a pull request: https://github.com/apache/cordova-firefoxos/pull/20 Discover b2g ports This should be an helper library that should contain functions to find the port of an existing b2g simulator (Firefox OS simulator) and eventually functions to start a

[GitHub] cordova-firefoxos pull request: Discover b2g ports

2014-08-01 Thread nicola
Github user nicola commented on the pull request: https://github.com/apache/cordova-firefoxos/pull/20#issuecomment-50915757 Sorry for the redundancy in code. I could compress that all, but I was expecting two different behaviors on two different machines. Keep me posted. --- If your

[GitHub] cordova-firefoxos pull request: Discover b2g ports

2014-08-01 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-firefoxos/pull/20#discussion_r15709986 --- Diff: bin/lib/b2g.js --- @@ -0,0 +1,74 @@ +#!/usr/bin/env node + +/* +Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-firefoxos pull request: Discover b2g ports

2014-08-01 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-firefoxos/pull/20#discussion_r1570 --- Diff: bin/lib/b2g.js --- @@ -0,0 +1,74 @@ +#!/usr/bin/env node + +/* +Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-firefoxos pull request: Discover b2g ports

2014-08-01 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-firefoxos/pull/20#discussion_r15710033 --- Diff: bin/lib/b2g.js --- @@ -0,0 +1,74 @@ +#!/usr/bin/env node + +/* +Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-plugin-inappbrowser pull request: CB-7133 port inappbrowse...

2014-08-01 Thread stacic
GitHub user stacic opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/55 CB-7133 port inappbrowser to plugin-test-framework You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-firefoxos pull request: Discover b2g ports

2014-08-01 Thread nicola
Github user nicola commented on a diff in the pull request: https://github.com/apache/cordova-firefoxos/pull/20#discussion_r15710411 --- Diff: bin/lib/b2g.js --- @@ -0,0 +1,74 @@ +#!/usr/bin/env node + +/* +Licensed to the Apache Software Foundation (ASF) under one

Re: [DISCUSS] Plugins Release

2014-08-01 Thread Bryan Higgins
Thanks Shaz! I couldn't find any other use of .ratignore in Cordova and coho isn't configured to look for one. Adding a ratExcludes section for plugin-globalization to cordova-coho/src/repoutil.js did the trick. On Fri, Aug 1, 2014 at 1:31 PM, Shazron shaz...@gmail.com wrote: You can add a

Re: Experimenting with JSCS + JSHint in cordova-lib

2014-08-01 Thread Steven Gill
I personally am a little hesitant to have to follow a certain coding style + am worried about outside contributors struggling with it. On the other hand, it would be nice for code readability to have uniform/consistent style. As long as we discuss what styles we want to use beforehand, I am open

Re: [DISCUSS] Plugins Release

2014-08-01 Thread Shazron
Oops yeah it's actually called .ratExcludes :P On Fri, Aug 1, 2014 at 11:16 AM, Bryan Higgins br...@bryanhiggins.net wrote: Thanks Shaz! I couldn't find any other use of .ratignore in Cordova and coho isn't configured to look for one. Adding a ratExcludes section for plugin-globalization to

Re: Experimenting with JSCS + JSHint in cordova-lib

2014-08-01 Thread Mark Koudritsky
With and empty config file JSCS would emit no errors whatsoever. As more options are added, the more of a style JSCS enforces. Let's try it this way, I'll split the current config file into 3 sections and people comment whether they think it should be enforced: ## Part 1, the whitespace basics

Re: plugin-test-framework PRs

2014-08-01 Thread purplecabbage
Staci, why not just one pull request for all these changes? Sent from my iPhone On Aug 1, 2014, at 10:19 AM, Staci Cooper staci@gmail.com wrote: I've noticed some problems I'd like to bring up. 1) https://github.com/apache/cordova-mobile-spec/blob/master/www/index.html#L44 This line

Re: remotely loaded pages

2014-08-01 Thread purplecabbage
I agree with all your statements Marcel. I use this approach frequently in dev for fast turnaround. Ultimately App Store policies decide what can and cannot be done. Regarding security, there is nothing I can do with a remote page that I can't already do inside my app. It's an issue of trust.

Re: Experimenting with JSCS + JSHint in cordova-lib

2014-08-01 Thread Steven Gill
All three parts look good to me! On Fri, Aug 1, 2014 at 1:15 PM, Mark Koudritsky kam...@google.com wrote: With and empty config file JSCS would emit no errors whatsoever. As more options are added, the more of a style JSCS enforces. Let's try it this way, I'll split the current config file

[GitHub] cordova-firefoxos pull request: Discover b2g ports

2014-08-01 Thread nicola
Github user nicola commented on the pull request: https://github.com/apache/cordova-firefoxos/pull/20#issuecomment-50933496 Updated --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

Re: git commit: CB-7249cordova-plugin-statusbar documentation translation: cordova-plugin-statusbar

2014-08-01 Thread Marcel Kinard
Lisa, assuming this is being run by your scripts, in the commit message could you add a space after the CB number? Thanks! On Aug 1, 2014, at 4:24 PM, ldel...@apache.org wrote: Repository: cordova-plugin-statusbar Updated Branches: refs/heads/master ad834b573 - df64e5b15

[GitHub] cordova-plugin-contacts pull request: Removed [optional] tag from ...

2014-08-01 Thread lorinbeer
Github user lorinbeer commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/37#issuecomment-50936354 Hi @sgrebnov, omitting contactFindOptions results in a errorJSON return message on Android, and I believe was replicated on iOS. Documenting

Re: remotely loaded pages

2014-08-01 Thread Frederico Galvão
I don't have the details in hand at the moment, but I remember seeing in more than one application store last year policies being changed to disallow remote code to run in an application on-demand. Such rules *could* as well be applied to Cordova apps that load remote content considered as code

Re: remotely loaded pages

2014-08-01 Thread Shazron
Adobe PhoneGap Build Hydration is different however -- it downloads an app payload that is run locally (points to the new www folder contents), and is only meant for dev purposes, not for App Store release. On Fri, Aug 1, 2014 at 2:34 PM, Frederico Galvão frederico.gal...@pontoget.com.br wrote:

Re: remotely loaded pages

2014-08-01 Thread Victor Sosa
Hi Frederico. While what you are saying about the policies stores is true, this applies to public stores only (as far as I can tell). For on-premise app stores this might be false because each store owner need to set and apply the governance for the apps. It could end on horrible results due to a

Re: remotely loaded pages

2014-08-01 Thread Marc Weiner
It's technically possible, and even (arguably) legal according to Apple's documentation, depending on the nature of the code and how it's implemented: 3.3.2 An Application may not download or install executable code. Interpreted code may only be used in an Application if all scripts, code and

Re: Experimenting with JSCS + JSHint in cordova-lib

2014-08-01 Thread Terence M. Bandoian
Nicely done. Seems reasonable, well-organized and easy to understand. -Terence Bandoian On 8/1/2014 3:15 PM, Mark Koudritsky wrote: With and empty config file JSCS would emit no errors whatsoever. As more options are added, the more of a style JSCS enforces. Let's try it this way, I'll split

Re: Experimenting with JSCS + JSHint in cordova-lib

2014-08-01 Thread Michal Mocny
lgtm On Fri, Aug 1, 2014 at 4:42 PM, Steven Gill stevengil...@gmail.com wrote: All three parts look good to me! On Fri, Aug 1, 2014 at 1:15 PM, Mark Koudritsky kam...@google.com wrote: With and empty config file JSCS would emit no errors whatsoever. As more options are added, the more

[GitHub] cordova-plugin-splashscreen pull request: CB-7204 Fixed race condi...

2014-08-01 Thread joshbuchea
Github user joshbuchea commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-50948393 What's the behavior of the issue this is supposed to fix? I'm having issues with the plugin not honoring AutoHideSplashScreen in iOS 7.1

Re: remotely loaded pages

2014-08-01 Thread purplecabbage
It is great design for development, and netflix. Sent from my iPhone On Aug 1, 2014, at 4:26 PM, Marc Weiner mhweiner...@gmail.com wrote: It's technically possible, and even (arguably) legal according to Apple's documentation, depending on the nature of the code and how it's implemented:

Re: [GitHub] cordova-plugin-contacts pull request: Removed [optional] tag from ...

2014-08-01 Thread purplecabbage
We don't need an cla for a 1 line documentation fix. Ultimately this is a defect in the plugin, and should be fixed. Documenting the quirk helps in the meantime, until it is fixed for Android and ios. On Aug 1, 2014, at 2:22 PM, lorinbeer g...@git.apache.org wrote: Github user lorinbeer