[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...

2014-08-11 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/55#issuecomment-51868071 @sgrebnov How do I get the command line arguments out from Context? In none javascript interface this is located in CORDOVA_CMDLINE --- If your project is set

[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...

2014-08-11 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/55#issuecomment-51868008 Here is a gist of a Hook I'm working on for IBM https://gist.github.com/csantanapr/9fc45c76b4d9a2d5ef85 You can see how I'm using Context opts and requi

[GitHub] cordova-plugin-file pull request: CB-6923 [WP8] Adding support to ...

2014-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/65 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] cordova-plugin-file pull request: CB-6994 - Windows 8 does not sav...

2014-08-11 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/54#issuecomment-51863357 Is this still valid? It is almost impossible to tell what has changed with all the whitespace noise in FileProxy.js. If this is still valid, please r

Re: cordova.js and cordova.platformVersion

2014-08-11 Thread Steven Gill
So I have removed cordova.version and added cordova.platformVersion on the branch cb-7219 on my repo. Check it out at https://github.com/stevengill/cordova-js/tree/cb-7219. It adds the output from "git rev-list HEAD --max-count=1" at the top as a comment in cordova.js and creates a constant named "

[GitHub] cordova-plugin-file pull request: CB-7027 GetMetada fails on Windo...

2014-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/56 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] cordova-plugin-device pull request: [fxos] Remove cordova version

2014-08-11 Thread rodms10
GitHub user rodms10 opened a pull request: https://github.com/apache/cordova-plugin-device/pull/21 [fxos] Remove cordova version It's unused after [CB-5105](https://issues.apache.org/jira/browse/CB-5105). You can merge this pull request into a Git repository by running: $ git p

[GitHub] cordova-plugin-file pull request: CB-7284 Improve File plugin for ...

2014-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/67 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

Apache Cordova 3.5.1: CVE-2014-3502 update

2014-08-11 Thread Marcel Kinard
The following text is amended from the original that was sent on August 4th. More background information on this amendment can be found at http://cordova.apache.org/announcements/2014/08/06/android-351-update.html Android Platform Release: 04 Aug 2014 CVE-2014-3502: Cordova apps can potentially

[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...

2014-08-11 Thread kamrik
Github user kamrik commented on the pull request: https://github.com/apache/cordova-lib/pull/55#issuecomment-51841422 I think we should leave this decision to Sergey and the Microsoft guys. While it would be nice to have CordovaProject class right away, it might take quite some time a

[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...

2014-08-11 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/55#issuecomment-51840027 I mean land in terms of pushing to master for others to contribute, and when feature is ready document as public api/feature. --- If your project is set up for i

[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...

2014-08-11 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/55#issuecomment-51839887 So how do we move forward with plugin hooks? Do we land what we have here and then open a new JIRA to take care about cordovaProject object? --- If your

cordova stats

2014-08-11 Thread Lisa Seacat DeLuca
So I'm putting together some statistics on Apache Cordova and ended up writing a quick little script to basically do some calculations based on the gitstats project. I created a public repository on github with my bash script if anyone is interested in running it themselves: https://github.com

Re: [Announcement] Plugins release August 11, 2014

2014-08-11 Thread Ian Clelland
Whoo! Thanks, Steve! On Mon, Aug 11, 2014 at 2:48 PM, Steven Gill wrote: > Plugins have been released! > > http://cordova.apache.org/news/2014/08/11/plugins-release.html > > https://twitter.com/apachecordova/status/498903223571185664 >

[Announcement] Plugins release August 11, 2014

2014-08-11 Thread Steven Gill
Plugins have been released! http://cordova.apache.org/news/2014/08/11/plugins-release.html https://twitter.com/apachecordova/status/498903223571185664

Re: [VOTE] Plugins Release

2014-08-11 Thread Steven Gill
The vote has now closed. The results are: Positive Binding Votes: 4 Steve Gill Andrew Grieve Bryan Higgins Ian Clelland The vote has passed. On Fri, Aug 8, 2014 at 9:55 AM, Bryan Higgins wrote: > +1 > > - Confirmed signatures and hashes > - Verified sha1s against tags > - Ran mobile spec on

Re: Directory Structure - CLI directory config proposal

2014-08-11 Thread Brian LeRoux
I can see the value but have found configurable path look ups tend to be very fragile. (The more config the more variable paths create more opportunities for weird side effects.) I echo the sentiment that we need to be 100% certain this feature does not break existing (default) workflow. On Mon,

Re: Notification on lock screen

2014-08-11 Thread Jesse
Daniela, this feature does not exist, please create a feature request. https://issues.apache.org/jira/browse/CB/ @purplecabbage risingj.com On Mon, Aug 11, 2014 at 7:44 AM, julio cesar sanchez wrote: > This is a mail list for people who develop/contribute to cordova, not for > people who dev

Re: Directory Structure - CLI directory config proposal

2014-08-11 Thread Jesse
I see zero value in this feature, so I will simply ask that we please don't break any expectations that already exist. If this can be achieved without altering the current workflow then I will keep quiet. @purplecabbage risingj.com On Mon, Aug 11, 2014 at 10:13 AM, Carlos Santana wrote: > Yep

[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...

2014-08-11 Thread agrieve
Github user agrieve commented on the pull request: https://github.com/apache/cordova-lib/pull/55#issuecomment-51811935 +1 for the "or even" clause there. I'd like to be able to write: var cordovaProject = cordova_lib.loadProject(rootDir) cordovaProject.setVerbosity(

Re: [iOS] Using workspaces

2014-08-11 Thread Andrew Grieve
I don't see the harm in it, but would be interested to know what the wins are, and how much work it would be to accomplish. e.g. Does the CordovaLib project not currently work within an xcworkspace? Is the current integration as simple as deleting CordovaLib as a subproject and adding it as a chil

Re: Directory Structure - CLI directory config proposal

2014-08-11 Thread Carlos Santana
Yep I agree with using .cordova/config.json for this directory config. and it would be in 3.x should not wait for 4.x On Mon, Aug 11, 2014 at 1:07 PM, Michal Mocny wrote: > Lets not add a new public config file until we have many long talks to > figure out all the requirements for a future CLI

[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...

2014-08-11 Thread kamrik
Github user kamrik commented on the pull request: https://github.com/apache/cordova-lib/pull/55#issuecomment-51810029 Unfortunately utils.js knows nothing about the project, it re-reads all the info from file system on each call. This results in lots of cases of re-parsing of config f

Re: [Vote] Tools Release for Android 3.5.1

2014-08-11 Thread Ian Clelland
+1 * Verified archives, tags and hashes * Ran functional tests (it does, indeed, download and use cordova-android 3.5.1) We should put cordova-cli on a branch somewhere, but otherwise it's good. (That doesn't affect the archive or the release, as long as we do it soon enough that it doesn't get g

Re: Directory Structure - CLI directory config proposal

2014-08-11 Thread Michal Mocny
Lets not add a new public config file until we have many long talks to figure out all the requirements for a future CLI. Perhaps PGDay US will be a good opportunity to get together in person and hash out some ideas? And since I don't think we should block work like what is being discussed here, w

Re: [iOS] Using workspaces

2014-08-11 Thread Carlos Santana
Shaz I have being looking into CocoaPods as an alternative to package cordova. One use case that I have seeing recently among users is that they will start with a Native iOS App, then use Cocoapods to add functionality, from this point they deal with a single workspace and two sub projects, one fo

Re: [Vote] Tools Release for Android 3.5.1

2014-08-11 Thread Ian Clelland
Odd -- the commit isn't on any branch, and `git fetch` doesn't retrieve it (at least for me). A fresh clone will get the entire repository, though, with that commit. On Mon, Aug 11, 2014 at 11:42 AM, Marcel Kinard wrote: > Dohp! Indeed I forgot to push that tag. Let me know if it isn't now as

Re: Directory Structure - CLI directory config proposal

2014-08-11 Thread Carlos Santana
I like what Mark suggested of not passing json string in the command line, and better to pass a json file. Why are we talking about 4.0 release? This can be landed on 3.x unless I'm missing something very obvious. I would also would like to propose that we expose the hidden config.json as a plubli

[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...

2014-08-11 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/55#issuecomment-51805610 Yes I agree having a class, but still pass a single context to the hook and then the Context object contains a CordovaProject class object return by util.js I t

[iOS] Using workspaces

2014-08-11 Thread Shazron
https://issues.apache.org/jira/browse/CB-5921 Proposing for the 4.0 stream since it is potentially a breaking change for tools. It has other benefits (see the issue).

Re: [Vote] Tools Release for Android 3.5.1

2014-08-11 Thread Marcel Kinard
Dohp! Indeed I forgot to push that tag. Let me know if it isn't now as expected. On Aug 7, 2014, at 11:51 AM, Ian Clelland wrote: > Cordova-lib works for me, but I can't find that tag (or commit) in > cordova-cli. Did it get pushed to the Apache repo? > > On Wed, Aug 6, 2014 at 6:14 PM, Marcel

RE: Directory Structure - CLI directory config proposal

2014-08-11 Thread Parashuram Narasimhan (MS OPEN TECH)
Should we go ahead and create a branch in the main project so that you can also add your ideas to it? We could target this feature for a 4.0 release. -Original Message- From: Mark Koudritsky [mailto:kam...@google.com] Sent: Monday, August 11, 2014 7:56 AM To: dev@cordova.apache.org Subj

RE: [Discuss] 3.6.0 Release

2014-08-11 Thread Parashuram Narasimhan (MS OPEN TECH)
I think we should also finalize on the platform switches so that we all agree on a pattern (even if it is different across platforms). This way, we can release 3.6.0 with a set of switches, and ensure that it is backward compatible. -Original Message- From: iclell...@google.com [mailt

[GitHub] cordova-plugin-file pull request: CB-7284 Improve File plugin for ...

2014-08-11 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-file/pull/67 CB-7284 Improve File plugin for windows platform compatibility with current API specs Fixes multiple spec tests errors (CB-7284)[https://issues.apache.org/jira/browse/CB-7284]:

Re: [Discuss] 3.6.0 Release

2014-08-11 Thread Ian Clelland
I'll see about committing that today; I've had to reorganize it quite a bit after the Big Config Refactor. Joe, I'm pretty certain that your code is still in master, but definitely add those tests to make sure, and to make sure we don't regress. Ian On Mon, Aug 11, 2014 at 10:52 AM, Marcel Kina

Re: Directory Structure - CLI directory config proposal

2014-08-11 Thread Mark Koudritsky
I like the way it looks now, but I would argue that we need to take it another step further and make it a CordovaProject class that should only be instantiated once and contain all the info of ProjectMeta + most of the info passed around in the ad-hoc opts objects. I'm somewhat against passing JSO

Re: [Discuss] 3.6.0 Release

2014-08-11 Thread Marcel Kinard
I agree with Joe. On Aug 11, 2014, at 10:02 AM, Joe Bowser wrote: > Let's not release until the new whitelist is figured out. That feature is > too important.

Re: Notification on lock screen

2014-08-11 Thread julio cesar sanchez
This is a mail list for people who develop/contribute to cordova, not for people who develop apps using cordova. Ask on this group instead https://groups.google.com/forum/m/#!forum/phonegap

[GitHub] cordova-plugin-device pull request: adds new property 'manufacture...

2014-08-11 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/20#issuecomment-51784352 I've linked this to https://issues.apache.org/jira/browse/CB-7285 for discussion. I'd like to see WP, FireOS (all Amazon?) FFOS chime in on this as well.

Re: [Discuss] 3.6.0 Release

2014-08-11 Thread Joe Bowser
Let's not release until the new whitelist is figured out. That feature is too important. I also need to land the test to confirm my fix is still in master. Back from PTO tomorrow. On Aug 11, 2014 6:55 AM, "Mike Billau" wrote: > There was talk about adding the "internal whitelist" that Ian buil

[GitHub] cordova-android pull request: Update tests.java

2014-08-11 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-android/pull/112#issuecomment-51783715 Is this just noise? Please close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...

2014-08-11 Thread kamrik
Github user kamrik commented on the pull request: https://github.com/apache/cordova-lib/pull/55#issuecomment-51783588 Problems with opts objects arise all over the place in cordova-lib, I got bitten by similar problems several times. My proposal would be to create a CordovaProject cla

Re: [Discuss] 3.6.0 Release

2014-08-11 Thread Mike Billau
There was talk about adding the "internal whitelist" that Ian built for the Android vulnerability fixes back into 3.6.0. It was removed from the initial security patches because is a breaking change. Currently in order to block sms:, tel:, and other protocols one needs to install a plugin from Ian

[GitHub] cordova-medic pull request: Windows Universal Apps support and imp...

2014-08-11 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-medic/pull/16#issuecomment-51778314 Could someone review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

Notification on lock screen

2014-08-11 Thread Daniela Gomes
Hello, My name is Daniela and I am new at building with cordova. My application was developed with cordova and a Pushwoosh plugin to receive notifications. But I'd like to show a notification like an alert on closed app or when screen is locked on Android devices. I heard it's possible to modify t