Re: Andrew on Vacation

2014-08-22 Thread Steven Gill
Have a good one! On Thursday, August 21, 2014, Andrew Grieve agri...@google.com wrote: I'll be back Sept 8th :)

[GitHub] cordova-weinre pull request: Allow update of weinreId without page...

2014-08-22 Thread shteou
Github user shteou commented on the pull request: https://github.com/apache/cordova-weinre/pull/7#issuecomment-53032403 Issue logged: https://issues.apache.org/jira/browse/CB-7367 Thanks. --- If your project is set up for it, you can reply to this email and have your

Re: Andrew on Vacation

2014-08-22 Thread Ally Ogilvie
Enjoy! On Fri, Aug 22, 2014 at 3:57 PM, Steven Gill stevengil...@gmail.com wrote: Have a good one! On Thursday, August 21, 2014, Andrew Grieve agri...@google.com wrote: I'll be back Sept 8th :) -- http://www.wizcorp.jp/Ally Ogilvie Lead Developer - MobDev. | Wizcorp Inc.

[GitHub] cordova-wp8 pull request: CB-7368 --archs=x86 now produces corre...

2014-08-22 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-wp8/pull/52 CB-7368 --archs=x86 now produces correct binaries. Fix for https://issues.apache.org/jira/browse/CB-7368 You can merge this pull request into a Git repository by running: $ git

Is there a decent Getting Started guide without prerequisite loops?

2014-08-22 Thread Matteo Sisti Sette
Hi, I was looking for a Getting Started kind of guide for developing in Cordova for the Android platform, but I've found myself trapped in a loop of links where page A links you to page B to install something that is a requirement, and page B links you back to page A to install something

[GitHub] cordova-plugin-dialogs pull request: Progress dialogs should be ca...

2014-08-22 Thread optikalefx
GitHub user optikalefx opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/28 Progress dialogs should be cancellable outside the window This change makes progress dialogs modal. In a sense that they can't be cancelled from an outside touch. This is expected

getting tired of using mouse to open safari to inspect and magic path for livereload

2014-08-22 Thread Carlos Santana
I was going down the rabbit whole to see if there is a way I can launch the safari debugger after doing a cordova emulate ios, and maybe adding a cli command cordova inspect ios It's kind of annoying because every time you do a build/emulate the safari window that is current debugging closes. and

RE: getting tired of using mouse to open safari to inspect and magic path for livereload

2014-08-22 Thread Ray Camden
Try GapDebug. It will try to reconnect on app relaunch. Plus, it lets you do the iOS stuff in Chrome, not Safari. From: Carlos Santana csantan...@gmail.com Sent: Friday, August 22, 2014 10:31 AM To: dev@cordova.apache.org Subject: getting tired of using

RE: Is there a decent Getting Started guide without prerequisite loops?

2014-08-22 Thread Ray Camden
I just went through this myself the past weekend. I did: Android SDK During that install, it noticed I didn't have Java (this was a VM) and it linked me to install that. Apache ANT Git Node.js (for npm) Then finally npm install -g cordova. That's it.

Re: getting tired of using mouse to open safari to inspect and magic path for livereload

2014-08-22 Thread Carlos Santana
Thanks Ray I don't know how I missed your post [1] on GapDebug GapDebug looks cool and clean, I have to give it a try and it mentions it's free for local debug, I don't know what would be not remote, maybe over wifi but I think that is totally a different use case, the local debug is more of what

Re: Is there a decent Getting Started guide without prerequisite loops?

2014-08-22 Thread Carlos Santana
yep that's the short recipe for android platform. soon will make git optional, when we have platforms downloaded by default from npm. but git will be still supported for plugin installation via git url. On Fri, Aug 22, 2014 at 11:53 AM, Ray Camden rayca...@adobe.com wrote: I just went

Re: Andrew on Vacation

2014-08-22 Thread Carlos Santana
wow long vacation, have fun ! On Fri, Aug 22, 2014 at 11:59 AM, Lorin Beer lorin.b...@gmail.com wrote: enjoy! On Fri, Aug 22, 2014 at 1:54 AM, Ally Ogilvie aogil...@wizcorp.jp wrote: Enjoy! On Fri, Aug 22, 2014 at 3:57 PM, Steven Gill stevengil...@gmail.com wrote: Have a

[GitHub] cordova-mobile-spec pull request: CB-7350 Make createmobilespec fr...

2014-08-22 Thread jengee
Github user jengee commented on a diff in the pull request: https://github.com/apache/cordova-mobile-spec/pull/103#discussion_r16607454 --- Diff: createmobilespec/createmobilespec.js --- @@ -210,122 +267,153 @@ if (argv.plugman) { shelljs.cp(-f,

Re: Andrew on Vacation

2014-08-22 Thread Kerri Shotts
Enjoy! Hope you are going somewhere fun! Sent from my phone. ___ Kerri Shotts photoKandy Studios, LLC On the Web: http://www.photokandy.com/ Social Media: Twitter: @photokandy, http://twitter.com/photokandy Tumblr:

Re: continuous integration woze

2014-08-22 Thread Lorin Beer
+1 to fixing the test -1 to warnings warnings are either treated like errors, or ignored entirely. I'm for treating warnings like errors in the first place On Thu, Aug 21, 2014 at 1:53 PM, Marcel Kinard cmarc...@gmail.com wrote: I agree. My personal philosophy is generally to treat warnings

Re: Plugin path when installing from git

2014-08-22 Thread Don Coleman
Thanks Michal, I was looking for this in the plugman docs instead of the cordova docs. Nice work on the plugin test framework https://github.com/apache/cordova-plugin-test-framework. On Thu, Aug 21, 2014 at 2:29 PM, Michal Mocny mmo...@chromium.org wrote:

[GitHub] cordova-mobile-spec pull request: CB-7350 Make createmobilespec fr...

2014-08-22 Thread jengee
Github user jengee commented on a diff in the pull request: https://github.com/apache/cordova-mobile-spec/pull/103#discussion_r16609983 --- Diff: createmobilespec/createmobilespec.js --- @@ -210,122 +267,153 @@ if (argv.plugman) { shelljs.cp(-f,

Re: Andrew on Vacation

2014-08-22 Thread Brian LeRoux
me too! enjoy (guessing you're not going to burning man?) On Fri, Aug 22, 2014 at 9:40 AM, Kerri Shotts kerrisho...@gmail.com wrote: Enjoy! Hope you are going somewhere fun! Sent from my phone. ___ Kerri Shotts photoKandy Studios, LLC On the Web:

Re: Plugin path when installing from git

2014-08-22 Thread Michal Mocny
Thanks! On Fri, Aug 22, 2014 at 1:23 PM, Don Coleman don.cole...@gmail.com wrote: Thanks Michal, I was looking for this in the plugman docs instead of the cordova docs. Nice work on the plugin test framework https://github.com/apache/cordova-plugin-test-framework. On Thu, Aug 21, 2014

[GitHub] cordova-android pull request: [CB-7371] Fixed: app crash after pho...

2014-08-22 Thread martincgg
GitHub user martincgg opened a pull request: https://github.com/apache/cordova-android/pull/115 [CB-7371] Fixed: app crash after phone language change The main reason of this behavior is the config.xml, origin=* tag, specifies access to all kind of resources on the network and

Re: Cordova upgrade scripts and 3.6.0 / whitelist

2014-08-22 Thread Michal Mocny
Personally, I think we could just document the steps to manually update the config.xml's. We have no concept at all of CLI project upgrades. If we change the default hooks/ format, or remove merges/ by default, you have to re-create the project to see those changes. I think this is similar. If

Re: continuous integration woze

2014-08-22 Thread Jesse
okay, that is what I did ... I will leave things as is, I just wanted to judge if everyone felt that 1 missing (though not required) ';' is enough to break the build. @purplecabbage risingj.com On Fri, Aug 22, 2014 at 9:40 AM, Lorin Beer lorin.b...@gmail.com wrote: +1 to fixing the test -1

Re: Cordova upgrade scripts and 3.6.0 / whitelist

2014-08-22 Thread Ian Clelland
Documentation is definitely a way out of this. I'd like to avoid the developer hassle that we introduced with File, when upgrading meant that previously working behaviour suddenly stopped working, so I'm trying to explore other alternatives first. On Fri, Aug 22, 2014 at 2:24 PM, Michal Mocny

[GitHub] cordova-plugin-dialogs pull request: Progress dialogs should be ca...

2014-08-22 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/28#issuecomment-53106919 I'm pretty sure that the pull request title doesn't match the description/implementation. --- If your project is set up for it, you can reply to this

Re: continuous integration woze

2014-08-22 Thread Michal Mocny
Sounds like we should leave the PR checks and testing as is: if it fails jshint, it breaks the build. What we can re-evaluate is our .jshintrc defaults: do we want to allow missing ; in our codebase? Seems like this is a very divided issue. I'm pro semicolons, but I hear thats old-school. I'm

Re: continuous integration woze

2014-08-22 Thread Josh Soref
Michal Mocny wrote: What we can re-evaluate is our .jshintrc defaults: do we want to allow missing ; in our codebase? Seems like this is a very divided issue. I'm pro semicolons, but I hear thats old-school. I'm also pro-choice ;) so I'd be happy to remove that option. I'm also pro-consistency

[GitHub] cordova-coho pull request: CB-5312 Support github.com/apache repos...

2014-08-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/34 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-dialogs pull request: Progress dialogs should be no...

2014-08-22 Thread optikalefx
Github user optikalefx commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/28#issuecomment-53110589 The current implementation allows the progress 1-100 dialog box to be cancelled by clicking outside the dialog window. This is unexpected behavior for

[GitHub] cordova-plugin-dialogs pull request: Progress dialogs should be no...

2014-08-22 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/28#issuecomment-53111051 The issue as I meant to imply it is that only Android supports this functionality, ultimately it should be moved/removed, or implemented for more

[GitHub] cordova-plugin-dialogs pull request: Progress dialogs should be no...

2014-08-22 Thread optikalefx
Github user optikalefx commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/28#issuecomment-53111223 iOS is modal by default already. So it already performs the expected behavior. I don't know about the other platforms. At least on Android this is a

Re: continuous integration woze

2014-08-22 Thread Mark Koudritsky
+1 for what Michal wrote (including the self bikeshedding :) It's a matter of JSHint config and I'm ok with changing it. Currently the JSHint config in cordova-lib is per file (using /* jshint */ config comments) and slightly differs between the files to accommodate for different styles present

[GitHub] cordova-plugin-camera pull request: Make crop work as expected

2014-08-22 Thread sovanyio
GitHub user sovanyio opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/43 Make crop work as expected Pass new uri to crop instead of pulling the low resolution image out of the intent return, return this uri if a crop was requested. You can merge this

Re: continuous integration woze

2014-08-22 Thread Jesse
I am pro consistency as well, and I prefer including semi-colons shows your intent, where a missing semi-colon could be intentional, or just forgotten. My ultimate point with this thread was just that I feel the CI tests should be concerned with function, and not form. I honestly don't care if

[GitHub] cordova-mobile-spec pull request: CB-7350 Rework createmobilespec

2014-08-22 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/105 CB-7350 Rework createmobilespec * fix platform flag documentation for --amazon - wrap very long lines - clarify that /bin/create isn't a system application... - drop

[GitHub] cordova-mobile-spec pull request: CB-7350 Rework createmobilespec

2014-08-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-mobile-spec/pull/105 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-android pull request: [CB-7371] Fixed: app crash after pho...

2014-08-22 Thread martincgg
Github user martincgg closed the pull request at: https://github.com/apache/cordova-android/pull/115 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-android pull request: [CB-7371 -Android] Fixed: app crash ...

2014-08-22 Thread martincgg
GitHub user martincgg opened a pull request: https://github.com/apache/cordova-android/pull/116 [CB-7371 -Android] Fixed: app crash after phone language change The main reason of this behavior is the config.xml, origin= tag, specifies access to all kind of resources on the

[GitHub] cordova-lib pull request: CB-7372 Remove use of path.join for mani...

2014-08-22 Thread Menardi
GitHub user Menardi opened a pull request: https://github.com/apache/cordova-lib/pull/77 CB-7372 Remove use of path.join for manifest.launch_path I was having issues on Windows when creating a new FirefoxOS project. A brand new project, when added to the Firefox App Manager, gave

[GitHub] cordova-android pull request: [CB-6837][Android] Fix: leaked windo...

2014-08-22 Thread martincgg
GitHub user martincgg opened a pull request: https://github.com/apache/cordova-android/pull/117 [CB-6837][Android] Fix: leaked window when hitting back button while alert being rendered Created arrayList on ChromeClient that it will register all showed AlertDialog, using