RE: [Discuss] 3.6.0 Release

2014-08-27 Thread Sergey Grebnov (Akvelon)
Btw, who will publish cordova-windows to npm? Since the name is not taken (we previously used cordova-windows8) I can do this, I'm also fine if someone else who is more experienced in such things will do this. Windows platform looks like as 100% ready for tagging, Jesse has added Release

Re: [Discuss] 3.6.0 Release

2014-08-27 Thread purplecabbage
All tagged too. I'll take care of the npm publish in the morning here. Sent from my iPhone On Aug 26, 2014, at 11:51 PM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com wrote: Btw, who will publish cordova-windows to npm? Since the name is not taken (we previously used

RE: [Discuss] 3.6.0 Release

2014-08-27 Thread Sergey Grebnov (Akvelon)
Jesse, could you please also include the following commit to 3.6.0. After additional testing I found out that it leads to incorrect filtering of not supported rules (https only) on Windows. https://github.com/apache/cordova-windows/commit/31bac42808e56a2239cbda07a02794147ebafb8b CB-7377

RE: [Discuss] 3.6.0 Release

2014-08-27 Thread Sergey Grebnov (Akvelon)
Pushed the following fix to CLI master which adds back missing reference to fs (requires for Windows platform). https://github.com/apache/cordova-cli/commit/6662888cffaab997a0f6daa7657d10962b23cf31 Looks like it has been accidentally removed by the following commit

[GitHub] cordova-lib pull request: CB-7372 Fix generated launch path for Fi...

2014-08-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/77 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-plugin-camera pull request: CB-7378 Adds windows platform ...

2014-08-27 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/44 CB-7378 Adds windows platform support. Fix for https://issues.apache.org/jira/browse/CB-7378 Adds support for windows platform and, especially, for WP8 You can merge

[GitHub] cordova-firefoxos pull request: CB-5956 firefoxos: Fixed minor typ...

2014-08-27 Thread zalun
Github user zalun commented on the pull request: https://github.com/apache/cordova-firefoxos/pull/5#issuecomment-53557886 @rixrix Please close the pull request --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-device pull request: [fxos] Remove cordova version

2014-08-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device/pull/21 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-file pull request: Overwrite existing file on getFi...

2014-08-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/69 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-inappbrowser pull request: inappbrowser events supp...

2014-08-27 Thread zalun
Github user zalun commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/57#issuecomment-53558383 Thanks! r+ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-inappbrowser pull request: inappbrowser events supp...

2014-08-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/57 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-inappbrowser pull request: FirefoxOS Tweak: Setting...

2014-08-27 Thread zalun
Github user zalun commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/44#issuecomment-53558674 @nowned please create a new pull request with the new code - it conflicts now. If you like, I can make the change manually as well. --- If your

Re: [Testing] No content to speak of

2014-08-27 Thread Martin Gonzalez
Agree, over android it looks good, however running the tests over Windows Phone, the final count is 13 new fails. Specs failing: 9, 9.5, 10, 11, 15, 24, 82, 110, 116, 121, 122, 123, 124. 2014-08-26 11:20 GMT-05:00 Marcel Kinard cmarc...@gmail.com: Thanks, Ian! On Android 4.4, I'm now getting

RE: [Testing] No content to speak of

2014-08-27 Thread Sergey Grebnov (Akvelon)
Vladimir Kotikov and me will join this testing party soon and help with the testing and necessary improvements(if any). Currently we see some problem with dynamic manual tests generation (at least in Camera tests) on Windows due to special unsafe html restrictions on this platform, Vladimir

[GitHub] cordova-blackberry pull request: CB-7409 update CORDOVA_HOME_DIR b...

2014-08-27 Thread bryanhiggins
Github user bryanhiggins commented on the pull request: https://github.com/apache/cordova-blackberry/pull/176#issuecomment-53574787 Is anything actually broken? AFAIK these environment variables are only used for bundling of binaries which would never be distributed via NPM.

[GitHub] cordova-plugin-file pull request: CB-7413 Adds support of 'ms-appd...

2014-08-27 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-file/pull/70 CB-7413 Adds support of 'ms-appdata://' URIs Fix for https://issues.apache.org/jira/browse/CB-7413 This also fixes resolving of `file://` urls You can merge this pull

File test failures (was: Re: [Testing] No content to speak of)

2014-08-27 Thread Ian Clelland
Martin, can you post the spec test output somewhere? (Or anyone who can replicate this on a windows phone device -- I don't have a test environment set up for that yet, but I'm slowly working at it) I've checked the code again from my side, and I can't see where or how it's failing, so the

RE: [Testing] No content to speak of

2014-08-27 Thread Edna Y Morales
I'm seeing many many failing iOS tests. They are seen across file, file-transfer, globalization, geolocation, and media with timeout and reference errors mostly. Can anyone else verify this or is it just me? Thanks, Edna Morales From: Sergey Grebnov (Akvelon) v-seg...@microsoft.com To:

Re: [Testing] No content to speak of

2014-08-27 Thread Ian Clelland
I'll check that out; the file changes could be related to my commits yesterday On Wed, Aug 27, 2014 at 10:58 AM, Edna Y Morales eymor...@us.ibm.com wrote: I'm seeing many many failing iOS tests. They are seen across file, file-transfer, globalization, geolocation, and media with timeout and

iOS mobile-spec failures (was: Re: [Testing] No content to speak of)

2014-08-27 Thread Ian Clelland
No, it appears that something is up with Jasmine on ios -- the custom matchers aren't being attached in all cases, so I am seeing errors in the console like: TypeError: 'undefined' is not a function (evaluating 'expect(fileEntry.name).toCanonicallyMatch(fileName)') because .toCanonicallyMatch is

Re: File test failures (was: Re: [Testing] No content to speak of)

2014-08-27 Thread Martin Gonzalez
Sure thing, give me a couple of minutes. 2014-08-27 9:55 GMT-05:00 Ian Clelland iclell...@chromium.org: Martin, can you post the spec test output somewhere? (Or anyone who can replicate this on a windows phone device -- I don't have a test environment set up for that yet, but I'm slowly

Re: File test failures (was: Re: [Testing] No content to speak of)

2014-08-27 Thread Martin Gonzalez
Done, Jasmine report has been attached to https://issues.apache.org/jira/browse/CB-7375. Please look at the listed spec failing, there are other failures over windows phone, but those were before of any of this changes. 2014-08-27 10:43 GMT-05:00 Martin Gonzalez martin.c.glez.g...@gmail.com:

Re: iOS mobile-spec failures (was: Re: [Testing] No content to speak of)

2014-08-27 Thread Ian Clelland
Something strange is definitely going on in the file tests; in the vicinity of spec.109. Custom matchers are not being added after that spec, but if I remove it, then the tests simply stop at that point. On Wed, Aug 27, 2014 at 11:40 AM, Ian Clelland iclell...@chromium.org wrote: No, it

Re: iOS mobile-spec failures (was: Re: [Testing] No content to speak of)

2014-08-27 Thread Martin Gonzalez
During testing, sometimes a callback is reached more than one time, this strange behavior I've faced over Windows phone with the Media tests, creating a loop. Then Edna test it out over iOS a few weeks ago and I recall that some of the callbacks were reached more than once, which is unusual.

Re: iOS mobile-spec failures (was: Re: [Testing] No content to speak of)

2014-08-27 Thread Edna Y Morales
Yeah I can confirm that behavior. I was seeing it this morning when I noticed that some specs were showing up as failing twice? Thanks, Edna Morales From: Martin Gonzalez martin.c.glez.g...@gmail.com To: dev@cordova.apache.org Date: 08/27/2014 01:06 PM Subject:Re: iOS

[GitHub] cordova-plugin-file pull request: Possible fix for CB-7415: Implem...

2014-08-27 Thread dzeims
GitHub user dzeims opened a pull request: https://github.com/apache/cordova-plugin-file/pull/71 Possible fix for CB-7415: Implement a more feature complete implementation of ProgressEvent * Reuse native ProgressEvent if supported * Partially or completely pollyfill

[GitHub] cordova-plugin-dialogs pull request: CB-7414 Document callback par...

2014-08-27 Thread swypych
GitHub user swypych opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/29 CB-7414 Document callback parameter for navigator.notification.alert Specifically for BB10 and may apply to other platforms... You can merge this pull request into a Git repository

RE: [Discuss] 3.6.0 Release

2014-08-27 Thread Sergey Grebnov (Akvelon)
Found out another Windows issue. Jesse could you pls take a look? Otherwise I'll investigate it my tomorrow morning. CB-7416 - Windows+plugins. source-file is not correctly processed Thx! Sergey -Original Message- From: Sergey Grebnov (Akvelon) [mailto:v-seg...@microsoft.com] Sent:

[GitHub] cordova-blackberry pull request: CB-7409 update CORDOVA_HOME_DIR b...

2014-08-27 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-blackberry/pull/176#issuecomment-53621621 npm_cache is where we want downstream distributions to put things going forward, so it makes sense to update this. --- If your project is set up for it, you

[GitHub] cordova-blackberry pull request: CB-7409 update CORDOVA_HOME_DIR b...

2014-08-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-blackberry/pull/176 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: iOS mobile-spec failures (was: Re: [Testing] No content to speak of)

2014-08-27 Thread Michal Mocny
One quick thing to try is to update the version of jasmine used by the harness app. 2.0 is new and its been a while since the assets were updated. -Michal On Wed, Aug 27, 2014 at 1:14 PM, Edna Y Morales eymor...@us.ibm.com wrote: Yeah I can confirm that behavior. I was seeing it this

Re: Directory Structure - CLI directory config proposal

2014-08-27 Thread Michal Mocny
Hmm, maybe we don't actually need these to be configurable. If cordova-lib just stopped containing hardcoded paths, and all modules required paths as inputs, then cordova-cli would have one pre-defined expected directory structure (not configurable), exactly as it is now. But if you want to

[GitHub] cordova-plugin-file pull request: [CB-7417][File tests] added prop...

2014-08-27 Thread martincgg
GitHub user martincgg opened a pull request: https://github.com/apache/cordova-plugin-file/pull/72 [CB-7417][File tests] added proper matcher to compare fullPath property Specs : 111, 112 121-124, were using [toBe, toEqual] to compare a Entry's fullPath property. The right

[GitHub] cordova-plugin-file pull request: [CB-7418][DirectoryEntry] Added ...

2014-08-27 Thread martincgg
GitHub user martincgg opened a pull request: https://github.com/apache/cordova-plugin-file/pull/73 [CB-7418][DirectoryEntry] Added fullPath variable as part of condition As well as nativeUrl property, the fullPath variable should be part of the condition to avoid that a null value

[GitHub] cordova-plugin-file pull request: [CB-7417][File tests] added prop...

2014-08-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/72 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-file pull request: [CB-7418][DirectoryEntry] Added ...

2014-08-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/73 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-file pull request: [CB-7419][WP8] Added support to ...

2014-08-27 Thread martincgg
GitHub user martincgg opened a pull request: https://github.com/apache/cordova-plugin-file/pull/74 [CB-7419][WP8] Added support to get metada from directory The error CODE 1, in the callback it was about the failed attempt to get the size of a directory using

[GitHub] cordova-firefoxos pull request: CB-5956 firefoxos: Fixed minor typ...

2014-08-27 Thread rixrix
Github user rixrix closed the pull request at: https://github.com/apache/cordova-firefoxos/pull/5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-firefoxos pull request: CB-5956 firefoxos: Fixed minor typ...

2014-08-27 Thread rixrix
Github user rixrix commented on the pull request: https://github.com/apache/cordova-firefoxos/pull/5#issuecomment-53655513 @zalun all good. closing this off --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

RE: Directory Structure - CLI directory config proposal

2014-08-27 Thread Treggiari, Leo
This would mean that you are either 100% cordova-cli directory structure compatible, and thus (potentially, at least) tool-interchangeable, or your have a different structure and are not interchangeable. Does that not map to user expectations? Interesting question. So there seems to be two

Re: iOS mobile-spec failures (was: Re: [Testing] No content to speak of)

2014-08-27 Thread Edna Y Morales
Running only the file plugin tests, updating the version of jasmine in the assets brought the failures down from 16 to 0. Thanks for the suggestion Michal! I will see what the results are for the rest of the plugins with the updated version of jasmine tomorrow. Thanks, Edna Morales From:

Re: iOS mobile-spec failures (was: Re: [Testing] No content to speak of)

2014-08-27 Thread Michal Mocny
Awesome :P Sometimes you get lucky ;) On Wed, Aug 27, 2014 at 8:50 PM, Edna Y Morales eymor...@us.ibm.com wrote: Running only the file plugin tests, updating the version of jasmine in the assets brought the failures down from 16 to 0. Thanks for the suggestion Michal! I will see what the

[GitHub] cordova-plugin-camera pull request: Add orientation support for PN...

2014-08-27 Thread yoshifp
GitHub user yoshifp opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/45 Add orientation support for PNG to Android You can merge this pull request into a Git repository by running: $ git pull https://github.com/yoshifp/cordova-plugin-camera patch-1