[GitHub] cordova-plugin-inappbrowser pull request: Windows platform fixes

2014-11-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/69 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-dialogs pull request: CB-7639 Notification.confirm(...

2014-11-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/35 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-medic pull request: Medic improvenents

2014-11-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-plugin-statusbar commit comment: d9a8528c8baaa1b94efa0b0ef...

2014-11-12 Thread purplecabbage
Github user purplecabbage commented on commit d9a8528c8baaa1b94efa0b0efea0c22ccf988cf1: https://github.com/apache/cordova-plugin-statusbar/commit/d9a8528c8baaa1b94efa0b0efea0c22ccf988cf1#commitcomment-8548965 In www/statusbar.js: In www/statusbar.js on line 76: This turns "#33

Re: introduction

2014-11-12 Thread Carlos Santana
Welcome Jonathan ! On Wed, Nov 12, 2014 at 10:31 AM Michal Mocny wrote: > Hi Jonathan! > > Seems you've been a lurker on these lists for a while and have helped > submit issues in the past. Thanks for signing up to contribute directly. > > -Michal > > On Wed, Nov 12, 2014 at 9:51 AM, Li, Jonatha

[GitHub] cordova-plugin-statusbar pull request: CB-7986 Add cordova-plugin-...

2014-11-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] cordova-plugin-statusbar commit comment: d9a8528c8baaa1b94efa0b0ef...

2014-11-12 Thread purplecabbage
Github user purplecabbage commented on commit d9a8528c8baaa1b94efa0b0efea0c22ccf988cf1: https://github.com/apache/cordova-plugin-statusbar/commit/d9a8528c8baaa1b94efa0b0efea0c22ccf988cf1#commitcomment-8548974 In www/statusbar.js: In www/statusbar.js on line 76: Nevermind, just

[GitHub] cordova-lib pull request: Add a type named "gradleReference" in fr...

2014-11-12 Thread fujunwei
Github user fujunwei commented on the pull request: https://github.com/apache/cordova-lib/pull/119#issuecomment-62823008 ping @clelland @agrieve Could you please help to take a look, Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear o

Re: Questions re: plugin variables

2014-11-12 Thread Shazron
I know it seems confusing, but the tag inside the tag is just some xml insertion into the config.xml file that is specified, but is not related to the tag specified for plugin.xml. It is the tag for config.xml. It should behave as specified in the Plugin Spec [1], when inside tags, except for

[GitHub] cordova-plugins pull request: Updated Plugin to iOS 8

2014-11-12 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugins/pull/16#issuecomment-62795139 Thanks Felipe, Before this can be pulled in - we need you to sign the Apache iCLA: http://www.apache.org/licenses/icla.txt Once I receive confirmation

[GitHub] cordova-docs pull request: CB-7971 Add cordova-plugin-battery-stat...

2014-11-12 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-docs/pull/246 CB-7971 Add cordova-plugin-battery-status support for Windows Phone 8.1 Updated the platforms support table [JIRA issue](https://issues.apache.org/jira/browse/CB-7971) [Related PR

[GitHub] cordova-docs pull request: CB-7970 Add cordova-plugin-vibration su...

2014-11-12 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-docs/pull/245 CB-7970 Add cordova-plugin-vibration support for Windows Phone 8.1 Updated the platforms support table [JIRA issue](https://issues.apache.org/jira/browse/CB-7970) [Related PR with

[GitHub] cordova-plugin-vibration pull request: CB-7977 Mention deviceready...

2014-11-12 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-vibration/pull/24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] cordova-plugin-file pull request: CB-7977 Mention deviceready in p...

2014-11-12 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/90 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] cordova-plugin-globalization pull request: CB-7977 Mention devicer...

2014-11-12 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-globalization/pull/30 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] cordova-plugin-inappbrowser pull request: CB-7977 Mention devicere...

2014-11-12 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/70 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-device-orientation pull request: CB-7977 Mention de...

2014-11-12 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-device-orientation/pull/17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-plugin-statusbar pull request: CB-7977 Mention deviceready...

2014-11-12 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] cordova-plugin-console pull request: CB-7977 Mention deviceready i...

2014-11-12 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-console/pull/7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] cordova-plugin-media pull request: CB-7977 Mention deviceready in ...

2014-11-12 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/36 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cordova-plugin-dialogs pull request: CB-7977 Mention deviceready i...

2014-11-12 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/40 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-geolocation pull request: CB-7977 Mention devicerea...

2014-11-12 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-geolocation/pull/30 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-media-capture pull request: CB-7977 Mention devicer...

2014-11-12 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-media-capture/pull/29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] cordova-plugin-camera pull request: CB-7977 Mention deviceready in...

2014-11-12 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/53 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] cordova-plugin-device-motion pull request: CB-7977 Mention devicer...

2014-11-12 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-device-motion/pull/19 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] cordova-plugin-contacts pull request: CB-7977 Mention deviceready ...

2014-11-12 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/50 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-file-transfer pull request: CB-7977 Mention devicer...

2014-11-12 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/49 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] cordova-plugin-contacts pull request: CB-7896 Pending tests for Sa...

2014-11-12 Thread MariaBukharina
Github user MariaBukharina commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/49#issuecomment-62753473 Thanks, I'll consider it when reviewing tests for windows phone 8. --- If your project is set up for it, you can reply to this email and have your

[VOTE] Tools Release, take 3

2014-11-12 Thread Mark Koudritsky
Please review and vote on this Tools Release. Release issue: https://issues.apache.org/jira/browse/CB-7988 Packages have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-7988/ And to npm under @rc tag To test them out you can use: npm -g uninstall cordova npm

Re: [VOTE] Tools Release, take 3

2014-11-12 Thread Mark Koudritsky
Please also review the updated blog post: https://github.com/cordova/apache-blog-posts/blob/master/2014-11-10-tools-release.md

Re: Fix for `cordova emulate ios` to support iPhone 6

2014-11-12 Thread Shazron
Hi Seth, The run script does not exist in the cordova-cli, it exists in the cordova-ios repo, and I believe this issue has already been fixed in 3.7.0. On Tue, Nov 11, 2014 at 5:24 PM, Seth Voltz wrote: > Hello, > > I just started with Cordova and wanted to keep everything on the CLI so I > can

Re: introduction

2014-11-12 Thread Michal Mocny
Hi Jonathan! Seems you've been a lurker on these lists for a while and have helped submit issues in the past. Thanks for signing up to contribute directly. -Michal On Wed, Nov 12, 2014 at 9:51 AM, Li, Jonathan wrote: > Hi all, > > I'm getting myself set up as a contributor to Cordova. So far

Re: introduction

2014-11-12 Thread Shazron
Welcome Jonathan! Looking forward to your first pull request. Your iCLA was just received today as well -- good timing. On Wed, Nov 12, 2014 at 6:51 AM, Li, Jonathan wrote: > Hi all, > > I'm getting myself set up as a contributor to Cordova. So far I've just > been working on projects that use

Re: Fix for `cordova emulate ios` to support iPhone 6

2014-11-12 Thread Shazron
Here is the file history: https://github.com/apache/cordova-ios/commits/master/bin/templates/scripts/cordova/run Thank you however for contributing! I would encourage you to file pull requests in the future. The repo itself has a CONTRIBUTING.md with guidelines. Each pull request should be accompa

Fix for `cordova emulate ios` to support iPhone 6

2014-11-12 Thread Seth Voltz
Hello,I just started with Cordova and wanted to keep everything on the CLI so I can run the build and emulate cycle without having to open Xcode. In order to support the iPhone 6 I edited the `platforms/ios/cordova/run` file to use ios-sim 3.x’s —devicetypeid syntax.I have attached it here but I wo

introduction

2014-11-12 Thread Li, Jonathan
Hi all, I'm getting myself set up as a contributor to Cordova. So far I've just been working on projects that use Cordova, but I hope to contribute back to Cordova in the future. The first change I plan to make is fixing bug CB-3071, so iOS cordova app does not need to use SDURLCache as a wor

Re: Suggestion: Warning about usage of patterns that conflict with the Firefox OS CSP

2014-11-12 Thread Axel Nennker
vulcanize does not work when inline script depends on the order of the scripts. vulcanize just extracts all inline script and includes vulcanize.js at the end of the html body var B = A; would not work because that becomes // ReferenceError B is not defined // var B = A; 2014-11-12

Re: Suggestion: Warning about usage of patterns that conflict with the Firefox OS CSP

2014-11-12 Thread Ian Clelland
I'm not familiar enough with the FirefoxOS architecture, but on Android, we had also considered the possibility of injecting a Content-Security-Policy in the response header for the application's start page -- this would be more secure, arguably, than a tag. The biggest problem is that that trick

Re: Whitelist breakout update

2014-11-12 Thread Ian Clelland
Sorry for dropping this thread for a week; let me see if I can address that -- By default, for brand new apps created with Cordova 4.x with no plugins, those will be blocked (this includes protocols like tel: and mailto:) . This was considered to be a security issue earlier this year, and we put m

Re: Suggestion: Warning about usage of patterns that conflict with the Firefox OS CSP

2014-11-12 Thread Frederik Braun
Response inline On 12.11.2014 14:35, Michal Mocny wrote: > We could add to > the default template, or create a plugin that injects it automatically and > try to get developers to install that plugin. > > This has some benefits for security of cordova apps and has been brought up > on these lists

Re: Suggestion: Warning about usage of patterns that conflict with the Firefox OS CSP

2014-11-12 Thread Michal Mocny
We could add to the default template, or create a plugin that injects it automatically and try to get developers to install that plugin. This has some benefits for security of cordova apps and has been brought up on these lists in that context (very recently by Ian's whitelist -> plugin thread).

[GitHub] cordova-plugin-camera pull request: cameraDirection option fix in ...

2014-11-12 Thread lgrignon
GitHub user lgrignon opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/54 cameraDirection option fix in Android Uses Android Camera API, which in API level 9, received some feature detection abilities. A custom activity has been created to control the c

[GitHub] cordova-android pull request: Typo in android gitignore (ant-built...

2014-11-12 Thread stefan-dimitrov-clouway
Github user stefan-dimitrov-clouway commented on the pull request: https://github.com/apache/cordova-android/pull/129#issuecomment-62710907 Why is this still not merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

Suggestion: Warning about usage of patterns that conflict with the Firefox OS CSP

2014-11-12 Thread Frederik Braun
Hi, I am not very involved with Cordova, but as far as I understand, Cordova Apps are allowed to use eval, inline scripts etc. We do not allow this in Firefox OS [1] and I am concerned that it may cause some friction when porting existing Cordova apps to Firefox OS and then realizing that a lot o