RE: [Discuss] Plugins release

2014-11-26 Thread Sergey Grebnov (Akvelon)
Jesse, sounds good, you can re-work any of them to show example/pattern and I'll assist you in reworking the rest. Thx! Sergey -Original Message- From: Jesse [mailto:purplecabb...@gmail.com] Sent: Tuesday, November 25, 2014 9:55 PM To: dev@cordova.apache.org Subject: Re: [Discuss]

[GitHub] cordova-plugin-dialogs pull request: [CB-7737] lower min height fo...

2014-11-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/44 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: [Discuss] Plugins release

2014-11-26 Thread julio cesar sanchez
Ian, can you take a look into this PR before updating the dialogs plugin? https://issues.apache.org/jira/browse/CB-7734 https://github.com/apache/cordova-plugin-dialogs/pull/39 2014-11-26 10:16 GMT+01:00 Sergey Grebnov (Akvelon) v-seg...@microsoft.com : Jesse, sounds good, you can re-work any

Notification in dialog plugin

2014-11-26 Thread Piotr Zalewa
Hi I came across an issue in writing a Notification support in Cordova. Dialogs plugin uses Notification for a classy object. I think it should be called Dialog or similar and not take the Notification. I actually think the navigator.notifications is wrong name either, that however might hold

Re: Notification in dialog plugin

2014-11-26 Thread Brian LeRoux
ya this is legacy pain; the source formerly known as phonegap predates push/local notifications! used to be vibrate, flash indicator lights (remember those on blackberries?) and beep (also lol) we named the plugin repo cordova-plugin-dialogue (and moved vibrate out) b/c that seemed more

Re: Notification in dialog plugin

2014-11-26 Thread Michal Mocny
+1, I think we shouldn't change the navigator.notifications interface, but the name of the internal type is unlikely to break anyone. Can do a major version bump on the plugin just in case. -Michal On Wed, Nov 26, 2014 at 11:07 AM, Brian LeRoux b...@brian.io wrote: ya this is legacy pain; the

[GitHub] cordova-plugin-file-transfer pull request: [CB-8014] fileKey optio...

2014-11-26 Thread marti1125
GitHub user marti1125 opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/51 [CB-8014] fileKey option is being sent with a wrong value due to a mistake in the code https://issues.apache.org/jira/browse/CB-8014 I updated array You can merge this

[GitHub] cordova-plugin-vibration pull request: CB-7970 Add cordova-plugin-...

2014-11-26 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-vibration/pull/25#issuecomment-64683921 I have reviewed the WinJS Globalization API: ~60% of the methods are supported (additional quirks can appear though). I will also

[GitHub] cordova-plugin-globalization pull request: CB-7972 Add cordova-plu...

2014-11-26 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-globalization/pull/31#issuecomment-64684076 I have reviewed the WinJS Globalization API: ~60% of the methods are supported (additional quirks can appear though). I will also

[GitHub] cordova-plugin-device-motion pull request: CB-8083 Fix acceleromet...

2014-11-26 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-plugin-device-motion/pull/21 CB-8083 Fix accelerometer callback on Windows https://issues.apache.org/jira/browse/CB-8083 This patch adds keepCallback property to tell proxy preserve callback so

[GitHub] cordova-plugin-vibration pull request: Fixes CB-7861 Bad comma.

2014-11-26 Thread lucasgonze
GitHub user lucasgonze opened a pull request: https://github.com/apache/cordova-plugin-vibration/pull/27 Fixes CB-7861 Bad comma. You can merge this pull request into a Git repository by running: $ git pull https://github.com/lucasgonze/cordova-plugin-vibration master

[GitHub] cordova-lib pull request: Added identifier checking for app id, se...

2014-11-26 Thread kamrik
Github user kamrik commented on the pull request: https://github.com/apache/cordova-lib/pull/123#issuecomment-64693426 A comment inside valid-identifier.js about what this file is for would be helpful, maybe also about why reserved words are forbidden in IDs. Otherwise looks good to

[GitHub] cordova-lib pull request: Added identifier checking for app id, se...

2014-11-26 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/123#issuecomment-64694095 Thanks, Good advice. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-vibration pull request: Fixes CB-7861 Bad comma.

2014-11-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-vibration/pull/27 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-lib pull request: Added identifier checking for app id, se...

2014-11-26 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/123#issuecomment-64704617 This is actually already merged, I am going to make some changes though. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-geolocation pull request: CB-8085 Fix geolocation p...

2014-11-26 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/32 CB-8085 Fix geolocation plugin on Windows https://issues.apache.org/jira/browse/CB-8085 This patch adds keepCallback property to tell proxy preserve callback so that it

Contributing to Cordova

2014-11-26 Thread Oliver Salzburg
Hello list, we've been working with Cordova for about a year now. In the process we've opened a couple of issues on the Cordova Jira and submitted a couple of pull requests on GitHub. I've noticed that responses to these actions usually take either a very long time, or don't happen at all.

Re: Contributing to Cordova

2014-11-26 Thread Josh Soref
Oliver wrote: we've been working with Cordova for about a year now. In the process we've opened a couple of issues on the Cordova Jira and submitted a couple of pull requests on GitHub. I've noticed that responses to these actions usually take either a very long time, or don't happen at

Re: Contributing to Cordova

2014-11-26 Thread Joe Bowser
On Wed Nov 26 2014 at 2:23:45 PM Oliver Salzburg oliver.salzb...@gmail.com wrote: Hello list, we've been working with Cordova for about a year now. In the process we've opened a couple of issues on the Cordova Jira and submitted a couple of pull requests on GitHub. I've noticed that

[GitHub] cordova-lib pull request: CB-8067 externalized valid-identifier it...

2014-11-26 Thread purplecabbage
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-lib/pull/124 CB-8067 externalized valid-identifier it is it's own module You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-lib pull request: CB-8067 externalized valid-identifier it...

2014-11-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/124 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[Android] MozillaView Update: PoC is working

2014-11-26 Thread Joe Bowser
Hey Just an update, I have a working PoC of the GeckoView-based WebView ready for people to look at here: https://github.com/infil00p/cordova-mozillaview-engine This is definitely a very different webview than what we have had currently, and I've had to re-think a lot of how we do things with

Re: [Android] MozillaView Update: PoC is working

2014-11-26 Thread Ally Ogilvie
Thoughts? That. Is. Awesome. How far back can you target Android? On Thu, Nov 27, 2014 at 9:08 AM, Joe Bowser bows...@gmail.com wrote: Hey Just an update, I have a working PoC of the GeckoView-based WebView ready for people to look at here:

Code Review Plz

2014-11-26 Thread Andrew Grieve
I've taken a stab at refactoring Android's splashscreen logic into the splashscreen plugin. https://github.com/apache/cordova-android/pull/134 https://github.com/apache/cordova-plugin-splashscreen/pull/32 In order to be backwards-compatible, I've: - Committed a copy of the plugin to