RE: platforms/plugins save and restore from config.xml

Also, I have Pull Requests that implements the --save flag as mentioned earlier : - https://github.com/apache/cordova-cli/pull/203 - https://github.com/apache/cordova-lib/pull/144 Thanks, Mefire -Original Message- From: Mefire O. [mailto:ommen...@microsoft.com] Sent: Thursday, January

[GitHub] cordova-cli pull request: CB-8227 CB-8237 CB-8238 Add --save optio...

GitHub user omefire opened a pull request: https://github.com/apache/cordova-cli/pull/203 CB-8227 CB-8237 CB-8238 Add --save option to 'cordova platform add', 'cordova platform remove' and 'cordova platform update' CB-8227 CB-8237 CB-8238 Add --save option to 'cordova platform add',

RE: platforms/plugins save and restore from config.xml

+1 on removing the --experimental flag after fixing the 'variables not being saved' bug. Thanks, Mefire -Original Message- From: Josh Soref [mailto:jso...@blackberry.com] Sent: Thursday, January 8, 2015 8:49 PM To: Cordova Dev Subject: Re: platforms/plugins save and restore from config.

[GitHub] cordova-lib pull request: CB-8227 CB8237 CB-8238 Add --save option...

GitHub user omefire opened a pull request: https://github.com/apache/cordova-lib/pull/144 CB-8227 CB8237 CB-8238 Add --save option to 'cordova platform add', 'cordova platform remove' and 'cordova platform update' CB-8227 CB8237 CB-8238 Add --save option to 'cordova platform add

Re: platforms/plugins save and restore from config.xml

Until adding plugins saves the variables provided, we really shouldn't / can't make this non experimental. Sent from my BlackBerry 10 smartphone. ‎ smime.p7s Description: S/MIME cryptographic signature

[GitHub] cordova-plugin-media pull request: CB-8252 Fire audio events from ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/41 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cordova-plugin-media pull request: CB-8252 Fire audio events from ...

Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/41#discussion_r22699122 --- Diff: RELEASENOTES.md --- @@ -103,3 +103,7 @@ * CB-7977 Mention `deviceready` in plugin docs * CB-7945 Made media.spec.15 and media.

Re: platforms/plugins save and restore from config.xml

cordova help has a section for "Experimental Commands" they are listed there. Once the save and restore is graduated that section will be empty though. -- Gorkem On 8 Jan 2015, at 21:32, Brian LeRoux wrote: Yes! Also quick q, are all experimental flags documented somewhere? (Other than code

Re: Reviewboard

They are zapped! On Thu, Jan 8, 2015 at 3:04 PM, Shazron wrote: > sounds good to remove! > > On Thu, Jan 8, 2015 at 8:46 AM, Michal Mocny wrote: > > +1 > > > > On Wed, Jan 7, 2015 at 4:20 PM, Jesse wrote: > > > >> Yeah, kill it. gh-pulls are much easier to review I think. > >> > >> @purplecab

Re: platforms/plugins save and restore from config.xml

Yes! Also quick q, are all experimental flags documented somewhere? (Other than code) On Thu, Jan 8, 2015, 6:29 PM Parashuram N (MS OPEN TECH) < panar...@microsoft.com> wrote: > +1 to graduating this out of experimental :) > > On 1/8/15, 4:25 PM, "Steven Gill" wrote: > > >+1 to remove --experime

Re: MobileSpec for testing cordova-lib@rc

Just checked out peer-dependencies. Looks like the way to move forward with handling our dependency issues. Right now, plugman publish creates a package.json file by grabbing info from plugin.xml. Once published, plugman will automatically delete the package.json file. I suggest we stop deleting t

Re: platforms/plugins save and restore from config.xml

+1 to graduating this out of experimental :) On 1/8/15, 4:25 PM, "Steven Gill" wrote: >+1 to remove --experimental > >On Thu, Jan 8, 2015 at 4:13 PM, Gorkem Ercan >wrote: > >> >> >> On 8 Jan 2015, at 17:29, Mefire O. wrote: >> >> Hi all, >>> >>> I am a big fan of the experimental "save" and "r

[GitHub] cordova-android pull request: Make JUnit tests to test pluggable w...

Github user fujunwei commented on the pull request: https://github.com/apache/cordova-android/pull/140#issuecomment-69277448 ping @clelland Could you please help me review this PR? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on

Review: Tools release blog post

https://github.com/cordova/apache-blog-posts/blob/master/2015-01-08-tools-release.md PRs welcome!

Re: platforms/plugins save and restore from config.xml

+1 to remove --experimental On Thu, Jan 8, 2015 at 4:13 PM, Gorkem Ercan wrote: > > > On 8 Jan 2015, at 17:29, Mefire O. wrote: > > Hi all, >> >> I am a big fan of the experimental "save" and "restore" features that are >> in the CLI and saw that Gorkem has also created another PR ( >> https://

Re: platforms/plugins save and restore from config.xml

On 8 Jan 2015, at 17:29, Mefire O. wrote: Hi all, I am a big fan of the experimental "save" and "restore" features that are in the CLI and saw that Gorkem has also created another PR (https://github.com/apache/cordova-lib/pull/143 ) to have a setting to auto persist/restore plugin versions

[GitHub] cordova-lib pull request: CB-8239 Add support for git urls to 'cor...

Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/141#issuecomment-69271082 @hstaudacher, I've added the remaining scenarios. I've copied over some of the changes you made in this branch and merged them with mine. I'd be grateful

Re: MobileSpec for testing cordova-lib@rc

+1 for publishing plugins to npm We will need to come up with a good naming convention so that translating from plugin id to npm package name would be trivial. Preferably with some stable prefix (like cordova_plugin_) so that it would be easy to distinguish plugins if they are listed with other de

Re: platforms/plugins save and restore from config.xml

Correct Josh. Good call on filing the bug. Definitely needs to get fixed soon. On Thu, Jan 8, 2015 at 2:58 PM, Josh Soref wrote: > I just filed > https://issues.apache.org/jira/browse/CB-8278 about readding platforms > after installing a plugin with variables.. > > It definitely needs to be fixe

Re: MobileSpec for testing cordova-lib@rc

This is rad! Definitely a great example showing the JS API. I am thinking about also starting to publish our plugins to npm and add a flag to plugman install to fetch from npm instead of cordova plugins registry. Thoughts? On Thu, Jan 8, 2015 at 1:09 PM, Mark Koudritsky wrote: > On Thu, Jan 8,

Re: platforms/plugins save and restore from config.xml

I just ‎filed  ‎https://issues.apache.org/jira/browse/CB-8278 about readding platforms after installing a plugin with variables.. It definitely needs to be fixed.  @sgill: I guess this also doesn't block the release because we probably shipped with this bug in a previous plugman. Unless variabl

RE: Cordova --list option implementation

I think we have a couple of options here: Option 1 - Adding --list as an optional parameter to cordova run List is related to run and there’s not that much need to introduce another top level command for this . Considering all the previous discussions we had I can see two potential implementatio

Re: platforms/plugins save and restore from config.xml

On 8 January 2015 at 14:29, Mefire O. wrote: > I am a big fan of the experimental "save" and "restore" features that are in > the CLI and saw that Gorkem has also created another PR > (https://github.com/apache/cordova-lib/pull/143 ) to have a setting to auto > persist/restore plugin versions w

platforms/plugins save and restore from config.xml

Hi all, I am a big fan of the experimental "save" and "restore" features that are in the CLI and saw that Gorkem has also created another PR (https://github.com/apache/cordova-lib/pull/143 ) to have a setting to auto persist/restore plugin versions which is a really interesting idea. On a rel

Re: Deprecation Wars: ICS vs Gingerbread

Correct. Next month one of the two will dip, and I think it will be ICS first. However it seems nobody actually tests regularly on 2.3.x, so I'm thinking it's better to be honest about the support we are offering than to say we support something we don't. Unless someone wants to put the time in

Re: Deprecation Wars: ICS vs Gingerbread

I think Joe was saying that since we usually deprecate at 5%, we are ~2/3% off from that mark. -Michal On Thu, Jan 8, 2015 at 5:08 PM, Marcel Kinard wrote: > Er, are we looking at the same data? I see Gingerbread at 7.8% and ICS at > 6.7% at that URL. "Data collected during a 7-day period endin

[GitHub] cordova-js pull request: Fixed callbackFromNative method

Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/98 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

Re: Deprecation Wars: ICS vs Gingerbread

Er, are we looking at the same data? I see Gingerbread at 7.8% and ICS at 6.7% at that URL. "Data collected during a 7-day period ending on January 5, 2015." > On Jan 7, 2015, at 6:39 PM, Joe Bowser wrote: > > http://developer.android.com/about/dashboards/index.html#2015 > > Due to two percent

Re: [All Platforms][CordovaJS] NO_RESULT handling

@Shazron the problem has been around for a while, I've just been avoiding it by running Cordova 4.0.0 / iOS 3.6.0 Changing Line 293 to else is what broke things. @Jessie applying the changes di

Re: MobileSpec for testing cordova-lib@rc

On Thu, Jan 8, 2015 at 3:47 PM, Michal Mocny wrote: > If we add node_modules to search path, will we be able to adjust which > versions of platforms/plugins it uses just by modifying package.json? > > Since platforms can be added by path. You can replace platforms = ['android'] with platforms = [

Re: How to test the cordova-android 4.0 by mobile spec

Created issue for the splashscreen: https://issues.apache.org/jira/browse/CB-8280 On Thu, Jan 8, 2015 at 1:28 PM, Andrew Grieve wrote: > Yep! Will have a look at this. > > On Thu, Jan 8, 2015 at 11:57 AM, Joe Bowser wrote: > >> That said, the tests failing should be filed as an issue. I think

Re: MobileSpec for testing cordova-lib@rc

If we add node_modules to search path, will we be able to adjust which versions of platforms/plugins it uses just by modifying package.json? Not sure if platforms use search path, or just plugins? Also not sure if we can install plugins from our registry using npm proper, but you can use the git

Re: [All Platforms][CordovaJS] NO_RESULT handling

Don, this change was just proposed and hasn't been implemented yet, so I'm not sure how you see a difference. https://github.com/apache/cordova-ios/compare/3.6.x...3.7.x On Thu, Jan 8, 2015 at 11:02 AM, Don Coleman wrote: > I know this is an old thread but I'm seeing problems with this in my > B

Re: [All Platforms][CordovaJS] NO_RESULT handling

I believe Don's issue is directly related to my recent change in cordova-js [#1], for which there is a reversing pull request [#2] The expectation of what a NO_RESULT meant was not documented, and my change made it so it called the error callback. I will be accepting the pull request today ( and

Re: [Code Review] Gradle Changes

On Thu, Jan 8, 2015 at 2:53 PM, Ian Clelland wrote: > On Tue Jan 06 2015 at 4:09:47 PM Andrew Grieve > wrote: > > > For anyone following the gradle work that's been happening, I have a PR > > that overhauls how settings are overridden. Rather than using custom > > environment variables, it uses

Re: MobileSpec for testing cordova-lib@rc

Nice! Great example of how to use the JS API. On Thu, Jan 8, 2015 at 2:55 PM, Mark Koudritsky wrote: > Josh, thanks for the suggestion. Added it here > < > https://github.com/kamrik/cordova-test-rc/commit/d3a1abeda45357c4cf32b28e6e63cc269d7d3bda > > > as > process.env.HOME = path.join(__dirname,

[GitHub] cordova-lib pull request: Auto save restore for plugins

Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/143#issuecomment-69242088 @agrieve Good catch. It is dumb luck this was working correctly. Updated the PR --- If your project is set up for it, you can reply to this email and have your reply

Re: [All Platforms][CordovaJS] NO_RESULT handling

You need to call setKeepCallbackAsBool:TRUE to be able to send subsequent callbacks. If you just don't send a result though, it'll stay waiting. You can remove the NO_RESULT. On Thu, Jan 8, 2015 at 2:02 PM, Don Coleman wrote: > I know this is an old thread but I'm seeing problems with this in m

[GitHub] cordova-plugin-media pull request: CB-8252 Fire audio events from ...

GitHub user jpchase opened a pull request: https://github.com/apache/cordova-plugin-media/pull/41 CB-8252 Fire audio events from native via message channel - Add startup logic to initialize a message channel for native -> Javascript - Applies only to android and amazon-fireos (as

[GitHub] cordova-lib pull request: Auto save restore for plugins

Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/143#issuecomment-69240637 @omefire Correct did that because plugman has its own hooks, I think, it may be useful to keep the config.xml updated for them --- If your project is set up for it,

Re: Reviewboard

sounds good to remove! On Thu, Jan 8, 2015 at 8:46 AM, Michal Mocny wrote: > +1 > > On Wed, Jan 7, 2015 at 4:20 PM, Jesse wrote: > >> Yeah, kill it. gh-pulls are much easier to review I think. >> >> @purplecabbage >> risingj.com >> >> On Wed, Jan 7, 2015 at 1:14 PM, Joe Bowser wrote: >> >> > W

Re: [Vote] Tools Release Jan 6, 2015

Yeah let's get that bug fixed for cordova-ios 3.8.0, it shouldn't stall this Tools release. On Thu, Jan 8, 2015 at 11:38 AM, Jenny Gee wrote: > I'll get started on testing this out today for blackberry, but I'm going to > need just a little bit more time. I hope to have results out EOD tomorrow.

Re: MobileSpec for testing cordova-lib@rc

Josh, thanks for the suggestion. Added it here as process.env.HOME = path.join(__dirname, 'home'); On Thu, Jan 8, 2015 at 2:19 PM, Josh Soref wrote: > Mark Koudritsky wrote: > >Trying to run MobileSpec w

Re: [Code Review] Gradle Changes

On Tue Jan 06 2015 at 4:09:47 PM Andrew Grieve wrote: > For anyone following the gradle work that's been happening, I have a PR > that overhauls how settings are overridden. Rather than using custom > environment variables, it uses Gradle properties. This is exactly what > properties in gradle we

RE: [Vote] Tools Release Jan 6, 2015

I'll get started on testing this out today for blackberry, but I'm going to need just a little bit more time. I hope to have results out EOD tomorrow. From: Sergey Grebnov (Akvelon) [v-seg...@microsoft.com] Sent: Thursday, January 08, 2015 2:31 PM To: dev@c

[GitHub] cordova-lib pull request: Auto save restore for plugins

Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/143#discussion_r22675940 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -206,7 +207,7 @@ module.exports = function plugin(command, targets, opts) {

[GitHub] cordova-lib pull request: CB-8043 CB-6462 CB-6105 Refactor orienta...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/128 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

RE: [Vote] Tools Release Jan 6, 2015

I vote +1: • Verified signatures and hashes • Installed Cordova from archives • Verified ability to create and run Cordova app with android, windows, android and WP8 platforms Thx! Sergey -Original Message- From: agri...@google.com [mailto:agri...@google.com

Re: MobileSpec for testing cordova-lib@rc

Mark Koudritsky wrote: >Trying to run MobileSpec with the tools release candidate yesterday >inspired me to write a script that would do it all with a single command >and a local installation of cordova-lib@rc without affecting the global >install/link. This also turned out to be a good example of

[GitHub] cordova-lib pull request: Link java files

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/142 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

MobileSpec for testing cordova-lib@rc

Trying to run MobileSpec with the tools release candidate yesterday inspired me to write a script that would do it all with a single command and a local installation of cordova-lib@rc without affecting the global install/link. This also turned out to be a good example of how to use cordova via JS

Re: [All Platforms][CordovaJS] NO_RESULT handling

I know this is an old thread but I'm seeing problems with this in my Bluetooth plugins now that people are upgrading. Cordova 4.1.2 with iOS 3.7.0 is broken. NO_RESULT calls the failure callback. After downgrading to Cordova 4.0.0 with iOS 3.6.0 the plugin works as expected. I use NO_RESULT since

Re: Cordova-Android 3.7.0 and 4.0.x releases.

Sounds like this is all good. I'm going to create a 3.7.0 branch today and start committing the fixes for CB-8026 into that. I'm going to hold off on merging 4.0.x into master until I hear back from other people on this thread. On Wed Jan 07 2015 at 2:34:06 PM Joe Bowser wrote: > Hey > > Do we

Re: Cordova-Android 3.7.0 and 4.0.x releases.

Right, I'm still trying to figure out how to get the command line to generate targetApi = 21. That said, I was hoping to have the merges be neater for CB-8026, since the changes are made in two different files, respectively. On Thu Jan 08 2015 at 10:48:50 AM Andrew Grieve wrote: > Yes! Sounds g

Re: Cordova-Android 3.7.0 and 4.0.x releases.

Yes! Sounds good to me! Although I'm not sure there's much point in creating the 3.7.x branch until CB-8026 is resolved and we set targetApi = 21 On Thu, Jan 8, 2015 at 1:44 PM, Joe Bowser wrote: > Sounds like this is all good. I'm going to create a 3.7.0 branch today and > start committing the

Re: [Vote] Tools Release Jan 6, 2015

That's awesome that you found this bug! But I agree with Steve. If it's not a regression, then there's no point in delaying a release. On Thu, Jan 8, 2015 at 1:25 PM, Steven Gill wrote: > That is not something that should stop the tools release. IOS isn't even > being updated in this release. Th

Re: Deprecation Wars: ICS vs Gingerbread

So, since nobody other than me was testing on Gingerbread, and since the tests don't even run on Gingerbread, I think we should stop supporting Gingerbread after 3.7.0. The reason for this is because I have no way to vote or verify that this release is actually good for what we support. It's easie

Re: How to test the cordova-android 4.0 by mobile spec

Yep! Will have a look at this. On Thu, Jan 8, 2015 at 11:57 AM, Joe Bowser wrote: > That said, the tests failing should be filed as an issue. I think this is > related to Andrew's recent refactor of the Splashscreen, removing it from > the core platform. These changes are relatively minor, but

Re: [Vote] Tools Release Jan 6, 2015

That is not something that should stop the tools release. IOS isn't even being updated in this release. The current released tools must have the same issue. This release is about getting users the updated blackberry, ubuntu and windows platform releases. iOS can fix the bug, do a platform release

[GitHub] cordova-lib pull request: Auto save restore for plugins

GitHub user gorkem opened a pull request: https://github.com/apache/cordova-lib/pull/143 Auto save restore for plugins uses .cordova/config.json to automatically save or restore plugins to/from config.xml on a project You can merge this pull request into a Git repository by runnin

Re: Deprecation Wars: ICS vs Gingerbread

Pluggable WebViews will be supported on 2.3, but the only WebView that kind-of works on Android 2.3 right now is MozillaWebView. We did throw the people stuck supporting 2.3 a bone with the work we did with the MozillaWebView work, but given the unstable state of the GeckoView itself, I don't know

Re: Deprecation Wars: ICS vs Gingerbread

The other day I saw a thread of a developer trying to support android 2.2, and told me he was from argentina, was building an app just for argentina and 2.2 had a big market share there. I'm from Spain and 2.3 devices are still sold here. I just tell this to add another point of view, but I'm OK w

Re: [Vote] Tools Release Jan 6, 2015

Fwiw, I just filed a bug against cordova-ios, `cordova platform update ios` isn't working. I'm -1 on shipping with this stuff broken. It's technically a bug in cordova-ios and not the tools, but it pretty much sucks, and it means our tools coverage/testing isn't sufficiently comprehensive. Note

Re: Deprecation Wars: ICS vs Gingerbread

Also I no longer test Gingerbread unless explicitly investigating an issue (and even then, last time was maybe a year ago). CCA apps have never targeted 2.3. On Thu, Jan 8, 2015 at 12:00 PM, Michal Mocny wrote: > My biased 2cents: Gingerbread may still have business sense in some cases, > but f

Re: Deprecation Wars: ICS vs Gingerbread

My biased 2cents: Gingerbread may still have business sense in some cases, but for new cordova apps, I can't see how it is justifiable. If you are maintaining a legacy app, you can stick to your older cordova version. If you are creating a new app that needs to target 2.3 (or 2.2 even) and still

Re: How to test the cordova-android 4.0 by mobile spec

That said, the tests failing should be filed as an issue. I think this is related to Andrew's recent refactor of the Splashscreen, removing it from the core platform. These changes are relatively minor, but can become huge w.r.t. docs and test coverage. On Thu Jan 08 2015 at 8:52:53 AM Michal Mo

Re: How to test the cordova-android 4.0 by mobile spec

It should be, but given that its on a branch (fewer passing eyeballs), the pace of changes on 4.0.x, and that the failing test in question is a manual test, things are easily overlooked. Thanks for bringing it up. Once 3.7 ships and 4.0 moves to master for next major release, I expect the tests w

Re: Reviewboard

+1 On Wed, Jan 7, 2015 at 4:20 PM, Jesse wrote: > Yeah, kill it. gh-pulls are much easier to review I think. > > @purplecabbage > risingj.com > > On Wed, Jan 7, 2015 at 1:14 PM, Joe Bowser wrote: > > > What's reviewboard? > > > > j/k, yeah kill it! > > On Wed Jan 07 2015 at 1:13:55 PM Andrew G

Re: Browser platform and unsupported plugins

Sergey, I think you have it right: use the underlying Browser implementation if possible, or call fail() otherwise is the right solution for cordova-browser implementations. Ripple will stub out its own implementation if it wants to control a fake data stream. Mixing fake data into cordova-browse

[GitHub] cordova-lib pull request: CB-8043 CB-6462 CB-6105 Refactor orienta...

Github user MMrko commented on the pull request: https://github.com/apache/cordova-lib/pull/128#issuecomment-69196226 Rebased on master (0f5dbafface487c5738f294e47520d8b2381134d). I squashed the changes into 3 commits: 6ef506ebd890bf3eca79f8bb034ee9e2ede1c948 Base parser & hel

[GitHub] cordova-plugin-file-transfer pull request: CB-8095 Adds support fo...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/53#issuecomment-69181362 @purplecabbage Done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-js pull request: Fixed callbackFromNative method

Github user mdudek commented on the pull request: https://github.com/apache/cordova-js/pull/98#issuecomment-69168149 Fixed also in cordova_b.js --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-media pull request: iOS play audio in background

Github user doender commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/12#issuecomment-69167497 bump --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] cordova-js pull request: Fixed callbackFromNative method

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-js/pull/98#issuecomment-69151406 It needs to be done here also: https://github.com/apache/cordova-js/blob/master/src/cordova_b.js#L212 --- If your project is set up for it, you can reply t

[GitHub] cordova-plugin-network-information pull request: Fixing early call...

GitHub user geoffgom opened a pull request: https://github.com/apache/cordova-plugin-network-information/pull/23 Fixing early calls connection state Our application requests directly "startup values" over an ajax connection. In the current browser implementation, the network-info