Re: platforms/plugins save and restore from config.xml

2015-01-08 Thread Gorkem Ercan
On 8 Jan 2015, at 17:29, Mefire O. wrote: Hi all, I am a big fan of the experimental save and restore features that are in the CLI and saw that Gorkem has also created another PR (https://github.com/apache/cordova-lib/pull/143 ) to have a setting to auto persist/restore plugin versions

Re: platforms/plugins save and restore from config.xml

2015-01-08 Thread Steven Gill
+1 to remove --experimental On Thu, Jan 8, 2015 at 4:13 PM, Gorkem Ercan gorkem.er...@gmail.com wrote: On 8 Jan 2015, at 17:29, Mefire O. wrote: Hi all, I am a big fan of the experimental save and restore features that are in the CLI and saw that Gorkem has also created another PR (

Re: platforms/plugins save and restore from config.xml

2015-01-08 Thread Brian LeRoux
Yes! Also quick q, are all experimental flags documented somewhere? (Other than code) On Thu, Jan 8, 2015, 6:29 PM Parashuram N (MS OPEN TECH) panar...@microsoft.com wrote: +1 to graduating this out of experimental :) On 1/8/15, 4:25 PM, Steven Gill stevengil...@gmail.com wrote: +1 to

Review: Tools release blog post

2015-01-08 Thread Steven Gill
https://github.com/cordova/apache-blog-posts/blob/master/2015-01-08-tools-release.md PRs welcome!

[GitHub] cordova-android pull request: Make JUnit tests to test pluggable w...

2015-01-08 Thread fujunwei
Github user fujunwei commented on the pull request: https://github.com/apache/cordova-android/pull/140#issuecomment-69277448 ping @clelland Could you please help me review this PR? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on

Re: platforms/plugins save and restore from config.xml

2015-01-08 Thread Gorkem Ercan
cordova help has a section for Experimental Commands they are listed there. Once the save and restore is graduated that section will be empty though. -- Gorkem On 8 Jan 2015, at 21:32, Brian LeRoux wrote: Yes! Also quick q, are all experimental flags documented somewhere? (Other than code)

[GitHub] cordova-plugin-media pull request: CB-8252 Fire audio events from ...

2015-01-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/41 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: platforms/plugins save and restore from config.xml

2015-01-08 Thread Parashuram N (MS OPEN TECH)
+1 to graduating this out of experimental :) On 1/8/15, 4:25 PM, Steven Gill stevengil...@gmail.com wrote: +1 to remove --experimental On Thu, Jan 8, 2015 at 4:13 PM, Gorkem Ercan gorkem.er...@gmail.com wrote: On 8 Jan 2015, at 17:29, Mefire O. wrote: Hi all, I am a big fan of the

Re: MobileSpec for testing cordova-lib@rc

2015-01-08 Thread Steven Gill
Just checked out peer-dependencies. Looks like the way to move forward with handling our dependency issues. Right now, plugman publish creates a package.json file by grabbing info from plugin.xml. Once published, plugman will automatically delete the package.json file. I suggest we stop deleting

[GitHub] cordova-plugin-media pull request: CB-8252 Fire audio events from ...

2015-01-08 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/41#discussion_r22699122 --- Diff: RELEASENOTES.md --- @@ -103,3 +103,7 @@ * CB-7977 Mention `deviceready` in plugin docs * CB-7945 Made media.spec.15 and

Re: Reviewboard

2015-01-08 Thread Andrew Grieve
They are zapped! On Thu, Jan 8, 2015 at 3:04 PM, Shazron shaz...@gmail.com wrote: sounds good to remove! On Thu, Jan 8, 2015 at 8:46 AM, Michal Mocny mmo...@chromium.org wrote: +1 On Wed, Jan 7, 2015 at 4:20 PM, Jesse purplecabb...@gmail.com wrote: Yeah, kill it. gh-pulls are much

[GitHub] cordova-lib pull request: CB-8227 CB8237 CB-8238 Add --save option...

2015-01-08 Thread omefire
GitHub user omefire opened a pull request: https://github.com/apache/cordova-lib/pull/144 CB-8227 CB8237 CB-8238 Add --save option to 'cordova platform add', 'cordova platform remove' and 'cordova platform update' CB-8227 CB8237 CB-8238 Add --save option to 'cordova platform

Re: platforms/plugins save and restore from config.xml

2015-01-08 Thread Josh Soref
Until adding plugins saves the variables provided, we really shouldn't / can't make this non experimental. Sent from my BlackBerry 10 smartphone. ‎ smime.p7s Description: S/MIME cryptographic signature

RE: platforms/plugins save and restore from config.xml

2015-01-08 Thread Mefire O .
+1 on removing the --experimental flag after fixing the 'variables not being saved' bug. Thanks, Mefire -Original Message- From: Josh Soref [mailto:jso...@blackberry.com] Sent: Thursday, January 8, 2015 8:49 PM To: Cordova Dev Subject: Re: platforms/plugins save and restore from

[GitHub] cordova-cli pull request: CB-8227 CB-8237 CB-8238 Add --save optio...

2015-01-08 Thread omefire
GitHub user omefire opened a pull request: https://github.com/apache/cordova-cli/pull/203 CB-8227 CB-8237 CB-8238 Add --save option to 'cordova platform add', 'cordova platform remove' and 'cordova platform update' CB-8227 CB-8237 CB-8238 Add --save option to 'cordova platform

[GitHub] cordova-js pull request: Fixed callbackFromNative method

2015-01-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/98 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Deprecation Wars: ICS vs Gingerbread

2015-01-08 Thread Marcel Kinard
Er, are we looking at the same data? I see Gingerbread at 7.8% and ICS at 6.7% at that URL. Data collected during a 7-day period ending on January 5, 2015. On Jan 7, 2015, at 6:39 PM, Joe Bowser bows...@gmail.com wrote: http://developer.android.com/about/dashboards/index.html#2015 Due to

Re: MobileSpec for testing cordova-lib@rc

2015-01-08 Thread Mark Koudritsky
+1 for publishing plugins to npm We will need to come up with a good naming convention so that translating from plugin id to npm package name would be trivial. Preferably with some stable prefix (like cordova_plugin_) so that it would be easy to distinguish plugins if they are listed with other

[GitHub] cordova-lib pull request: CB-8239 Add support for git urls to 'cor...

2015-01-08 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/141#issuecomment-69271082 @hstaudacher, I've added the remaining scenarios. I've copied over some of the changes you made in this branch and merged them with mine. I'd be

Re: Deprecation Wars: ICS vs Gingerbread

2015-01-08 Thread Michal Mocny
I think Joe was saying that since we usually deprecate at 5%, we are ~2/3% off from that mark. -Michal On Thu, Jan 8, 2015 at 5:08 PM, Marcel Kinard cmarc...@gmail.com wrote: Er, are we looking at the same data? I see Gingerbread at 7.8% and ICS at 6.7% at that URL. Data collected during a

Re: Deprecation Wars: ICS vs Gingerbread

2015-01-08 Thread Joe Bowser
Correct. Next month one of the two will dip, and I think it will be ICS first. However it seems nobody actually tests regularly on 2.3.x, so I'm thinking it's better to be honest about the support we are offering than to say we support something we don't. Unless someone wants to put the time

platforms/plugins save and restore from config.xml

2015-01-08 Thread Mefire O .
Hi all, I am a big fan of the experimental save and restore features that are in the CLI and saw that Gorkem has also created another PR (https://github.com/apache/cordova-lib/pull/143 ) to have a setting to auto persist/restore plugin versions which is a really interesting idea. On a

Re: platforms/plugins save and restore from config.xml

2015-01-08 Thread Darryl Pogue
On 8 January 2015 at 14:29, Mefire O. ommen...@microsoft.com wrote: I am a big fan of the experimental save and restore features that are in the CLI and saw that Gorkem has also created another PR (https://github.com/apache/cordova-lib/pull/143 ) to have a setting to auto persist/restore

Re: platforms/plugins save and restore from config.xml

2015-01-08 Thread Josh Soref
I just ‎filed  ‎https://issues.apache.org/jira/browse/CB-8278 about readding platforms after installing a plugin with variables.. It definitely needs to be fixed.  @sgill: I guess this also doesn't block the release because we probably shipped with this bug in a previous plugman. Unless

Re: platforms/plugins save and restore from config.xml

2015-01-08 Thread Steven Gill
Correct Josh. Good call on filing the bug. Definitely needs to get fixed soon. On Thu, Jan 8, 2015 at 2:58 PM, Josh Soref jso...@blackberry.com wrote: I just filed https://issues.apache.org/jira/browse/CB-8278 about readding platforms after installing a plugin with variables.. It definitely

Re: MobileSpec for testing cordova-lib@rc

2015-01-08 Thread Steven Gill
This is rad! Definitely a great example showing the JS API. I am thinking about also starting to publish our plugins to npm and add a flag to plugman install to fetch from npm instead of cordova plugins registry. Thoughts? On Thu, Jan 8, 2015 at 1:09 PM, Mark Koudritsky kam...@google.com wrote:

[GitHub] cordova-plugin-media pull request: iOS play audio in background

2015-01-08 Thread doender
Github user doender commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/12#issuecomment-69167497 bump --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-js pull request: Fixed callbackFromNative method

2015-01-08 Thread mdudek
Github user mdudek commented on the pull request: https://github.com/apache/cordova-js/pull/98#issuecomment-69168149 Fixed also in cordova_b.js --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-network-information pull request: Fixing early call...

2015-01-08 Thread geoffgom
GitHub user geoffgom opened a pull request: https://github.com/apache/cordova-plugin-network-information/pull/23 Fixing early calls connection state Our application requests directly startup values over an ajax connection. In the current browser implementation, the

[GitHub] cordova-js pull request: Fixed callbackFromNative method

2015-01-08 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-js/pull/98#issuecomment-69151406 It needs to be done here also: https://github.com/apache/cordova-js/blob/master/src/cordova_b.js#L212 --- If your project is set up for it, you can reply

[GitHub] cordova-plugin-file-transfer pull request: CB-8095 Adds support fo...

2015-01-08 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/53#issuecomment-69181362 @purplecabbage Done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

Re: Deprecation Wars: ICS vs Gingerbread

2015-01-08 Thread julio cesar sanchez
The other day I saw a thread of a developer trying to support android 2.2, and told me he was from argentina, was building an app just for argentina and 2.2 had a big market share there. I'm from Spain and 2.3 devices are still sold here. I just tell this to add another point of view, but I'm OK

[GitHub] cordova-lib pull request: Auto save restore for plugins

2015-01-08 Thread gorkem
GitHub user gorkem opened a pull request: https://github.com/apache/cordova-lib/pull/143 Auto save restore for plugins uses .cordova/config.json to automatically save or restore plugins to/from config.xml on a project You can merge this pull request into a Git repository by

Re: Deprecation Wars: ICS vs Gingerbread

2015-01-08 Thread Joe Bowser
Pluggable WebViews will be supported on 2.3, but the only WebView that kind-of works on Android 2.3 right now is MozillaWebView. We did throw the people stuck supporting 2.3 a bone with the work we did with the MozillaWebView work, but given the unstable state of the GeckoView itself, I don't

Re: [Vote] Tools Release Jan 6, 2015

2015-01-08 Thread Steven Gill
That is not something that should stop the tools release. IOS isn't even being updated in this release. The current released tools must have the same issue. This release is about getting users the updated blackberry, ubuntu and windows platform releases. iOS can fix the bug, do a platform release

Re: How to test the cordova-android 4.0 by mobile spec

2015-01-08 Thread Andrew Grieve
Yep! Will have a look at this. On Thu, Jan 8, 2015 at 11:57 AM, Joe Bowser bows...@gmail.com wrote: That said, the tests failing should be filed as an issue. I think this is related to Andrew's recent refactor of the Splashscreen, removing it from the core platform. These changes are

Re: Deprecation Wars: ICS vs Gingerbread

2015-01-08 Thread Joe Bowser
So, since nobody other than me was testing on Gingerbread, and since the tests don't even run on Gingerbread, I think we should stop supporting Gingerbread after 3.7.0. The reason for this is because I have no way to vote or verify that this release is actually good for what we support. It's

Re: [Vote] Tools Release Jan 6, 2015

2015-01-08 Thread Andrew Grieve
That's awesome that you found this bug! But I agree with Steve. If it's not a regression, then there's no point in delaying a release. On Thu, Jan 8, 2015 at 1:25 PM, Steven Gill stevengil...@gmail.com wrote: That is not something that should stop the tools release. IOS isn't even being

[GitHub] cordova-lib pull request: CB-8043 CB-6462 CB-6105 Refactor orienta...

2015-01-08 Thread MMrko
Github user MMrko commented on the pull request: https://github.com/apache/cordova-lib/pull/128#issuecomment-69196226 Rebased on master (0f5dbafface487c5738f294e47520d8b2381134d). I squashed the changes into 3 commits: 6ef506ebd890bf3eca79f8bb034ee9e2ede1c948 Base parser

Re: Deprecation Wars: ICS vs Gingerbread

2015-01-08 Thread Michal Mocny
Also I no longer test Gingerbread unless explicitly investigating an issue (and even then, last time was maybe a year ago). CCA apps have never targeted 2.3. On Thu, Jan 8, 2015 at 12:00 PM, Michal Mocny mmo...@chromium.org wrote: My biased 2cents: Gingerbread may still have business sense in

Re: [Vote] Tools Release Jan 6, 2015

2015-01-08 Thread Josh Soref
Fwiw, I just filed a bug against cordova-ios, `cordova platform update ios` isn't working. I'm -1 on shipping with this stuff broken. It's technically a bug in cordova-ios and not the tools, but it pretty much sucks, and it means our tools coverage/testing isn't sufficiently comprehensive. Note

Re: How to test the cordova-android 4.0 by mobile spec

2015-01-08 Thread Joe Bowser
That said, the tests failing should be filed as an issue. I think this is related to Andrew's recent refactor of the Splashscreen, removing it from the core platform. These changes are relatively minor, but can become huge w.r.t. docs and test coverage. On Thu Jan 08 2015 at 8:52:53 AM Michal

Re: Deprecation Wars: ICS vs Gingerbread

2015-01-08 Thread Michal Mocny
My biased 2cents: Gingerbread may still have business sense in some cases, but for new cordova apps, I can't see how it is justifiable. If you are maintaining a legacy app, you can stick to your older cordova version. If you are creating a new app that needs to target 2.3 (or 2.2 even) and still

Re: Browser platform and unsupported plugins

2015-01-08 Thread Michal Mocny
Sergey, I think you have it right: use the underlying Browser implementation if possible, or call fail() otherwise is the right solution for cordova-browser implementations. Ripple will stub out its own implementation if it wants to control a fake data stream. Mixing fake data into

Re: Cordova-Android 3.7.0 and 4.0.x releases.

2015-01-08 Thread Andrew Grieve
Yes! Sounds good to me! Although I'm not sure there's much point in creating the 3.7.x branch until CB-8026 is resolved and we set targetApi = 21 On Thu, Jan 8, 2015 at 1:44 PM, Joe Bowser bows...@gmail.com wrote: Sounds like this is all good. I'm going to create a 3.7.0 branch today and

Re: Cordova-Android 3.7.0 and 4.0.x releases.

2015-01-08 Thread Joe Bowser
Right, I'm still trying to figure out how to get the command line to generate targetApi = 21. That said, I was hoping to have the merges be neater for CB-8026, since the changes are made in two different files, respectively. On Thu Jan 08 2015 at 10:48:50 AM Andrew Grieve agri...@chromium.org

Re: Cordova-Android 3.7.0 and 4.0.x releases.

2015-01-08 Thread Joe Bowser
Sounds like this is all good. I'm going to create a 3.7.0 branch today and start committing the fixes for CB-8026 into that. I'm going to hold off on merging 4.0.x into master until I hear back from other people on this thread. On Wed Jan 07 2015 at 2:34:06 PM Joe Bowser bows...@gmail.com wrote:

Re: [All Platforms][CordovaJS] NO_RESULT handling

2015-01-08 Thread Don Coleman
I know this is an old thread but I'm seeing problems with this in my Bluetooth plugins now that people are upgrading. Cordova 4.1.2 with iOS 3.7.0 is broken. NO_RESULT calls the failure callback. After downgrading to Cordova 4.0.0 with iOS 3.6.0 the plugin works as expected. I use NO_RESULT

[GitHub] cordova-lib pull request: Link java files

2015-01-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/142 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: MobileSpec for testing cordova-lib@rc

2015-01-08 Thread Josh Soref
Mark Koudritsky wrote: Trying to run MobileSpec with the tools release candidate yesterday inspired me to write a script that would do it all with a single command and a local installation of cordova-lib@rc without affecting the global install/link. This also turned out to be a good example of

[GitHub] cordova-plugin-media pull request: CB-8252 Fire audio events from ...

2015-01-08 Thread jpchase
GitHub user jpchase opened a pull request: https://github.com/apache/cordova-plugin-media/pull/41 CB-8252 Fire audio events from native via message channel - Add startup logic to initialize a message channel for native - Javascript - Applies only to android and amazon-fireos (as

Re: How to test the cordova-android 4.0 by mobile spec

2015-01-08 Thread Andrew Grieve
Created issue for the splashscreen: https://issues.apache.org/jira/browse/CB-8280 On Thu, Jan 8, 2015 at 1:28 PM, Andrew Grieve agri...@chromium.org wrote: Yep! Will have a look at this. On Thu, Jan 8, 2015 at 11:57 AM, Joe Bowser bows...@gmail.com wrote: That said, the tests failing should

Re: [All Platforms][CordovaJS] NO_RESULT handling

2015-01-08 Thread Don Coleman
@Shazron the problem has been around for a while, I've just been avoiding it by running Cordova 4.0.0 / iOS 3.6.0 Changing Line 293 https://github.com/apache/cordova-ios/compare/3.6.x...3.7.x#diff-f151c4cb27b3afeea45c8a625186e011L293 to else is what broke things. @Jessie applying the changes

Re: MobileSpec for testing cordova-lib@rc

2015-01-08 Thread Mark Koudritsky
On Thu, Jan 8, 2015 at 3:47 PM, Michal Mocny mmo...@chromium.org wrote: If we add node_modules to search path, will we be able to adjust which versions of platforms/plugins it uses just by modifying package.json? Since platforms can be added by path. You can replace platforms = ['android']

RE: [Vote] Tools Release Jan 6, 2015

2015-01-08 Thread Sergey Grebnov (Akvelon)
I vote +1: • Verified signatures and hashes • Installed Cordova from archives • Verified ability to create and run Cordova app with android, windows, android and WP8 platforms Thx! Sergey -Original Message- From: agri...@google.com

RE: [Vote] Tools Release Jan 6, 2015

2015-01-08 Thread Jenny Gee
I'll get started on testing this out today for blackberry, but I'm going to need just a little bit more time. I hope to have results out EOD tomorrow. From: Sergey Grebnov (Akvelon) [v-seg...@microsoft.com] Sent: Thursday, January 08, 2015 2:31 PM To:

Re: [Vote] Tools Release Jan 6, 2015

2015-01-08 Thread Shazron
Yeah let's get that bug fixed for cordova-ios 3.8.0, it shouldn't stall this Tools release. On Thu, Jan 8, 2015 at 11:38 AM, Jenny Gee j...@blackberry.com wrote: I'll get started on testing this out today for blackberry, but I'm going to need just a little bit more time. I hope to have results

Re: Reviewboard

2015-01-08 Thread Shazron
sounds good to remove! On Thu, Jan 8, 2015 at 8:46 AM, Michal Mocny mmo...@chromium.org wrote: +1 On Wed, Jan 7, 2015 at 4:20 PM, Jesse purplecabb...@gmail.com wrote: Yeah, kill it. gh-pulls are much easier to review I think. @purplecabbage risingj.com On Wed, Jan 7, 2015 at 1:14 PM,

Re: MobileSpec for testing cordova-lib@rc

2015-01-08 Thread Andrew Grieve
Nice! Great example of how to use the JS API. On Thu, Jan 8, 2015 at 2:55 PM, Mark Koudritsky kam...@google.com wrote: Josh, thanks for the suggestion. Added it here https://github.com/kamrik/cordova-test-rc/commit/d3a1abeda45357c4cf32b28e6e63cc269d7d3bda as process.env.HOME =

Re: [All Platforms][CordovaJS] NO_RESULT handling

2015-01-08 Thread Jesse
I believe Don's issue is directly related to my recent change in cordova-js [#1], for which there is a reversing pull request [#2] The expectation of what a NO_RESULT meant was not documented, and my change made it so it called the error callback. I will be accepting the pull request today ( and

[GitHub] cordova-lib pull request: Auto save restore for plugins

2015-01-08 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/143#discussion_r22675940 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -206,7 +207,7 @@ module.exports = function plugin(command, targets, opts) {

[GitHub] cordova-lib pull request: CB-8043 CB-6462 CB-6105 Refactor orienta...

2015-01-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/128 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [Code Review] Gradle Changes

2015-01-08 Thread Ian Clelland
On Tue Jan 06 2015 at 4:09:47 PM Andrew Grieve agri...@chromium.org wrote: For anyone following the gradle work that's been happening, I have a PR that overhauls how settings are overridden. Rather than using custom environment variables, it uses Gradle properties. This is exactly what

Re: MobileSpec for testing cordova-lib@rc

2015-01-08 Thread Mark Koudritsky
Josh, thanks for the suggestion. Added it here https://github.com/kamrik/cordova-test-rc/commit/d3a1abeda45357c4cf32b28e6e63cc269d7d3bda as process.env.HOME = path.join(__dirname, 'home'); On Thu, Jan 8, 2015 at 2:19 PM, Josh Soref jso...@blackberry.com wrote: Mark Koudritsky wrote: Trying to

[GitHub] cordova-lib pull request: Auto save restore for plugins

2015-01-08 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/143#issuecomment-69240637 @omefire Correct did that because plugman has its own hooks, I think, it may be useful to keep the config.xml updated for them --- If your project is set up for it,

[GitHub] cordova-lib pull request: Auto save restore for plugins

2015-01-08 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/143#issuecomment-69242088 @agrieve Good catch. It is dumb luck this was working correctly. Updated the PR --- If your project is set up for it, you can reply to this email and have your

Re: [Code Review] Gradle Changes

2015-01-08 Thread Andrew Grieve
On Thu, Jan 8, 2015 at 2:53 PM, Ian Clelland iclell...@chromium.org wrote: On Tue Jan 06 2015 at 4:09:47 PM Andrew Grieve agri...@chromium.org wrote: For anyone following the gradle work that's been happening, I have a PR that overhauls how settings are overridden. Rather than using custom