Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/6#discussion_r22960109
--- Diff: node_modules/.bin/shjs ---
@@ -1 +1,15 @@
-../shelljs/bin/shjs
--- End diff --
For offline installs you still need to
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-browser/pull/6#issuecomment-69970299
@nikhilkh: please use `git rebase` to fold the fixes for 2d77f2b into
aad4c25
---
If your project is set up for it, you can reply to this email and have your
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/6#discussion_r22959941
--- Diff: node_modules/.bin/shjs ---
@@ -1 +1,15 @@
-../shelljs/bin/shjs
--- End diff --
@mmocny : checking them in is the only way
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-test-framework/pull/6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/6#discussion_r22961441
--- Diff: node_modules/.bin/shjs ---
@@ -1 +1,15 @@
-../shelljs/bin/shjs
--- End diff --
Good question @mmocny and you're not the
Github user basvanbeek commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/20#issuecomment-69969853
@purplecabbage so while the Android API has implemented a method to easily
get the Manufacturer name from the device, we are declined to reach that
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/6#discussion_r22960012
--- Diff: node_modules/.bin/shjs ---
@@ -1 +1,15 @@
-../shelljs/bin/shjs
--- End diff --
@nikhilkh : i would prefer you split it into a
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/20#issuecomment-69973766
I am not waiving it away, or neglecting it, just stating my opinion of it's
relative value.
If others feel strongly for it then by all means, we
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/20#issuecomment-69971601
Personally, I don't think exposing this is a good thing. And if the UA
already exposes this junk, then, I'd rather people sniff it so that they're
aware
For those joining the thread late - Here's the Google doc link that's trying to
consolidate the conversation:
https://docs.google.com/document/d/1qKjhzSf48ybGg2GFZPtjXP8dkF4Z5Jnc7FU41V3-jFc/edit
-Chuck
-Original Message-
From: Chuck Lantz [mailto:cla...@microsoft.com]
Sent: Wednesday,
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-test-framework/pull/8
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/6#discussion_r22968802
--- Diff: www/main.js ---
@@ -215,6 +237,12 @@ function createEnablerList() {
enablerList.appendChild(checkButtonBar);
You may also want to mention you tried to factor this conversation into the
google doc and repoint them to it once you're done editing.
Before you do that, I'd also add our proposed plugin syntax in that section
before you send it out. Maybe use strikethrough on the XML section with the
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-browser/pull/6#issuecomment-69970475
well, err, specifically: for lines you're adding in aad4c25 with bad
whitespace, you should fold in the fixes from 2d77f2b. If you're fixing the
entire file, you
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/6#discussion_r22968690
--- Diff: www/main.js ---
@@ -225,6 +253,43 @@ function createEnablerList() {
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-device/pull/20#discussion_r22973090
--- Diff: src/blackberry10/index.js ---
@@ -57,6 +57,7 @@ module.exports = {
modelName = getModelName(),
uuid =
Looking at the Hooks read me at
https://github.com/apache/cordova-lib/blob/master/cordova-lib/templates/hooks-README.md.
Looks like after_plugin_uninstall is missing from the list. I'm assuming
it's supposed to be there? Let me know and I'll make the change.
John M. Wargo
-Original
All,
I have incorporated feedback into the Google docs as suggested by others.
Please, cast another look.
For reviews/ comments/suggestions, please take a look at :
https://docs.google.com/document/d/1qKjhzSf48ybGg2GFZPtjXP8dkF4Z5Jnc7FU41V3-jFc/edit
It seems to me like most people agree with
Josh - John is actually talking about after plugin *uninstall*, not install.
On Wed, Jan 14, 2015 at 4:40 PM, Josh Soref jso...@blackberry.com wrote:
John wrote:
Looking at the Hooks read me at
https://github.com/apache/cordova-lib/blob/master/cordova-lib/templates/hooks-README.md
.
John wrote:
Looking at the Hooks read me at
https://github.com/apache/cordova-lib/blob/master/cordova-lib/templates/hooks-README.md.
Looks like after_plugin_uninstall is missing from the list.
I'm assuming it's supposed to be there? Let me know and I'll make the change.
I noticed that sometime ago - my thinking is, there is no more context
(.opts.plugin object) really after the plugin is uninstalled, that's why
the hook is not there.
On Wed, Jan 14, 2015 at 4:27 PM, Wargo, John john.wa...@sap.com wrote:
Looking at the Hooks read me at
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/40#issuecomment-70025695
I think you added the check wrongly - you added it to setVolume?
As for tests, we have a bunch of auto tests written in jasmine:
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-browser/pull/6#issuecomment-70004026
@jsoref Thanks for reviewing this and the instructions for doing the git
magic. It was useful. I have made the changes that you requested.
---
If your project
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/148#issuecomment-70015916
Task for docs update : https://issues.apache.org/jira/browse/CB-8308
I'll probably send another PR for that by the end of the week.
---
If your project is set
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/40#discussion_r22986048
--- Diff: www/Media.js ---
@@ -149,9 +149,21 @@ Media.prototype.release = function() {
* Adjust the volume.
*/
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/40#discussion_r22986072
--- Diff: www/Media.js ---
@@ -149,9 +149,21 @@ Media.prototype.release = function() {
* Adjust the volume.
*/
Github user whitecolor commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/40#issuecomment-70030634
Sorry, my bad, would you like me to do a rebase or fixing commit on top?
---
If your project is set up for it, you can reply to this email and have your
GitHub user jpchase opened a pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/8
CB-8295 Enable CSP for mobile spec
- Uses a javascript include file (provided by mobile spec app) to
document.write a CSP tag on page
- If hosted outside of mobile spec,
Github user IngusSkaistkalns commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/20#issuecomment-70050191
@purplecabbage - maybe, but how do you expect to get string `samsung` from
string like this - `Mozilla/5.0 (Linux; U; Android 4.4.2; en-gb;
Sync your repos before the time comes
https://blogs.apache.org/infra/entry/downtime_notice_for_the_r
Either way is fine.
@purplecabbage
risingj.com
On Wed, Jan 14, 2015 at 6:27 PM, whitecolor g...@git.apache.org wrote:
Github user whitecolor commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/40#issuecomment-70030634
Sorry, my bad, would you like me to
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/20#issuecomment-69961610
The user-agent has adequate information to handle this.
-1
---
If your project is set up for it, you can reply to this email and have your
reply
Glad to meet you, thanks for the patch!
On Tue, Jan 13, 2015 at 8:54 PM, Andrew Grieve agri...@chromium.org wrote:
Welcome Nikhil!
On Tue, Jan 13, 2015 at 4:59 PM, Steven Gill stevengil...@gmail.com
wrote:
Welcome Nikhil!
On Tue, Jan 13, 2015 at 1:56 PM, Nikhil Khandelwal
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-android/pull/143#issuecomment-69948386
Addressed all CR notes, @agrieve could you please take a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-android/pull/143#issuecomment-69948911
Rebased on top of master branch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/6#discussion_r22957388
--- Diff: node_modules/.bin/shjs ---
@@ -1 +1,15 @@
-../shelljs/bin/shjs
--- End diff --
Why are node_modules even checked in?
GitHub user jsoref opened a pull request:
https://github.com/apache/cordova-blackberry/pull/180
CB-8306 Fix parseUri to handle http://foo/bar?a...@b.comwhatever
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-js/pull/101
CB-8302 Added `npm test` script
JIRA item: https://issues.apache.org/jira/browse/CB-8302
You can merge this pull request into a Git repository by running:
$ git pull
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/113#issuecomment-69891183
I currently get a `Missing semicolon.` error in `src/android/exec.js` when
I run createmobilespec. This may be fixed in the latest version: please merge
Github user IngusSkaistkalns commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/20#issuecomment-69907763
Real life use-case: App for displaying specific ads on mobile devices in
stores. Manager installs this app, thats acts like a screensaver/daydream
40 matches
Mail list logo
