Re: anybody from phonegap build team here?

2015-01-16 Thread Ally Ogilvie
Julio, This might help you http://community.phonegap.com/nitobi/topics/please-upgrade-your-phonegap-build-account-to-submit-a-plugin You understand correct. However, it's not all bad news: You can still upload your plugin to the Cordova Registry and recommend to your users they add

[GitHub] cordova-android pull request: CB-8201 Add support for auth dialogs...

2015-01-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/143 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-android pull request: CB-8201 Add support for auth dialogs...

2015-01-16 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-android/pull/143#issuecomment-70233057 Done. @agrieve thx for review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: anybody from phonegap build team here?

2015-01-16 Thread julio cesar sanchez
Ally, thanks for the link, I opened another thread and got a similar answer. (I should have searched). It's sad because I submited some plugins when having a paid plan wasn't necessary for submitting plugins. One of them was approved and it's used by more than 5000 apps. Now I can't update the

[GitHub] cordova-android pull request: Make JUnit tests to test pluggable w...

2015-01-16 Thread fujunwei
Github user fujunwei commented on the pull request: https://github.com/apache/cordova-android/pull/140#issuecomment-70243782 ping @clelland PTAL, Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-mobile-spec pull request: CB-8131 Rewrote non plugin auto ...

2015-01-16 Thread alsorokin
Github user alsorokin commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/113#issuecomment-70258752 I've rebased this. No error for me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-docs pull request: CB-8318 Add translation validation tool

2015-01-16 Thread kant2002
GitHub user kant2002 opened a pull request: https://github.com/apache/cordova-docs/pull/260 CB-8318 Add translation validation tool Tool verifies that all links are present in the translation You can merge this pull request into a Git repository by running: $ git pull

Re: Created a plugin to help with local plugin development

2015-01-16 Thread Carlos Santana
My impression was that after uninstall didn't made sense to implement, since the hook declare via plugin.xml and all related files don't exist so there is nothing to run. The only valid case would be for hooks defined in directory, if they want to listen to uninstall events for any plugin. On

RE: anybody from phonegap build team here?

2015-01-16 Thread Ally Ogilvie
The plugin I try to maintain is used in over 61,000 apps on PhoneGap Build alone. I feel your pain. :) Please be vocal about it. Sent from my Windows PhoneFrom: julio cesar sanchez Sent: ‎16/‎01/‎2015 19:53 To: dev@cordova.apache.org Subject: Re: anybody from phonegap build team here? Ally,

Re: Thought on improving translation and docs

2015-01-16 Thread Andrey Kurdumov
First tool which is could verify links in translation is ready. Pull request is ready https://github.com/apache/cordova-docs/pull/260 . 08 Янв 2015 г. 11:31 пользователь Andrey Kurdumov kant2...@googlemail.com написал: @Marcel Thanks for feedback and don't worry you don't hurt me. What I want

CI for cordova-js and cordova-cli

2015-01-16 Thread Alexander Sorokin
Hi Guys, I like the cordova-lib CI via Travis and AppVeyor. I would like to add this feature to cordova-js and cordova-cli. I've proposed Travis and AppVeyor scripts to these repositories. Now they are merged into master. I assume the next step is to wire Travis and AppVeyor to repositories.

[GitHub] cordova-blackberry pull request: CB-8306 Fix parseUri to handle ht...

2015-01-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-blackberry/pull/180 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: CI for cordova-js and cordova-cli

2015-01-16 Thread Jesse
Underway for Cordova-js. I created an issue with infra to setup the integration. Issue# to follow once I am at a computer. On Jan 16, 2015, at 9:04 AM, Alexander Sorokin alexander.soro...@akvelon.com wrote: Hi Guys, I like the cordova-lib CI via Travis and AppVeyor. I would like to

RE: Cordova --list option implementation

2015-01-16 Thread Murat Sutunc
All issues addressed, changes can be merged now. -Original Message- From: Murat Sutunc [mailto:mura...@microsoft.com] Sent: Sunday, January 11, 2015 11:53 PM To: dev@cordova.apache.org Subject: RE: Cordova --list option implementation I've made the changes wrt what has been discussed:

[GitHub] cordova-cli pull request: CB-8168 --list support for CLI

2015-01-16 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/205#discussion_r23103005 --- Diff: doc/run.txt --- @@ -1,13 +1,14 @@ Synopsis -cordova-cli run [BUILD] [PROD] [TARGET] [EXP] [PLATS] [-- POPTS] +

[GitHub] cordova-cli pull request: CB-8168 --list support for CLI

2015-01-16 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/205#discussion_r23103109 --- Diff: doc/run.txt --- @@ -1,13 +1,14 @@ Synopsis -cordova-cli run [BUILD] [PROD] [TARGET] [EXP] [PLATS] [-- POPTS] +

[GitHub] cordova-cli pull request: CB-8168 --list support for CLI

2015-01-16 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/205#discussion_r23103169 --- Diff: doc/run.txt --- @@ -20,6 +21,10 @@ Deploys app on specified platform devices / emulators --emulator . Deploy to

[GitHub] cordova-cli pull request: CB-8168 --list support for CLI

2015-01-16 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/205#discussion_r23103253 --- Diff: doc/run.txt --- @@ -1,13 +1,14 @@ Synopsis -cordova-cli run [BUILD] [PROD] [TARGET] [EXP] [PLATS] [-- POPTS] +

[GitHub] cordova-cli pull request: CB-8168 --list support for CLI

2015-01-16 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/205#discussion_r23103363 --- Diff: src/cli.js --- @@ -206,12 +207,13 @@ function cli(inputArgs) { // calling into platform code should be dealing with this based

[GitHub] cordova-cli pull request: CB-8168 --list support for CLI

2015-01-16 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/205#discussion_r23103480 --- Diff: src/cli.js --- @@ -220,6 +222,11 @@ function cli(inputArgs) { } opts.options = downstreamArgs.concat(unparsedArgs);

RE: Cordova --list option implementation

2015-01-16 Thread Josh Soref
No. That's not really how it goes. And I'd like people to understand this. Things don't just go in the moment there aren't comments. In general, we give people time to review. And sometimes someone will put a +1 saying I think it's ready. I'm sorry that I didn't give all my comments at once. I

RE: Cordova --list option implementation

2015-01-16 Thread Murat Sutunc
Oh.. I've addressed the issues couple times and I thought you reviewed the previous changes. Didn't mean to be pushy, sorry about that. I have a question regarding the CR process. I've searched up the wiki but couldn't find a good answer for this. When addressing issues, is it ok to create a

[GitHub] cordova-docs pull request: CB-8318 Add translation validation tool

2015-01-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/260 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: Thought on improving translation and docs

2015-01-16 Thread Andrew Grieve
merged On Fri, Jan 16, 2015 at 1:06 PM, Andrey Kurdumov kant2...@googlemail.com wrote: First tool which is could verify links in translation is ready. Pull request is ready https://github.com/apache/cordova-docs/pull/260 . 08 Янв 2015 г. 11:31 пользователь Andrey Kurdumov

RE: Cordova --list option implementation

2015-01-16 Thread Josh Soref
You should be doing git commit --amend in general. Rebase is mostly important when someone else committed code and you want to have that code too. We want you to rebase your changes onto those changes. (It's also helpful for when you want to safely split out changes into distinct commits, e.g.

Re: Cordova --list option implementation

2015-01-16 Thread Murat Sutunc
Im actually doing git --amend now but everytime I push the history is lost due to force push. github is not able to save/rebase previous comments. Wish there was a better solution for this. Sent from my iPhone On Jan 16, 2015, at 11:51 AM, Josh Soref jso...@blackberry.com wrote: You should

Re: Thought on improving translation and docs

2015-01-16 Thread Andrey Kurdumov
I remember about deduping. I thought about it in context of translation. Even if I will dedupe them I have to provide infrastructure for providing localized version of images. For that I have to create additional processing step. Some resources should be shared like CSS for example. Not have clear

[GitHub] cordova-cli pull request: CB-8168 --list support for CLI

2015-01-16 Thread muratsu
Github user muratsu commented on the pull request: https://github.com/apache/cordova-cli/pull/205#issuecomment-70330630 @jsoref please take a look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

Re: CI for cordova-js and cordova-cli

2015-01-16 Thread Jesse
The issue I created for infra is here: INFRA-9017 [1] Unfortunately they are claiming to not support AppVeyor, and saying they don't do anything special for TravisCI. Please vote up this issue. Cheers, Jesse [1] https://issues.apache.org/jira/browse/INFRA-9017 @purplecabbage risingj.com

[GitHub] cordova-wp8 pull request: CB-8310: Fix to cordova run wp8 to attem...

2015-01-16 Thread nikhilkh
GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-wp8/pull/70 CB-8310: Fix to cordova run wp8 to attempt to deploy to device before it... This change makes the cordova run wp8 behavior similar to Android. It attempts to deploy to device before trying the

[GitHub] cordova-browser pull request: CB-8224: Add support to launch a spe...

2015-01-16 Thread nikhilkh
GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-browser/pull/8 CB-8224: Add support to launch a specified browser using --target switch... With this change there is support for multiple browsers on Windows, Mac and Linux. I have tried my best to keep

[GitHub] cordova-mobile-spec pull request: CB-8131 Rewrote non plugin auto ...

2015-01-16 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/113#issuecomment-70349610 On OSX, everything is green. On Windows, everything except Whitelist is green. On Whitelist I'm seeing an error, `... encountered a declaration exception`