GitHub user dpogue opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/60
CB-5059 Add a CookieManager abstraction for pluggable webviews.
This allows FileTransfer to correctly use webview cookies regardless of
which webview engine is in use.
/
Hi Joe,
>
> The tests don't work with Crosswalk because Crosswalk's main class doesn't
> inherit from a view. This is why we had to change the CordovaWebView
> from being a class to being an Interface in the first place. I don't think
> there is
> a way for these tests to work with Crosswalk be
GitHub user dblotsky opened a pull request:
https://github.com/apache/cordova-medic/pull/24
[INFRA-8588] Fixing build script bugs, with a focus on OS X.
Adding install step for `cordova-js` and running `createmobilespec.js`
directly with `node` instead of running it from command-lin
Github user dpogue commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/151#discussion_r23665411
--- Diff: framework/src/org/apache/cordova/ICordovaCookieManager.java ---
@@ -0,0 +1,45 @@
+/*
+ Licensed to the Apache Software Foundati
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/151#discussion_r23665332
--- Diff: framework/src/org/apache/cordova/ICordovaCookieManager.java ---
@@ -0,0 +1,45 @@
+/*
+ Licensed to the Apache Software Founda
Github user dpogue commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/151#discussion_r23664825
--- Diff: framework/src/org/apache/cordova/ICordovaCookieManager.java ---
@@ -0,0 +1,45 @@
+/*
+ Licensed to the Apache Software Foundati
Hey All,
In preparation of the upcoming hangout this Thursday, here is my proposal
on publishing plugins to npm (Phase 1) and adding a top level package.json
into every cordova project (Phase 2).
https://docs.google.com/document/d/1M0L4RHp8U6T_TZANaGz20RwLDulM1_iE56osU-o_bUU/edit?usp=sharing
Look
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-browser/pull/8#issuecomment-71756729
I rebased and updated this change. I would love someone to review this.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
r
Looking at the plugin guide at
http://cordova.apache.org/docs/en/4.0.0/plugin_ref_spec.md.html the first
sentence on the page refers to a Cordova Plugin Namespace page that no longer
exists: http://apache.org/cordova/ns/plugins/1.0.
Anyone know what happened to it?
--
*John M. Wargo*
www.john
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-windows/pull/55#issuecomment-71734265
This may be better served living in cordova-coho which is the tool that we
use to package a release.
Or possibly have the generate_certificate.js call `
Github user kirkshoop commented on the pull request:
https://github.com/apache/cordova-windows/pull/55#issuecomment-71731795
@purplecabbage Yes, this does add a dependency on node-forge, but only for
publishing the platform, not when using it. Thus the node-forge package has not
been
What exactly would this flag do underneath? I suppose it will add the crosswalk
plugin and run it's tests. Am I missing anything else?
> On Jan 27, 2015, at 12:29 PM, Jesse wrote:
>
> If you know there will be more, wouldn't it be simpler to just do something
> like :
> --webview=crosswalk // ?
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-windows/pull/55#issuecomment-71725852
I believe this still makes node-forge a dependency.
Running `npm install` will install all 'dependencies' and all
'devDependencies' and the only way to p
If you know there will be more, wouldn't it be simpler to just do something
like :
--webview=crosswalk // ?
Just a small thing.
@purplecabbage
risingj.com
On Tue, Jan 27, 2015 at 12:23 PM, Andrew Grieve
wrote:
> I think that would be manageable. Especially since right now there is only
> 1.
>
I think that would be manageable. Especially since right now there is only
1.
On Tue, Jan 27, 2015 at 2:16 PM, Joe Bowser wrote:
> I don't know if we want to do that, then we'd have to create flags for
> every potential third party webview.
>
> On Tue Jan 27 2015 at 7:03:28 AM Andrew Grieve
> w
I don't know if we want to do that, then we'd have to create flags for
every potential third party webview.
On Tue Jan 27 2015 at 7:03:28 AM Andrew Grieve wrote:
> Sounds good. We should add a --crosswalk flag to createmobilespec.sh :)
>
> On Tue, Jan 27, 2015 at 2:07 AM, Hu, Ningxin wrote:
>
>
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/55#issuecomment-71706426
looks great!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user kirkshoop commented on the pull request:
https://github.com/apache/cordova-windows/pull/55#issuecomment-71703538
@sgrebnov I changed the code to only use node-forge if it is installed. I
tried `npm install --production` and the console reported that the certificate
was not
Github user kirkshoop commented on the pull request:
https://github.com/apache/cordova-browser/pull/9#issuecomment-71700549
@jsoref Thanks for the comments, please see my updates
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user kirkshoop commented on the pull request:
https://github.com/apache/cordova-browser/pull/9#issuecomment-71700446
I agree that duplicating functionality has consequences.
I would like to understand the scenarios that `cordova serve` supports. If
the existing `cordova ser
Github user kirkshoop commented on the pull request:
https://github.com/apache/cordova-browser/pull/9#issuecomment-71698886
rebased the commits to master and changes the messages.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user sandstrom commented on the pull request:
https://github.com/apache/cordova-plugins/pull/18#issuecomment-71673165
@shazron friendly ping!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user sandstrom commented on the pull request:
https://github.com/apache/cordova-plugins/pull/15#issuecomment-71672888
@clelland @shazron sorry for the prodding, but is there any chance you can
take a look at this?
---
If your project is set up for it, you can reply to this ema
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/151#discussion_r23613974
--- Diff: framework/src/org/apache/cordova/ICordovaCookieManager.java ---
@@ -0,0 +1,45 @@
+/*
+ Licensed to the Apache Software Foundat
Sounds good. We should add a --crosswalk flag to createmobilespec.sh :)
On Tue, Jan 27, 2015 at 2:07 AM, Hu, Ningxin wrote:
> Hi Joe,
>
> >
> > Crosswalk has its own release schedule, so it should have its own test
> project
> > somewhere that tests the interfaces that it implements. Of course,
Github user oliversalzburg commented on the pull request:
https://github.com/apache/cordova-wp8/pull/66#issuecomment-71624489
@purplecabbage That sounds like a good idea. I'll do that, rebase on top
master and replace this feature branch. But it could take me a couple of hours
until I
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-wp8/pull/66#issuecomment-71620695
@oliversalzburg Oops, My last change to add the comment looks like it means
this has to be rebased.
I will pull this in, but I have one more small change.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-wp8/pull/74
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-wp8/pull/74
Add comment block to explain the intent of this code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/purplecabbage/cordova-wp8 annota
Github user oliversalzburg commented on the pull request:
https://github.com/apache/cordova-wp8/pull/66#issuecomment-71618719
While I was looking into this, I realized what my original intention for
this change was. There is a certain period before `cordova-plugin-console` is
register
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-wp8/pull/73#issuecomment-71616866
I'll add a comment to the code to make it more obvious. Sorry for not
doing this sooner.
---
If your project is set up for it, you can reply to this email and
Github user oliversalzburg commented on the pull request:
https://github.com/apache/cordova-wp8/pull/73#issuecomment-71616569
Thanks. If only there was a way to communicate intent of code, then I would
not have wasted any time in the first place.
---
If your project is set up for it,
Github user oliversalzburg closed the pull request at:
https://github.com/apache/cordova-wp8/pull/73
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-wp8/pull/73#issuecomment-71615144
console.log is expected intrinsic browser behavior and should exist without
needing to install a plugin.
The default template cordova application even has co
GitHub user oliversalzburg opened a pull request:
https://github.com/apache/cordova-wp8/pull/73
Removed ConsoleHelper from VS Project Template
It is not clear what the intent or benefit of the code is at this point.
Identical functionality is provided by cordova-plugin-console.
Github user Mitko-Kerezov commented on the pull request:
https://github.com/apache/cordova-lib/pull/151#issuecomment-71607363
Hey @shazron can you take a look at this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
36 matches
Mail list logo
