Hi Dmitry,
That’s great to hear about medic improvements.
I submitted a PR for a fix to the gradle build for Android. Hope you can take a
look or recommend a dev who might be able to.
https://issues.apache.org/jira/browse/CB-8452
Also, any tips on this mobile-spec timeout would be useful.
The J
+1
Verified file-transfer plugin fix
Some Ad-hoc testing on windows and wp8
> On Feb 12, 2015, at 6:03 PM, Andrew Grieve wrote:
>
> c'mon. one more
>
> On Thu, Feb 12, 2015 at 10:59 AM, Andrew Grieve
> wrote:
>
>> Just tried deleting device & file-transfer tags and then re-pushing
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/128#issuecomment-74192861
See the latest comment in https://issues.apache.org/jira/browse/CB-8084 and
please continue the discussion there, thanks.
---
If your project is set up for it, you
c'mon. one more
On Thu, Feb 12, 2015 at 10:59 AM, Andrew Grieve
wrote:
> Just tried deleting device & file-transfer tags and then re-pushing them.
> Hopefully that will kick github...
>
> On Thu, Feb 12, 2015 at 8:58 AM, Ian Clelland
> wrote:
>
>> That's odd -- in the Apache repo, the t
Woo! All sounds great! Paramedic sounds awesome for sure. Basically moving
from buildbot to travis/appveyor, and isolating plugins, sounds like win!
Joe - FYI, if you use cordova-lib@master, you can "cordova platform add
android --link", and then you don't need to copy changes back (plugin add
--l
Thanks for updating the unit tests Shazron!
I've added an extra commit to the jshint PR for travis to install ios-sim &
ios-deploy. The failing test in question should be passing now but I'm waiting
on travis to pick up the latest commit just to be safe:
https://github.com/apache/cordova-ios/p
Took care of concerns and merged into master.
On Tue, Feb 10, 2015 at 11:12 AM, Steven Gill
wrote:
> Appreciate the feedback!
>
> At nodesummit today and tomorrow. Will try to find some time to respond.
> On Feb 9, 2015 2:46 PM, "Michal Mocny" wrote:
>
>> (I commented on the other thread)
>>
>>
Okay, back to your original thread ...
What platforms have failing tests, and where are they?
And I am +1 on a) b) and c) but to my knowledge, we should already be doing
this.
@purplecabbage
risingj.com
On Thu, Feb 12, 2015 at 4:54 PM, Shazron wrote:
> cordova-ios' travis integration runs p
cordova-ios' travis integration runs project creation tests as well as
the Objective-C unit tests. So far I've been updating the unit tests
if there is a change in any platform code that can be unit tested.
Right now iOS is failing on Travis because ios-sim is not found
(although this should be be
Github user stevengill commented on commit
adab8c9accfd769019837bb1cc36a2975f9742b0:
https://github.com/apache/cordova-lib/commit/adab8c9accfd769019837bb1cc36a2975f9742b0#commitcomment-9728548
In cordova-lib/src/plugman/registry/registry.js:
In cordova-lib/src/plugman/registry/reg
Github user stevengill commented on commit
adab8c9accfd769019837bb1cc36a2975f9742b0:
https://github.com/apache/cordova-lib/commit/adab8c9accfd769019837bb1cc36a2975f9742b0#commitcomment-9728537
In cordova-lib/src/plugman/registry/registry.js:
In cordova-lib/src/plugman/registry/reg
Before moving on to plugins, I would like to get full consensus on CI
unit-tests for android & ios. If we all agree on it, let's create JIRA items
and start working on it.
For plugin testing we can create a separate thread and discuss in more detail.
There has been a lot of work going on with
Yeah I purposely used the simctl synchronous calls in the context of
it working like the old ios-sim too (since I was assuming it's for
ios-sim only) but for other node code that might need this, async
would be better. I'll make the change when I get to this code again.
On Thu, Feb 12, 2015 at 11:
I've been trying out cordova-paramedic, and it's great. Being able to
quickly run the tests for a plugin (to test pull requests) is a big
time saver vs having to run createmobilespec, and if we get the
travis/appveyor integration this will be even more seamless
On Thu, Feb 12, 2015 at 1:57 PM, Jes
Hi,
This has been discussed briefly before:
http://mail-archives.apache.org/mod_mbox/cordova-dev/201311.mbox/%3CCAK_TSX+dKpLr7vCCacN9kMv1d0=wn2z1dfapheyeam3r_dv...@mail.gmail.com%3E
Problem is when using the FileTransfer plugin to download a file, if
the file is interrupted it will get automat
Github user stevengill commented on commit
fcf37d03d12301d26cb4bcbb0107b085325f40d6:
https://github.com/apache/cordova-lib/commit/fcf37d03d12301d26cb4bcbb0107b085325f40d6#commitcomment-9727513
In cordova-lib/src/plugman/init-defaults.js:
In cordova-lib/src/plugman/init-defaults.js
Github user stevengill commented on commit
fcf37d03d12301d26cb4bcbb0107b085325f40d6:
https://github.com/apache/cordova-lib/commit/fcf37d03d12301d26cb4bcbb0107b085325f40d6#commitcomment-9727493
In cordova-lib/src/plugman/init-defaults.js:
In cordova-lib/src/plugman/init-defaults.js
Github user stevengill commented on commit
fcf37d03d12301d26cb4bcbb0107b085325f40d6:
https://github.com/apache/cordova-lib/commit/fcf37d03d12301d26cb4bcbb0107b085325f40d6#commitcomment-9727378
In cordova-lib/src/PluginInfo.js:
In cordova-lib/src/PluginInfo.js on line 317:
Good
For CB-8444, I'm proposing to eventually remove the clobber of
'window.open' that is done by the InAppBrowser plugin.
The problem I'm trying to solve is unintended changes to the behaviour of
window.open calls in an app. An example of untended change is an app that
adds a plugin which provides an
on a branch? ;)
On Thu, Feb 12, 2015 at 2:47 PM, Andrew Grieve wrote:
> Awesomesauce. Going to move forward then (with putting back the
> accidentally deleted test). If there's other things missed, they can be
> brought back as well.
>
> On Thu, Feb 12, 2015 at 12:47 PM, Brian LeRoux wrote:
>
>
Currently cordova-ios, cordova-android, cordova-windows, cordova-wp8 all
have travis||appveyor integration in their github mirrors.
These tests should definitely be extended to include much much more. For
the most part they are currently just testing project creation, but ios and
android can run
GitHub user jpchase opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/80
CB-8444 Don't clobber `window.open`
There are scenarios where an app needs the built-in `window.open`
functionality (i.e. to open an url in the system browser). As the InAppBrow
oh wow I was not aware of simctl, this is very good approach to use node to
drive it, no more need for compile code.
On Thu, Feb 12, 2015 at 2:43 PM, Andrew Grieve wrote:
> Awesome stuff! Makes perfect sense now that there's (finally) an Xcode tool
> for dealing with simulator.
>
> Only one nit
+1 on integrating platform tests into CI.
Thanks,
Mefire
-Original Message-
From: Joe Bowser [mailto:bows...@gmail.com]
Sent: Thursday, February 12, 2015 1:34 PM
To: dev@cordova.apache.org
Subject: Re: Adding unit tests to travis for Android/iOS
+1. I know Travis has JUnit integration
+1. I know Travis has JUnit integration and thanks to Android Studio, the
only easy way to debug Cordova without copying and pasting code out of a
generated project is to open the test project. There should be no excuse
to not write tests since it's harder/more annoying to use the CLI when
workin
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/166#issuecomment-74155732
When the flag --save/autosave on, we should not be retrieving the version
from config.xml.
For example,
- config.xml contains org.apache.cordova.device@0.
There has been a lot of discussion about tests lately and I feel the urge to
jump in and make some suggestions regarding the way we test things. I'm still
fairly new in the community and sometimes don't have the whole background
story, so please if I'm missing something let me know.
Currently w
Andrew,
Here at Ionic, we've had a few users request something like this. My
approach has been to create a Cordova plugin, that takes the following
steps:
Creates an instance of the original webview
Executes some JS inside the webview that will grab all entries for
localstorage
If Android pre KIT
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/166#issuecomment-74151973
Hey @gorkem, I notice that --save covers add and remove. Are you going to
send a pull request to handle the update case ? : 'cordova plugin update
org.apache.cordova
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/166#issuecomment-74151061
Hey @gorkem, I notice that --save covers add and remove. Are you going to
send a pull request to handle the update case ? : 'cordova plugin update
org.apache.cordova
I suppose the same issues would exist for UIWebView vs WKWebView.
On Thu, Feb 12, 2015 at 3:46 PM, Andrew Grieve wrote:
> Worth a discussion about this, I think.
>
> If you have an app already launched that uses localstorage/websql, and
> want to switch to xwalk, how can you migrate your data?
>
Worth a discussion about this, I think.
If you have an app already launched that uses localstorage/websql, and want
to switch to xwalk, how can you migrate your data?
What if you want to use system webview for API >= 21 and xwalk only for old
phones? Then you need to move data in the reverse dire
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/166#issuecomment-74146324
'saving to config.xml' should happen after the plugin has been installed on
the platforms.
That way, if any error is encountered during the install, the config.x
Tests are definitely critical before we call for a vote :) I don't mind a
short time between landing the code and landing the tests.
On Thu, Feb 12, 2015 at 2:48 PM, Andrew Grieve wrote:
> Code LGTM! I think it's a good idea to land on master and pursue tests
> after-the-fact. More time on mast
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/166#issuecomment-74145216
I think the 'saving to config.xml' should be moved into a separate function
and called from here. this function is getting way too long to easily reason
about it.
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/166#issuecomment-74143188
if no version is specified for (e.g: cordova plugin add
org.apache.cordova.device --save), we end up saving the current edge version
(org.apache.cordova.device@0.2.1
Code LGTM! I think it's a good idea to land on master and pursue tests
after-the-fact. More time on master means more real-world testing before it
being released.
On Wed, Feb 11, 2015 at 10:23 PM, Ian Clelland
wrote:
> Not specifically, yet -- I have done manual testing on it so far, and was
> g
Awesomesauce. Going to move forward then (with putting back the
accidentally deleted test). If there's other things missed, they can be
brought back as well.
On Thu, Feb 12, 2015 at 12:47 PM, Brian LeRoux wrote:
> I see no situation where we don't want a feature branch vetted by >1 person
> befo
Awesome stuff! Makes perfect sense now that there's (finally) an Xcode tool
for dealing with simulator.
Only one nit about the actual code is that it'd be better to use
child_process.exec rather than shelljs, since there's no real need to have
the function be synchronous.
On Thu, Feb 12, 2015 at
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/166#issuecomment-74128449
Cool feature list. reviewing this, :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Projecting future plans for ios-deploy as well here:
https://github.com/phonegap/ios-deploy/issues/103
On Thu, Feb 12, 2015 at 10:03 AM, Shazron wrote:
> Time to give this some sunlight. Right now it's the 3.x series, which
> relies on some custom C code.
>
> For 4.x [1], I implemented a wrapper
Time to give this some sunlight. Right now it's the 3.x series, which
relies on some custom C code.
For 4.x [1], I implemented a wrapper [2] around the Xcode tool simctl
[3], using nodejs.
I believe it's ready for testing, so if you want to test:
npm install -g ios-sim@4.0.1
Please file issues
Github user muratsu closed the pull request at:
https://github.com/apache/cordova-android/pull/154
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
I see no situation where we don't want a feature branch vetted by >1 person
before we land anything on master …short of fixing broken tests.
I assume good faith. Joe: you had a bad day and, I think, you still feel
mistrust after previous commits landing on master stalling out your work
last summer
Github user stefangordon commented on the pull request:
https://github.com/apache/cordova-lib/pull/164#issuecomment-74116684
Great stuff! Any pointers on how users can easily install this via NPM now?
I've only had success manually cloning the lib and cli repos and copying
correct bin
This commit may not have warranted this discussion.
I think we agree that large changes/commits should be on feature branches, and
discussed before being merged.
Let's go with that.
> On Feb 12, 2015, at 8:49 AM, Andrew Grieve wrote:
>
> Sounds like you've been having a rough time. :( Hope
Github user grantkemp commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/12#issuecomment-74113244
+2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
GitHub user gorkem opened a pull request:
https://github.com/apache/cordova-cli/pull/209
Save/Restore for plugins and platforms CLI changes
Also see https://github.com/apache/cordova-lib/pull/166
Remove save and restore command and updates docs for plugin save
You can merge
GitHub user gorkem opened a pull request:
https://github.com/apache/cordova-lib/pull/166
Save/Restore for plugins and platforms
I think this is a good point to merge these features.. It provides most of
the functionality and frankly I am tired of rebasing/merging.
Several f
Sounds like you've been having a rough time. :( Hope you get through it.
Believe me when I say I hear you loud and clear about making changes on
feature branches. I just don't think this one fits.
- No one (other than me) has touched the tests since September of last
year, so it's unlikely that a
On Thu Feb 12 2015 at 7:44:52 AM Andrew Grieve wrote:
> I agree that significant changes should be reviewed first. But for the most
> part Cordova is a review-after-commit kind of place,
No, it's not. Cordova is only like that because you consistently make it
like that. Constantly committing
Just tried deleting device & file-transfer tags and then re-pushing them.
Hopefully that will kick github...
On Thu, Feb 12, 2015 at 8:58 AM, Ian Clelland
wrote:
> That's odd -- in the Apache repo, the tags appear to be correct (and they
> are on my local repos as well) -- GitHub is the only pla
Github user Shilo commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/12#issuecomment-74094377
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
I agree that significant changes should be reviewed first. But for the most
part Cordova is a review-after-commit kind of place, and this change didn't
touch any code that we release (strictly tests... that have been broken for
a very long time), so I don't think it qualifies.
On Thu, Feb 12, 2015
That's odd -- in the Apache repo, the tags appear to be correct (and they
are on my local repos as well) -- GitHub is the only place I see that bad
tag.
GitHub also does have the correct commits (4330db8 and 1882bfb) as well,
but the r0.3.0 tag isn't applied to the commit in -device.
What I reall
I vote +1
•Ran mobilespec autotests on Android, Windows and WP8.
•Performed manual ad-hoc testing.
•Verified Release Notes.
-Sergey Grebnov
-Original Message-
From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve
Sent: Wednesday, February 11, 2015 5:
You may or may not, but I think it would be nice to let others review your
(significant) changes before dumping them to master.
> On Feb 11, 2015, at 6:34 PM, Andrew Grieve wrote:
>
>> On Wed, Feb 11, 2015 at 5:00 PM, Jesse wrote:
>>
>> +1 Revert
>>
>> And please let's stop deleting what
Hi all,
I can confirm that the file transfer bug is fixed in this one, though I see
another issue here: the tags for `device` and `file transfer` plugins are not
matching the actual GitHub tags. The file transfer one is just not updated from
previous release attempt, but the device one did not
58 matches
Mail list logo
