Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25230972
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) u
Summarizing conclusions so far (not 100% we all agree on this, please do
speak up):
- PluginId and Npm Package Name should be the same. We cannot force this
for all plugins, but we can set the tone with core plugins.
- We will change all plugins to use the cordova-plugin-* name/id.
- We will bump
Just thinking out loud..
I guess it wouldn't actually do that unless you are using actual npm cli to
install plugins. With the current plan we are still just using
cordova/plugman to fetch using the npm lib, and so can probably resolve
peerDependencies whenever/however we want (like auto-fetching
Github user gorkem commented on the pull request:
https://github.com/apache/cordova-lib/pull/143#issuecomment-75690753
closing as this is obsolete
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user gorkem closed the pull request at:
https://github.com/apache/cordova-lib/pull/143
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/168
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
I suppose it's workable, but it seems worse than what we currently have.
E.g. I don't care about Android, but npm peerDependencies will complain
until I've installed the android.support.v4 plugin into my node_modules.
On Mon, Feb 23, 2015 at 4:26 PM, Michal Mocny wrote:
> I scanned the core plug
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25224883
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25224748
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25224693
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Thanks Dmitry.
Also, I had to run "npm install" in cordova-lib/cordova-lib for some
reason as well for it to work. You and Jesse MacFadyen should
collaborate (not sure if you have) -- he has his cordova-paramedic
tool that may have advantages (like reporting failures/error codes to
the console so i
Hi list,
Over the past few weeks, I've developed an automated mobilespec-like tool in
the process of resuscitating Cordova's CI. It's tentatively called
cordova-medivac, and it can currently be found here:
http://github.com/dblotsky/cordova-medivac. I'd like to pitch it to the
community as a p
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/170#issuecomment-75670437
I think this PR is ready to be merged in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/168#issuecomment-75669608
@gorkem, I did find some things that needed to be updated in
restore-util.js. those have been taken care of.
---
If your project is set up for it, you can reply to
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/168#issuecomment-75660844
@gorkem, cool. working on a rebase + update to new dependent modules ...
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user marcuspridham opened a pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/11
CB-8528 Update test framework plugin to use Jasmine 2.2.0.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/marcuspri
Github user gorkem commented on the pull request:
https://github.com/apache/cordova-lib/pull/168#issuecomment-75658796
@omefire this looks OK and would like to get it in. The dependencies have
changed though save.js and restore.js are gone. I could not quickly spot
anything on platfor
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/166#issuecomment-75656828
what about the other options ? (opts).
shouldn't we pass them along to 'prepare' ?
---
If your project is set up for it, you can reply to this email and have you
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/166
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-cli/pull/209
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user bluety opened a pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/37
Fix error from translation, params namespace
Fix params namespace
Fix code block
You can merge this pull request into a Git repository by running:
$ git pull https://githu
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/166#issuecomment-75640710
when --save/autosave is on, we should be overriding what's in config.xml,
like we do on the platform side :
https://github.com/apache/cordova-lib/blob/master/cordova
I scanned the core plugins, and only contacts uses platform specific deps,
and only for 2 BB plugins.
Also scanned the top 20 non-core plugins from CPR, and:
- com.cranberrygame.phonegap.plugin.ad.admob
- depends on google-play-services only on android, but that plugin only
supports android.
-
On Mon, Feb 23, 2015 at 3:36 PM, Andrew Grieve wrote:
> You can use plugin.xml to print a message upon installation.
>
> Plugins can specify dependencies on a per-platform basis. Don't think we
> can capture this with package.json without using custom keys.
>
Do we need to? I mean, this is a b
You can use plugin.xml to print a message upon installation.
Plugins can specify dependencies on a per-platform basis. Don't think we
can capture this with package.json without using custom keys.
On Mon, Feb 23, 2015 at 2:42 PM, Michal Mocny wrote:
> On Mon, Feb 23, 2015 at 2:22 PM, Steven G
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/170#issuecomment-75623519
@gorkem, yes platforms.json is a new file in the platforms directory. think
of it as the equivalent of the .fetch.json file we have for plugins.
---
If your project
On Mon, Feb 23, 2015 at 2:22 PM, Steven Gill wrote:
> +1 to giving plugins major version bump
> +1 to publishing old versions to npm
>
> Short term we can keep dependency tag using plugin ids. Wouldn't it make
> more sense long term to move those dependencies into package.json file of
> each plug
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/166#issuecomment-75615699
you forgot to negate opts.save as well : if(!autosave && !opts.save && ...)
---
If your project is set up for it, you can reply to this email and have your
reply app
+1 to giving plugins major version bump
+1 to publishing old versions to npm
Short term we can keep dependency tag using plugin ids. Wouldn't it make
more sense long term to move those dependencies into package.json file of
each plugin?
I am going to begin the process of adding package.json to al
Github user cjpearson commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/171#discussion_r25187454
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -521,19 +521,27 @@ function getCreateArgs(platDetails, projectRoot, cfg,
template_dir, opts) {
Github user cjpearson commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/171#discussion_r25187402
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -521,19 +521,27 @@ function getCreateArgs(platDetails, projectRoot, cfg,
template_dir, opts) {
Github user cjpearson commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/160#discussion_r25187348
--- Diff: bin/create ---
@@ -23,14 +23,15 @@ var create = require('./lib/create');
var args = require('./lib/simpleargs').getArgs(process.argv
Thanks for taking this on! Left a comment on each, but generally looks good
to me!
On Sun, Feb 22, 2015 at 4:12 PM, Connor Pearson wrote:
> I've opened two pull requests for this issue:
>
> https://github.com/apache/cordova-lib/pull/171
> https://github.com/apache/cordova-android/pull/160
>
> On
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/171#discussion_r25186284
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -521,19 +521,27 @@ function getCreateArgs(platDetails, projectRoot, cfg,
template_dir, opts) {
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/160#discussion_r25186024
--- Diff: bin/create ---
@@ -23,14 +23,15 @@ var create = require('./lib/create');
var args = require('./lib/simpleargs').getArgs(process.argv);
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/171#discussion_r25185875
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -521,19 +521,27 @@ function getCreateArgs(platDetails, projectRoot, cfg,
template_dir, opts) {
GitHub user AxelNennker opened a pull request:
https://github.com/apache/cordova-lib/pull/172
CB-8448 add support for activities
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AxelNennker/cordova-lib master
Alternatively you ca
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25184230
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/166#issuecomment-75574968
Reviewing latest changes ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
On Thu, Feb 19, 2015 at 9:15 PM, Nikhil Khandelwal
wrote:
> Responses inline.
>
> My initial thinking was to create a 'cordova package' command that did all
> the steps that you mention below. I can see value in having this integrated
> as part of 'cordova build' itself for Android. There are sti
Hi Shawn.
Thanks for connecting with the Apache Cordova dev community, but this is
the development community and we focus on that here. My advise is that you
go to StackOverflow and post your question tagging it with cordova.
Moreover, you will get greater response there than in here.
http://stack
Github user gorkem commented on the pull request:
https://github.com/apache/cordova-lib/pull/166#issuecomment-75547919
I think I have addressed the concerns with the latest. If everyone is cool
with it, we should go ahead and merge them in.
---
If your project is set up for it, you c
Please review and vote on this 3.8.0 Windows Release.
Release issue: https://issues.apache.org/jira/browse/CB-8524
Repos ready to be released have been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-8524
The package was published from its corresponding git tag:
cord
I'm going to start a vote thread soon, but propose to release this as 3.8.0
instead of 3.7.2 due to the following reasons:
1. There is new functionality here so this is a NOT a patch release
2. 3.7.x was released 4 months ago (11/2014)
3. Due to many changes in master it will be hard to cherry pi
44 matches
Mail list logo
