Github user EddyVerbruggen commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/22#discussion_r2210
--- Diff: doc/index.md ---
@@ -41,6 +41,10 @@ Preferences
+- __AndroidStatusBarBackgroundColor__ (color
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/174#issuecomment-76512869
What do you mean ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Thinking about it further, I do agree these are non-blocking.
Sorry for delaying the process.
I vote +1.
Thanks,
Mefire
-Original Message-
From: Parashuram N (MS OPEN TECH) [mailto:panar...@microsoft.com]
Sent: Friday, February 27, 2015 9:11 PM
To: dev@cordova.apache.org
Subject: RE:
Agree with Gorkem, I think these bugs are non-blocking. I don't think we should
block the release for this - this only impacts certain plugins, when using the
--save feature. I think it may make sense to do a patch release, if we don't
want to block this release.
-Original Message-
Fro
I really wish some of this stuff was communicated during the discuss phase
:(
On Feb 27, 2015 8:55 PM, "Gorkem Ercan" wrote:
>
>
> On 27 Feb 2015, at 22:19, Mefire O. wrote:
>
> I've spent some time testing, found two bugs and I vote -1 until we
>> address those :
>> - https://issues.apache.org/
Github user gorkem commented on the pull request:
https://github.com/apache/cordova-lib/pull/174#issuecomment-76510698
If we change this now it will just make the migration from to
logic more complex.
---
If your project is set up for it, you can reply to this email and have your
r
On 27 Feb 2015, at 22:19, Mefire O. wrote:
I've spent some time testing, found two bugs and I vote -1 until we
address those :
- https://issues.apache.org/jira/browse/CB-8577
I do not think this is a show stopper, probably not even a bug, I have
not had time to change the old tags. Actual
[Sorry to pollute the voting thread.]
Here are two pull requests that fix the issues I mentioned earlier :
- https://github.com/apache/cordova-lib/pull/173
- https://github.com/apache/cordova-lib/pull/174
I'll be voting +1, once and if these get included.
Thanks,
Mefire
-Original Message
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-lib/pull/174
CB-8577 BugFix 'cordova plugin add --save' should properly save
variables into config.xml to enable restoring later on.
CB-8577 BugFix 'cordova plugin add --save' should properly save
variab
Github user djdmbrwsk commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/22#issuecomment-76509417
Really looking forward to this! Setting the color at runtime is key for
Android 5 because more and more apps have different colors for each layer. Ex
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-lib/pull/173
CB-8578 BugFix: 'cordova plugin should be able to restore urls and
folders in addition to versions.
CB-8578 BugFix: 'cordova plugin should be able to restore urls and
folders in addition to
Github user dpogue commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/22#issuecomment-76508631
Rather than more config.xml preferences, might it be better to set the
statusBar colour on all platforms based on the `` tag
as per the WHATWG spec?
I've spent some time testing, found two bugs and I vote -1 until we address
those :
- https://issues.apache.org/jira/browse/CB-8577
- https://issues.apache.org/jira/browse/CB-8578
I should be able to send pull requests to fix them shortly.
Thanks,
Mefire
-Original Message-
From: Mefire
Github user sinofool commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/22#discussion_r25553628
--- Diff: doc/index.md ---
@@ -41,6 +41,10 @@ Preferences
+- __AndroidStatusBarBackgroundColor__ (color hex st
On 27 Feb 2015, at 21:16, Michal Mocny wrote:
Looks good. Few comments:
- "You can manage plugin and platform versions using the --save
command" =>
"You can now save your list of installed plugins and platforms using
the
--save command".
Should we also add "Saved platforms and plugins a
Looks good. Few comments:
- "You can manage plugin and platform versions using the --save command" =>
"You can now save your list of installed plugins and platforms using the
--save command".
- (I don't think --save actually helps with management of versions)
- We are going to be doing a blog p
On Fri, Feb 27, 2015 at 5:30 PM, Dmitry Blotsky
wrote:
> Thanks for the feedback, Michal! The issue we had with using the
> checkboxes was that it was not easily automatable. A more simple solution
> was to use a parameter to specify the plugins you want installed, instead
> of installing all of
huzzah!
On Fri, Feb 27, 2015 at 7:07 PM, Shazron wrote:
> Proceeding with the wkwebview -> 4.x branch merge next week, and also
> rebase/merge 4.x off master to pickup the latest master bits.
>
>
> On Thu, Jan 29, 2015 at 4:48 PM, Shazron wrote:
> > Reviving this thread. After the hangout today
Still have some formatting to do of the changes.
https://github.com/cordova/apache-blog-posts/blob/master/2015-03-02-tools-release.md
Any other highlights I should mention?
Proceeding with the wkwebview -> 4.x branch merge next week, and also
rebase/merge 4.x off master to pickup the latest master bits.
On Thu, Jan 29, 2015 at 4:48 PM, Shazron wrote:
> Reviving this thread. After the hangout today, the proposal now is:
>
> 1. Integrate the "wkwebview" (pluggable we
Steven, Thanks for initiating this.
I'll be performing some tests/checks and will then cast my vote accordingly.
Thanks,
Mefire
-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com]
Sent: Friday, February 27, 2015 1:21 PM
To: dev@cordova.apache.org
Subject: [Vote] Tools Re
No regressions were seen. FYI
Thanks,
Edna Morales
Personally, I never use mobile-spec because it is buggy on windows+wp8, and
nearly impossible to tell if a failure is a bad test or bad code, (this may
be better now, but I've already lost faith). I needed a way to easily test
a particular plugin in isolation, which is why I wrote paramedic.
The
Thanks for the feedback, Michal! The issue we had with using the checkboxes was
that it was not easily automatable. A more simple solution was to use a
parameter to specify the plugins you want installed, instead of installing all
of them and then disabling them. Also the dependencies-plugin in
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/22#issuecomment-76480150
Yes, that is correct.
Also, [1] in js takes care of making sure you get a valid #RRGGBB even if
it is passed 'RGB'
and ColorByName simply c
Github user EddyVerbruggen commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/22#issuecomment-76476575
Hi @purplecabbage thanks for the quick review!
I've now added runtime support for `backgroundColorByHexString` as you
suggested (includin
Please review and vote on this Tools Release.
Release issue: https://issues.apache.org/jira/browse/CB-8555
All the tools have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8555/
All the tools have also been published to npm under the rc tag.
Feel free to test them
Github user EddyVerbruggen commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/22#discussion_r25538963
--- Diff: doc/index.md ---
@@ -41,6 +41,10 @@ Preferences
+- __AndroidStatusBarBackgroundColor__ (color
Looks like I had a cordova-test-frameworks directory (no idea why) in my
cordova directory. It was coming up during the searchpath search and its
version was set to 0.1. Removed it. Problem solved
On Fri, Feb 27, 2015 at 11:35 AM, Steven Gill
wrote:
> Trying to run createmobilespec as part of t
Trying to run createmobilespec as part of the tools release.
Running into this problem.
TypeError: Invalid Version: 0.1
at new SemVer
(/Users/stevengill/repo/cordova/cordova-lib/cordova-lib/node_modules/semver/semver.js:256:11)
at compare
(/Users/stevengill/repo/cordova/cordova-lib/cordov
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/60#issuecomment-76456224
lgtm!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
I sent a pull request for the release notes, please merge before shipping.
Sergey wrote:
> Sent the following PR since I don't have write access to the repo.
> Please review and merge, all required changes and improvements are
> welcome.
> https://github.com/cordova/apache-blog-posts/pull/32/fil
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/22#issuecomment-76453675
This should be identical to the other platforms.
Documentation should specify the 'quirk' in how the Android guidelines
recommend it's usage.
Github user sinofool commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/22#discussion_r25529377
--- Diff: doc/index.md ---
@@ -41,6 +41,10 @@ Preferences
+- __AndroidStatusBarBackgroundColor__ (color hex st
Certainly would match the equivalent cordova-cli repo name.
On the other hand, I'm sometimes annoyed that the `cordova-cli` repo name
!= `cordova` package name.
But with the move to npm, perhaps plugman-cli dies eventually anyway?
-Michal
On Fri, Feb 27, 2015 at 12:49 PM, Jesse wrote:
> We sh
We should consider calling plugman plugman-cli so it is more clear that this
simply adds a (you guessed it) command line interface ...
> On Feb 27, 2015, at 8:01 AM, Mark Koudritsky wrote:
>
> Yes, the instructions look correct.
> If you dan't need to use the `plugman` command, you don't nee
Looks good to me.
On 2/27/15, 8:00 AM, "Shazron" wrote:
>Added you to the repo as a committer, for next time.
>
>
>On Fri, Feb 27, 2015 at 3:44 AM, Sergey Grebnov (Akvelon)
> wrote:
>> Sent the following PR since I don't have write access to the repo.
>>Please review and merge, all required cha
Yes, the instructions look correct.
If you dan't need to use the `plugman` command, you don't need
cordova-plugman.
On Fri, Feb 27, 2015 at 12:21 AM, Toda, Shingo
wrote:
> Hi devs
>
> I read through this document to know how I can install CLI from cloned
> cordova-cli.
> https://github.com/apach
Added you to the repo as a committer, for next time.
On Fri, Feb 27, 2015 at 3:44 AM, Sergey Grebnov (Akvelon)
wrote:
> Sent the following PR since I don't have write access to the repo. Please
> review and merge, all required changes and improvements are welcome.
>
> https://github.com/cordova
Github user cjpearson commented on the pull request:
https://github.com/apache/cordova-lib/pull/171#issuecomment-76387512
@agrieve I've addressed your comments, could you take another look? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply a
Sent the following PR since I don't have write access to the repo. Please
review and merge, all required changes and improvements are welcome.
https://github.com/cordova/apache-blog-posts/pull/32/files
Thx!
Sergey
-
To unsubs
GitHub user EddyVerbruggen opened a pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/22
Allow setting the statusbar backgroundcolor on Android
Since Android Lollipop the statusbar of your app is no longer black. On a
Samsung Galaxy S5 my mostly white app now has
42 matches
Mail list logo
