[GitHub] cordova-medic pull request: Short Slave Documentation Improvements

2015-04-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/42 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-file pull request: CB-8819 Fixed FileReader's readA...

2015-04-14 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/108#issuecomment-92690268 Merged to master in https://github.com/apache/cordova-plugin-file/commit/6f20c19263df80b4bc5aebc1d75e7567d105b2bf @alsorokin, could you please

[GitHub] cordova-medic pull request: Short Slave Documentation Improvements

2015-04-14 Thread alsorokin
Github user alsorokin commented on the pull request: https://github.com/apache/cordova-medic/pull/42#issuecomment-92692784 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: Proposal: Expose check_reqs at the CLI level

2015-04-14 Thread Sachax
Absolutely +1 Sent from my iPhone - 4eSPJ Sacha Herbert Website:www.sachax.com Studio: Via A. Bertani, 20a - 00153 Roma Office: +39 06 933 798 66 Mobile: +39 392 188 0793 Twitter:sachax08 Skype: as3_master Il presente messaggio e-mail contiene

[GitHub] cordova-plugin-file pull request: CB-8849 Fixed ReadAsArrayBuffer ...

2015-04-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/111 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-file pull request: CB-8849 Fixed ReadAsArrayBuffer ...

2015-04-14 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-file/pull/111 CB-8849 Fixed ReadAsArrayBuffer to return ArrayBuffer and not Array on WP8 https://issues.apache.org/jira/browse/CB-8849 You can merge this pull request into a Git repository by

[GitHub] cordova-plugin-file pull request: CB-8819 Fixed FileReader's readA...

2015-04-14 Thread alsorokin
Github user alsorokin closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/108 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-lib pull request: Save/Restore for plugins and platforms

2015-04-14 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/166#issuecomment-92777120 correct. `restore` command is removed and restoration happens during `prepare`. You can call `cordova prepare` explicitly to get the similar results to `restore`.

Re: Buildbot for Cordova on Apache Infra - Update

2015-04-14 Thread Willy Aguirre
Hi Dmitry, 1- added firefoxos to cordova.conf is on the PR https://github.com/marti1125/cordova-medic/blob/CB-8734/buildbot-conf/cordova.conf#L303 Slave: I think is not neccesary to add some specific instructions for Firefox OS because in the old version I only I made the slave and then run

Re: [Vote] 4.0.0 Android Release

2015-04-14 Thread Joe Bowser
+1 - verified archive - ran mobile-spec - audited headers. On Tue, Apr 14, 2015 at 9:56 AM Andrew Grieve agri...@chromium.org wrote: I don't think we need to re-start since no one's -'ve voted, and nothing would be different. Feel free to start voting! :) On Tue, Apr 14, 2015 at 10:36 AM,

Re: Tools for Cordova Commits Presentation Slides

2015-04-14 Thread Michael Brooks
Fantastic deck Andrew! On Mon, Apr 13, 2015 at 10:46 PM, Carlos Santana csantan...@gmail.com wrote: slides look great ! ;-) On Mon, Apr 13, 2015 at 5:53 PM, Andrew Grieve agri...@chromium.org wrote: Thanks guys! Jesse - your name is there because you were last to comment on the PR.

Re: Tools for Cordova Commits Presentation Slides

2015-04-14 Thread Willy Aguirre
Is there a video about this presentation? 2015-04-14 12:55 GMT-05:00 Michael Brooks mich...@michaelbrooks.ca: Fantastic deck Andrew! On Mon, Apr 13, 2015 at 10:46 PM, Carlos Santana csantan...@gmail.com wrote: slides look great ! ;-) On Mon, Apr 13, 2015 at 5:53 PM, Andrew Grieve

Re: [Vote] 4.0.0 Android Release

2015-04-14 Thread Andrew Grieve
I don't think we need to re-start since no one's -'ve voted, and nothing would be different. Feel free to start voting! :) On Tue, Apr 14, 2015 at 10:36 AM, Joe Bowser bows...@gmail.com wrote: So...since nobody voted on this thread, I think it's safe to say the vote failed. We should probably

Re: [Vote] 4.0.0 Android Release

2015-04-14 Thread Brian LeRoux
+1 On Tue, Apr 14, 2015, 1:07 PM Joe Bowser bows...@gmail.com wrote: +1 - verified archive - ran mobile-spec - audited headers. On Tue, Apr 14, 2015 at 9:56 AM Andrew Grieve agri...@chromium.org wrote: I don't think we need to re-start since no one's -'ve voted, and nothing would be

Re: [Vote] 4.0.0 Android Release

2015-04-14 Thread Simon MacDonald
+1 Simon Mac Donald http://hi.im/simonmacdonald On Tue, Apr 14, 2015 at 2:14 PM, Brian LeRoux b...@brian.io wrote: +1 On Tue, Apr 14, 2015, 1:07 PM Joe Bowser bows...@gmail.com wrote: +1 - verified archive - ran mobile-spec - audited headers. On Tue, Apr 14, 2015 at 9:56 AM Andrew

Re: Proposal: Expose check_reqs at the CLI level

2015-04-14 Thread Parashuram N (MS OPEN TECH)
Carlos, you are right, check_reqs should be in the platform repo, CLI will just proxy the call to the platforms. On 4/13/15, 10:29 PM, Carlos Santana csantan...@gmail.com wrote: +1 if check_reqs are kept in the platform repos, currently check_reqs is a platform concerned if it's available from

RE: Proposal: Expose check_reqs at the CLI level

2015-04-14 Thread Parashuram N (MS OPEN TECH)
I think you raise an interesting point on the behavior of check_reqs for platform that are not yet added. The options, as you mention are Question 1 1 - Add the platform, run check_reqs script, remove the platform and report results. 1.5 - Just download the check_reqs script (or use it from

RE: Proposal: Expose check_reqs at the CLI level

2015-04-14 Thread Treggiari, Leo
My opinions. Q1. Just say that platform is not added, so cannot check requirements. I don't think it is important to support the platform-not-added case. Q2. Should the requirements be checked when a platform is added, or when it is built ? 'platform add' should work even when the

[GitHub] cordova-ios pull request: CB-8855 Fix display ios devices with --l...

2015-04-14 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-ios/pull/137#issuecomment-93073139 :beer: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-ios pull request: CB-8855 Fix display ios devices with --l...

2015-04-14 Thread muratsu
Github user muratsu commented on the pull request: https://github.com/apache/cordova-ios/pull/137#issuecomment-93073824 :+1: :smile: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

ios devices never show up with --list

2015-04-14 Thread Carlos Santana
When I run cordova run ios --device --list is always empty $ cordova run ios --device --list Available ios devices: Any special requirement I need to make this to work? Looking at the code this is not using ios-deploy to list the ios devices plug to usb. Is using [1] something weird like:

Re: ios devices never show up with --list

2015-04-14 Thread Shazron
Seems to me a regression. When I ran the old bash script from 3.7.0, it lists it fine: https://raw.githubusercontent.com/apache/cordova-ios/3.7.0/bin/templates/scripts/cordova/lib/list-devices On Tue, Apr 14, 2015 at 12:55 PM, Carlos Santana csantan...@gmail.com wrote: When I run cordova run ios

[GitHub] cordova-plugin-media pull request: Fixed the problem with multiple...

2015-04-14 Thread batman11111
Github user batman1 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/33#issuecomment-93054522 How can I use this fix with phonegap build? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Re: ios devices never show up with --list

2015-04-14 Thread Carlos Santana
Thanks Shaz for checking opened an issue CB-8855 and sent PR for review, go ahead and merge if it looks good to you. On Tue, Apr 14, 2015 at 4:08 PM, Shazron shaz...@gmail.com wrote: Seems to me a regression. When I ran the old bash script from 3.7.0, it lists it fine:

[GitHub] cordova-ios pull request: CB-8855 Fix display ios devices with --l...

2015-04-14 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/137#issuecomment-93065250 Seems to work. Pulling in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-ios pull request: CB-8855 Fix display ios devices with --l...

2015-04-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/137 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature