Re: Experimenting with API for cordova tooling

2015-04-24 Thread Mark Koudritsky
I like the idea of cordova-discuss, lets give it a try ) To read the md file formatted: https://github.com/kamrik/cordova-discuss/blob/master/proposals/PlatformProject.md To comment, look at the pull request https://github.com/cordova/cordova-discuss/pull/4 On Fri, Apr 24, 2015 at 10:16 PM, Paras

Re: Experimenting with API for cordova tooling

2015-04-24 Thread Parashuram N (MS OPEN TECH)
Should we move this docs to cordova-discuss instead -https://github.com/cordova/cordova-discuss ? On 4/24/15, 4:02 PM, "Mark Koudritsky" wrote: >I'm back from ApacheCon and vacation. Very glad to see some enthusiasm >about this! >My thoughts about the next steps turned out to be rather lengthy s

[GitHub] cordova-plugin-file-transfer pull request: CB-8761 [wp8]: Copy coo...

2015-04-24 Thread sgrebnov
Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/74#discussion_r29094475 --- Diff: src/wp/FileTransfer.cs --- @@ -210,6 +216,80 @@ public FileTransferProgress(long bTotal = 0, long bLoaded = 0) }

Re: [Android] InAppBrowser and URI whitelisting

2015-04-24 Thread Joe Bowser
So, since we make this Category.BROWSABLE, we can safely say that this is working as intended and close it? :P I disagree about not restricting it to the intent whitelist, because that sounds messed up that we wouldn't let an app, with the trusted content run an intent, but we'd let untrusted cont

Re: [Android] InAppBrowser and URI whitelisting

2015-04-24 Thread Andrew Grieve
The browser allows any intents, but attaches Category.BROWSABLE to the intents, which is supposed to make them safe. We don't restrict the IAB to the network whitelist, so it follows (maybe?) that we wouldn't restrict it to the intent whitelist. On Fri, Apr 24, 2015 at 6:06 PM, Jesse wrote: > Wh

Re: Experimenting with API for cordova tooling

2015-04-24 Thread Mark Koudritsky
I'm back from ApacheCon and vacation. Very glad to see some enthusiasm about this! My thoughts about the next steps turned out to be rather lengthy so here is a doc: https://docs.google.com/document/d/1jxQvygBtTeCYhxMtHLD9jgKTKZofMJdux1UIzsdd5b0 The most important next steps are: - Take one platf

Re: [Android] InAppBrowser and URI whitelisting

2015-04-24 Thread Jesse
What does the browser do? That's what the InAppBrowser should do ... It may also make sense to allow the host cordova app decide whether or not to allow it. Presumably the host app could allow all intents, but not want to extend that to it's InAppBrowser control, or allow some intents for some dom

Re: Buildbot: buildslave cordova-ios-slave was lost

2015-04-24 Thread Carlos Santana
+1 Let it Go On Fri, Apr 24, 2015 at 5:45 PM, Dmitry Blotsky wrote: > Builds were failing because the screensaver was activating and preventing > emulators from starting. Gotchas are now documented so that this kind of > stuff doesn't happen next time we reconfigure a machine. > > Machine is

RE: Buildbot: buildslave cordova-ios-slave was lost

2015-04-24 Thread Dmitry Blotsky
Builds were failing because the screensaver was activating and preventing emulators from starting. Gotchas are now documented so that this kind of stuff doesn't happen next time we reconfigure a machine. Machine is back up and didn't miss any builds. For the first time in forever all of iOS, An

[GitHub] cordova-medic pull request: [CB-8910] Fixing growing temp director...

2015-04-24 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-medic/pull/46 [CB-8910] Fixing growing temp directory issue Specifying NPM temp folder to be in build directory instead of system temp folder so that it gets cleaned up during `medic.js clean`. You can me

[GitHub] cordova-plugin-file-transfer pull request: CB-8761 [wp8]: Copy coo...

2015-04-24 Thread dpolivy
Github user dpolivy commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/74#discussion_r29088108 --- Diff: src/wp/FileTransfer.cs --- @@ -210,6 +216,80 @@ public FileTransferProgress(long bTotal = 0, long bLoaded = 0) }

[Android] InAppBrowser and URI whitelisting

2015-04-24 Thread Joe Bowser
Hey I was looking at CB-8180, and I'm wondering what the correct behaviour for intents being launched from URIs should be for an InAppBrowser. Should these have free reign to open whatever, or should they also be bound by the rules of the whitelist? What do people think? Joe

Re: Bug : cordova 5.0.0 & cordova-plugin-camera

2015-04-24 Thread Joe Bowser
Delete the line in the plugin's java, and your project will compile fine. This is an unused import. Conversely, you could install the file plugin. In the future can you file an issue? I've created one there for tracking purposes: https://issues.apache.org/jira/browse/CB-8909 On Fri, Apr 24, 20

[GitHub] cordova-plugin-file-transfer pull request: CB-8761 [wp8]: Copy coo...

2015-04-24 Thread sgrebnov
Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/74#discussion_r29086624 --- Diff: src/wp/FileTransfer.cs --- @@ -210,6 +216,80 @@ public FileTransferProgress(long bTotal = 0, long bLoaded = 0) }

[GitHub] cordova-plugin-file-transfer pull request: CB-8761 [wp8]: Copy coo...

2015-04-24 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/74#issuecomment-96067403 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-file-transfer pull request: CB-8761 [wp8]: Copy coo...

2015-04-24 Thread dpolivy
Github user dpolivy commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/74#issuecomment-96058947 @vladimir-kotikov Thanks for the comments! I addressed your feedback, and pushed up a new diff. I squashed the changes into a single commit -- hope t

Re: Is there a way to specify the ios device to run?

2015-04-24 Thread Carlos Santana
Thanks Shaz, what I suspected but was not sure how to pass the id to ios-deploy I also found another problems related running cordova emulate --list, it shows duplicates when Xcode is configured with multiple versions of iOS versions 7.1, 8.3 User can't tell what id to use for cordova emulate --ta

Re: Is there a way to specify the ios device to run?

2015-04-24 Thread Shazron
ios-deploy certainly supports it (--id or -i) However this flag and its argument is not passed to ios-deploy from cordova/run: https://github.com/apache/cordova-ios/blob/f7a888140951e1952acd40f3ec54d13726f2fae4/bin/templates/scripts/cordova/lib/run.js#L111 On Fri, Apr 24, 2015 at 10:44 AM, Carl

Is there a way to specify the ios device to run?

2015-04-24 Thread Carlos Santana
If I have two iOS devices plug to USB. How can I select which one I want to deploy the App? cordova run ios --target doesn't work Is this a bug, a limitation on ios-deploy, by design, etc..? -- Carlos Santana

Bug : cordova 5.0.0 & cordova-plugin-camera

2015-04-24 Thread Clement Mellinas
Hi, I saw the annoucement of Cordova 5.0.0 and I updated it and all cordova plugins. But, now I can't build my project due to the *'cordova-plugin-camera' *and specifically this file : *https://github.com/apache/cordova-plugin-camera/blob/master/src/android/CameraLauncher.java

Buildbot: buildslave cordova-ios-slave was lost

2015-04-24 Thread buildbot
The Buildbot working for 'ASF Buildbot' has noticed that the buildslave named cordova-ios-slave went away It last disconnected at Fri Apr 24 16:42:04 2015 (buildmaster-local time) The admin on record (as reported by BUILDSLAVE:info/admin) was 'Dmitry Blotsky '. Sincerely, The Buildbot http://

[GitHub] cordova-plugin-splashscreen pull request: Add fullscreen options

2015-04-24 Thread TheBosZ
Github user TheBosZ commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-95968778 The options are not the same as those options change the whole project while these only affect the splash screen. We have a client that's requested t

[GitHub] cordova-android pull request: CB-8902: use immersive mode when ava...

2015-04-24 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/175#discussion_r29046696 --- Diff: framework/src/org/apache/cordova/CordovaActivity.java --- @@ -130,6 +147,18 @@ public void onCreate(Bundle savedInstanceState) {

[GitHub] cordova-android pull request: CB-8902: use immersive mode when ava...

2015-04-24 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/175#discussion_r29046647 --- Diff: framework/src/org/apache/cordova/CordovaActivity.java --- @@ -115,8 +116,24 @@ public void onCreate(Bundle savedInstanceState) {

[GitHub] cordova-android pull request: CB-8902: use immersive mode when ava...

2015-04-24 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/175#discussion_r29046516 --- Diff: framework/src/org/apache/cordova/CordovaActivity.java --- @@ -115,8 +116,24 @@ public void onCreate(Bundle savedInstanceState) {

[GitHub] cordova-android pull request: CB-8902: use immersive mode when ava...

2015-04-24 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/175#discussion_r29046326 --- Diff: framework/src/org/apache/cordova/CordovaActivity.java --- @@ -130,6 +147,18 @@ public void onCreate(Bundle savedInstanceState) {

[GitHub] cordova-plugin-splashscreen pull request: Add fullscreen options

2015-04-24 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/45#discussion_r29045956 --- Diff: src/android/SplashScreen.java --- @@ -254,8 +262,12 @@ public void run() { } splashDia

[GitHub] cordova-plugin-splashscreen pull request: Add fullscreen options

2015-04-24 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/45#discussion_r29045852 --- Diff: README.md --- @@ -54,12 +54,18 @@ In your `config.xml`, you need to add the following preferences:

[GitHub] cordova-plugin-file-transfer pull request: CB-8761 [wp8]: Copy coo...

2015-04-24 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/74#discussion_r29036352 --- Diff: src/wp/FileTransfer.cs --- @@ -210,6 +216,77 @@ public FileTransferProgress(long bTotal = 0, long bLoaded = 0)

[GitHub] cordova-plugin-file-transfer pull request: CB-8761 [wp8]: Copy coo...

2015-04-24 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/74#discussion_r29036350 --- Diff: src/wp/FileTransfer.cs --- @@ -210,6 +216,77 @@ public FileTransferProgress(long bTotal = 0, long bLoaded = 0)

[GitHub] cordova-plugin-file-transfer pull request: CB-8761 [wp8]: Copy coo...

2015-04-24 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/74#discussion_r29036346 --- Diff: src/wp/FileTransfer.cs --- @@ -210,6 +216,77 @@ public FileTransferProgress(long bTotal = 0, long bLoaded = 0)