[GitHub] cordova-medic pull request: CB-9196 Medic cleanup

2015-06-16 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-medic/pull/56 CB-9196 Medic cleanup CB-9196 Adding JSHint config for medic. Making medic-log return an error code. Making `medic-clean`'s `--exclude` flag repeatable. Making `medic-clean` take a target di

[GitHub] cordova-plugin-file pull request: NPE fix

2015-06-16 Thread Greunlis
GitHub user Greunlis opened a pull request: https://github.com/apache/cordova-plugin-file/pull/117 NPE fix Our application suddenly stopped working on Android, I found out, it was because of this NullPointerException. You can merge this pull request into a Git repository by running

[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores

2015-06-16 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-coho/pull/86 CB-9109 Switching to using .ratignores Switched to using a repository's `.ratignore` file instead of the `ratExcludes` property inside of coho. You can merge this pull request into a Git repo

[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...

2015-06-16 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-112617030 Sweet! Thanks. I'll take a look tonight/tomorrow and see if we can figure this out. Let me know if you come up with any findings. We may have to open

[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...

2015-06-16 Thread agamemnus
Github user agamemnus commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-112616455 I can't re-open it. Reproduce steps would be to use any Google Expansion File plugin (like mine here, and see these steps to update to Cordova 5: http

[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...

2015-06-16 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-112616193 Any chance you can give me some steps to reproduce it? --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...

2015-06-16 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-112615819 I think only you or apache infra people can re-open it. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...

2015-06-16 Thread agamemnus
Github user agamemnus commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-112615378 It is still closed. You have to re-open it manually. (button below comment textbox) My changes did fix the issue for me, but only because I ha

[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...

2015-06-16 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-112615358 This is a pretty big problem IMO. File plugin not working. I am going to test it to see if I can reproduce the issues. A better solution would be if t

[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...

2015-06-16 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-112614830 Reverted it. Hopefully this PR opens agian --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...

2015-06-16 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-112614600 Argh, Just merged it in haha. I am going to revert it so we have more time to test. Looks like it is causing problems. I'd say we stick with

[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...

2015-06-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-whitelist/pull/6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...

2015-06-16 Thread agamemnus
Github user agamemnus commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-112611552 (And to be honest, I am fuzzy about what ``allowedNavigations``, ``allowedRequests``, and ``allowedIntents`` exactly mean.) --- If your project is se

[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...

2015-06-16 Thread agamemnus
Github user agamemnus commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-112611004 Actually, hold on a second. The change is not quite what the title says. It only automatically whitelists ``content://``, ``cdvfile://``, and ``file://

Re: [VOTE] Cordova Serve 0.1.2 release

2015-06-16 Thread Jesse
You need to leave the vote open longer than 23 hours ... 72 is the usual, as there may be -1s coming ( not likely, but we have to leave the window open ) @purplecabbage risingj.com On Tue, Jun 16, 2015 at 5:08 PM, Steven Gill wrote: > I would say no. We can point to the release notes during the

[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...

2015-06-16 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-112609463 This looks good to me. I'll merge it in --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

Re: [VOTE] Cordova Serve 0.1.2 release

2015-06-16 Thread Steven Gill
I would say no. We can point to the release notes during the next tools release or something. On Tue, Jun 16, 2015 at 5:07 PM, Tim Barham wrote: > The vote has now closed. The results are: > > Positive binding votes: 4 > Tim Barham > Vladimir Kotikov > Steven Gill > Jesse MacFadyen > > The vote

RE: [VOTE] Cordova Serve 0.1.2 release

2015-06-16 Thread Tim Barham
The vote has now closed. The results are: Positive binding votes: 4 Tim Barham Vladimir Kotikov Steven Gill Jesse MacFadyen The vote has passed. Thanks all! I will publish to dist and npm. Question: Does a release like this require a blog post? Thanks, Tim -Original Message- From: Je

[GitHub] cordova-registry-web pull request: CB-9194 Created faq page and ad...

2015-06-16 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-registry-web/pull/13#issuecomment-112604724 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] cordova-plugin-media pull request: fix record and play NullPointer...

2015-06-16 Thread uareurapid
Github user uareurapid commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/56#issuecomment-112604611 Ok thank you --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] cordova-registry-web pull request: CB-9195 Sorting platforms and a...

2015-06-16 Thread rakatyal
GitHub user rakatyal opened a pull request: https://github.com/apache/cordova-registry-web/pull/14 CB-9195 Sorting platforms and adding more option You can merge this pull request into a Git repository by running: $ git pull https://github.com/rakatyal/cordova-registry-web rag

Re: [VOTE] Cordova Serve 0.1.2 release

2015-06-16 Thread Jesse
+1 ran coho verify-archive reviewed code @purplecabbage risingj.com On Tue, Jun 16, 2015 at 4:27 PM, Steven Gill wrote: > +1 > > * Verified archive using coho verify-archive command > * Manually looked at files. Looks good. > > On Tue, Jun 16, 2015 at 12:34 AM, Vladimir Kotikov (Akvelon) < > v

[GitHub] cordova-registry-web pull request: CB-9194 Created faq page and ad...

2015-06-16 Thread muratsu
GitHub user muratsu opened a pull request: https://github.com/apache/cordova-registry-web/pull/13 CB-9194 Created faq page and added header Live demo at: http://people.apache.org/~muratsu/index.html You can merge this pull request into a Git repository by running: $ git pull h

Re: [VOTE] Cordova Serve 0.1.2 release

2015-06-16 Thread Steven Gill
+1 * Verified archive using coho verify-archive command * Manually looked at files. Looks good. On Tue, Jun 16, 2015 at 12:34 AM, Vladimir Kotikov (Akvelon) < v-vlk...@microsoft.com> wrote: > I vote +1 > > * Verified license headers for the cordova-serve > * Verified archive from dist for cordov

[GitHub] cordova-plugin-console pull request: CB-9191 Add basic test

2015-06-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-console/pull/11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Facebook infer on Cordova / plugins

2015-06-16 Thread Axel Nennker
Hi, I ran infer on one of my projects and get the output below. I looked only at the first issue reported and it I think it is an issue and easy to fix. http://fbinfer.com/docs/hello-world.html#hello-world-android Maybe this should be run on all Android plugins and Cordova Android code from time

[GitHub] cordova-plugin-console pull request: CB-9191 Add basic test

2015-06-16 Thread purplecabbage
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-plugin-console/pull/11 CB-9191 Add basic test This pr is just to see if travis likes what it sees. I will be adding more tests shortly. You can merge this pull request into a Git repository by run

[GitHub] cordova-ios pull request: Fix Q include in check_reqs.js

2015-06-16 Thread jhampton
Github user jhampton commented on the pull request: https://github.com/apache/cordova-ios/pull/132#issuecomment-112565149 Ditto - our team is currently unable to build a project because of this bug. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-lib pull request: fix CB-9145 prepare can lose data during...

2015-06-16 Thread tony--
Github user tony-- commented on the pull request: https://github.com/apache/cordova-lib/pull/242#issuecomment-112557560 Merged commit [2598231](https://github.com/tony--/cordova-lib/commit/25982317b26c831dbea9d6b71dd57a90b933fc68) into apache:master, closing. --- If your project is

[GitHub] cordova-lib pull request: fix CB-9145 prepare can lose data during...

2015-06-16 Thread tony--
Github user tony-- closed the pull request at: https://github.com/apache/cordova-lib/pull/242 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: CB-9162 - Default Variables

2015-06-16 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/247#issuecomment-112552487 Thanks for the update, @ogoguel. Squashed and merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] cordova-lib pull request: CB-9162 - Default Variables

2015-06-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/247 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: CB-9162 - Default Variables

2015-06-16 Thread ogoguel
Github user ogoguel commented on the pull request: https://github.com/apache/cordova-lib/pull/247#issuecomment-112522204 Added missing test for variables parsing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[iOS] Remove non-CLI template

2015-06-16 Thread Shazron
I propose to remove the non-CLI template starting in cordova-ios 4.0.0. It was originally used to easily test your own plugins, but now we have the alternative using the CLI: cordova plugin add --link path/to/your/plugin

[GitHub] cordova-lib pull request: CB-9188 Confusing error after delete plu...

2015-06-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/249 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-ios pull request: CB-8197 Switch to nodejs for ios platfor...

2015-06-16 Thread shazron
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/146#discussion_r32547846 --- Diff: bin/templates/project/__CLI__.xcodeproj/project.pbxproj --- @@ -374,7 +374,7 @@ ); runOnlyForDep

[GitHub] cordova-lib pull request: CB-9188 Confusing error after delete plu...

2015-06-16 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/249 CB-9188 Confusing error after delete plugin folder then prepare. Catch this scenario and display a useful message. You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-lib pull request: CB-9122 Added tests for platform/plugin ...

2015-06-16 Thread omefire
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/246#discussion_r32539540 --- Diff: cordova-lib/spec-cordova/save.spec.js --- @@ -0,0 +1,435 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] cordova-coho pull request: Handle multiple modules within a single...

2015-06-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/85 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-ios pull request: CB-8197 Switch to nodejs for ios platfor...

2015-06-16 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-ios/pull/146#issuecomment-112483772 LGTM. Adding `glob` does increase the size of ios platform considerably. I'm assuming there is no other cheaper way to do this. --- If your project is set up for

[GitHub] cordova-ios pull request: CB-8197 Switch to nodejs for ios platfor...

2015-06-16 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/146#discussion_r32538324 --- Diff: bin/templates/project/__CLI__.xcodeproj/project.pbxproj --- @@ -374,7 +374,7 @@ ); runOnlyForDe

[GitHub] cordova-coho pull request: CB-8214 COHO. Rename windowsphone to wp...

2015-06-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/60 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: fix CB-9145 prepare can lose data during...

2015-06-16 Thread tony--
Github user tony-- commented on the pull request: https://github.com/apache/cordova-lib/pull/242#issuecomment-112480771 AND I screwed up my first commit comment by prepending the word "fix" before the JIRA issue. I will adhere to the formatting guidelines in the future. --- If your

Re: [DISCUSS] 5.1.1 Docs Release?

2015-06-16 Thread Victor Sosa
Thanks Steven, just verified them On Mon, Jun 15, 2015 at 7:29 PM Steven Gill wrote: > docs have been released! > > On Fri, Jun 12, 2015 at 8:06 AM, Victor Sosa > wrote: > > > Hi Steven. > > > > Translations are committed now and I did a quick check on the docs. > > Translations are there. Coul

[GitHub] cordova-coho pull request: Handle multiple modules within a single...

2015-06-16 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-coho/pull/85#issuecomment-112478743 Thanks @stevengill! Will merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cordova-lib pull request: fix CB-9145 prepare can lose data during...

2015-06-16 Thread tony--
Github user tony-- commented on the pull request: https://github.com/apache/cordova-lib/pull/242#issuecomment-112409200 Thanks @purplecabbage! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-lib pull request: CB-9122 Added tests for platform/plugin ...

2015-06-16 Thread alsorokin
Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/246#discussion_r32515523 --- Diff: cordova-lib/spec-cordova/save.spec.js --- @@ -0,0 +1,435 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] cordova-plugin-file-transfer pull request: Fix/wp8 browser cookies

2015-06-16 Thread mlaponder
GitHub user mlaponder opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/90 Fix/wp8 browser cookies [wp8] Make it possible to use the webview's cookiestore to do HTTP requests On the wp8 platform, cookies used to be always copied from the webv

[GitHub] cordova-plugin-inappbrowser pull request: CB-9158 - InAppBrowser z...

2015-06-16 Thread syndbg
Github user syndbg commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/104#issuecomment-112385310 The white spaces are automatically stripped by my text editor. --- If your project is set up for it, you can reply to this email and have your reply

RE: [VOTE] Cordova Serve 0.1.2 release

2015-06-16 Thread Vladimir Kotikov (Akvelon)
I vote +1 * Verified license headers for the cordova-serve * Verified archive from dist for cordova-serve * Installed cordova-serve@rc from npm and verified that it works correctly with corresponding cordova-lib version --- Best regards, Vladimir -Original Message- From: Ti