[GitHub] cordova-medic pull request: CB-8936 Gathering logs on Windows

2015-07-15 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/58#discussion_r34749192 --- Diff: medic/medic-run.js --- @@ -232,12 +233,18 @@ function windowsSpecificPreparation(argv) { /^\s*\$appActivator .*$/gim,

[GitHub] cordova-coho pull request: CB-9361 Make verify-tags working nicely...

2015-07-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/91 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-medic pull request: CB-8936 Gathering logs on Windows

2015-07-15 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/58#discussion_r34749430 --- Diff: medic/medic-run.js --- @@ -232,12 +233,18 @@ function windowsSpecificPreparation(argv) { /^\s*\$appActivator .*$/gim,

Re: [DISCUSS] Release Cordova Plugin npm Search

2015-07-15 Thread Carlos Santana
dumb question why we are using npmsearch? and not a direct api to npmjs, like I said it might be a dumb question On Mon, Jul 13, 2015 at 6:39 PM Steven Gill stevengil...@gmail.com wrote: Murat and I are going to meet tomorrow to try and launch this to plugins.cordova.io. Once it is out there,

Re: [DISCUSS] Release Cordova Plugin npm Search

2015-07-15 Thread Murat Sutunc
There's no such thing as dumb questions! npmjs sadly doesn't give out much information about packages.. From what I recall, they didnt have author name and license information.. which are important for us. On Jul 15, 2015, at 9:06 PM, Carlos Santana csantan...@gmail.com wrote: dumb

Re: [Android] Working with M - An update

2015-07-15 Thread Carlos Santana
So far permissions is the only thing we saw that would require some thinking for Android M, other features are OK. I would prefer to open a bug and push very hard and get Andrew to fix geolocation thant bringing the geo plugin from the dead. With Android M, we should try to follow what the

Re: Google Analytics on Cordova Docs

2015-07-15 Thread Andrey Kurdumov
Anybody please publish update with GA code to the website. 2015-07-10 10:31 GMT+06:00 Andrey Kurdumov kant2...@googlemail.com: Docs still not updated with latest GA code, and I would like to have access to that GA account too :) 2015-07-10 4:20 GMT+06:00 Carlos Santana csantan...@gmail.com:

Re: Oz

2015-07-15 Thread Carlos Santana
software and research can do anything even send a a probe to Pluto :-) On Mon, Jul 13, 2015 at 12:28 PM Jesse purplecabb...@gmail.com wrote: It is possible and it involves research. Cheers, Jesse On Jul 12, 2015, at 2:43 PM, Ozy Oz o...@ozyoz.com wrote: Hello, We are

[GitHub] cordova-windows pull request: CB-9359: Adds support for .appxbundl...

2015-07-15 Thread robpaveza
Github user robpaveza commented on the pull request: https://github.com/apache/cordova-windows/pull/102#issuecomment-121792352 I don't really have a preference. We could say be consistent with msbuild and do a pipe separator but I don't think that is terribly valuable. The

[GitHub] cordova-windows pull request: CB-9359: Adds support for .appxbundl...

2015-07-15 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-windows/pull/102#issuecomment-121792934 Sounds fair! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-coho pull request: CB-9361 Make verify-tags working nicely...

2015-07-15 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-coho/pull/91#issuecomment-121795384 Tried on bash and cmd on Windows, and on bash on OSX; all work fine. LGTM! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-medic pull request: CB-8936 Gathering logs on Windows

2015-07-15 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/58#discussion_r34748954 --- Diff: medic/medic-run.js --- @@ -222,6 +222,7 @@ function windowsSpecificPreparation(argv) { var appUtilsPath = path.join(libPath,

[GitHub] cordova-plugin-media pull request: CB-9238 Media plugin cannot rec...

2015-07-15 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/58#issuecomment-121547583 @robpaveza, thanks for review, I have addressed your comments. --- If your project is set up for it, you can reply to this email and have your reply

Re: [Android] Working with M - An update

2015-07-15 Thread Andrew Grieve
Thanks for looking into this Joe! The runtime permissions is quite a big change! M is still in preview, so if you find any webview bugs, please feel free to send me a repro app and I'll do my best to get it fixed. In terms of Cordova API changes, here's some thoughts on your branch: - Plugins

[GitHub] cordova-registry-web pull request: Improve the gulp workflow to in...

2015-07-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-registry-web/pull/25 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request: CB-8627: Only update fetch.json when plu...

2015-07-15 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-lib/pull/228#issuecomment-121700137 What's the status on this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-registry-web pull request: Improve the gulp workflow to in...

2015-07-15 Thread nikhilkh
GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-registry-web/pull/25 Improve the gulp workflow to include support for browser-sync and use… … envify to create React production build. You can merge this pull request into a Git repository by running:

[GitHub] cordova-js pull request: CB-9370 Fixes failing tests on Node 0.12 ...

2015-07-15 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-js/pull/121#discussion_r34707474 --- Diff: package.json --- @@ -9,7 +9,7 @@ url: http://git-wip-us.apache.org/repos/asf/cordova-js.git; }, engines: { -

[DISCUSS] Tools Release

2015-07-15 Thread Steven Gill
We have some important bug fixes that need to go out for the CLI. Going to do a full tools release Any roadblocks? Any PRs I should look at? I'm going to be merging https://github.com/apache/cordova-lib/pull/254

[GitHub] cordova-registry-web pull request: Change batch size for XHR reque...

2015-07-15 Thread nikhilkh
GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-registry-web/pull/26 Change batch size for XHR requests to improve perf This is based on previous PR: https://github.com/apache/cordova-registry-web/pull/25. Only cfd52c4 is new. You can merge this pull

[GitHub] cordova-js pull request: CB-9366 Log error.stack as it helps with ...

2015-07-15 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-js/pull/118#issuecomment-121736314 Not a huge deal. I was assuming that most errors here would be the result of a missing callback, in which case stack.length is 0. In the case where the

[GitHub] cordova-js pull request: CB-9370 Fixes failing tests on Node 0.12 ...

2015-07-15 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-js/pull/121#issuecomment-121743440 lgtm! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-windows pull request: add build matrix

2015-07-15 Thread purplecabbage
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-windows/pull/103 add build matrix Testing to see if this resolves our AppVeyor issues with recent builds. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-js pull request: CB-9366 Log error.stack as it helps with ...

2015-07-15 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-js/pull/118#issuecomment-121752375 If you have multiple calls to cordova methods and one of them might be missing a callback or passing another incorrect argument (like in a scenario similar to the

[GitHub] cordova-windows pull request: CB-9359: Adds support for .appxbundl...

2015-07-15 Thread robpaveza
GitHub user robpaveza opened a pull request: https://github.com/apache/cordova-windows/pull/101 CB-9359: Adds support for .appxbundle creation .appxbundle files are convenient app packages which can be uploaded to the Windows Store. They contain debug or release (typically

[GitHub] cordova-windows pull request: CB-9359: Adds support for .appxbundl...

2015-07-15 Thread robpaveza
Github user robpaveza closed the pull request at: https://github.com/apache/cordova-windows/pull/101 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-windows pull request: CB-9359: Adds support for .appxbundl...

2015-07-15 Thread robpaveza
GitHub user robpaveza opened a pull request: https://github.com/apache/cordova-windows/pull/102 CB-9359: Adds support for .appxbundle creation .appxbundle files are convenient app packages which can be uploaded to the Windows Store. They contain debug or release (typically

Re: Buildbot: buildslave cordova-windows-slave was lost

2015-07-15 Thread Dmitry Blotsky
Just noticed this, but it seems like both machines are back up. Seems like a short-lived network issue. Kindly, Dmitry On Jul 13, 2015, at 8:49 PM, build...@apache.org wrote: The Buildbot working for 'ASF Buildbot' has noticed that the buildslave named cordova-windows-slave went away It

[GitHub] cordova-windows pull request: CB-9359: Adds support for .appxbundl...

2015-07-15 Thread robpaveza
Github user robpaveza commented on the pull request: https://github.com/apache/cordova-windows/pull/101#issuecomment-121745707 I see a different history on AppVeyor than on my machine, I'm going to close the PR and re-create. --- If your project is set up for it, you can reply to

Re: [Android] Working with M - An update

2015-07-15 Thread Joe Bowser
On Wed, Jul 15, 2015 at 11:12 AM Andrew Grieve agri...@chromium.org wrote: Thanks for looking into this Joe! The runtime permissions is quite a big change! M is still in preview, so if you find any webview bugs, please feel free to send me a repro app and I'll do my best to get it fixed.

[GitHub] cordova-windows pull request: CB-9359: Adds support for .appxbundl...

2015-07-15 Thread robpaveza
Github user robpaveza commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/102#discussion_r34741242 --- Diff: template/cordova/lib/MSBuildTools.js --- @@ -38,6 +38,13 @@ MSBuildTools.prototype.buildProject = function(projFile, buildType,

[GitHub] cordova-lib pull request: CB-9330 Removes 'plugman publish' relate...

2015-07-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/254 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-windows pull request: CB-9359: Adds support for .appxbundl...

2015-07-15 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-windows/pull/102#issuecomment-121789647 Small question: do you think it's better to have an argument contain multiple values with an arbitrary separator (in other tools we sometimes use commas, or

[GitHub] cordova-windows pull request: add build matrix

2015-07-15 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/103#issuecomment-121755583 Okay, we have the same issues that cordova-js was having with node v0.12 failing and v0.10 succeeding. What is the proper way to fix this? --- If

Re: [CI] Medic Update

2015-07-15 Thread Dmitry Blotsky
I’m 100% down for a test matrix. My idea for CI triggers and schedule is as follows: - on commit to a tool, run its “npm test” - on commit to a platform, run its “npm test” - on commit to a plugin, run its “npm test”, create mobilespec, and run “cordova build” - 2 times a day, run E2E For E2E,

[GitHub] cordova-windows pull request: add build matrix

2015-07-15 Thread purplecabbage
Github user purplecabbage closed the pull request at: https://github.com/apache/cordova-windows/pull/103 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-windows pull request: Lock AppVeyor environment node versi...

2015-07-15 Thread purplecabbage
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-windows/pull/104 Lock AppVeyor environment node version at 0.10 for now. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-registry-web pull request: Change batch size for XHR reque...

2015-07-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-registry-web/pull/26 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-medic pull request: CB-9172 Retry running tests if somethi...

2015-07-15 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/57#issuecomment-121764740 This is a really hacky way to do retries in Buildbot, and I don't think we should do it. There is a way for this to be done in the script we call, so let's keep

[GitHub] cordova-windows pull request: CB-9359: Adds support for .appxbundl...

2015-07-15 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/102#discussion_r34736868 --- Diff: template/cordova/lib/MSBuildTools.js --- @@ -38,6 +38,13 @@ MSBuildTools.prototype.buildProject = function(projFile, buildType,

[GitHub] cordova-js pull request: CB-9370 Fixes failing tests on Node 0.12 ...

2015-07-15 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-js/pull/121 CB-9370 Fixes failing tests on Node 0.12 due to stale dependency This PR fixes tests on AppVeyor, broken by updated NodeJS on CI machines as described in

[GitHub] cordova-lib pull request: CB-9371: Don't delete orientation prefer...

2015-07-15 Thread cjpearson
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-lib/pull/260 CB-9371: Don't delete orientation preferences by default You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-lib

[GitHub] cordova-js pull request: CB-9366 Log error.stack as it helps with ...

2015-07-15 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-js/pull/118#issuecomment-121640154 What's the downside of adding this? This is really an exceptional scenario and should not hit commonly to clutter console log with ugly stack traces. Also,

[GitHub] cordova-js pull request: CB-9370 Fixes failing tests on Node 0.12 ...

2015-07-15 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-js/pull/121#issuecomment-121638909 LGTM overall. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-js pull request: CB-9370 Fixes failing tests on Node 0.12 ...

2015-07-15 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-js/pull/121#discussion_r34685625 --- Diff: package.json --- @@ -9,7 +9,7 @@ url: http://git-wip-us.apache.org/repos/asf/cordova-js.git; }, engines: { -

[GitHub] cordova-js pull request: CB-9370 Fixes failing tests on Node 0.12 ...

2015-07-15 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-js/pull/121#discussion_r34686348 --- Diff: package.json --- @@ -9,7 +9,7 @@ url: http://git-wip-us.apache.org/repos/asf/cordova-js.git; }, engines: { -