[GitHub] cordova-lib pull request: CB-9291 Fixes Appveyor build failure

2015-07-17 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/264 CB-9291 Fixes Appveyor build failure This fixes Appveyor build failure, introduced by https://github.com/apache/cordova-js/commit/eb620e2934e2d6706e71a2f8957343935d6dcf32 You can

[GitHub] cordova-plugin-device pull request: Change UUID to use [UIDevice i...

2015-07-17 Thread cjpearson
Github user cjpearson commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/36#issuecomment-122255716 I think you might still want to check in user defaults first, so the uuid value doesn't change for users who already had the app installed. --- If

[GitHub] cordova-windows pull request: CB-9159 Fix Windows Phone 8.1 deploy...

2015-07-17 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/91#issuecomment-122286092 I'll see if this is still actual and will do rebase on Monday. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-windows pull request: CB-9159 Fix Windows Phone 8.1 deploy...

2015-07-17 Thread sgrebnov
Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/91#discussion_r34892373 --- Diff: template/cordova/lib/run.js --- @@ -169,20 +135,10 @@ module.exports.help = function () { process.exit(0); }; -

[GitHub] cordova-plugin-file-transfer pull request: CB-9376 Fix FileTransfe...

2015-07-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/94 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-android pull request: cdvBuildMultipleApks casting fixed

2015-07-17 Thread mlegenhausen
GitHub user mlegenhausen opened a pull request: https://github.com/apache/cordova-android/pull/199 cdvBuildMultipleApks casting fixed Casting `cdvBuildMultipleApks` via `!!` does not work when you want to modify the build process via the command line. The problem can be simply

[GitHub] cordova-android pull request: cdvBuildMultipleApks casting fixed

2015-07-17 Thread mlegenhausen
Github user mlegenhausen commented on the pull request: https://github.com/apache/cordova-android/pull/199#issuecomment-122279880 I found a workaround: `cordova build android -- --gradleArg=-PcdvBuildMultipleApks=''`. The problem really bothers when you want to use the

[GitHub] cordova-plugin-file-transfer pull request: CB-9376 Fix FileTransfe...

2015-07-17 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/94#issuecomment-122281766 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-lib pull request: CB-9332 Upgrade npm and semver to actual...

2015-07-17 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/263#issuecomment-122267015 LGTM/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: Discuss Android plugin compatibility problem

2015-07-17 Thread Carlos Santana
What's the problem Joe? Having declaring cradle dependencies in plugin.xml I think is a good thing. At high level a plugin should be able to some how declare its dependencies for things located in gradle/maven via plugin.xml, a metada file, or hook. We in IBM are using gradle in plugin.xml for

Re: Discuss Android plugin compatibility problem

2015-07-17 Thread Carlos Santana
Stupid iOS autocorrect had a bunch of typos gradle not cradle On Fri, Jul 17, 2015 at 9:06 AM Carlos Santana csantan...@gmail.com wrote: What's the problem Joe? Having declaring cradle dependencies in plugin.xml I think is a good thing. At high level a plugin should be able to some how

[GitHub] cordova-plugman pull request: CB-9332 Removes unnecessary dependen...

2015-07-17 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugman/pull/85#issuecomment-122265904 LGTM. Let's get this in before the release. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-lib pull request: CB-9332 Upgrade npm and semver to actual...

2015-07-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/263 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-9332 Upgrade npm and semver to actual...

2015-07-17 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/263#discussion_r34887344 --- Diff: cordova-lib/package.json --- @@ -22,20 +22,19 @@ cordova-js: 4.0.0, cordova-registry-mapper: 1.x, cordova-serve:

[GitHub] cordova-lib pull request: CB-9291 Fixes Appveyor build failure

2015-07-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/264 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-9332 Upgrade npm and semver to actual...

2015-07-17 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/263#discussion_r34888109 --- Diff: cordova-lib/package.json --- @@ -22,20 +22,19 @@ cordova-js: 4.0.0, cordova-registry-mapper: 1.x,

[GitHub] cordova-plugman pull request: CB-9332 Removes unnecessary dependen...

2015-07-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugman/pull/85 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-file-transfer pull request: Return FILE_NOT_FOUND_E...

2015-07-17 Thread Ganster41
GitHub user Ganster41 opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/95 Return FILE_NOT_FOUND_ERR when receiving 404 code on iOS, same as on Android If I receive 404 response code, when downloading file, I got FILE_NOT_FOUND_ERR on Android and

[GitHub] cordova-android pull request: CB-9382 [Android] Fix KeepRunning se...

2015-07-17 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-android/pull/200 CB-9382 [Android] Fix KeepRunning setting when Plugin activity is showed https://issues.apache.org/jira/browse/CB-9382 You can merge this pull request into a Git repository by running:

Re: Discuss Android plugin compatibility problem

2015-07-17 Thread Joe Bowser
I'm fine with it. I just spaced out and forgot we did that for Crosswalk. I thought we had a reference to a gradle file instead. On Fri, Jul 17, 2015 at 6:14 AM Carlos Santana csantan...@gmail.com wrote: What's the problem Joe? Having declaring cradle dependencies in plugin.xml I think is a

[GitHub] cordova-plugin-device-motion pull request: CB-9339 Increase the de...

2015-07-17 Thread gdehaan
Github user gdehaan commented on the pull request: https://github.com/apache/cordova-plugin-device-motion/pull/32#issuecomment-122312399 I have the same problem with Nexus 4 phone on 5.1.1. I added some logging and I never see the onAccuracyChanged callback. --- If your project

[GitHub] cordova-registry-web pull request: Use gulp-serve instead of brows...

2015-07-17 Thread muratsu
GitHub user muratsu opened a pull request: https://github.com/apache/cordova-registry-web/pull/27 Use gulp-serve instead of browser-sync Two problems I've encountered: - On Windows, browser-sync depends on VS and python 2.x. - On Windows, 2 of my machines ran into 256

[GitHub] cordova-plugin-device pull request: Change UUID to use [UIDevice i...

2015-07-17 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/36#issuecomment-122194054 First of all, an issue is needed before merging this, create a new one here http://issues.cordova.io/ and use the identifier you get on this pull

[GitHub] cordova-lib pull request: restore-util.js can't handle git urls

2015-07-17 Thread hstaudacher
GitHub user hstaudacher opened a pull request: https://github.com/apache/cordova-lib/pull/262 restore-util.js can't handle git urls When adding a plugin to the config.xml using a git url e.g. plugin name=https://...; / a spec is not needed because the plugin needs to be checked

[GitHub] cordova-lib pull request: restore-util.js can't handle git urls

2015-07-17 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/262#issuecomment-122217955 Ooops, updated my comments, now you should see the examples. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-android pull request: CB-9372: Remove unused files: 'main....

2015-07-17 Thread omefire
GitHub user omefire opened a pull request: https://github.com/apache/cordova-android/pull/198 CB-9372: Remove unused files: 'main.js' 'master.css' CB-9372: Remove unused files: 'main.js' 'master.css' You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-lib pull request: Change cordova-lib to execute plugin hoo...

2015-07-17 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/236#issuecomment-122213253 What's the reason behind this proposed change ? What use case does this fulfill ? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-lib pull request: restore-util.js can't handle git urls

2015-07-17 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/262#issuecomment-122218149 Also keep in mind that instead of modifying the config.xml manually, you can do : `cordova plugin add https://github.com/apache/cordova-plugin-file.git --save` and

Re: [DISCUSS] cordova-ios 3.9.0 release

2015-07-17 Thread julio cesar sanchez
+1 2015-07-17 6:24 GMT+02:00 Carlos Santana csantan...@gmail.com: +1 I think MS mentioned they wanted to cherry pick the signing using build.json On Thu, Jul 16, 2015 at 7:25 PM Shazron shaz...@gmail.com wrote: From the hangout today someone mentioned fixes that need to go out, 4.x was

[GitHub] cordova-lib pull request: restore-util.js can't handle git urls

2015-07-17 Thread hstaudacher
Github user hstaudacher commented on the pull request: https://github.com/apache/cordova-lib/pull/262#issuecomment-122212722 sorry don't see your examples --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-lib pull request: restore-util.js can't handle git urls

2015-07-17 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/262#issuecomment-122212324 Hey @hstaudacher, I think you're using the plugin syntax within config.xml in a wrong way. It's not supposed to be : plugin name=https://...; / It

Re: Discuss Android plugin compatibility problem

2015-07-17 Thread Mefire O .
So, it seems like mechanisms are already in place to enable us to do what we wanna do here. The actionable step I'm seeing here is 'updating the docs to ask plugin devs to use plugin.xml to define gradle dependencies'. If you folks agree with what this actionable item, I will create a jira

RE: [DISCUSS] cordova-ios 3.9.0 release

2015-07-17 Thread Nikhil Khandelwal
+1. Yes, let's do it. Thanks, Shaz! Let me know if I can help here - though I still don’t have good judgement on iOS on what should go out and what should not. Thanks, Nikhil -Original Message- From: julio cesar sanchez [mailto:jcesarmob...@gmail.com] Sent: Thursday, July 16, 2015

RE: [DISCUSS] Release Cordova-Android 4.1.0

2015-07-17 Thread Nikhil Khandelwal
Joe: Are you working on doing this release? Do you need help? It would be good to have this done before we do the next tools release - which also has a discuss thread. Thanks, Nikhil -Original Message- From: Joe Bowser [mailto:bows...@gmail.com] Sent: Thursday, July 9, 2015 9:47 AM

RE: Discuss Android plugin compatibility problem

2015-07-17 Thread Sergey Grebnov (Akvelon)
Agree, sounds like a good plan. I'm going to review and fix this in most popular cordova plugins and having this as an official recommendation I can refer to will be great (part of Android plugins dev guide). PS. I've also double checked Cordova core plugins and they are not affected (there

[GitHub] cordova-plugman pull request: CB-9332 Removes unnecessary dependen...

2015-07-17 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugman/pull/85 CB-9332 Removes unnecessary dependencies You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugman CB-9332

[GitHub] cordova-lib pull request: CB-9332 Upgrade npm and semver to actual...

2015-07-17 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/263 CB-9332 Upgrade npm and semver to actual versions This PR upgrades npm and semver to actual versions. See https://issues.apache.org/jira/browse/CB-9332 You can merge this pull

[GitHub] cordova-lib pull request: restore-util.js can't handle git urls

2015-07-17 Thread hstaudacher
Github user hstaudacher commented on the pull request: https://github.com/apache/cordova-lib/pull/262#issuecomment-122248878 Alright, thanks guys, I couldn't find any documentation for this. Will close the request now. --- If your project is set up for it, you can reply to this

[GitHub] cordova-lib pull request: restore-util.js can't handle git urls

2015-07-17 Thread hstaudacher
Github user hstaudacher closed the pull request at: https://github.com/apache/cordova-lib/pull/262 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request: restore-util.js can't handle git urls

2015-07-17 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/262#issuecomment-122245665 To clarify - the `name` is always the plugin name/id. The `spec` is either a version, a version range, or a location (locar folder, tarball, git repo) to get the

Re: [DISCUSS] Release Cordova-Android 4.1.0

2015-07-17 Thread Joe Bowser
I haven't started on this release at all yet. I can start the release process on Monday but I'm on PTO on the 25th so someone else should really handle this one. Cutting releases is a long and frustrating process, and trying to rush it always leads to disaster. On Fri, Jul 17, 2015, 9:29 AM

RE: [DISCUSS] Release Cordova-Android 4.1.0

2015-07-17 Thread Nikhil Khandelwal
I can take this up. Thanks! Look out for the VOTE thread soon. Thanks, Nikhil -Original Message- From: Joe Bowser [mailto:bows...@gmail.com] Sent: Friday, July 17, 2015 9:43 AM To: dev@cordova.apache.org Subject: Re: [DISCUSS] Release Cordova-Android 4.1.0 I haven't started on this

FW: Github - Ability to add tags to pull requests

2015-07-17 Thread Nikhil Khandelwal
FYI. In short, we are part of an early access program from github that should allow us to have better ability to manage pull requests and issues in Github. https://github.com/blog/2020-improved-organization-permissions Thanks, Nikhil -Original Message- From: David Nalley

Re: [DISCUSS] Release Cordova-Android 4.1.0

2015-07-17 Thread Homer, Tony
Nikhil- I'd like to get this PR merged in for 4.1.0: https://github.com/apache/cordova-android/pull/182 I'll try to get it merged in today. Tony On 7/17/15, 12:49 PM, Nikhil Khandelwal nikhi...@microsoft.com wrote: I can take this up. Thanks! Look out for the VOTE thread soon. Thanks,

RE: Google Analytics on Cordova Docs

2015-07-17 Thread Nikhil Khandelwal
I have updated the GA tracking id to the new one for a lot of recent versions of the docs. We're getting data as well now. We'll have to figure out how to summarize and make that data actionable. Thanks, Nikhil -Original Message- From: Andrey Kurdumov [mailto:kant2...@googlemail.com]

[GitHub] cordova-registry-web pull request: Adding delete-this to blacklist...

2015-07-17 Thread rakatyal
GitHub user rakatyal opened a pull request: https://github.com/apache/cordova-registry-web/pull/28 Adding delete-this to blacklisted plugins You can merge this pull request into a Git repository by running: $ git pull https://github.com/rakatyal/cordova-registry-web

Re: Discuss Android plugin compatibility problem

2015-07-17 Thread Carlos Santana
+1 to doc and maybe add as a comment in plugin template in cli Having low number of dependencies or not all is something is good that we aim for. On Fri, Jul 17, 2015 at 11:59 AM Sergey Grebnov (Akvelon) v-seg...@microsoft.com wrote: Agree, sounds like a good plan. I'm going to review and fix

Re: FW: Github - Ability to add tags to pull requests

2015-07-17 Thread Carlos Santana
Thanks for sharing Nikhil with the broader audience On Fri, Jul 17, 2015 at 1:51 PM Nikhil Khandelwal nikhi...@microsoft.com wrote: FYI. In short, we are part of an early access program from github that should allow us to have better ability to manage pull requests and issues in Github.

[CI] iOS build breaking

2015-07-17 Thread Dmitry Blotsky
https://ci.apache.org/builders/cordova-ios/builds/36/steps/running-tests/logs/stdio CDVCamera.m:23:9: fatal error: 'Cordova/NSData+Base64.h' file not found #import Cordova/NSData+Base64.h ^ 1 error generated. Kindly, Dmitry

[GitHub] cordova-android pull request: CB-9149: Make gradle alias subprojec...

2015-07-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/182 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[DISCUSS] CI Hardware

2015-07-17 Thread Dmitry Blotsky
Hi all, As per the hangout, please respond to this thread with machines and devices you can hook up to the CI. Also please list relevant info like hardware capabilities of the machines and devices. For example, our hardware is as follows: - cordova-windows-slave - 8GB RAM -

[CI] Medic Update

2015-07-17 Thread Dmitry Blotsky
Hey folks, This week’s updates regarding CI: - iOS build is broken and needs fixing (tracked by CB-9383) - Windows run is crashing and needs fixing (no JIRA yet) - per-commit builds are still waiting on Apache Infra (tracked by INFRA-9979) Test status (for succeeding builds): 1 on Android on

Re: [DISCUSS] CI Hardware

2015-07-17 Thread Jesse
Hi Dmitry, I think we can set up similar hardware at Adobe, the problem that we face though is networking. We will probably need to fight for an external connection that is not heavily secured. Are there any specific network requirements we should be aware of? I am pretty sure we can also get

[GitHub] cordova-lib pull request: CB-9384 Plugman should be able to checko...

2015-07-17 Thread purplecabbage
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-lib/pull/265 CB-9384 Plugman should be able to checkout a commit SHA actually checkout git_ref because it may be a branch OR a commit SHA This functionality was lost when CB-8908 was