[GitHub] cordova-android pull request: CB-9404 Fixed an exception when path...

2015-07-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/203 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-plugin-statusbar pull request: CB-9214 - [iOS] Landscape w...

2015-07-27 Thread TheBikingViking
Github user TheBikingViking commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/27#issuecomment-125466147 When will this pull request be merged back? --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] cordova-plugin-camera pull request: CB-9151 Trigger captureAction ...

2015-07-27 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/110#issuecomment-125397586 This seems to work, but perhaps removing the listener on the first call would be a better approach. Also, I assume I can button mash the cancel

RE: [VOTE] Cordova-android 4.1.0 release (Take 2)

2015-07-27 Thread Nikhil Khandelwal
This vote has passed. Thanks! Summary of +1s: - Steven Gill - Sergey Grebnov - Nikhil Khandelwal Since I'm OOF for the rest of the week, Murat will help with publishing the blog post & putting the release out on dist & npm. Thanks, Nikhil -Original Message- From: Steven Gill [mailto:ste

[GitHub] cordova-plugin-file pull request: Make Android default persistent ...

2015-07-27 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/127#issuecomment-125350084 This looks great to me! My only questions are, do we need a migration plugin? or should this version include migration code? Assuming an

Re: Make internal storage default on Android

2015-07-27 Thread Simon MacDonald
Pull Request sent: https://github.com/apache/cordova-plugin-file/pull/127 Simon Mac Donald http://hi.im/simonmacdonald On Mon, Jul 27, 2015 at 10:55 AM, Simon MacDonald wrote: > kk, I think this has enough support and I'll end up putting together a > pull request today. > > > Simon Mac Donald

[GitHub] cordova-plugin-file pull request: Make Android default persistent ...

2015-07-27 Thread macdonst
GitHub user macdonst opened a pull request: https://github.com/apache/cordova-plugin-file/pull/127 Make Android default persistent file location internal **TL;DR Summary** We should switch the default for the Cordova Android File System to be on internal storage, not the SD

[GitHub] cordova-docs pull request: CB-9408: Documented the new `windows-pa...

2015-07-27 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-docs/pull/300#issuecomment-125334695 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] cordova-plugin-contacts pull request: Remove ops

2015-07-27 Thread manugb
Github user manugb commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/70#issuecomment-125333148 Had anyone take a look at this ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-contacts pull request: Close photo cursor

2015-07-27 Thread manugb
Github user manugb commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/69#issuecomment-125333116 Had anyone take a look at this ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-contacts pull request: Return rawId

2015-07-27 Thread manugb
Github user manugb commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/68#issuecomment-125333085 Had anyone take a look at this ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-lib pull request: CB-9408: Added support for `windows-pack...

2015-07-27 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/268#issuecomment-125331417 LGTM ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] cordova-windows pull request: CB-9408: Added a `windows-packageVer...

2015-07-27 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-windows/pull/105#issuecomment-125328305 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-plugin-camera pull request: CB-9151 Trigger captureAction ...

2015-07-27 Thread muratsu
GitHub user muratsu opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/110 CB-9151 Trigger captureAction only once Prevent multiple captureAction calls by using `clicked` attribute You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-plugin-camera pull request: CB-9413 Close RandomAccessStre...

2015-07-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/109 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera pull request: CB-9413 Close RandomAccessStre...

2015-07-27 Thread muratsu
GitHub user muratsu opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/109 CB-9413 Close RandomAccessStream once copied RandomAccessStream.copyAsync does not close destination stream, which is casuing a WinRT exception. Use copyAndCloseAsync instead. You ca

[GitHub] cordova-plugin-device-motion pull request: CB-9339 Increase the de...

2015-07-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-motion/pull/32 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

RE: [VOTE] Cordova-android 4.1.0 release (Take 2)

2015-07-27 Thread Steven Gill
+1 On Jul 27, 2015 1:20 AM, "Nikhil Khandelwal" wrote: > Bump... > > Sent from Outlook > > > > > On Thu, Jul 23, 2015 at 8:13 AM -0700, "Sergey Grebnov (Akvelon)" < > v-seg...@microsoft.com> wrote: > > I vote +1: > > * Manually verified

[GitHub] cordova-plugin-file-transfer pull request: removed broken link in ...

2015-07-27 Thread elitan
GitHub user elitan opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/96 removed broken link in README You can merge this pull request into a Git repository by running: $ git pull https://github.com/elitan/cordova-plugin-file-transfer master Al

Re: Make internal storage default on Android

2015-07-27 Thread Simon MacDonald
kk, I think this has enough support and I'll end up putting together a pull request today. Simon Mac Donald http://hi.im/simonmacdonald On Mon, Jul 27, 2015 at 10:40 AM, Andrew Grieve wrote: > Ian and I made the switch to internal (via the preference). > > - I thought at one point the default

Re: Make internal storage default on Android

2015-07-27 Thread Andrew Grieve
Ian and I made the switch to internal (via the preference). - I thought at one point the default app template set the preference to internal, so that new apps would get the better behaviour and existing apps would continue to work. I don't see this happening now though :( - The duplicate files/fil

RE: [DISCUSS] cordova-ios 3.9.0 release

2015-07-27 Thread Sergey Grebnov (Akvelon)
Please review prepared release branch[1] and release notes[2]. Does anyone have any reason to delay a cordova-ios platform release? Any outstanding patches to land? If not, I will start the release voting tomorrow. [1] https://github.com/apache/cordova-ios/commits/3.9.x [2] https://github.com/

RE: [VOTE] Cordova-android 4.1.0 release (Take 2)

2015-07-27 Thread Nikhil Khandelwal
Bump... Sent from Outlook On Thu, Jul 23, 2015 at 8:13 AM -0700, "Sergey Grebnov (Akvelon)" mailto:v-seg...@microsoft.com>> wrote: I vote +1: * Manually verified platform could be added, built and run * Run autotests (mobile spec) Thx! Sergey Grebnov -Orig