[GitHub] cordova-js pull request: CB-9370 Switches to another jsdom depende...

2015-08-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/127 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-android pull request: CB-9557 Fixes apk install failure wh...

2015-08-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/209 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-registry pull request: Revert "Revert "made registry read-...

2015-08-31 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-registry/pull/1#issuecomment-136591049 Is there any reason to keep all the commented code around? It will live in the repo history anyway, why not delete it? --- If your project is set up for i

Re: Marshmallow Update and Cordova-Android 5.0

2015-08-31 Thread Joe Bowser
BTW: I got Contacts somewhat working with Marshmellow. It's still got the same crappy concurrency bugs that it always has, and I am not sure how to resolve those without re-writing the damn thing, but the purpose of this is to figure out how to get permissions to work, and I have something that wo

[GitHub] cordova-medic pull request: CB-8936 iOS logs gathering

2015-08-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/60 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-medic pull request: CB-8936 iOS logs gathering

2015-08-31 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/60#discussion_r38379807 --- Diff: buildbot-conf/cordova.conf --- @@ -360,9 +360,10 @@ def cordova_steps_run_tests(platform, extra_args=list()): 'log',

RE: [Vote] Tools Release Aug 28th

2015-08-31 Thread Tim Barham
+1 * Verified tags with coho verify-tags * Verified signature and hashes with coho verify-archive * Verified package contents match git repo at tag * Installed Cordova * Built and ran blank app for Windows, Android, Browser * Verified blank app launches without error in Ripple -Original Messa

RE: Update: Plugins Registry warnings

2015-08-31 Thread Nikhil Khandelwal
On a related note, was our plan to do re-direction from old plugin registry ID to npm ID? I still get a warning and no automatic re-direction with latest cordova. cordova plugin add org.apache.cordova.camera Fetching plugin "org.apache.cordova.camera" via npm WARNING: org.apache.cordova.camera h

[GitHub] cordova-ios pull request: CB-9462 iOS 3.9.0 breaks npm link module...

2015-08-31 Thread rayshan
Github user rayshan commented on the pull request: https://github.com/apache/cordova-ios/pull/153#issuecomment-136541007 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cordova-android pull request: The extra digit need to be added to ...

2015-08-31 Thread fujunwei
Github user fujunwei commented on the pull request: https://github.com/apache/cordova-android/pull/211#issuecomment-136538202 @agrieve --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] cordova-android pull request: CB-9557 Fixes apk install failure wh...

2015-08-31 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-android/pull/209#issuecomment-136538097 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-coho pull request: CB-9585 Support globs with 'coho verify...

2015-08-31 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-coho/pull/93 CB-9585 Support globs with 'coho verify-archive' command. This adds supports for globs to the `coho verify-archive` command, so you can pass wildcards such as: coho verify-archiv

[GitHub] cordova-docs pull request: Adding linting, link verifier and slack...

2015-08-31 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/323#discussion_r38375651 --- Diff: gulpfile.js --- @@ -247,6 +250,23 @@ gulp.task("link-bugs", function (done) { exec(bin("linkify-bugs.sh"), [path.join(SOURCE_DIR, "_p

[GitHub] cordova-docs pull request: Adding linting, link verifier and slack...

2015-08-31 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/323#discussion_r38374303 --- Diff: www/_includes/footer.html --- @@ -72,3 +74,6 @@ +

[GitHub] cordova-docs pull request: Removed redundant TOC headers in docs

2015-08-31 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/324#issuecomment-136531188 [I love it](https://youtube.googleapis.com/v/keLVVzekMbU?start=0&end=2&version=3)! Merged. --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-docs pull request: Removed redundant TOC headers in docs

2015-08-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/324 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: Adding linting, link verifier and slack...

2015-08-31 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/323#discussion_r38373786 --- Diff: gulpfile.js --- @@ -247,6 +250,23 @@ gulp.task("link-bugs", function (done) { exec(bin("linkify-bugs.sh"), [path.join(SOURCE_DIR, "_p

[GitHub] cordova-docs pull request: Adding linting, link verifier and slack...

2015-08-31 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/323#discussion_r38373580 --- Diff: gulpfile.js --- @@ -247,6 +250,23 @@ gulp.task("link-bugs", function (done) { exec(bin("linkify-bugs.sh"), [path.join(SOURCE_DIR, "_p

[GitHub] cordova-docs pull request: Adding linting, link verifier and slack...

2015-08-31 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/323#discussion_r38373489 --- Diff: gulpfile.js --- @@ -247,6 +250,23 @@ gulp.task("link-bugs", function (done) { exec(bin("linkify-bugs.sh"), [path.join(SOURCE_DIR, "_p

[GitHub] cordova-docs pull request: Adding linting, link verifier and slack...

2015-08-31 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/323#discussion_r38373454 --- Diff: gulpfile.js --- @@ -247,6 +250,23 @@ gulp.task("link-bugs", function (done) { exec(bin("linkify-bugs.sh"), [path.join(SOURCE_DIR, "_p

[GitHub] cordova-docs pull request: Adding linting, link verifier and slack...

2015-08-31 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/323#discussion_r38373392 --- Diff: gulpfile.js --- @@ -31,6 +33,7 @@ var WATCH_INTERVAL= 1000; // in milliseconds var ROOT_DIR = "."; var SOURCE_DIR = path.join(

RE: [DISCUSS] Tools Release?

2015-08-31 Thread Tim Barham
Thanks Steve. And yeah, I'd done the testing - just wanted to verify the archives :). -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Tuesday, September 1, 2015 4:00 AM To: dev@cordova.apache.org Subject: RE: [DISCUSS] Tools Release? Hey Tim, You are correct.

[GitHub] cordova-osx pull request: Fix a typo in README.md

2015-08-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-osx/pull/11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[VOTE] 3.8.0 BlackBerry Release

2015-08-31 Thread Bryan Higgins
Please review and vote on this 3.8.0 BlackBerry Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9576 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-9576 The packag

[GitHub] cordova-plugin-vibration pull request: [CB-7966] Add cordova-plugi...

2015-08-31 Thread surajpindoria
GitHub user surajpindoria opened a pull request: https://github.com/apache/cordova-plugin-vibration/pull/37 [CB-7966] Add cordova-plugin-vibration support for browser platform The previous imple You can merge this pull request into a Git repository by running: $ git pull https:

[GitHub] cordova-plugin-statusbar pull request: [CB-7965] Add cordova-plugi...

2015-08-31 Thread surajpindoria
GitHub user surajpindoria opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/31 [CB-7965] Add cordova-plugin-statusbar support for browser platform You can merge this pull request into a Git repository by running: $ git pull https://github.com/suraj

[GitHub] cordova-osx pull request: CB-9581 OSX WebView does not send cookie...

2015-08-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-osx/pull/22 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-osx pull request: @trivial add 'Resources' group so that p...

2015-08-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-osx/pull/21 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-osx pull request: CB-9581 OSX WebView does not send cookie...

2015-08-31 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-osx/pull/22#issuecomment-136527429 I'll pull this in and close both this and PR #21 at the same time. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

Re: Update: Plugins Registry warnings

2015-08-31 Thread Steven Gill
So I have a PR ready to make the registry read-only. [1] Unfortunately, plugman don't support outputting the errors received from the registry to our users. `plugman publish PLUGIN` outputs `publish fail`. Even though I added a nice error message to the registry, users won't see it. Maybe other t

[GitHub] cordova-registry pull request: Revert "Revert "made registry read-...

2015-08-31 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-registry/pull/1 Revert "Revert "made registry read-only"" This reverts commit f0b3f27c960b7a5ddce6c0219f29c7278356045f. You can merge this pull request into a Git repository by running: $ git pull h

[GitHub] cordova-osx pull request: CB-9581 OSX WebView does not send cookie...

2015-08-31 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-osx/pull/22 CB-9581 OSX WebView does not send cookies is safari cache is cleared this also includes PR #18 You can merge this pull request into a Git repository by running: $ git pull https://github

Re: [Discuss] BlackBerry Release

2015-08-31 Thread Bryan Higgins
I'm on it :) On Mon, Aug 31, 2015 at 7:00 PM, Steven Gill wrote: > Lets get this vote thread started! > > On Mon, Aug 31, 2015 at 1:06 PM, Tim Windsor > wrote: > > > I've tested the mobile-spec app on the previous version and the new one. > > While there are issues, they appear to be the same f

Re: [Discuss] BlackBerry Release

2015-08-31 Thread Steven Gill
Lets get this vote thread started! On Mon, Aug 31, 2015 at 1:06 PM, Tim Windsor wrote: > I've tested the mobile-spec app on the previous version and the new one. > While there are issues, they appear to be the same from what I've seen. > > Tim Windsor > Open Source Technical Lead – Devices > > >

[GitHub] cordova-cli pull request: CB-9523 Show out of date message for old...

2015-08-31 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-cli/pull/219#issuecomment-136522067 Good idea. Things to think about though. 1) what if the user says no to updating. The message should not show up everytime they use cordova. Some global

[GitHub] cordova-osx pull request: Fix a typo in README.md

2015-08-31 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-osx/pull/11#issuecomment-136515109 this should be closed. the typo is fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] cordova-plugin-camera pull request: Retaining image ratio when res...

2015-08-31 Thread muratsu
Github user muratsu commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/118#issuecomment-136510649 Yup, looks like right. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] cordova-plugin-camera pull request: Retaining image ratio when res...

2015-08-31 Thread trubit
Github user trubit commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/118#issuecomment-136507080 Yeah, in my case it worked, but correct calculation is: var scale = Math.min(targetWidth / this.width, targetHeight / this.height); Calcul

[GitHub] cordova-plugin-camera pull request: Retaining image ratio when res...

2015-08-31 Thread muratsu
Github user muratsu commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/118#issuecomment-136498895 I think the logic needs some rework. Imagine original picture with size 2w x 1h (aspect ratio 2). If we want to scale this image to 10x5 this CR will

[GitHub] cordova-docs pull request: Cordova website plugin improvements

2015-08-31 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/325 Cordova website plugin improvements Converts the plugin help pages to markdown so that their formatting remains consistent with the rest of the website and tweaked their content slightly. Als

Re: Cordova Face to Face meeting

2015-08-31 Thread Shazron
I definitely can do a SotU. I'll own iOS. On Monday, August 31, 2015, Parashuram N wrote: > I will see if we can set up a hangouts for this. I am sure we can set up a > Lync meeting in the conference rooms. > We also have 1 hour allocated for discussing the agenda, but I think we > should use th

[GitHub] cordova-docs pull request: Removed redundant TOC headers in docs

2015-08-31 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/324 Removed redundant TOC headers in docs You can merge this pull request into a Git repository by running: $ git pull https://github.com/riknoll/cordova-docs cordova-website-toc-fix Altern

RE: [Discuss] BlackBerry Release

2015-08-31 Thread Tim Windsor
I've tested the mobile-spec app on the previous version and the new one. While there are issues, they appear to be the same from what I've seen. Tim Windsor Open Source Technical Lead – Devices -Original Message- From: Bryan Higgins [mailto:br...@bryanhiggins.net] Sent: Saturday, Au

[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...

2015-08-31 Thread marcuspridham
Github user marcuspridham commented on the pull request: https://github.com/apache/cordova-lib/pull/292#issuecomment-136482068 Thanks. I just tried these cases it appears to already work. The search path provided with prepare passes through https://github.com/apache/cordova-lib/blob/

[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...

2015-08-31 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/292#issuecomment-136472329 Thanks for suggesting these changes. However, I have a suggestion : As it currently stands, it seems like adding adding a platform or restoring from co

[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...

2015-08-31 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/292#issuecomment-136471159 Thanks for suggesting these changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-docs pull request: Adding linting, link verifier and slack...

2015-08-31 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/323#discussion_r38346892 --- Diff: gulpfile.js --- @@ -31,6 +33,7 @@ var WATCH_INTERVAL= 1000; // in milliseconds var ROOT_DIR = "."; var SOURCE_DIR = path.join(

[GitHub] cordova-docs pull request: Adding linting, link verifier and slack...

2015-08-31 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/323#discussion_r38346729 --- Diff: www/_includes/footer.html --- @@ -72,3 +74,6 @@ +

RE: Cordova Face to Face meeting

2015-08-31 Thread Parashuram N
I will see if we can set up a hangouts for this. I am sure we can set up a Lync meeting in the conference rooms. We also have 1 hour allocated for discussing the agenda, but I think we should use this mailing list to seed that discussions. Shaz, can you do a "state of the union" something in the

Marshmallow Update and Cordova-Android 5.0

2015-08-31 Thread Joe Bowser
Hey So, I created a new topic branch of my github with the new changes as suggested earlier. https://github.com/infil00p/cordova-android/tree/smores The thing we have to make sure works is if the user turns off the permissions on Marshmellow. Right now if the permissions are off, everything cra

[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...

2015-08-31 Thread omefire
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/292#discussion_r38341095 --- Diff: cordova-lib/src/cordova/prepare.js --- @@ -56,7 +56,7 @@ function prepare(options) { var hooksRunner = new HooksRunner(projectRoot);

[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...

2015-08-31 Thread omefire
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/292#discussion_r38340821 --- Diff: cordova-lib/src/cordova/prepare.js --- @@ -56,7 +56,7 @@ function prepare(options) { var hooksRunner = new HooksRunner(projectRoot);

[GitHub] cordova-docs pull request: added phonegap to tools section

2015-08-31 Thread stevengill
Github user stevengill closed the pull request at: https://github.com/apache/cordova-docs/pull/322 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

RE: [DISCUSS] Tools Release?

2015-08-31 Thread Steven Gill
Hey Tim, You are correct. I forgot to run svn commit. Updated RC's are now there. You can also test using npm install -g cordova@rc On Aug 30, 2015 10:01 PM, "Tim Barham" wrote: > Hey Steve - you mention version bumps for lib, cli and plugman, but that > doesn't seem to be what's in dist/dev..

[GitHub] cordova-wp8 pull request: Get rid of Math.random() when making a r...

2015-08-31 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-wp8/pull/86#issuecomment-136438829 Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] cordova-wp8 pull request: Get rid of Math.random() when making a r...

2015-08-31 Thread scale-tone
Github user scale-tone commented on the pull request: https://github.com/apache/cordova-wp8/pull/86#issuecomment-136438200 > please also file an ICLA here: http://www.apache.org/dev/new-committers-guide.html#cla OK, just sent the form to secret...@apache.org. 2015-

[GitHub] cordova-lib pull request: CB-9354 Fix array merging with complex i...

2015-08-31 Thread m1r4ge
Github user m1r4ge commented on the pull request: https://github.com/apache/cordova-lib/pull/256#issuecomment-136423739 @vladimir-kotikov It's seemed to me that I tried that method and it didn't work properly. Now everything works fine. Thx for clarifications. I'll file Aache ICLA soo

[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...

2015-08-31 Thread marcuspridham
GitHub user marcuspridham opened a pull request: https://github.com/apache/cordova-lib/pull/292 CB-8993 Plugin restore ignores search path When restoring a platform the search path needs to be provided otherwise plugins will always be resolved to npm. You can merge this pull req

[GitHub] cordova-docs pull request: Gulp now correctly serves the productio...

2015-08-31 Thread riknoll
Github user riknoll closed the pull request at: https://github.com/apache/cordova-docs/pull/321 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-9354 Fix array merging with complex i...

2015-08-31 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/256#issuecomment-136397624 @m1r4ge, tested and confirm that this works. However, there is already a `nodeEqual` method (see https://github.com/apache/cordova-lib/blob/master/cordova-

[GitHub] cordova-plugin-contacts pull request: CB-9579 Fixed failed tests w...

2015-08-31 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/74 CB-9579 Fixed failed tests when "DeleteMe" contact already exists https://issues.apache.org/jira/browse/CB-9579 You can merge this pull request into a Git repository by running:

[GitHub] cordova-lib pull request: CB-9354 Fix array merging with complex i...

2015-08-31 Thread KonradFak
Github user KonradFak commented on the pull request: https://github.com/apache/cordova-lib/pull/256#issuecomment-136372119 +1, waiting for merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] cordova-lib pull request: CB-9354 Fix array merging with complex i...

2015-08-31 Thread psychowico
Github user psychowico commented on the pull request: https://github.com/apache/cordova-lib/pull/256#issuecomment-136369156 can you merge this, plz? very annoying bug. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cordova-lib pull request: CB-9556 Don't uninstall dependent plugin...

2015-08-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/287 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: CB-9556 Don't uninstall dependent plugin...

2015-08-31 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/287#discussion_r38295456 --- Diff: cordova-lib/src/plugman/install.js --- @@ -273,8 +273,13 @@ function runInstall(actions, platform, project_dir, plugin_dir, plugins_di

Unified logging proposal

2015-08-31 Thread Sergey Shakhnazarov (Akvelon)
Hi guys, Please take a look at proposal on Unified logging (related to the proposal on cordova-lib refactoring[1]): https://github.com/cordova/cordova-discuss/issues/14 [1]: https://github.com/cordova/cordova-discuss/pull/12 Please let me know if you have any questions or considerations. Best