[GitHub] cordova-lib pull request: CB-9617 Do not restore plugins immediate...

2015-09-09 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/304#issuecomment-139129776 Will review tomorrow --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] cordova-lib pull request: CB-9631 Save plugin to config.xml only i...

2015-09-09 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/303#issuecomment-139129689 Thanks for fast response! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] cordova-lib pull request: CB-9631 Save plugin to config.xml only i...

2015-09-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/303 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-docs pull request: Fixed links, search, and source formatt...

2015-09-09 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/337#issuecomment-139129330 Merged! Feel free to close. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] cordova-lib pull request: CB-9631 Save plugin to config.xml only i...

2015-09-09 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/303#issuecomment-139127308 LGTM ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] cordova-docs pull request: Multiple updates to cordova plugin sear...

2015-09-09 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/335#issuecomment-139078394 Thanks Richard for making the fixes! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cordova-docs pull request: Fixed links, search, and source formatt...

2015-09-09 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/337 Fixed links, search, and source formatting for contribute Does the following: * Removed whitespace in contribute/index.html * Fixes broken links in contribute * Calls the appro

[GitHub] cordova-docs pull request: Multiple updates to cordova plugin sear...

2015-09-09 Thread nikhilkh
Github user nikhilkh closed the pull request at: https://github.com/apache/cordova-docs/pull/335 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: Add support for description meta tag on...

2015-09-09 Thread nikhilkh
Github user nikhilkh closed the pull request at: https://github.com/apache/cordova-docs/pull/334 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: Sort versions by latest version first

2015-09-09 Thread nikhilkh
Github user nikhilkh closed the pull request at: https://github.com/apache/cordova-docs/pull/333 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: Sort versions by latest version first

2015-09-09 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/333#issuecomment-139065627 Merged. Feel free to close. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] cordova-docs pull request: Add support for description meta tag on...

2015-09-09 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/334#issuecomment-139064936 Merged. Feel free to close. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] cordova-docs pull request: Multiple updates to cordova plugin sear...

2015-09-09 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/335#issuecomment-139064740 Merged. Feel free to close. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] cordova-docs pull request: Added text for browse online items on c...

2015-09-09 Thread riknoll
Github user riknoll closed the pull request at: https://github.com/apache/cordova-docs/pull/336 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: Added text for browse online items on c...

2015-09-09 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/336#issuecomment-139061504 Merged. Feel free to close. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] cordova-medic pull request: CB-8936 Utilizing --dump flag for logs...

2015-09-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/61 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-medic pull request: CB-8936 Utilizing --dump flag for logs...

2015-09-09 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/61#issuecomment-139059642 Merged, but GitHub still hasn't picked up the changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

Re: [REVIEW] CPR readonly blog post.

2015-09-09 Thread Jesse
Yeah, it could definitely be cleaned out. All the registry stuff can go, search? Does plugman registry still overwrite npmjs.org globally? How are platforms handling variables? My team is hiring! @purplecabbage risingj.com On Wed, Sep 9, 2015 at 2:37 PM, Steven Gill wrote: > I actually think

Re: [REVIEW] CPR readonly blog post.

2015-09-09 Thread Steven Gill
I actually think the numbers will drop over time. Plugman has lost registry functionality (publishing, unpublishing, owners, etc). Plugin installation is moving into platforms instead of tools. That will signify the end of needing a tool to install plugins for non cli workflows. Will still be neede

[GitHub] cordova-plugin-statusbar pull request: Mistake. Please remove

2015-09-09 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/33#issuecomment-139050353 Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] cordova-plugin-statusbar pull request: Mistake. Please remove

2015-09-09 Thread Pacjonek
Github user Pacjonek closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/33 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-statusbar pull request: Mistake. Please remove

2015-09-09 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/33#issuecomment-139049800 @Pacjonek Just hit the 'close pull request' button! It is MUCH easier for you to close your own, otherwise we actually need to make a commit to cl

Re: [REVIEW] CPR readonly blog post.

2015-09-09 Thread Jesse
We still need it. There is a very important and difficult workflow for people who want to add a 'little' cordova to an existing app. Think of a visual studio wizard to add a cordova view to an existing app. The reality of it is simply that it is architected as a secondary module, so we can easily r

[GitHub] cordova-docs pull request: Multiple updates to cordova plugin sear...

2015-09-09 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/335#issuecomment-139041694 And yes, we should switch to a URI builder at some point. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-docs pull request: Multiple updates to cordova plugin sear...

2015-09-09 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/335#issuecomment-139040510 Also, it might be useful to switch to a proper URI builder for constructing URIs now. --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-docs pull request: Multiple updates to cordova plugin sear...

2015-09-09 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/335#issuecomment-139040608 @dblotsky I addressed your concerns with Gulpfile. Gulp will now reload the browser twice on plugins changes. The first will update the code and the second will be

Re: [REVIEW] Tools release blog post

2015-09-09 Thread Steven Gill
using @latest isn't necessary as that is the default. We have never had @latest be part of our install instructions before, why add more characters? Updated the rest. https://github.com/cordova/apache-blog-posts/blob/master/2015-09-09-tools-release.md Posting soon. On Tue, Sep 8, 2015 at 8:13 P

[GitHub] cordova-windows pull request: CB-9632 Fixed tests not to fail on T...

2015-09-09 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/121#issuecomment-139012294 Cool, I thought it did handle the `\\` as well, but I guess not. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] cordova-lib pull request:

2015-09-09 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/commit/81737ec35d74cd0c5f17c3ce946eaf3de813be02#commitcomment-13143900 In cordova-lib/src/CordovaError.js: In cordova-lib/src/CordovaError.js on line 36: What is the purpose of `na

[GitHub] cordova-lib pull request:

2015-09-09 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/commit/81737ec35d74cd0c5f17c3ce946eaf3de813be02#commitcomment-13143836 In cordova-lib/src/CordovaError.js: In cordova-lib/src/CordovaError.js on line 35: IMO adding `ErrorCodes` as

[GitHub] cordova-docs pull request: Multiple updates to cordova plugin sear...

2015-09-09 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/335#issuecomment-139000724 The issue is that `{{ site.baseurl }}` strings need to be processed by Jekyll and the updated gulpfile bypasses that --- If your project is set up for it, you can

[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...

2015-09-09 Thread f3rno
Github user f3rno commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-138998550 @cjpearson, you are a gentleman and a scholar. After nearly a day of on-off debugging due to keyboard related issues, your fork works perfectly (so far) :dancer:

[GitHub] cordova-docs pull request: Multiple updates to cordova plugin sear...

2015-09-09 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/335#issuecomment-138993518 Updating a file in the plugins folder causes all image links in the plugins page to be broken once the page refreshes (and on all subsequent refreshes) --- If you

[GitHub] cordova-docs pull request: Added text for browse online items on c...

2015-09-09 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/336 Added text for browse online items on contact page You can merge this pull request into a Git repository by running: $ git pull https://github.com/riknoll/cordova-docs cordova-website-co

[GitHub] cordova-windows pull request: CB-9632 Fixed tests not to fail on T...

2015-09-09 Thread alsorokin
Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/121#discussion_r39071454 --- Diff: spec/unit/deployment.spec.js --- @@ -150,7 +151,7 @@ describe('Windows 10 deployment interacts with the file system as expected.', fu

[GitHub] cordova-docs pull request: Multiple updates to cordova plugin sear...

2015-09-09 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/335#discussion_r39071423 --- Diff: gulpfile.js --- @@ -224,7 +223,8 @@ gulp.task("plugins", function() { } return stream - +.pipe(browser

[GitHub] cordova-docs pull request: Multiple updates to cordova plugin sear...

2015-09-09 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/335#discussion_r39071336 --- Diff: gulpfile.js --- @@ -234,8 +234,7 @@ gulp.task("plugins", function() { // minified JS has some things that look like

[GitHub] cordova-docs pull request: Multiple updates to cordova plugin sear...

2015-09-09 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/335#discussion_r39071280 --- Diff: gulpfile.js --- @@ -121,7 +121,7 @@ gulp.task("watch", ["serve"], function () { path.join(ROOT_DIR, "**", "*.yml"),

[GitHub] cordova-windows pull request: CB-9632 Fixed tests not to fail on T...

2015-09-09 Thread alsorokin
Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/121#discussion_r39069953 --- Diff: spec/unit/deployment.spec.js --- @@ -150,7 +151,7 @@ describe('Windows 10 deployment interacts with the file system as expected.', fu

[GitHub] cordova-windows pull request: CB-9632 Fixed tests not to fail on T...

2015-09-09 Thread alsorokin
Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/121#discussion_r39068918 --- Diff: spec/unit/deployment.spec.js --- @@ -150,7 +151,7 @@ describe('Windows 10 deployment interacts with the file system as expected.', fu

[GitHub] cordova-windows pull request: CB-9632 Fixed tests not to fail on T...

2015-09-09 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/121#discussion_r39068742 --- Diff: spec/unit/deployment.spec.js --- @@ -150,7 +151,7 @@ describe('Windows 10 deployment interacts with the file system as expected.', fu

[GitHub] cordova-docs pull request: Multiple updates to cordova plugin sear...

2015-09-09 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/335#issuecomment-138973904 Checking multiple platform filters results in an improperly encoded URL. I have a fix, do you want me to push it? --- If your project is set up for it, you can re

[GitHub] cordova-plugin-camera pull request: CB-9633 iOS Taking a Picture W...

2015-09-09 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/122 CB-9633 iOS Taking a Picture With Option destinationType:NATIVE_URI not working In case sourceType == Camera we receive nil as Uri because image is stored in memory. This PR adds lo

[GitHub] cordova-lib pull request: CB-9617 Do not restore plugins immediate...

2015-09-09 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/304#issuecomment-138958045 @omefire, @TimBarham, please review when possible --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-lib pull request: CB-9631 Save plugin to config.xml only i...

2015-09-09 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/303#issuecomment-138957595 @omefire, review please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] cordova-docs pull request: Cordova website

2015-09-09 Thread bgashler1
Github user bgashler1 closed the pull request at: https://github.com/apache/cordova-docs/pull/315 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-lib pull request: CB-9617 Do not restore plugins immediate...

2015-09-09 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/304 CB-9617 Do not restore plugins immediately after plugin removal https://github.com/apache/cordova-lib/commit/14675051c400a6811a6c6171fbf92f3475244630 introduced `cordova.prepare` call

Re: Marshmallow Update and Cordova-Android 5.0

2015-09-09 Thread Joe Bowser
Android is already there, isn't it? On Tue, Sep 8, 2015, 9:16 PM Nikhil Khandelwal wrote: > It would be great to add this platform matrix to our buildbot CI. Any > volunteers? > > -Nikhil > > -Original Message- > From: Karen Tran [mailto:ktop...@gmail.com] > Sent: Monday, September 7, 20

[GitHub] cordova-lib pull request: CB-9631 Save plugin to config.xml only i...

2015-09-09 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/303 CB-9631 Save plugin to config.xml only if installation succeeds This fixes [CB-9631](https://issues.apache.org/jira/browse/CB-9631) The idea is that we need to save installed p

[GitHub] cordova-windows pull request: CB-9632 Fixed tests not to fail on T...

2015-09-09 Thread alsorokin
Github user alsorokin commented on the pull request: https://github.com/apache/cordova-windows/pull/121#issuecomment-138937598 Travis build is green: https://travis-ci.org/apache/cordova-windows/builds/79485657 --- If your project is set up for it, you can reply to this email and hav

[GitHub] cordova-windows pull request: CB-9632 Fixed tests not to fail on T...

2015-09-09 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-windows/pull/121 CB-9632 Fixed tests not to fail on Travis-CI https://issues.apache.org/jira/browse/CB-9632 You can merge this pull request into a Git repository by running: $ git pull https://github

[GitHub] cordova-plugin-camera pull request: Retaining image ratio when res...

2015-09-09 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/118#issuecomment-138917699 Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-camera pull request: Retaining image ratio when res...

2015-09-09 Thread trubit
Github user trubit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/118 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-inappbrowser pull request: CB-8467 provide hide met...

2015-09-09 Thread zalun
Github user zalun commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/101#issuecomment-138903930 FFOS +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-medic pull request: CB-8936 Utilizing --dump flag for logs...

2015-09-09 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-medic/pull/61 CB-8936 Utilizing --dump flag for logs on Windows https://issues.apache.org/jira/browse/CB-8936 You can merge this pull request into a Git repository by running: $ git pull https://gith

[GitHub] cordova-lib pull request: CB-8615, CB-9588 Better Cordova plugin s...

2015-09-09 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-lib/pull/301#issuecomment-138896325 Tests pass now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

Re: [DRAFT] Apache Cordova September Board Report

2015-09-09 Thread Carlos Santana
You already sent when I notice this email. I only have one comment: "Thank Shaz for all your work and keeping on top of things" I sometimes forget to give a simple thank you -- Carlos On Tue, Sep 8, 2015 at 8:58 PM Shazron wrote: > Sent. > > On Tue, Sep 8, 2015 at 2:31 PM, Shazron wrote: > >

[GitHub] cordova-lib pull request: CB-8615, CB-9588 Better Cordova plugin s...

2015-09-09 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-lib/pull/301#issuecomment-138880965 Rebased on top of master which now includes #300 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-lib pull request: CB-9601 Fix .versions support...

2015-09-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/300 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-plugin-camera pull request: Focus control and nicer UI for...

2015-09-09 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/106#issuecomment-138875519 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-camera pull request: Focus control and nicer UI for...

2015-09-09 Thread Gillardo
Github user Gillardo closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/106 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] cordova-plugin-camera pull request: Focus control and nicer UI for...

2015-09-09 Thread Gillardo
Github user Gillardo commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/106#issuecomment-138869845 done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-lib pull request:

2015-09-09 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/commit/fba11ecfb031e527b7185b48656351bd5bbee1be#commitcomment-13132683 In cordova-lib/src/platforms/PlatformApiPoly.js: In cordova-lib/src/platforms/PlatformApiPoly.js on line 54:

[GitHub] cordova-lib pull request:

2015-09-09 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/commit/fba11ecfb031e527b7185b48656351bd5bbee1be#commitcomment-13132684 In cordova-lib/src/platforms/PlatformApiPoly.js: In cordova-lib/src/platforms/PlatformApiPoly.js on line 38:

[GitHub] cordova-plugin-camera pull request: Focus control and nicer UI for...

2015-09-09 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/106#issuecomment-138863604 @Gillardo, could you please close this one manually. --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] cordova-plugin-camera pull request: Retaining image ratio when res...

2015-09-09 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/118#issuecomment-138862030 This was merged in https://github.com/apache/cordova-plugin-camera/commit/cad9ab0419ec3c90f0c052483177952d364a353d but not auto-closed. @trubit,

[GitHub] cordova-plugin-camera pull request: CB-9622 WP8 Camera Option dest...

2015-09-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/119 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera pull request: CB-9622 WP8 Camera Option dest...

2015-09-09 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/119#issuecomment-138861385 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] cordova-plugin-camera pull request: CB-9623 Fixes various issues w...

2015-09-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/120 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request: CB-8615, CB-9588 Better Cordova plugin s...

2015-09-09 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-lib/pull/301#issuecomment-138849439 Tests fail as we added corresponding unit tests including tests for windows 10 proj which has semver related issue(CB-9601): https://github.com/apache/cordova-lib/

[GitHub] cordova-plugin-statusbar pull request: Add support for colored hea...

2015-09-09 Thread Pacjonek
GitHub user Pacjonek opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/33 Add support for colored headers in multitasking view (Android) It would be nice if you added support for colored headers in multitasking view in Android. I think about somethin