Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/304#issuecomment-139129776
Will review tomorrow
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/303#issuecomment-139129689
Thanks for fast response!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/303
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/337#issuecomment-139129330
Merged! Feel free to close.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/303#issuecomment-139127308
LGTM !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/335#issuecomment-139078394
Thanks Richard for making the fixes!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-docs/pull/337
Fixed links, search, and source formatting for contribute
Does the following:
* Removed whitespace in contribute/index.html
* Fixes broken links in contribute
* Calls the appro
Github user nikhilkh closed the pull request at:
https://github.com/apache/cordova-docs/pull/335
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user nikhilkh closed the pull request at:
https://github.com/apache/cordova-docs/pull/334
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user nikhilkh closed the pull request at:
https://github.com/apache/cordova-docs/pull/333
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/333#issuecomment-139065627
Merged. Feel free to close.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/334#issuecomment-139064936
Merged. Feel free to close.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/335#issuecomment-139064740
Merged. Feel free to close.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user riknoll closed the pull request at:
https://github.com/apache/cordova-docs/pull/336
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/336#issuecomment-139061504
Merged. Feel free to close.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-medic/pull/61
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-medic/pull/61#issuecomment-139059642
Merged, but GitHub still hasn't picked up the changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Yeah, it could definitely be cleaned out. All the registry stuff can go,
search? Does plugman registry still overwrite npmjs.org globally?
How are platforms handling variables?
My team is hiring!
@purplecabbage
risingj.com
On Wed, Sep 9, 2015 at 2:37 PM, Steven Gill wrote:
> I actually think
I actually think the numbers will drop over time. Plugman has lost registry
functionality (publishing, unpublishing, owners, etc). Plugin installation
is moving into platforms instead of tools. That will signify the end of
needing a tool to install plugins for non cli workflows. Will still be
neede
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/33#issuecomment-139050353
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user Pacjonek closed the pull request at:
https://github.com/apache/cordova-plugin-statusbar/pull/33
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/33#issuecomment-139049800
@Pacjonek Just hit the 'close pull request' button! It is MUCH easier for
you to close your own, otherwise we actually need to make a commit to cl
We still need it.
There is a very important and difficult workflow for people who want to add
a 'little' cordova to an existing app. Think of a visual studio wizard to
add a cordova view to an existing app.
The reality of it is simply that it is architected as a secondary module,
so we can easily r
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/335#issuecomment-139041694
And yes, we should switch to a URI builder at some point.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/335#issuecomment-139040510
Also, it might be useful to switch to a proper URI builder for constructing
URIs now.
---
If your project is set up for it, you can reply to this email and have
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/335#issuecomment-139040608
@dblotsky I addressed your concerns with Gulpfile. Gulp will now reload the
browser twice on plugins changes. The first will update the code and the second
will be
using @latest isn't necessary as that is the default. We have never had
@latest be part of our install instructions before, why add more characters?
Updated the rest.
https://github.com/cordova/apache-blog-posts/blob/master/2015-09-09-tools-release.md
Posting soon.
On Tue, Sep 8, 2015 at 8:13 P
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-windows/pull/121#issuecomment-139012294
Cool, I thought it did handle the `\\` as well, but I guess not.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/commit/81737ec35d74cd0c5f17c3ce946eaf3de813be02#commitcomment-13143900
In cordova-lib/src/CordovaError.js:
In cordova-lib/src/CordovaError.js on line 36:
What is the purpose of `na
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/commit/81737ec35d74cd0c5f17c3ce946eaf3de813be02#commitcomment-13143836
In cordova-lib/src/CordovaError.js:
In cordova-lib/src/CordovaError.js on line 35:
IMO adding `ErrorCodes` as
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/335#issuecomment-139000724
The issue is that `{{ site.baseurl }}` strings need to be processed by
Jekyll and the updated gulpfile bypasses that
---
If your project is set up for it, you can
Github user f3rno commented on the pull request:
https://github.com/apache/cordova-plugins/pull/18#issuecomment-138998550
@cjpearson, you are a gentleman and a scholar. After nearly a day of on-off
debugging due to keyboard related issues, your fork works perfectly (so far)
:dancer:
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/335#issuecomment-138993518
Updating a file in the plugins folder causes all image links in the plugins
page to be broken once the page refreshes (and on all subsequent refreshes)
---
If you
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-docs/pull/336
Added text for browse online items on contact page
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/riknoll/cordova-docs cordova-website-co
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/121#discussion_r39071454
--- Diff: spec/unit/deployment.spec.js ---
@@ -150,7 +151,7 @@ describe('Windows 10 deployment interacts with the file
system as expected.', fu
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/335#discussion_r39071423
--- Diff: gulpfile.js ---
@@ -224,7 +223,8 @@ gulp.task("plugins", function() {
}
return stream
-
+.pipe(browser
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/335#discussion_r39071336
--- Diff: gulpfile.js ---
@@ -234,8 +234,7 @@ gulp.task("plugins", function() {
// minified JS has some things that look like
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/335#discussion_r39071280
--- Diff: gulpfile.js ---
@@ -121,7 +121,7 @@ gulp.task("watch", ["serve"], function () {
path.join(ROOT_DIR, "**", "*.yml"),
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/121#discussion_r39069953
--- Diff: spec/unit/deployment.spec.js ---
@@ -150,7 +151,7 @@ describe('Windows 10 deployment interacts with the file
system as expected.', fu
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/121#discussion_r39068918
--- Diff: spec/unit/deployment.spec.js ---
@@ -150,7 +151,7 @@ describe('Windows 10 deployment interacts with the file
system as expected.', fu
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/121#discussion_r39068742
--- Diff: spec/unit/deployment.spec.js ---
@@ -150,7 +151,7 @@ describe('Windows 10 deployment interacts with the file
system as expected.', fu
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/335#issuecomment-138973904
Checking multiple platform filters results in an improperly encoded URL. I
have a fix, do you want me to push it?
---
If your project is set up for it, you can re
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/122
CB-9633 iOS Taking a Picture With Option destinationType:NATIVE_URI not
working
In case sourceType == Camera we receive nil as Uri because image is stored
in memory. This PR adds lo
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/304#issuecomment-138958045
@omefire, @TimBarham, please review when possible
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/303#issuecomment-138957595
@omefire, review please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user bgashler1 closed the pull request at:
https://github.com/apache/cordova-docs/pull/315
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/304
CB-9617 Do not restore plugins immediately after plugin removal
https://github.com/apache/cordova-lib/commit/14675051c400a6811a6c6171fbf92f3475244630
introduced `cordova.prepare` call
Android is already there, isn't it?
On Tue, Sep 8, 2015, 9:16 PM Nikhil Khandelwal
wrote:
> It would be great to add this platform matrix to our buildbot CI. Any
> volunteers?
>
> -Nikhil
>
> -Original Message-
> From: Karen Tran [mailto:ktop...@gmail.com]
> Sent: Monday, September 7, 20
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/303
CB-9631 Save plugin to config.xml only if installation succeeds
This fixes [CB-9631](https://issues.apache.org/jira/browse/CB-9631)
The idea is that we need to save installed p
Github user alsorokin commented on the pull request:
https://github.com/apache/cordova-windows/pull/121#issuecomment-138937598
Travis build is green:
https://travis-ci.org/apache/cordova-windows/builds/79485657
---
If your project is set up for it, you can reply to this email and hav
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-windows/pull/121
CB-9632 Fixed tests not to fail on Travis-CI
https://issues.apache.org/jira/browse/CB-9632
You can merge this pull request into a Git repository by running:
$ git pull https://github
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/118#issuecomment-138917699
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user trubit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/118
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user zalun commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/101#issuecomment-138903930
FFOS +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-medic/pull/61
CB-8936 Utilizing --dump flag for logs on Windows
https://issues.apache.org/jira/browse/CB-8936
You can merge this pull request into a Git repository by running:
$ git pull https://gith
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-lib/pull/301#issuecomment-138896325
Tests pass now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
You already sent when I notice this email.
I only have one comment: "Thank Shaz for all your work and keeping on top
of things"
I sometimes forget to give a simple thank you
-- Carlos
On Tue, Sep 8, 2015 at 8:58 PM Shazron wrote:
> Sent.
>
> On Tue, Sep 8, 2015 at 2:31 PM, Shazron wrote:
>
>
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-lib/pull/301#issuecomment-138880965
Rebased on top of master which now includes #300
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/300
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/106#issuecomment-138875519
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user Gillardo closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/106
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
Github user Gillardo commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/106#issuecomment-138869845
done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/commit/fba11ecfb031e527b7185b48656351bd5bbee1be#commitcomment-13132683
In cordova-lib/src/platforms/PlatformApiPoly.js:
In cordova-lib/src/platforms/PlatformApiPoly.js on line 54:
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/commit/fba11ecfb031e527b7185b48656351bd5bbee1be#commitcomment-13132684
In cordova-lib/src/platforms/PlatformApiPoly.js:
In cordova-lib/src/platforms/PlatformApiPoly.js on line 38:
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/106#issuecomment-138863604
@Gillardo, could you please close this one manually.
---
If your project is set up for it, you can reply to this email and have your
reply appea
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/118#issuecomment-138862030
This was merged in
https://github.com/apache/cordova-plugin-camera/commit/cad9ab0419ec3c90f0c052483177952d364a353d
but not auto-closed. @trubit,
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/119
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/119#issuecomment-138861385
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/120
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-lib/pull/301#issuecomment-138849439
Tests fail as we added corresponding unit tests including tests for windows
10 proj which has semver related issue(CB-9601):
https://github.com/apache/cordova-lib/
GitHub user Pacjonek opened a pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/33
Add support for colored headers in multitasking view (Android)
It would be nice if you added support for colored headers in multitasking
view in Android.
I think about somethin
71 matches
Mail list logo
