Re: Cordova website redesign

2015-09-23 Thread Carlos Santana
This looks great. Can you add a sub page link in the navigation column to this page? http://cordova.apache.org/use-the-force-luke/docs/en/edge/plugin_ref/spec.html On Wed, Sep 23, 2015 at 7:50 PM Anis KADRI wrote: > Waw. It looks really really nice! Thanks so much for taking care of this. > >

Re: Plugin docs generation

2015-09-23 Thread Carlos Santana
This is great!, left feedback on the PR On Wed, Sep 23, 2015 at 8:11 PM Steven Gill wrote: > I left some feedback on the PR > > On Mon, Sep 21, 2015 at 3:28 AM, Sergey Shakhnazarov (Akvelon) < > v-ses...@microsoft.com> wrote: > > > Hello dev-list, > > > > I have squashed plugin docs-gen issue in

Re: Plugin docs generation

2015-09-23 Thread Steven Gill
I left some feedback on the PR On Mon, Sep 21, 2015 at 3:28 AM, Sergey Shakhnazarov (Akvelon) < v-ses...@microsoft.com> wrote: > Hello dev-list, > > I have squashed plugin docs-gen issue into the PR[1], please take a look, > I would appreciate your feedback! > The solution uses jsdoc-to-markdown

Re: Cordova website redesign

2015-09-23 Thread Anis KADRI
Waw. It looks really really nice! Thanks so much for taking care of this. On Wed, Sep 23, 2015 at 2:45 PM Shazron wrote: > Thank you for doing this, the site is great! > The community will love this. > > On Wed, Sep 23, 2015 at 11:02 AM, Ryan J. Salva > wrote: > > TLDR > > > > -- Feedback reque

Re: [Proposal][iOS] Drop support for iOS 7

2015-09-23 Thread Anis KADRI
+1 to dropping iOS 7.0 support. One can't even download iOS 7.0 simulator in XCode 7.0 anymore. On Wed, Sep 23, 2015 at 8:43 AM Carlos Santana wrote: > Hi I like what I see in the Windows Platform repo README.md > https://github.com/apache/cordova-windows#requirements > > They lis the Mobile OS

[GitHub] cordova-docs pull request: Add Pacifica to showcase apps.

2015-09-23 Thread drbeermann
Github user drbeermann closed the pull request at: https://github.com/apache/cordova-docs/pull/360 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] cordova-docs pull request: Add Pacifica to showcase apps.

2015-09-23 Thread drbeermann
Github user drbeermann commented on the pull request: https://github.com/apache/cordova-docs/pull/360#issuecomment-142758383 Awesome, thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

Re: [Android] 5.0.x release branch?

2015-09-23 Thread Frederico Galvão
> > > Based on [1] I think we're overthinking here... > > > > I might have missed something, but as far as I understood it all, the > only > > thing preventing new plugin versions from working on older > cordova-android > > based projects is the POSSIBLE FACT that these projects will still > > have

Re: Cordova website redesign

2015-09-23 Thread Shazron
Thank you for doing this, the site is great! The community will love this. On Wed, Sep 23, 2015 at 11:02 AM, Ryan J. Salva wrote: > TLDR > > -- Feedback requested for a proposed Cordova website redesign at > http://cordova.apache.org/use-the-force-luke > > -- The redesign was influenced by interv

Re: [Android] 5.0.x release branch?

2015-09-23 Thread Steven Gill
so plugins that require cordova-android 5.0 + should definitely be adding an engine tag specifying that. We could look into some way for cordova-cli possibly fetching older versions if cordova plugin add fails but I imagine this code being ugly and easily breakable. it would be nice to start movi

Re: [Android] 5.0.x release branch?

2015-09-23 Thread Joe Bowser
On Wed, Sep 23, 2015 at 2:05 PM, Frederico Galvão < frederico.gal...@pontoget.com.br> wrote: > Based on [1] I think we're overthinking here... > > I might have missed something, but as far as I understood it all, the only > thing preventing new plugin versions from working on older cordova-android

Re: [Android] 5.0.x release branch?

2015-09-23 Thread Frederico Galvão
Based on [1] I think we're overthinking here... I might have missed something, but as far as I understood it all, the only thing preventing new plugin versions from working on older cordova-android based projects is the POSSIBLE FACT that these projects will still have android:targetSdkVersion="N

Re: Our development process, revisited

2015-09-23 Thread Carlos Santana
Call me dumb now. So what if Nexus 6P is not out yet, let's work on master and keep it stable and use branches for features or not stable code. What is the harm of putting the new code for target API 23 on master while Nexus 6P is not out yet? - Carlos Sent from my iPhone > On Sep 23, 2015,

Re: Our development process, revisited

2015-09-23 Thread Joe Bowser
On Wed, Sep 23, 2015 at 1:32 PM, Steven Gill wrote: > If we had to rush a CVE, wouldn't it make sense to do that off an existing > released branch (4.1.x)? > > I think the only valid point is we don't want master in a state where tests > aren't passing. Until then, work on a branch. But if tests

Re: Our development process, revisited

2015-09-23 Thread Steven Gill
If we had to rush a CVE, wouldn't it make sense to do that off an existing released branch (4.1.x)? I think the only valid point is we don't want master in a state where tests aren't passing. Until then, work on a branch. But if tests are passing, no harm moving it into master. Especially if you w

[GitHub] cordova-docs pull request: Add Sworkit to Cordova App Showcase

2015-09-23 Thread gylippus
Github user gylippus commented on the pull request: https://github.com/apache/cordova-docs/pull/361#issuecomment-142718883 Thanks @dblotsky --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] cordova-docs pull request: Add Sworkit to Cordova App Showcase

2015-09-23 Thread gylippus
Github user gylippus closed the pull request at: https://github.com/apache/cordova-docs/pull/361 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: Add Sworkit to Cordova App Showcase

2015-09-23 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/361#issuecomment-142716538 Merged! Please feel free to close the PR and delete the branch. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] cordova-docs pull request: Add Pacifica to showcase apps.

2015-09-23 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/360#issuecomment-142712182 Merged! Feel free to close the PR and delete the branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-docs pull request: Adding Syntax Highlighting to Site

2015-09-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/359 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

Our development process, revisited

2015-09-23 Thread Joe Bowser
Hey So, once again, we're trying to do this 5.0.x thing. And once again, I'm finding that I want to create a long-lived 5.0.x branch because that's what we should do for major releases. This won't be as long lived as last time (should be released in early October, before we do our off-site, beca

[GitHub] cordova-docs pull request: Implementing Proper Latest Docs Version

2015-09-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/358 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

Re: Cordova website redesign

2015-09-23 Thread Steven Gill
Awesome! We might want to add more apps to showcase before we push it live. Love the focus on quickstart. We can probably remove tizen from http://cordova.apache.org/use-the-force-luke/docs/en/edge/guide/support/index.html Docs site looks good! I like the edit button which takes you to the gith

[GitHub] cordova-medic pull request: CB-8936 Tweaking windows log gathering...

2015-09-23 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/64#issuecomment-142696116 I misspelled "This closes #64"... sorry. This is merged and can be closed and pruned. --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-plugin-file pull request: fix install on amazon-fireos

2015-09-23 Thread tomstgeorge
Github user tomstgeorge commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/113#issuecomment-142695583 Trying again to get my app working on amazon-fireos. Using this fix I know get this when trying to build ``` [javac] /Library/MobileApp

[GitHub] cordova-ios pull request: CB-9693 Fix www copy with spaces in proj...

2015-09-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/166 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [Android] 5.0.x release branch?

2015-09-23 Thread Joe Bowser
On Wed, Sep 23, 2015 at 11:30 AM, Joe Bowser wrote: > > On Wed, Sep 23, 2015 at 11:22 AM, Homer, Tony > wrote: > >> Joe- >> >> As far as I can tell, the API 23 calls are currently unguarded so smores >> will only work on M Preview. >> I know your smores branch is a POC, but I was wondering about

Re: [Android] 5.0.x release branch?

2015-09-23 Thread Joe Bowser
On Wed, Sep 23, 2015 at 11:22 AM, Homer, Tony wrote: > Joe- > > As far as I can tell, the API 23 calls are currently unguarded so smores > will only work on M Preview. > I know your smores branch is a POC, but I was wondering about backwards > compatibility. > Do you anticipate adding Build.VERSI

[GitHub] cordova-medic pull request: CB-9695 Add a command to print globall...

2015-09-23 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/67#issuecomment-142687647 I don't think this needs a medic.js command. You can just run `npm ls -g` and add it to `CORDOVA_STEPS_SET_SETTINGS`. --- If your project is set up for it, you c

Re: [Android] 5.0.x release branch?

2015-09-23 Thread Homer, Tony
Joe- As far as I can tell, the API 23 calls are currently unguarded so smores will only work on M Preview. I know your smores branch is a POC, but I was wondering about backwards compatibility. Do you anticipate adding Build.VERSION.SDK_INT >= Build.VERSION_CODES.M guard clauses for backwards comp

[GitHub] cordova-medic pull request: CB-9660 Kill wp8.1 emulator in medic-k...

2015-09-23 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/66#issuecomment-142686868 Just a thought: are WP8 and WP8.1 emulators using the same process? --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] cordova-docs pull request: Adding Syntax Highlighting to Site

2015-09-23 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/359#discussion_r40237793 --- Diff: _config.yml --- @@ -26,7 +26,13 @@ keep_files: [".git", ".svn", "wiki-images", "images", "downloads"] lsi: false # don't produce an ind

[GitHub] cordova-ios pull request: CB-9690 Can't submit iPad apps to the Ap...

2015-09-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/167 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Cordova website redesign

2015-09-23 Thread Ryan J. Salva
TLDR -- Feedback requested for a proposed Cordova website redesign at http://cordova.apache.org/use-the-force-luke -- The redesign was influenced by interviews with 300+ mobile developers. From these conversations, we identified six top level goals: 1. Establish that Cordova is an active project

Re: [Android] 5.0.x release branch?

2015-09-23 Thread Joe Bowser
On Wed, Sep 23, 2015 at 9:36 AM, Carlos Santana wrote: > No need to major version change for the Plugins, the API of the didn't > change. > Web developer still uses the same JS API to use the plugin. > > I would do a major version bump on Geolocation. The API itself didn't change but the behavio

[GitHub] cordova-android pull request: CB-9608 cordova-android no longer bu...

2015-09-23 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-android/pull/217#issuecomment-142671130 This should work on OSX now as well (`path.join('.', '/some/abs/path.tofile')` was turning path to relative in #215 ). --- If your project is set up for it, yo

[GitHub] cordova-android pull request: CB-9608 cordova-android no longer bu...

2015-09-23 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-android/pull/217 CB-9608 cordova-android no longer builds on Node 0.10 or below Replaced `path.isAbsolute` usage with `path.resolve`. [Jira issue](https://issues.apache.org/jira/browse/CB-9608) You

[GitHub] cordova-docs pull request: Implementing Proper Latest Docs Version

2015-09-23 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/358#issuecomment-142657609 Looks good to me! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

Re: [Android] 5.0.x release branch?

2015-09-23 Thread Carlos Santana
No need to major version change for the Plugins, the API of the didn't change. Web developer still uses the same JS API to use the plugin. Yes I did some thinking around the plugin search website. I think is a good topic for the F2F. Now that IBM is using Cordova Plugin more heavily to package our

[GitHub] cordova-android pull request: CB-9608 cordova-android no longer bu...

2015-09-23 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-android/pull/215#issuecomment-142655973 Investigating path issues on a Mac, closing this for now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-android pull request: CB-9608 cordova-android no longer bu...

2015-09-23 Thread daserge
Github user daserge closed the pull request at: https://github.com/apache/cordova-android/pull/215 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] cordova-android pull request: CB-9080 Cordova CLI run for Android ...

2015-09-23 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-android/pull/216#issuecomment-142654150 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-docs pull request: Adding Syntax Highlighting to Site

2015-09-23 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/359#discussion_r40224664 --- Diff: _config.yml --- @@ -26,7 +26,13 @@ keep_files: [".git", ".svn", "wiki-images", "images", "downloads"] lsi: false # don't produce an inde

RE: [Android] 5.0.x release branch?

2015-09-23 Thread Nikhil Khandelwal
Merging threads. I was no aware of any security implications of using reflection - Perhaps if the reflection target can be controlled through external data. In any case, I understand your hesitation with use of reflection. I would love to have longer discussions on the F2F on what approaches we

[GitHub] cordova-docs pull request: Adding Syntax Highlighting to Site

2015-09-23 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/359#issuecomment-142652316 Looks good to me! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

RE: [DISCUSS] Tools Release

2015-09-23 Thread Steven Gill
Merged and sent you an invitation to have access to repo On Sep 22, 2015 7:20 PM, "Sergey Grebnov (Akvelon)" wrote: > Could someone merge the post or give me write access to the > apache-blog-posts repo please. > https://github.com/cordova/apache-blog-posts/pull/46 > > I'll update npm after that.

RE: [DISCUSS] Tools Release

2015-09-23 Thread Sergey Grebnov (Akvelon)
Thank you Steve! -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Wednesday, September 23, 2015 9:12 AM To: dev@cordova.apache.org Subject: RE: [DISCUSS] Tools Release Merged and sent you an invitation to have access to repo On Sep 22, 2015 7:20 PM, "Sergey Gre

[GitHub] cordova-android pull request: CB-9080 Cordova CLI run for Android ...

2015-09-23 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-android/pull/216 CB-9080 Cordova CLI run for Android versions 4.1.1 and lower throws e… …rror [Jira issue](https://issues.apache.org/jira/browse/CB-9080) You can merge this pull request into a

Re: [Proposal][iOS] Drop support for iOS 7

2015-09-23 Thread Carlos Santana
Hi I like what I see in the Windows Platform repo README.md https://github.com/apache/cordova-windows#requirements They lis the Mobile OS that they support and the ones that still work but deprecated. I think it will be clear to have the same for the other platforms (i.e. ios and android) For iO

[GitHub] cordova-plugin-media pull request: audio-recorder-format-fix-html5

2015-09-23 Thread krishlakshmanan
GitHub user krishlakshmanan opened a pull request: https://github.com/apache/cordova-plugin-media/pull/70 audio-recorder-format-fix-html5 You can merge this pull request into a Git repository by running: $ git pull https://github.com/krishlakshmanan/cordova-plugin-media audio

[GitHub] cordova-plugin-media pull request: audio-recorder-format-fix-html5

2015-09-23 Thread krishlakshmanan
GitHub user krishlakshmanan opened a pull request: https://github.com/apache/cordova-plugin-media/pull/69 audio-recorder-format-fix-html5 You can merge this pull request into a Git repository by running: $ git pull https://github.com/krishlakshmanan/cordova-plugin-media audio

[GitHub] cordova-medic pull request: CB-9695 Add a command to print globall...

2015-09-23 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-medic/pull/67 CB-9695 Add a command to print globally installed npm modules https://issues.apache.org/jira/browse/CB-9695 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-media pull request: audio-recorder-format-fix-html5

2015-09-23 Thread krishlakshmanan
Github user krishlakshmanan closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/69 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-android pull request: CB-9608 cordova-android no longer bu...

2015-09-23 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-android/pull/215#issuecomment-142625693 :+1: lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] cordova-android pull request: CB-9608 cordova-android no longer bu...

2015-09-23 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-android/pull/215 CB-9608 cordova-android no longer builds on Node 0.10 or below Replaced `path.isAbsolute` usage with `path.resolve`. [Jira issue](https://issues.apache.org/jira/browse/CB-9608) You

[GitHub] cordova-plugin-contacts pull request: Get input stream from relati...

2015-09-23 Thread vincipop
GitHub user vincipop opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/77 Get input stream from relative path "Get an input stream based on file path or uri " didn't work for relative paths so modified line 1635 The problem is still present for path

[GitHub] cordova-medic pull request: CB-9660 Kill wp8.1 emulator in medic-k...

2015-09-23 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-medic/pull/66 CB-9660 Kill wp8.1 emulator in medic-kill on Windows https://issues.apache.org/jira/browse/CB-9660 You can merge this pull request into a Git repository by running: $ git pull https://g

[GitHub] cordova-docs pull request: Add Sworkit to Cordova App Showcase

2015-09-23 Thread gylippus
GitHub user gylippus opened a pull request: https://github.com/apache/cordova-docs/pull/361 Add Sworkit to Cordova App Showcase As requested, Sworkit has been added to the Cordova App Showcase You can merge this pull request into a Git repository by running: $ git pull https://

[GitHub] cordova-lib pull request: icon parameter should not be relative to...

2015-09-23 Thread david-barth-canonical
Github user david-barth-canonical commented on the pull request: https://github.com/apache/cordova-lib/pull/299#issuecomment-142564241 Yes, makes sense. Icon management needs more tweaks, but this way it will work better already Thanks for the review. --- If your project is set up fo

[GitHub] cordova-lib pull request: icon parameter should not be relative to...

2015-09-23 Thread tsschaffert
Github user tsschaffert commented on the pull request: https://github.com/apache/cordova-lib/pull/299#issuecomment-142535031 Shouldn't this be handled similar to how it is done in the manifest generation of cordova-ubuntu? Then the 'www' part should be replaced by '../..' (otherwise i