Merging smores branch into Cordova-Android TODAY

2015-10-16 Thread Joe Bowser
Hey I'm going to be merging the smores branch into master by 3:00 PM today. I've left this pull request open for the past week, so we should be ready to go. Please let me know if there's any reason I shouldn't merge this in. Once this is merged, there will be a discuss thread for

Re: Windows platform and cordova-plugin-file

2015-10-16 Thread Steven Gill
Hey Alex! Welcome! I don't have a ton of experience with the file plugin but I can definitely guide you and answer your questions + merge PRs you have vetted. We definitely need help with plugins currently. Not enough eyes to keep up with PRs. Could you possibly join our slack room and just

Using Cordova Plugins with ReactNative

2015-10-16 Thread Parashuram N
During the Face to Face yesterday, I showed a quick hack that I put together to use Cordova plugins in React Native. I was encouraged to share it on the dev mailing list. Would love to hear what you guys think about the idea. The basic idea here is that we have more than 1000 Cordova plugins

[GitHub] cordova-docs pull request: orubase

2015-10-16 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/389#issuecomment-148793673 Please submit an image with this PR. Or, if I understand correctly, please close this PR since it looks like you've made another more recent one with updated

[GitHub] cordova-docs pull request: Ajout de popvox.png

2015-10-16 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/386#issuecomment-148796375 Hi @juspriet. Thank you for the PR! Please add a description for your app. The instructions to do this are here:

Re: Using Cordova Plugins with ReactNative

2015-10-16 Thread Michael Brooks
So rad! Amazing work Parashuram! On Fri, Oct 16, 2015 at 10:25 AM, Parashuram N wrote: > During the Face to Face yesterday, I showed a quick hack that I put > together to use Cordova plugins in React Native. I was encouraged to share > it on the dev mailing list. Would

[GitHub] cordova-docs pull request: Orubase tool information added

2015-10-16 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/390#issuecomment-148791749 Please open this PR against the `cordova-website` branch. Also, GitHub isn't able to see the originating repository for this PR. --- If your project is set up

[GitHub] cordova-docs pull request: Keepe App Added to Showcase

2015-10-16 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/376#issuecomment-148794314 Ping! Please close this PR when you have a moment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-docs pull request: Keepe App Added to Showcase

2015-10-16 Thread vkeepe
Github user vkeepe closed the pull request at: https://github.com/apache/cordova-docs/pull/376 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: Add ReactEurope App to Showcase

2015-10-16 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/379#issuecomment-148794641 Ping @csantanapr! Please close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-docs pull request: Buildr added to the showcase

2015-10-16 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/378#issuecomment-148794536 Ping @mahnuh! Please close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

RE: Merging smores branch into Cordova-Android TODAY

2015-10-16 Thread Parashuram N
As discussed in the Cordova Face to Face yesterday, we said that we want our users to be aware of changes like these that will hit them. Is someone looking at writing a blog post for this ? -Original Message- From: Joe Bowser [mailto:bows...@gmail.com] Sent: Friday, October 16, 2015

Re: Merging smores branch into Cordova-Android TODAY

2015-10-16 Thread Dmitry Blotsky
I’m installing 23 on the CI right now. Should be done, conservatively, in 2 hours. > On Oct 16, 2015, at 1:38 PM, Joe Bowser wrote: > > OK, I locally did the rebase. How soon can we get the CI to have > android-23 installed so that Travis no longer fails? > > On Fri, Oct

[GitHub] cordova-docs pull request: Please add One Verse BIBLE app

2015-10-16 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/384#issuecomment-148821640 Hey @ozexpert: sorry, I've been having issues with the links. https://onever.se is not responding, and http://onever.se gives a 404. Has the URI changed? ---

Re: [DISCUSS] Curating Apps

2015-10-16 Thread Tommy Williams
+1 for curation. Apps in the showcase should really be the best of the best, yeah? Apps that show that the myths about Cordova aren’t true, etc. On 17 October 2015 at 07:44:49, Joe Bowser (bows...@gmail.com) wrote: Yes, I definitely think we should be curating the apps to make sure they're

[GitHub] cordova-docs pull request: Adding windows 10 to the platform suppo...

2015-10-16 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/388#issuecomment-148826136 Merged. Please close the PR and delete the branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Re: [DISCUSS] Curating Apps

2015-10-16 Thread Joe Bowser
Yes, I definitely think we should be curating the apps to make sure they're legit. On Fri, Oct 16, 2015 at 10:49 AM, Dmitry Blotsky wrote: > Hey folks, > > Just a quick thought: should we be curating the apps in the showcase to > make sure they’re legit? I verify that

[GitHub] cordova-docs pull request: Please add One Verse BIBLE app

2015-10-16 Thread ozexpert
Github user ozexpert commented on the pull request: https://github.com/apache/cordova-docs/pull/384#issuecomment-148823063 I'm sorry i recently changed the domain but this should work http://www.onever.se --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-docs pull request: Please add One Verse BIBLE app

2015-10-16 Thread ozexpert
Github user ozexpert commented on the pull request: https://github.com/apache/cordova-docs/pull/384#issuecomment-148823193 I'll redirect http://onever.se -> to http://www.onever.se --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-docs pull request: Adding windows 10 to the platform suppo...

2015-10-16 Thread rakatyal
Github user rakatyal closed the pull request at: https://github.com/apache/cordova-docs/pull/388 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-docs pull request: Adding survey banner

2015-10-16 Thread rakatyal
Github user rakatyal closed the pull request at: https://github.com/apache/cordova-docs/pull/382 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Merging smores branch into Cordova-Android TODAY

2015-10-16 Thread Joe Bowser
OK, I'll push this monday. On Fri, Oct 16, 2015 at 2:37 PM, Dmitry Blotsky wrote: > I’m installing 23 on the CI right now. Should be done, conservatively, in > 2 hours. > > > On Oct 16, 2015, at 1:38 PM, Joe Bowser wrote: > > > > OK, I locally did the

[GitHub] cordova-plugin-file-transfer pull request: Prevent Fatal Exception...

2015-10-16 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/79#issuecomment-148653298 Confirm this fix prevents a crash on 5.0.1 device: ``` E/FileTransfer(32760): Catch workaround for fatal exception

[GitHub] cordova-plugin-camera pull request: added allowEdit support for an...

2015-10-16 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/12#issuecomment-148635350 Read the quirks Android Quirks Android also uses the Crop Activity for allowEdit, even though crop should work and actually pass the

[GitHub] cordova-lib pull request: Ensure the iOS 'Resources/icons' and 'Re...

2015-10-16 Thread ryanwilliams83
GitHub user ryanwilliams83 opened a pull request: https://github.com/apache/cordova-lib/pull/323 Ensure the iOS 'Resources/icons' and 'Resources/splash' dirs exist. Fixes the following problem. Ryans-Mac:mobile ryan$ cordova platform add

[GitHub] cordova-plugin-file-transfer pull request: CB-9385 Return FILE_NOT...

2015-10-16 Thread Ganster41
Github user Ganster41 closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/95 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-plugin-file-transfer pull request: CB-9385 Return FILE_NOT...

2015-10-16 Thread Ganster41
Github user Ganster41 commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/95#issuecomment-148633714 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-file-transfer pull request: Prevent Fatal Exception...

2015-10-16 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/79#issuecomment-148654338 @virix, Thank you for the contribution! Could you please rename the PR and commit title to `"CB-8431 File Transfer tests crash on Android

[GitHub] cordova-plugin-file-transfer pull request: Prevent Fatal Exception...

2015-10-16 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/79#discussion_r4724 --- Diff: src/android/FileTransfer.java --- @@ -977,7 +977,11 @@ public void run() {

[GitHub] cordova-plugin-file-transfer pull request: uploadResponse encoding...

2015-10-16 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/71#issuecomment-148675826 @codable, thanks for the fix! Can you please add a

[GitHub] cordova-plugin-file pull request: Update Cordova storage guide loc...

2015-10-16 Thread mbrookes
GitHub user mbrookes opened a pull request: https://github.com/apache/cordova-plugin-file/pull/139 Update Cordova storage guide location. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mbrookes/cordova-plugin-file patch-1

[GitHub] cordova-plugin-camera pull request: save data and metadata to disk...

2015-10-16 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/114#issuecomment-148684035 Ping, @nourshamrok --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-camera pull request: Try to use realpath filename i...

2015-10-16 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/99#issuecomment-148681683 Yep, see it now. Merging. Thanks for contribution, @nantunes! --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-plugin-camera pull request: Try to use realpath filename i...

2015-10-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/99 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera pull request: Make dest NATIVE_URI compatibl...

2015-10-16 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-148683134 The issue is fixed now in https://github.com/apache/cordova-plugin-camera/pull/122 This PR seems not actual anymore. --- If your project is

[GitHub] cordova-plugin-file-transfer pull request: CB-9673 Fixed test spec...

2015-10-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/102 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-ios pull request: 3.9.x

2015-10-16 Thread ilicgo
GitHub user ilicgo opened a pull request: https://github.com/apache/cordova-ios/pull/172 3.9.x Twitter widget don't work, because the twitter javascript create an iframe without src attribute. This made a request with the scheme about (about:blank). Like android platform we allow

[GitHub] cordova-cli pull request: CB-9784 Remove CLI logger levels prefixe...

2015-10-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/224 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-9590 - Ubuntu support for the new plu...

2015-10-16 Thread david-barth-canonical
Github user david-barth-canonical commented on the pull request: https://github.com/apache/cordova-lib/pull/294#issuecomment-148743166 ok, i understand the problem now. In particular, the code to guess the classname is nice, but other platforms resort to encapsulating this

[GitHub] cordova-lib pull request: Ensure the iOS 'Resources/icons' and 'Re...

2015-10-16 Thread dpogue
Github user dpogue commented on the pull request: https://github.com/apache/cordova-lib/pull/323#issuecomment-148736992 cordova-ios 4 uses xcassets instead of the Resources folder. cordova-lib was updated to handle that in 0c5bed6dd141cf1d1156e09a62dc048c49cd6f8e, but it hasn't been

[GitHub] cordova-lib pull request: CB-9815 Engine name="cordova" should che...

2015-10-16 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-lib/pull/324 CB-9815 Engine name="cordova" should check tools version, not platforms https://issues.apache.org/jira/browse/CB-9815 You can merge this pull request into a Git repository by running: $

[GitHub] cordova-android pull request: CB-9782 Implements PlatformApi contr...

2015-10-16 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/226#discussion_r42260468 --- Diff: bin/create --- @@ -1,49 +1,56 @@ -#!/usr/bin/env node - -/* - Licensed to the Apache Software Foundation (ASF)

[GitHub] cordova-osx pull request: CB-9818 Reloading the webview in OSX loo...

2015-10-16 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-osx/pull/25 CB-9818 Reloading the webview in OSX looses the CordovaBridgeUti You can merge this pull request into a Git repository by running: $ git pull https://github.com/tripodsan/cordova-osx

[GitHub] cordova-docs pull request: Please add One Verse BIBLE app

2015-10-16 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/384#issuecomment-148868402 Hi @ozexpert. We're in the middle of a major merge in the repo, so I unfortunately won't be able to do this merge today. Stay tuned, and I will revisit it next

[DISCUSS] Camera plugin considerations in Android

2015-10-16 Thread Richard Knoll
Hey all, Over the past week or so I have been conducting a review of the issues for the camera plugin in JIRA and have noticed two big areas of confusion that seem to plague users in Android. I want to start a DISCUSS thread because both of these involve larger decisions to be made. 1.

Re: [DISCUSS] Camera plugin considerations in Android

2015-10-16 Thread Joe Bowser
Hey Comments are inline. Insights into weird behaviour ahead! On Fri, Oct 16, 2015 at 4:32 PM, Richard Knoll wrote: > Hey all, > > Over the past week or so I have been conducting a review of the issues for > the camera plugin in JIRA and have noticed two big areas of

[GitHub] cordova-docs pull request: Add HealthPlanet, Ohalog and Undog Apps...

2015-10-16 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/385#issuecomment-148870301 Hi @argelius. Thanks for the PR! We're currently in the middle of a major merge in the repo, and I will revisit this PR next week. Please stay tuned! --- If

Re: [DISCUSS] Curating Apps

2015-10-16 Thread Dmitry Blotsky
So, there are two items to address here: - display policy - content policy I propose the following policy for app content: - if the app is on an app store, it is OK to show on our page I propose the following strategy for app display: - show 6 apps and 6 tools - pick them at random at each page

[GitHub] cordova-docs pull request: Please add One Verse BIBLE app

2015-10-16 Thread ozexpert
Github user ozexpert commented on the pull request: https://github.com/apache/cordova-docs/pull/384#issuecomment-148869692 Thanks for letting me know. That is fine with me ~ :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Cordova Face to Face Summary

2015-10-16 Thread Steven Gill
Hey Everyone! We had a great couple of days in Redmond at the Cordova face to face. Thanks to everyone who made it out in person and to those of you who joined in remotely! And a special thanks to Parashuram and the rest of the Microsoft committers who helped organize and host the event! The two

Re: [DISCUSS] Camera plugin considerations in Android

2015-10-16 Thread Joe Bowser
Oops, Have to respond to my last comment: On Fri, Oct 16, 2015 at 4:50 PM, Joe Bowser wrote: > Hey > > Comments are inline. Insights into weird behaviour ahead! > > On Fri, Oct 16, 2015 at 4:32 PM, Richard Knoll > wrote: > >> Hey all, >> >> Over the

[GitHub] cordova-docs pull request: Ski patrol mobile app showcase

2015-10-16 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/391#issuecomment-148868593 Hi @garymeyer. Thank you for the PR! We're in the middle of a big merge in this repo, so I will get to this merge next week. Stay tuned. --- If your project is

[GitHub] cordova-docs pull request: Add BurracoON app to showcase

2015-10-16 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/392#issuecomment-148868714 Hi @Rickgbw. Thank you for the PR! We're currently in the middle of a major merge. We will revisit this PR next week. Stay tuned! --- If your project is set up

[GitHub] cordova-docs pull request: Please add One Verse BIBLE app

2015-10-16 Thread ozexpert
Github user ozexpert commented on the pull request: https://github.com/apache/cordova-docs/pull/384#issuecomment-148764813 Hi, any progress on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-docs pull request: Please add One Verse BIBLE app

2015-10-16 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/384#issuecomment-148795462 Hi! Sorry for the delay: we've been tied up with a Cordova meeting for these last two days. I'll merge this PR today. --- If your project is set up for it, you

[GitHub] cordova-docs pull request: Adding survey banner

2015-10-16 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/382#issuecomment-148794949 Merged! Please close the PR and delete the branch when you have a moment. --- If your project is set up for it, you can reply to this email and have your reply