RE: Merging smores branch into Cordova-Android TODAY

2015-10-18 Thread Nikhil Khandelwal
Thanks Joe! Most of the changes look good. I did leave a comment on the design of the CordovaPlugin base class - I don’t want to block progress on that. Feel free to merge it - but let's see if we can rationalize why we are adding the base class methods - it seems only for the Geoloc plugin -

[GitHub] cordova-plugin-camera pull request: CB-9193: Add 'showLibraryButto...

2015-10-18 Thread dpolivy
Github user dpolivy commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/104#issuecomment-149044779 @jcesarmobile Is this a quirk just because it's only implemented on iOS, Android, and WP? @infil00p Actually, it is consistent on Android, and

Re: [DISCUSS] CI and testing

2015-10-18 Thread Steven Gill
Forgot to mention that Masa would look into the jenkins build system his company is using and give advice on our move to jenkins. On Sun, Oct 18, 2015 at 8:11 PM, Steven Gill wrote: > At the Cordova F2F[1], we discussed updates to our CI system. > > Dimitry will be

[DISCUSS] CI and testing

2015-10-18 Thread Steven Gill
At the Cordova F2F[1], we discussed updates to our CI system. Dimitry will be leading an effort to move our CI from buildbot to jenkins. Buildbot has been unstable and struggles to handle the testing load we need it to. You can view Dimitry's slides at [2]. Dimitry and I will also be reviewing

RE: Is CPR going offline

2015-10-18 Thread Parashuram N
To follow up on this, we discussed it at the face to face. Steve has an action item to look at the download count for CPR - at the moment, the number of requests seem to make it hard to shut down. Carlos also said if we could get cloudant to host this registry. -Original Message-

RE: Using Cordova Plugins with ReactNative

2015-10-18 Thread Parashuram N
Thanks :) -Original Message- From: mikeywbro...@gmail.com [mailto:mikeywbro...@gmail.com] On Behalf Of Michael Brooks Sent: Friday, October 16, 2015 10:29 AM To: dev@cordova.apache.org Subject: Re: Using Cordova Plugins with ReactNative So rad! Amazing work Parashuram! On Fri, Oct 16,

[GitHub] cordova-android pull request: Cordova-Android 5.0/Marshmallow Upda...

2015-10-18 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/223#discussion_r42330756 --- Diff: framework/src/org/apache/cordova/CordovaPlugin.java --- @@ -359,4 +361,38 @@ public boolean onReceivedClientCertRequest(CordovaWebView

RE: Merging smores branch into Cordova-Android TODAY

2015-10-18 Thread Nikhil Khandelwal
I think there are two aspects of the CI. I think Dmitry is handling the BuildBOT CI update to support android-23. Travis CI need android 23 which is causing Joe's change to fail in PR state: https://travis-ci.org/apache/cordova-android/builds/83964922 Joe you need to update Travis, as

[GitHub] cordova-plugin-test-framework pull request: CB-8973: Changed the f...

2015-10-18 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/14#issuecomment-149079635 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[DISCUSS] CPR end of life

2015-10-18 Thread Steven Gill
At the Cordova F2F[1], we discussed keeping CPR online for a little while longer as it is still fairly active. The next version of cordova-cli will auto convert oldIDs to newIDs and that should lower the activity on the server. Carlos and I are looking into finding different hosting for the CPR.

Re: [DISCUSS] Curating Apps

2015-10-18 Thread Jesse
This was part of my hesitation in doing this. PhoneGap.com gets >20 submissions a week, and someone has to look at them, validate them. Here [1] is a link to page 30 of the android apps, and there are 24 apps per page. We also have to consider appropriateness of the app, is it adult? mature? We

[DISCUSS] CocoaPods dependencies for iOS plugins

2015-10-18 Thread Steven Gill
At the Cordova F2F, everyone seemed to agree that we should bring CocoaPods support to plugins as dependencies for iOS. Cordova-android currently uses Gradle as a way to enable external dependency resolution for plugins using the framework tag. A suggestion about using the engine tag to fetch

[GitHub] cordova-plugin-camera pull request: CB-9193: Add 'showLibraryButto...

2015-10-18 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/104#issuecomment-149005887 -1 to adding new quirks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-camera pull request: CB-9193: Add 'showLibraryButto...

2015-10-18 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/104#issuecomment-149027648 -1 to this as well. This wouldn't be consistent on Android, since we're using Intents to launch a camera, and it's possible some devices wouldn't have